[PATCH 3/4] rtc-s3c: add variants for S3C2443 and S3C2416

2011-12-21 Thread Heiko Stübner
Especially the TICNT registers are different from the two rtc types that currently exists. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-rtc.h | 17 ++ drivers/rtc/rtc-s3c.c | 43 ++-- 2 files

[PATCH v3 0/7] s3c-hsudc: regulator handling and a lot of fixes

2011-12-19 Thread Heiko Stübner
In his response to the first submission Felipe Balbi asked to also move the driver to the new udc_start and udc_stop functions and to make an effort to reduce dependencies on archictecture code. v3 of the series does not try to provide a remove function, due to the possible lifetime problem of

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: As the driver is also buildable as a module it should need a cleanup function for the removal of the module. My guess is that this wasn't implemented

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 09:10:48 schrieb Russell King - ARM Linux: On Sat, Dec 17, 2011 at 08:26:33PM +0100, Heiko Stübner wrote: As the driver is also buildable as a module it should need a cleanup function for the removal of the module. My guess is that this wasn't implemented

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 20:45:18 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 08:33:32PM +0100, Heiko Stübner wrote: Am Sonntag 18 Dezember 2011, 20:01:02 schrieben Sie: On Sun, Dec 18, 2011 at 07:50:37PM +0100, Heiko Stübner wrote: I didn't get this far. With your

Re: [PATCH 3/7] s3c-hsudc: add a remove function

2011-12-18 Thread Heiko Stübner
Am Sonntag 18 Dezember 2011, 21:39:53 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 09:24:12PM +0100, Heiko Stübner wrote: Am Sonntag 18 Dezember 2011, 20:45:18 schrieb Russell King - ARM Linux: On Sun, Dec 18, 2011 at 08:33:32PM +0100, Heiko Stübner wrote: Am Sonntag 18

[PATCH 3/7] s3c-hsudc: add a remove function

2011-12-17 Thread Heiko Stübner
As the driver is also buildable as a module it should need a cleanup function for the removal of the module. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/usb/gadget/s3c-hsudc.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git

[PATCH 4/7] s3c-hsudc: add missing otg_put_transceiver in probe

2011-12-17 Thread Heiko Stübner
The number of get and put calls should always be equal. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/usb/gadget/s3c-hsudc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index

[PATCH 5/7] s3c-hsudc: move device registration to probe and remove

2011-12-17 Thread Heiko Stübner
Instead of adding and deleting the gadget device in the start and stop invocations. Use device_register in the probe method to initialize and add the gadget device and unregister it in the remove function. This also requires a release function for the gadget device. Signed-off-by: Heiko Stuebner

[PATCH 6/7] s3c-hsudc: use udc_start and udc_stop functions

2011-12-17 Thread Heiko Stübner
udc_start and udc_stop reduce code duplication in comparison to start and stop generalising calls done by all drivers (i.e. bind and unbind) and moving these calls to common code. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/usb/gadget/s3c-hsudc.c | 44

[PATCH 7/7] s3c-hsudc: Add regulator handling

2011-12-17 Thread Heiko Stübner
The udc has three supplies: vdda (3.3V), vddi (1.2V) and vddosc (1.8-3.3V). Turn these on and off on start and stop calls. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/usb/gadget/s3c-hsudc.c | 43 --- 1 files changed, 39 insertions(+), 4

Re: [linux-next] make s5p64x0_defconfig build error

2011-12-15 Thread Heiko Stübner
Am Donnerstag, 15. Dezember 2011, 00:54:58 schrieb Axel Lin: Hi Kukjin, Axel and Will, thanks for pointing out. Oops, I couldn't have much time to follow up :( But let me look at that in this weekend and I know, it can be escaped before merge window :) I also found the same build

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2011-12-13 Thread Heiko Stübner
Am Montag, 5. Dezember 2011, 15:06:06 schrieb Mark Brown: Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when the

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-13 Thread Heiko Stübner
Am Dienstag, 13. Dezember 2011, 15:49:44 schrieb Heiko Stübner: Am Montag, 5. Dezember 2011, 17:50:13 schrieb Mark Brown: Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2011-12-12 Thread Heiko Stübner
Hi Thomas, thanks for your review and you are of course right with both your suggestions. I will submit a v2 series shortly, implementing these suggestions. Heiko Am Sonntag, 11. Dezember 2011, 06:47:43 schrieb Thomas Abraham: Hi Heiko, On 9 December 2011 15:20, Heiko Stübner he

[PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2011-12-12 Thread Heiko Stübner
Use the data field of of_device_id to hold the type for s3c_cpu_type. Signed-off-by: Heiko Stuebner he...@sntech.de Reviewed-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/rtc/rtc-s3c.c | 31 ++- 1 files changed, 22 insertions(+), 9 deletions(-) diff

[PATCH 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450

2011-12-09 Thread Heiko Stübner
Similar to the ADC the RTC of S3C2443 and S3C2416/2450 has some slight variances when compared to the existing types. This series adds support for those SoCs. As with the ADC patches, these changes where tested on S3C2416 hardware. The S3C2443 quirks are a subset of those and are done according

[PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions

2011-12-09 Thread Heiko Stübner
regs-rtc.h uses a mixture of tabs and spaces and also (xy) to format bits. So, before adding new stuff clean up the formatting and also add spaces to the bit definitions (i.e. (x y) ) Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-rtc.h | 66

[PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2011-12-09 Thread Heiko Stübner
Use the data field of of_device_id to hold the type for s3c_cpu_type. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/rtc/rtc-s3c.c | 27 +-- 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index

[PATCH 4/4] ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices

2011-12-09 Thread Heiko Stübner
As the S3C24xx SoCs use the same rtc device a renaming capability like in the adc driver is necessary. This patch adds a s3c_rtc_setname function and names the rtc devices for S3C2443 and S3C2416 accordingly. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/s3c2416.c

Re: [RFC][PATCH] Consolidate Samsung MAINTAINERS

2011-11-29 Thread Heiko Stübner
Am Dienstag, 15. November 2011, 08:11:05 schrieb Kukjin Kim: Kukjin Kim wrote: Heiko Stübner wrote: Am Sonntag 23 Oktober 2011, 00:12:14 schrieb Heiko Stübner: These days most Samsung stuff gets in the kernel through Kukjin Kim. This patch changes MAINTAINERS to reflect

Re: s3c2440 / s3c2416 broken

2011-11-09 Thread Heiko Stübner
Hi Paul, Am Donnerstag, 10. November 2011, 01:14:59 schrieb Thomas Abraham: On 10 November 2011 05:00, Paul Schilling paul.s.schill...@gmail.com wrote: Boot past init slow - stalled when using jffs2 also. On Wed, Nov 9, 2011 at 4:12 PM, Paul Schilling paul.s.schill...@gmail.com

Re: [RFC][PATCH] Consolidate Samsung MAINTAINERS

2011-11-04 Thread Heiko Stübner
Am Sonntag 23 Oktober 2011, 00:12:14 schrieb Heiko Stübner: These days most Samsung stuff gets in the kernel through Kukjin Kim. This patch changes MAINTAINERS to reflect this. By adding Kukjin Kim to the maintainers for S3C2410, S3C244x and S3C64xx alongside Ben Dooks the extra entries

[RFC][PATCH] Consolidate Samsung MAINTAINERS

2011-10-22 Thread Heiko Stübner
These days most Samsung stuff gets in the kernel through Kukjin Kim. This patch changes MAINTAINERS to reflect this. By adding Kukjin Kim to the maintainers for S3C2410, S3C244x and S3C64xx alongside Ben Dooks the extra entries become identical to the base ARM/SAMSUNG entry and can move into it.

Re: [PATCH 0/8] S3C2416: Enable armdiv and armclk

2011-10-14 Thread Heiko Stübner
Hi Kgene, Am Freitag, 14. Oktober 2011, 09:14:11 schrieb Kukjin Kim: Heiko Stübner wrote: [...] Heiko Stuebner (8): S3C2416: Add armdiv_mask constant. [...] As a note, if required, 1st patch which is fixing will be sent to stable. I don't think this is really necessary. The original

Re: [PATCH V3 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names

2011-10-11 Thread Heiko Stübner
Hi, somehow this did not apply against linux-next for me: error: patch failed: arch/arm/mach-exynos4/clock.c:1250 error: arch/arm/mach-exynos4/clock.c: patch does not apply error: patch failed: arch/arm/mach-s3c64xx/clock.c:697 error: arch/arm/mach-s3c64xx/clock.c: patch does not apply error:

Re: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-10-10 Thread Heiko Stübner
Hi Kgene, Am Montag, 10. Oktober 2011, 06:28:19 schrieb Kukjin Kim: Kukjin Kim wrote: Heiko Stübner wrote: Hi Kgene, Am Sonntag 02 Oktober 2011, 09:38:18 schrieb Kukjin Kim: How about following? I think following is also not bad... ok, I don't claim to have the right

[PATCH v3 0/5] S3C2443/S3C2416: Implement support for ADC

2011-10-10 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416/2450 differ in some regards from previous (S3C2410, etc) and later (S3C64XX, S5P) SoCs. This patch series adds support for these ADC implementations. Each patch was compile tested. But as I have only access to S3C2416 hardware, real life testing happened

[PATCH 1/5] S3C2443/S3C2416: Add adc registers

2011-10-10 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 2/5] s3c-adc: Fix mux bit modification in s3c_adc_select

2011-10-10 Thread Heiko Stübner
The mux bits in the adccon register should be cleared only if muxing is really done in ADCCON and not another register. This patch introduces a conditional for this. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/adc.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 3/5] S3C24XX: Allow overriding of adc device name

2011-10-10 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416 contain quirks not present in the stock S3C24xx adc. Therefore allow them to alter the device name via s3c_adc_setname. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/adc-core.h |2 +- 1 files changed, 1

[PATCH 4/5] s3c-adc: Add support for S3C2443

2011-10-10 Thread Heiko Stübner
The S3C2443-adc is 10 bit wide and has its mux-select in an extra register at base+0x18 Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2443/s3c2443.c |3 +++ arch/arm/plat-samsung/adc.c | 17 - 2 files changed, 15 insertions(+), 5 deletions(-) diff

[PATCH 5/5] s3c-adc: Add support for S3C2416/S3C2450

2011-10-10 Thread Heiko Stübner
The ADC of the S3C2416/2450 SoC is 10 or 12 bit wide, has its source selection in the register base+0x18 and its width selection in bit 03 of the ADCCON register. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/s3c2416.c |3 +++ arch/arm/plat-samsung/adc.c | 25

Re: [PATCH 3/3] ARM: SAMSUNG: Add lookup of sdhci-s3c clocks using generic names

2011-10-05 Thread Heiko Stübner
Am Mittwoch, 5. Oktober 2011, 07:31:09 schrieb Rajeshwari Shinde: Add support for lookup of sdhci-s3c controller clocks using generic names for s3c2416, s3c64xx, s5pc100, s5pv210 and exynos4 SoC's. Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com --- [...] diff --git

Re: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-10-02 Thread Heiko Stübner
Hi Kgene, Am Sonntag 02 Oktober 2011, 09:38:18 schrieb Kukjin Kim: How about following? I think following is also not bad... ok, I don't claim to have the right solution, so if keeping the TYPE_xxx enum is better, I will do a rework of the series according to your solution and resend it.

[PATCH v2 1/2] S3C2443/S3C2416: Add adc registers

2011-09-28 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: add spaces around arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH v2 2/2] s3c-adc: describe features via quirk constants

2011-09-28 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 0/8] S3C2416: Enable armdiv and armclk

2011-09-28 Thread Heiko Stübner
To enable cpu frequency scaling on the S3C2416/2450 it is necessary to define the arm-divider and armclock. The layout of the clocks (i.e. msysclk - armdiv - armclk) is the same on all three architectures (S3C2443/2416/2450) and only the possible dividers for armdiv differ. Therefore it is

[PATCH 1/8] S3C2416: Add armdiv_mask constant

2011-09-28 Thread Heiko Stübner
The S3C2416/2450 has only 3 bits for the armdiv setting instead of the 4 bits of the S3C2443. Signed-off-by: Heiko Stuebner he...@sntech.de --- .../mach-s3c2410/include/mach/regs-s3c2443-clock.h |1 + arch/arm/mach-s3c2416/clock.c |2 +- 2 files changed, 2

[PATCH 2/8] S3C2443: Add infrastructure to transmit armdiv to common code

2011-09-28 Thread Heiko Stübner
This is needed for making the armdiv clock common to S3C2443 and S3C2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c|4 +++- arch/arm/mach-s3c2443/clock.c|4 +++- arch/arm/plat-s3c24xx/include/plat/s3c2443.h |4

[PATCH 3/8] S3C2443: Move clk_arm and clk_armdiv to common code

2011-09-28 Thread Heiko Stübner
The system-layout of the armdiv and armclk is common to S3C2443/2416/2450 and only differs in the array of possible dividers. Therefore it is possible to reuse the clock definitions for all of these SoCs. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2443/clock.c |

[PATCH 4/8] S3C2416: Add comment describing the armdiv/armclk

2011-09-28 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2416/clock.c b/arch/arm/mach-s3c2416/clock.c index 3060796..7aa0cfa 100644 --- a/arch/arm/mach-s3c2416/clock.c +++

[PATCH 6/8] S3C2443: handle unset armdiv values gracefully

2011-09-28 Thread Heiko Stübner
The armdiv array may contain unset divider values. Check the relevant value to prevent division by zero errors. Also check for set nr_armdiv and armdivmask before meddling with clkdiv0. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/s3c2443-clock.c | 27

[PATCH 7/8] S3C2443: Accommodate cpufreq frequency scheme in armdiv

2011-09-28 Thread Heiko Stübner
Cpufreq uses frequencies in kHz and not Hz, so set_rate and round_rate would be called with a frequency of 26000 instead of 2 but the clock functions check for rates smaller or equal to the targetrate. As the armdiv does not support steps this small we can accommodate this by simply

[PATCH 8/8] S3C2443: use clk_get_rate to init fclk in common_setup_clocks

2011-09-28 Thread Heiko Stübner
Previously the fclk rate was calculated by dividing the pll through the divider value of the armdiv. With a real armdiv clk in place it's possible to simply read its value, which does essentially the same. This change makes the whole fdiv_fn function pointers supplied to

[PATCH] S3C2443: Add devname for hsmmc1 pclk

2011-09-28 Thread Heiko Stübner
S3C2443 uses hsmmc1 as its only hsmmc device and for S3C2416/2450 it's the second hsmmc channel with the same PCLKCON bit. The hsmmc-if clocks on both systems already got a devname, as did the hsmmc pclk for hsmmc0 on the S3C2416. So to make it possible to identify the hsmmc1 pclk on S3C2416 add

Re: [PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-09-26 Thread Heiko Stübner
Am Donnerstag 15 September 2011, 10:49:15 schrieben Sie: Heiko Stübner wrote: Am Sonntag, 28. August 2011, 20:06:31 schrieb Heiko Stübner: S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers

[PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv

2011-09-22 Thread Heiko Stübner
The changed statement should set the old armdiv bits to 0 and not everything else, before setting the new value. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2443/clock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c2443/clock.c

Re: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-21 Thread Heiko Stübner
Hi, Am Mittwoch, 21. September 2011, 14:32:14 schrieben Sie: Heiko Stübner wrote: The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used

[PATCH v2 0/7] S3C2443/S3C2416: Implement support for ADC

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416/2450 differ in some regards from previous (S3C2410, etc) and later (S3C64XX, S5P) SoCs. Defining more TYPE_ADCVx types for these SoCs would complicate the necessary checks a lot. Therefore I opted for the use of quirk constants which can describe the features

[PATCH 1/7] S3C2443/S3C2416: Add adc registers

2011-09-18 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 3/7] s3c-adc: Replace TYPE_ADCVx conditionals with quirks

2011-09-18 Thread Heiko Stübner
This patch replaces the static TYPE_ADCVs checks with checks for specific features of an adc block. For this the s3c_cpu_type enum in driver_data ist int containing containing the bit values describing the indivial adc block. This patch contains no functional changes, it merely replaces the type

[PATCH 4/7] s3c-adc: Fix mux bit modification in s3c_adc_select

2011-09-18 Thread Heiko Stübner
The mux bits in the adccon register should be cleared only if muxing is really done in ADCCON and not another register. This patch introduces a conditional for this. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/adc.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 5/7] S3C24XX: Allow overriding of adc device name

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416 contain quirks not present in the stock S3C24xx adc. Therefore allow them to alter the device name via s3c_adc_setname. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/adc-core.h |2 +- 1 files changed, 1

[PATCH v2 6/7] s3c-adc: Add support for S3C2443

2011-09-18 Thread Heiko Stübner
The S3C2443-adc is 10 bit wide and has its mux-select in an extra register at base+0x18 Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: wrap line over 80 chars and move setname call arch/arm/mach-s3c2443/s3c2443.c |3 +++ arch/arm/plat-samsung/adc.c |7 +++

[PATCH v2 7/7] s3c-adc: Add support for S3C2416/S3C2450

2011-09-18 Thread Heiko Stübner
The ADC of the S3C2416/2450 SoC is 10 or 12 bit wide, has its source selection in the register base+0x18 and its width selection in bit 03 of the ADCCON register. Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: move setname call arch/arm/mach-s3c2416/s3c2416.c |3 +++

Re: [PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-09-15 Thread Heiko Stübner
Am Sonntag, 28. August 2011, 20:06:31 schrieb Heiko Stübner: S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. ping? Any

[PATCH 5/7] S3C24XX: Allow overriding of adc device name

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416 contain quirks not present in the stock S3C24xx adc. Therefore allow them to alter the device name via s3c_adc_setname. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/adc-core.h |2 +- 1 files changed, 1

[PATCH 1/7] S3C2443/S3C2416: Add adc registers

2011-09-08 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 0/7] S3C2443/S3C2416: Implement support for ADC

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416/2450 differ in some regards from previous (S3C2410, etc) and later (S3C64XX, S5P) SoCs. Defining more TYPE_ADCVx types for these SoCs would complicate the necessary checks a lot. Therefore I opted for the use of quirk constants which can describe the features

[PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 4/7] s3c-adc: Fix mux bit modification in s3c_adc_select

2011-09-08 Thread Heiko Stübner
The mux bits in the adccon register should be cleared only if muxing is really done in ADCCON and not another register. This patch introduces a conditional for this. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/adc.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 7/7] s3c-adc: Add support for S3C2416/S3C2450

2011-09-08 Thread Heiko Stübner
The ADC of the S3C2416/2450 SoC is 10 or 12 bit wide, has its source selection in the register base+0x18 and its width selection in bit 03 of the ADCCON register. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/mach-smdk2416.c |3 +++ arch/arm/plat-samsung/adc.c

[PATCH 3/7] s3c-adc: Replace TYPE_ADCVx conditionals with quirks

2011-09-08 Thread Heiko Stübner
This patch replaces the static TYPE_ADCVs checks with checks for specific features of an adc block. For this the s3c_cpu_type enum in driver_data ist int containing containing the bit values describing the indivial adc block. This patch contains no functional changes, it merely replaces the type

[PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-08-28 Thread Heiko Stübner
S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. The I2S clocks were simply moved from S3C2443 to s3c2443-clock.c as they

[PATCH v2 4/4] S3C2443: Add hsspi-clock from pclk and rename unused S3C2443 hsspi sclk

2011-08-28 Thread Heiko Stübner
This clock is common to S3C2443/2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- Changes since v1: rename s3c2443 hsspi sclk (until now unused) arch/arm/mach-s3c2443/clock.c |2 +- arch/arm/plat-s3c24xx/s3c2443-clock.c |5 + 2 files changed, 6 insertions(+), 1

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-23 Thread Heiko Stübner
Am Dienstag 23 August 2011, 05:42:47 schrieb Kukjin Kim: Heiko Stübner wrote: Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus reference clock, selectable from external

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-21 Thread Heiko Stübner
Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus reference clock, selectable from external, esysclk or epllref + * + * Note, this used to be two clocks, but was compressed

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-21 Thread Heiko Stübner
Am Sonntag 21 August 2011, 22:26:16 schrieb Marek Vasut: On Sunday, August 21, 2011 07:25:04 PM Heiko Stübner wrote: Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus

[PATCH 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-08-20 Thread Heiko Stübner
S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. The I2S clocks were simply moved from S3C2443 to s3c2443-clock.c as they

[PATCH 2/4] S3C2443: Define constant for HSSPI pclk

2011-08-20 Thread Heiko Stübner
It's the same clock for 2443/2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- .../mach-s3c2410/include/mach/regs-s3c2443-clock.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2410/include/mach/regs-s3c2443-clock.h

[PATCH 3/4] S3C2416: Add HSSPI clock sourced from EPLL

2011-08-20 Thread Heiko Stübner
This clock is special to the S3C2416/2450 SoCs. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2416/clock.c b/arch/arm/mach-s3c2416/clock.c index

[PATCH 0/2] Remove hw_addr dma leftovers from S3C24xx machs

2011-08-10 Thread Heiko Stübner
While trying to sort the dma for S3C2416 I stumbled open the hw_addr declarations in the other dma.c files. It took me a while to figure out that they seem to be some sort of leftover, i.e. they are used in dma-pl080.c of the old Samsung kernels based on 2.6.21 but nowhere in current kernels.

[PATCH 1/2] Remove hw_addr from s3c24XX dma channel declarations

2011-08-10 Thread Heiko Stübner
According to commit c4806174c516d26bf4a72db1789cfc96e4950d07 (ARM: S3C2412: DMA: Remove I2S FIFO address) the S3C DMA API does not make use of hw_addr.to/from declared for some of the channels in mach-s3c24XX/dma.c Grepping through the kernel also did non reveal any new users of these properties

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Heiko Stübner
Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote: This patch adds to support DMA generic API to transfer raw SPI data. Basiclly the spi driver uses DMA generic API if architecture supports it. Otherwise, uses

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Heiko Stübner
Am Montag 08 August 2011, 20:16:58 schrieben Sie: On Mon, Aug 8, 2011 at 11:25 PM, Heiko Stübner he...@sntech.de wrote: Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: Btw, this spi driver is for S3C64xx(with pl080) and S5P(with pl330) series, both of which have DMAENGINE drivers

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: +#if defined(CONFIG_DMADEV_PL330) + memset(slave_config, 0, sizeof(slave_config)); + slave_config.direction = DMA_TO_DEVICE; +

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: +#if defined(CONFIG_DMADEV_PL330

[PATCH v3 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-02 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Changes since v1: add missing Signed-off-by lines Changes since v2: fix mangled tabs Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in

[PATCH v3 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-02 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966

[PATCH v3 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-02 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5

[PATCH v3 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-02 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git

[PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c remove the now empty

[PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++

[PATCH 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-s3c2410/irq.c

[PATCH 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
--- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git a/arch/arm/mach-s3c2410/Makefile b/arch/arm/mach-s3c2410/Makefile index

Re: [PATCH] Fix compile failures by syscore_ops change on s3c2416

2011-06-01 Thread Heiko Stübner
Am Dienstag 31 Mai 2011 schrieb Sergei Shtylyov: On 31-05-2011 0:34, Heiko Stübner wrote: s3c24xx_irq_syscore_ops is only defined in mach-s3c2410/irq.c which is not used by s3c2416. Also s3c2410_dma_chan needs a struct prefix Saying also seems a good sign that you should do two

Re: [PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011 schrieb Abdoulaye Walsimou GAYE: Heiko Stübner wrote: The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. I submitted same patches days ago [1], [1] http://thread.gmane.org

[PATCH v2 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966

[PATCH v2 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5

[PATCH v2 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git

Re: [PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011, 18:01:34 schrieben Sie: Hello. Heiko Stübner wrote: s3c2410_dma_chan is not a type itself, so struct is required. Your signoffs are missing, so your patches can't be applied... *grml* ... I seem to have bad luck with my patches these days will resend Heiko

[PATCH] Fix compile failures by syscore_ops change on s3c2416

2011-05-30 Thread Heiko Stübner
s3c24xx_irq_syscore_ops is only defined in mach-s3c2410/irq.c which is not used by s3c2416. Also s3c2410_dma_chan needs a struct prefix --- It feels wrong to put a double of s3c24xx_irq_syscore_ops in another file, but I haven't found a better place for the whole thing yet. Might

I80 interface on S3C and manual command mode

2011-05-15 Thread Heiko Stübner
Hi, I'm working on porting a kernel to a device which has an epaper-controller connected to the I80 interface of an S3C2416 and uses its manual command mode, via SIFCCON[0,1,2], as the datasheet calls it. While digging around the mailinglists I found patches by Inki Dae that implement the I80

[PATCH v3 0/4] USB: gadget: Add Samsung S3C24xx USB HS controller driver

2011-05-07 Thread Heiko Stübner
Hi all, Am Samstag 16 April 2011, 16:58:30 schrieb Greg KH: I'd prefer to get the correct version implemented and would not like to accept a patch that everyone knows is wrong. again the whole 4-patch series. This time with added set_wedge function. Thanks Heiko -- To unsubscribe from this

[PATCH 1/4] ARM: S3C2416: Add USB Phy register definitions

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com Add register definitions required to configure the USB Phy. The definitions for PHYCTRL, PHYPWR, URSTCON and UCLKCON registers and corresponding bit field definitions are added. Signed-off-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Sangbeom

[PATCH 2/4] ARM: S3C24XX: Add plaform device definition for USB High-Speed gadget controller.

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com S3C2416, S3C2443 and S3C2450 includes a USB High-Speed Gadget controller module. This patch adds the following for supporting this controller. 1. Definition for USB High-Speed controller base address. 2. Platform device instantiation. 3. Declaration for

[PATCH v5 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx SoC's that include this controller. Signed-off-by: Thomas Abraham

[PATCH 4/4] ARM: S3C2416: Add support for USB 2.0 High-Speed gadget controller

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com Add support for USB 2.0 High-Speed gadget controller driver for Samsung's S3C2416 processor. Signed-off-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Sangbeom Kim sbki...@samsung.com --- arch/arm/mach-s3c2416/mach-smdk2416.c | 27

<    2   3   4   5   6   7   8   >