Re: [PATCH RESEND 0/4] USB: gadget: Add Samsung S3C24xx USB HS controller driver

2011-04-08 Thread Heiko Stübner
Am Mittwoch 23 März 2011 schrieb Heiko Stübner: On 2010-10-13 Sangbeom Kim sent 4 patches to add support the USB High-Speed device controller module on Samsung's S3C2416, S3C2443 and S3C2450. [1] bdooks worte on 2010-10-22: patch 3/4 needs a bit of work, otherwise looks ok. I'll look

[PATCH RESEND v2 0/4] USB: gadget: Add Samsung S3C24xx USB HS controller driver

2011-04-14 Thread Heiko Stübner
Am Donnerstag 14 April 2011 schrieb Greg KH: The Renesas driver got number 0x29, so this patch no longer applies :( Care to respin this whole series against the next linux-next tree and resend it to me so I can apply it? As requested by greg k-h, again the whole 4-patch series against most

[PATCH 2/4] ARM: S3C24XX: Add plaform device definition for USB High-Speed gadget controller.

2011-04-14 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com S3C2416, S3C2443 and S3C2450 includes a USB High-Speed Gadget controller module. This patch adds the following for supporting this controller. 1. Definition for USB High-Speed controller base address. 2. Platform device instantiation. 3. Declaration for

[PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-14 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx SoC's that include this controller. Signed-off-by: Thomas Abraham

[PATCH 4/4] ARM: S3C2416: Add support for USB 2.0 High-Speed gadget controller

2011-04-14 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com Add support for USB 2.0 High-Speed gadget controller driver for Samsung's S3C2416 processor. Signed-off-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Sangbeom Kim sbki...@samsung.com --- arch/arm/mach-s3c2416/mach-smdk2416.c | 27

Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-14 Thread Heiko Stübner
Am Donnerstag 14 April 2011, 17:47:48 schrieb Greg KH: On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote: On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote: From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed

Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-16 Thread Heiko Stübner
Am Donnerstag 14 April 2011, 19:15:23 schrieb Alan Stern: On Thu, 14 Apr 2011, Greg KH wrote: On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote: On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote: From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416,

Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-16 Thread Heiko Stübner
Am Samstag 16 April 2011, 16:58:30 schrieb Greg KH: On Sat, Apr 16, 2011 at 12:00:31PM +0200, Heiko Stübner wrote: Am Donnerstag 14 April 2011, 19:15:23 schrieb Alan Stern: On Thu, 14 Apr 2011, Greg KH wrote: On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote: On Thu, 14 Apr

S3C2416, S3C2443 HS-SPI driver?

2011-04-28 Thread Heiko Stübner
Hi, does a driver for spi on s3c2416/s3c2443 SoCs exist somewhere? The one for the other s3c24XX SoCs seems to be different. I did a comparison of the spi-parts of s3c2416 and s3c6400 manuals and they seem very much alike in their registers and working descriptions. The only real differences

[PATCH v3 0/4] USB: gadget: Add Samsung S3C24xx USB HS controller driver

2011-05-07 Thread Heiko Stübner
Hi all, Am Samstag 16 April 2011, 16:58:30 schrieb Greg KH: I'd prefer to get the correct version implemented and would not like to accept a patch that everyone knows is wrong. again the whole 4-patch series. This time with added set_wedge function. Thanks Heiko -- To unsubscribe from this

[PATCH 1/4] ARM: S3C2416: Add USB Phy register definitions

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com Add register definitions required to configure the USB Phy. The definitions for PHYCTRL, PHYPWR, URSTCON and UCLKCON registers and corresponding bit field definitions are added. Signed-off-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Sangbeom

[PATCH 2/4] ARM: S3C24XX: Add plaform device definition for USB High-Speed gadget controller.

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com S3C2416, S3C2443 and S3C2450 includes a USB High-Speed Gadget controller module. This patch adds the following for supporting this controller. 1. Definition for USB High-Speed controller base address. 2. Platform device instantiation. 3. Declaration for

[PATCH v5 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx SoC's that include this controller. Signed-off-by: Thomas Abraham

[PATCH 4/4] ARM: S3C2416: Add support for USB 2.0 High-Speed gadget controller

2011-05-07 Thread Heiko Stübner
From: Thomas Abraham thomas...@samsung.com Add support for USB 2.0 High-Speed gadget controller driver for Samsung's S3C2416 processor. Signed-off-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Sangbeom Kim sbki...@samsung.com --- arch/arm/mach-s3c2416/mach-smdk2416.c | 27

I80 interface on S3C and manual command mode

2011-05-15 Thread Heiko Stübner
Hi, I'm working on porting a kernel to a device which has an epaper-controller connected to the I80 interface of an S3C2416 and uses its manual command mode, via SIFCCON[0,1,2], as the datasheet calls it. While digging around the mailinglists I found patches by Inki Dae that implement the I80

[PATCH] Fix compile failures by syscore_ops change on s3c2416

2011-05-30 Thread Heiko Stübner
s3c24xx_irq_syscore_ops is only defined in mach-s3c2410/irq.c which is not used by s3c2416. Also s3c2410_dma_chan needs a struct prefix --- It feels wrong to put a double of s3c24xx_irq_syscore_ops in another file, but I haven't found a better place for the whole thing yet. Might

[PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c remove the now empty

[PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++

[PATCH 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-s3c2410/irq.c

[PATCH 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
--- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git a/arch/arm/mach-s3c2410/Makefile b/arch/arm/mach-s3c2410/Makefile index

Re: [PATCH] Fix compile failures by syscore_ops change on s3c2416

2011-06-01 Thread Heiko Stübner
Am Dienstag 31 Mai 2011 schrieb Sergei Shtylyov: On 31-05-2011 0:34, Heiko Stübner wrote: s3c24xx_irq_syscore_ops is only defined in mach-s3c2410/irq.c which is not used by s3c2416. Also s3c2410_dma_chan needs a struct prefix Saying also seems a good sign that you should do two

Re: [PATCH 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011 schrieb Abdoulaye Walsimou GAYE: Heiko Stübner wrote: The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. I submitted same patches days ago [1], [1] http://thread.gmane.org

[PATCH v2 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966

[PATCH v2 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-01 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5

[PATCH v2 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-01 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git

Re: [PATCH 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-01 Thread Heiko Stübner
Am Mittwoch 01 Juni 2011, 18:01:34 schrieben Sie: Hello. Heiko Stübner wrote: s3c2410_dma_chan is not a type itself, so struct is required. Your signoffs are missing, so your patches can't be applied... *grml* ... I seem to have bad luck with my patches these days will resend Heiko

[PATCH v3 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx

2011-06-02 Thread Heiko Stübner
The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Changes since v1: add missing Signed-off-by lines Changes since v2: fix mangled tabs Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in

[PATCH v3 1/3] Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan

2011-06-02 Thread Heiko Stübner
s3c2410_dma_chan is not a type itself, so struct is required. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index c10d10c..2abf966

[PATCH v3 2/3] Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c

2011-06-02 Thread Heiko Stübner
s3c24xx_irq_syscore_ops was only defined for s3c2410 cpus leading to compile errors on for example 2412 and 2416. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/irq.c |5 - arch/arm/plat-s3c24xx/irq.c |6 ++ 2 files changed, 6 insertions(+), 5

[PATCH v3 3/3] remove the now empty mach-s3c2410/irq.c

2011-06-02 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 29 - 2 files changed, 0 insertions(+), 30 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c diff --git

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: +#if defined(CONFIG_DMADEV_PL330) + memset(slave_config, 0, sizeof(slave_config)); + slave_config.direction = DMA_TO_DEVICE; +

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-04 Thread Heiko Stübner
Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: Am Montag 04 Juli 2011, 18:42:51 schrieb Grant Likely: On Mon, Jul 04, 2011 at 09:18:34PM +0900, Kukjin Kim wrote: +#if defined(CONFIG_DMADEV_PL330

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Heiko Stübner
Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote: This patch adds to support DMA generic API to transfer raw SPI data. Basiclly the spi driver uses DMA generic API if architecture supports it. Otherwise, uses

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Heiko Stübner
Am Montag 08 August 2011, 20:16:58 schrieben Sie: On Mon, Aug 8, 2011 at 11:25 PM, Heiko Stübner he...@sntech.de wrote: Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: Btw, this spi driver is for S3C64xx(with pl080) and S5P(with pl330) series, both of which have DMAENGINE drivers

[PATCH 0/2] Remove hw_addr dma leftovers from S3C24xx machs

2011-08-10 Thread Heiko Stübner
While trying to sort the dma for S3C2416 I stumbled open the hw_addr declarations in the other dma.c files. It took me a while to figure out that they seem to be some sort of leftover, i.e. they are used in dma-pl080.c of the old Samsung kernels based on 2.6.21 but nowhere in current kernels.

[PATCH 1/2] Remove hw_addr from s3c24XX dma channel declarations

2011-08-10 Thread Heiko Stübner
According to commit c4806174c516d26bf4a72db1789cfc96e4950d07 (ARM: S3C2412: DMA: Remove I2S FIFO address) the S3C DMA API does not make use of hw_addr.to/from declared for some of the channels in mach-s3c24XX/dma.c Grepping through the kernel also did non reveal any new users of these properties

[PATCH 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-08-20 Thread Heiko Stübner
S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. The I2S clocks were simply moved from S3C2443 to s3c2443-clock.c as they

[PATCH 2/4] S3C2443: Define constant for HSSPI pclk

2011-08-20 Thread Heiko Stübner
It's the same clock for 2443/2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- .../mach-s3c2410/include/mach/regs-s3c2443-clock.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2410/include/mach/regs-s3c2443-clock.h

[PATCH 3/4] S3C2416: Add HSSPI clock sourced from EPLL

2011-08-20 Thread Heiko Stübner
This clock is special to the S3C2416/2450 SoCs. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2416/clock.c b/arch/arm/mach-s3c2416/clock.c index

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-21 Thread Heiko Stübner
Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus reference clock, selectable from external, esysclk or epllref + * + * Note, this used to be two clocks, but was compressed

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-21 Thread Heiko Stübner
Am Sonntag 21 August 2011, 22:26:16 schrieb Marek Vasut: On Sunday, August 21, 2011 07:25:04 PM Heiko Stübner wrote: Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-23 Thread Heiko Stübner
Am Dienstag 23 August 2011, 05:42:47 schrieb Kukjin Kim: Heiko Stübner wrote: Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus reference clock, selectable from external

[PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-08-28 Thread Heiko Stübner
S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. The I2S clocks were simply moved from S3C2443 to s3c2443-clock.c as they

[PATCH v2 4/4] S3C2443: Add hsspi-clock from pclk and rename unused S3C2443 hsspi sclk

2011-08-28 Thread Heiko Stübner
This clock is common to S3C2443/2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- Changes since v1: rename s3c2443 hsspi sclk (until now unused) arch/arm/mach-s3c2443/clock.c |2 +- arch/arm/plat-s3c24xx/s3c2443-clock.c |5 + 2 files changed, 6 insertions(+), 1

[PATCH 5/7] S3C24XX: Allow overriding of adc device name

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416 contain quirks not present in the stock S3C24xx adc. Therefore allow them to alter the device name via s3c_adc_setname. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/adc-core.h |2 +- 1 files changed, 1

[PATCH 1/7] S3C2443/S3C2416: Add adc registers

2011-09-08 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 0/7] S3C2443/S3C2416: Implement support for ADC

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416/2450 differ in some regards from previous (S3C2410, etc) and later (S3C64XX, S5P) SoCs. Defining more TYPE_ADCVx types for these SoCs would complicate the necessary checks a lot. Therefore I opted for the use of quirk constants which can describe the features

[PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-08 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 4/7] s3c-adc: Fix mux bit modification in s3c_adc_select

2011-09-08 Thread Heiko Stübner
The mux bits in the adccon register should be cleared only if muxing is really done in ADCCON and not another register. This patch introduces a conditional for this. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/adc.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 7/7] s3c-adc: Add support for S3C2416/S3C2450

2011-09-08 Thread Heiko Stübner
The ADC of the S3C2416/2450 SoC is 10 or 12 bit wide, has its source selection in the register base+0x18 and its width selection in bit 03 of the ADCCON register. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/mach-smdk2416.c |3 +++ arch/arm/plat-samsung/adc.c

[PATCH 3/7] s3c-adc: Replace TYPE_ADCVx conditionals with quirks

2011-09-08 Thread Heiko Stübner
This patch replaces the static TYPE_ADCVs checks with checks for specific features of an adc block. For this the s3c_cpu_type enum in driver_data ist int containing containing the bit values describing the indivial adc block. This patch contains no functional changes, it merely replaces the type

Re: [PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-09-15 Thread Heiko Stübner
Am Sonntag, 28. August 2011, 20:06:31 schrieb Heiko Stübner: S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers. So as a first step in this direction, these patches add their respective clocks. ping? Any

[PATCH v2 0/7] S3C2443/S3C2416: Implement support for ADC

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416/2450 differ in some regards from previous (S3C2410, etc) and later (S3C64XX, S5P) SoCs. Defining more TYPE_ADCVx types for these SoCs would complicate the necessary checks a lot. Therefore I opted for the use of quirk constants which can describe the features

[PATCH 1/7] S3C2443/S3C2416: Add adc registers

2011-09-18 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 3/7] s3c-adc: Replace TYPE_ADCVx conditionals with quirks

2011-09-18 Thread Heiko Stübner
This patch replaces the static TYPE_ADCVs checks with checks for specific features of an adc block. For this the s3c_cpu_type enum in driver_data ist int containing containing the bit values describing the indivial adc block. This patch contains no functional changes, it merely replaces the type

[PATCH 4/7] s3c-adc: Fix mux bit modification in s3c_adc_select

2011-09-18 Thread Heiko Stübner
The mux bits in the adccon register should be cleared only if muxing is really done in ADCCON and not another register. This patch introduces a conditional for this. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/adc.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 5/7] S3C24XX: Allow overriding of adc device name

2011-09-18 Thread Heiko Stübner
The adc blocks of S3C2443 and S3C2416 contain quirks not present in the stock S3C24xx adc. Therefore allow them to alter the device name via s3c_adc_setname. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/adc-core.h |2 +- 1 files changed, 1

[PATCH v2 6/7] s3c-adc: Add support for S3C2443

2011-09-18 Thread Heiko Stübner
The S3C2443-adc is 10 bit wide and has its mux-select in an extra register at base+0x18 Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: wrap line over 80 chars and move setname call arch/arm/mach-s3c2443/s3c2443.c |3 +++ arch/arm/plat-samsung/adc.c |7 +++

[PATCH v2 7/7] s3c-adc: Add support for S3C2416/S3C2450

2011-09-18 Thread Heiko Stübner
The ADC of the S3C2416/2450 SoC is 10 or 12 bit wide, has its source selection in the register base+0x18 and its width selection in bit 03 of the ADCCON register. Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: move setname call arch/arm/mach-s3c2416/s3c2416.c |3 +++

Re: [PATCH 2/7] s3c-adc: describe features via quirk constants

2011-09-21 Thread Heiko Stübner
Hi, Am Mittwoch, 21. September 2011, 14:32:14 schrieben Sie: Heiko Stübner wrote: The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used

[PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv

2011-09-22 Thread Heiko Stübner
The changed statement should set the old armdiv bits to 0 and not everything else, before setting the new value. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2443/clock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c2443/clock.c

Re: [PATCH v2 0/4] S3C2416: Enable IIS and HSSPI clocks

2011-09-26 Thread Heiko Stübner
Am Donnerstag 15 September 2011, 10:49:15 schrieben Sie: Heiko Stübner wrote: Am Sonntag, 28. August 2011, 20:06:31 schrieb Heiko Stübner: S3C2416/2450 (probably S3C2443 too) can use the newer style kernel-drivers made for S3C64xx and above for their I2S and HS-SPI controllers

[PATCH v2 1/2] S3C2443/S3C2416: Add adc registers

2011-09-28 Thread Heiko Stübner
The adc blocks of the S3C2443 and S3C2416 define some additional registers and bits. Signed-off-by: Heiko Stuebner he...@sntech.de --- changes since v1: add spaces around arch/arm/plat-samsung/include/plat/regs-adc.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH v2 2/2] s3c-adc: describe features via quirk constants

2011-09-28 Thread Heiko Stübner
The adc blocks of S3C2410 through S5P have a multitude of quirks, i.e. moved bits or whole new registers. This patch tries to describe these individual features through constants which can be used to describe an adc. As SoCs sometimes share only some of these quirks defining TYPE_ADCVx values

[PATCH 0/8] S3C2416: Enable armdiv and armclk

2011-09-28 Thread Heiko Stübner
To enable cpu frequency scaling on the S3C2416/2450 it is necessary to define the arm-divider and armclock. The layout of the clocks (i.e. msysclk - armdiv - armclk) is the same on all three architectures (S3C2443/2416/2450) and only the possible dividers for armdiv differ. Therefore it is

[PATCH 1/8] S3C2416: Add armdiv_mask constant

2011-09-28 Thread Heiko Stübner
The S3C2416/2450 has only 3 bits for the armdiv setting instead of the 4 bits of the S3C2443. Signed-off-by: Heiko Stuebner he...@sntech.de --- .../mach-s3c2410/include/mach/regs-s3c2443-clock.h |1 + arch/arm/mach-s3c2416/clock.c |2 +- 2 files changed, 2

[PATCH 2/8] S3C2443: Add infrastructure to transmit armdiv to common code

2011-09-28 Thread Heiko Stübner
This is needed for making the armdiv clock common to S3C2443 and S3C2416/2450. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c|4 +++- arch/arm/mach-s3c2443/clock.c|4 +++- arch/arm/plat-s3c24xx/include/plat/s3c2443.h |4

[PATCH 3/8] S3C2443: Move clk_arm and clk_armdiv to common code

2011-09-28 Thread Heiko Stübner
The system-layout of the armdiv and armclk is common to S3C2443/2416/2450 and only differs in the array of possible dividers. Therefore it is possible to reuse the clock definitions for all of these SoCs. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2443/clock.c |

[PATCH 4/8] S3C2416: Add comment describing the armdiv/armclk

2011-09-28 Thread Heiko Stübner
Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c2416/clock.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c2416/clock.c b/arch/arm/mach-s3c2416/clock.c index 3060796..7aa0cfa 100644 --- a/arch/arm/mach-s3c2416/clock.c +++

[PATCH 6/8] S3C2443: handle unset armdiv values gracefully

2011-09-28 Thread Heiko Stübner
The armdiv array may contain unset divider values. Check the relevant value to prevent division by zero errors. Also check for set nr_armdiv and armdivmask before meddling with clkdiv0. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-s3c24xx/s3c2443-clock.c | 27

[PATCH 7/8] S3C2443: Accommodate cpufreq frequency scheme in armdiv

2011-09-28 Thread Heiko Stübner
Cpufreq uses frequencies in kHz and not Hz, so set_rate and round_rate would be called with a frequency of 26000 instead of 2 but the clock functions check for rates smaller or equal to the targetrate. As the armdiv does not support steps this small we can accommodate this by simply

[PATCH 8/8] S3C2443: use clk_get_rate to init fclk in common_setup_clocks

2011-09-28 Thread Heiko Stübner
Previously the fclk rate was calculated by dividing the pll through the divider value of the armdiv. With a real armdiv clk in place it's possible to simply read its value, which does essentially the same. This change makes the whole fdiv_fn function pointers supplied to

[PATCH] S3C2443: Add devname for hsmmc1 pclk

2011-09-28 Thread Heiko Stübner
S3C2443 uses hsmmc1 as its only hsmmc device and for S3C2416/2450 it's the second hsmmc channel with the same PCLKCON bit. The hsmmc-if clocks on both systems already got a devname, as did the hsmmc pclk for hsmmc0 on the S3C2416. So to make it possible to identify the hsmmc1 pclk on S3C2416 add

[PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

2014-01-12 Thread Heiko Stübner
The function is nearly empty and samsung_cpu_rev is static so already 0 making the function obsolete, therefore remove it. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c24xx/common.c |1 - arch/arm/plat-samsung/cpu.c |7 ---

Re: [PATCH 0/6] mmc: sdhci-s3c: Fix base clock source management

2014-01-12 Thread Heiko Stübner
Am Samstag, 11. Januar 2014, 22:39:00 schrieb Tomasz Figa: Tested on S3C6410-based Mini6410 board, with following performance figures: * Before this series (133 MHz HCLK always selected, leading to at most 33 MHz card clock): root@tiny6410:~# hdparm -t /dev/mmcblk0 /dev/mmcblk0:

Re: [PATCH] ARM: s3c24xx: explicit dependency on plat/gpio-cfg.h

2014-01-14 Thread Heiko Stübner
Am Dienstag, 14. Januar 2014, 15:13:08 schrieb Linus Walleij: Previously the custom GPIO header for the S3C24xx would in turn bring in the custom pin control implementation from plat/gpio-cfg.h. This is not good as it mixes up two subsystems and makes the dependencies hard to track. Make the

Re: [PATCH 1/1] ARM: S3C24XX: Move rtc-core.h from plat to mach

2014-01-15 Thread Heiko Stübner
Am Montag, 30. Dezember 2013, 16:10:08 schrieb Sachin Kamat: plat/rtc-core.h is only referenced from mach-s3c24xx. Hence move it there to de-populate the plat directory. While at it also do some cleanup of the header file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Heiko

Re: [PATCH] serial: samsung: move clock deactivation below uart registration

2014-01-21 Thread Heiko Stübner
/?h=fixes [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=bcee63488ece9a0fca8be19951428a7b41001e66 Am Donnerstag, 5. Dezember 2013, 00:54:38 schrieb Heiko Stübner: Commit 60e93575476f (serial: samsung: enable clock before clearing pending interrupts during init

Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function

2014-01-24 Thread Heiko Stübner
On Thursday 23 January 2014 23:35:29 Tomasz Figa wrote: On 23.01.2014 20:02, Heiko Stübner wrote: Am Donnerstag, 23. Januar 2014, 19:51:34 schrieb Tomasz Figa: On 23.01.2014 19:36, Heiko Stübner wrote: In general, I want to try establishing some sort of general restart way

Re: [PATCH V2] regulator: fixed: update to devm_* API

2014-01-27 Thread Heiko Stübner
On Tuesday, 28. January 2014 12:46:01 Manish Badarkhe wrote: Hi Dmitry, Thank you for your review. On Tue, Jan 28, 2014 at 12:03 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Tue, Jan 28, 2014 at 08:42:00AM +0530, Manish Badarkhe wrote: Update the code to

Re: [PATCH V2] regulator: fixed: update to devm_* API

2014-01-28 Thread Heiko Stübner
On Tuesday, 28. January 2014 14:16:39 Manish Badarkhe wrote: Hi Heiko Thank you for your reply. On Tue, Jan 28, 2014 at 1:08 PM, Heiko Stübner he...@sntech.de wrote: On Tuesday, 28. January 2014 12:46:01 Manish Badarkhe wrote: Hi Dmitry, Thank you for your review. On Tue, Jan

Re: [PATCH v2 1/7] cpufreq: cpufreq-cpu0: allow optional safe voltage during frequency transitions

2014-01-30 Thread Heiko Stübner
On Thursday, 30. January 2014 18:23:44 Thomas Abraham wrote: Hi Mike, On Wed, Jan 29, 2014 at 12:17 AM, Mike Turquette mturque...@linaro.org wrote: On Mon, Jan 27, 2014 at 9:30 PM, Thomas Abraham ta.oma...@gmail.com wrote: Hi Mike, On Tue, Jan 28, 2014 at 1:55 AM, Mike Turquette

Re: [PATCH v2 1/7] cpufreq: cpufreq-cpu0: allow optional safe voltage during frequency transitions

2014-02-05 Thread Heiko Stübner
Am Freitag, 31. Januar 2014, 20:10:51 schrieb Mike Turquette: Quoting Heiko Stübner (2014-01-30 07:09:04) On Thursday, 30. January 2014 18:23:44 Thomas Abraham wrote: Hi Mike, On Wed, Jan 29, 2014 at 12:17 AM, Mike Turquette mturque...@linaro.org wrote: On Mon, Jan 27, 2014

Re: [PATCH v2 7/9] clk: samsung: Drop old suspend/resume code

2014-02-07 Thread Heiko Stübner
Am Donnerstag, 6. Februar 2014, 19:16:54 schrieb Tomasz Figa: Since all SoC drivers have been moved to local suspend/resume handling, the old code can be safely dropped. Signed-off-by: Tomasz Figa t.f...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com So it looks like I'll

Re: [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework

2014-02-11 Thread Heiko Stübner
Hi Kukjin, Am Dienstag, 11. Februar 2014, 11:46:13 schrieb Kukjin Kim: 2014-02-10 1:26 GMT+05:30 Tomasz Figa tomasz.f...@gmail.com: For patches 4, 5, 9, 10, 11, 12: Reviewed-by: Tomasz Figa t.f...@samsung.com For patches 6, 7: Acked-by: Tomasz Figa t.f...@samsung.com

Re: [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()

2014-02-11 Thread Heiko Stübner
Am Sonntag, 12. Januar 2014, 21:34:29 schrieb Heiko Stübner: The function is nearly empty and samsung_cpu_rev is static so already 0 making the function obsolete, therefore remove it. Signed-off-by: Heiko Stuebner he...@sntech.de ping :-) --- arch/arm/mach-s3c24xx/common.c

Re: [PATCH] ARM: SAMSUNG: remove obsolete tick.h

2014-02-11 Thread Heiko Stübner
Am Freitag, 10. Januar 2014, 17:17:43 schrieb kg...@kernel.org: Heiko Stübner wrote: Commit 48cf83dc12f2 (ARM: samsung: remove unused tick.h) removed some occurences of tick.h. tick.h itself and s3c24xx_ostimer_pending was only used by the old timer driver and is not used anymore

[PATCH 0/2] ARM: SAMSUNG: move all arches to generic uncompress.h

2014-02-16 Thread Heiko Stübner
On 2014-01-06 Sachin Kamat posted two patches converting Exynos to use the generic uncompress.h. But in fact all Samsung platforms can go this route, as all Samsung uncompress.h files are simply used to set up the serial port. As the original patches were not yet applied, this series includes

[PATCH 1/2] ARM: SAMSUNG: use generic uncompress.h

2014-02-16 Thread Heiko Stübner
All Samsung platforms use the custom uncompress.h simply to setup the uart for the initial debug output. This can also be done using the generic uncompress.h. Suggested-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/Kconfig.debug | 5 +++-- 1

[PATCH 2/2] ARM: SAMSUNG: remove all custom uncompress.h

2014-02-16 Thread Heiko Stübner
All Samsung platforms now use the generic uncompress.h so all the custom ones can be removed. Suggested-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-exynos/include/mach/uncompress.h | 48 ---

Re: [PATCH 02/12] dt-bindings: document s3c24xx controller for external clock output

2014-02-16 Thread Heiko Stübner
Am Sonntag, 9. Februar 2014, 02:54:40 schrieb Tomasz Figa: Hi Heiko, On 13.12.2013 13:59, Heiko Stübner wrote: The clock settings are distributed over a regular register and parts of the misccr register. Signed-off-by: Heiko Stuebner he...@sntech.de --- .../bindings/clock

[PATCH v5 2/7] clk: samsung: add plls used by the s3c2443

2014-02-17 Thread Heiko Stübner
The s3c2443 uses different plls that are not present yet. Therefore add the two needed types. Signed-off-by: Heiko Stuebner he...@sntech.de Acked-by: Tomasz Figa t.f...@samsung.com Acked-by: Mike Turquette mturque...@linaro.org --- drivers/clk/samsung/clk-pll.c | 72

[PATCH v5 3/7] dt-bindings: add binding for clock-controller of s3c2443 and following

2014-02-17 Thread Heiko Stübner
Starting with the s3c2443 the s3c24xx series got a new clock tree compared to the previous s3c24xx socs. This binding describes the clock controller found in the s3c2443, s3c2416 and s3c2450 socs. Signed-off-by: Heiko Stuebner he...@sntech.de Acked-by: Tomasz Figa t.f...@samsung.com ---

[PATCH v5 4/7] clk: samsung: add clock-driver for s3c2416, s3c2443 and s3c2450

2014-02-17 Thread Heiko Stübner
The three SoCs share a common clock tree which only differs in the existence of some special clocks. As with all parts common to these three SoCs the driver is named after the s3c2443, as it was the first SoC introducing this structure and there exists no other label to describe this s3c24xx

[PATCH v5 6/7] ARM: dt: add clock data for s3c2416

2014-02-17 Thread Heiko Stübner
This adds the clock controller itself, the xti clock on the smdk2416 as well as the clock references in the individual device nodes. Signed-off-by: Heiko Stuebner he...@sntech.de Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/s3c2416-smdk2416.dts | 13 +++

[PATCH v5 7/7] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework

2014-02-17 Thread Heiko Stübner
This converts the mentioned platforms to use the newly introduced driver for the common clock framework for them. With this the whole legacy clock structure can go away too. Signed-off-by: Heiko Stuebner he...@sntech.de Reviewed-by: Tomasz Figa t.f...@samsung.com ---

Re: [PATCH 08/12] clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442

2014-02-17 Thread Heiko Stübner
Hi Tomasz, Am Sonntag, 9. Februar 2014, 20:34:26 schrieb Tomasz Figa: +/* + * fixed rate clocks generated outside the soc + * Only necessary until the devicetree-move is complete + */ +struct samsung_fixed_rate_clock s3c2410_common_frate_clks[] __initdata = { + FRATE(XTI, xti,

Re: [PATCH 08/12] clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442

2014-02-17 Thread Heiko Stübner
Am Montag, 17. Februar 2014, 23:37:16 schrieb Tomasz Figa: On 17.02.2014 22:05, Heiko Stübner wrote: Hi Tomasz, Am Sonntag, 9. Februar 2014, 20:34:26 schrieb Tomasz Figa: +/* + * fixed rate clocks generated outside the soc + * Only necessary until the devicetree-move is complete

[PATCH v2 0/5] ARM: S3C24XX: convert s3c2412 to common clock framework

2014-02-22 Thread Heiko Stübner
Second incarnation of the series converting s3c2412/s3c2413 to the common clock framework. As before the conversion is done by a mix of datasheet data and the pre-existing clock code and as this time I have no hardware of this type, it is compile-tested only. So hopefully somebody with s3c2412 hw

<    1   2   3   4   5   6   7   8   >