[PATCH 3/9] ARM: dts: exynos4210-universal: add super device node for exynos drm

2014-04-13 Thread Inki Dae
Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4210-universal_c210.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index 0a80a72..5351ac4 100644

[PATCH 5/9] ARM: dts: exynos4412-trats2: add super device node for exynos drm

2014-04-13 Thread Inki Dae
Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4412-trats2.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts index 53c717b..115b9ed 100644 --- a/arch/arm/boot/dts

[PATCH v2 7/9] drm/exynos: separate dpi from fimd

2014-04-13 Thread Inki Dae
From: Andrzej Hajda The patch separates dpi related routines from fimd. Changelog v2: - Rename ctx->dpi to ctx->display Signed-off-by: Andrzej Hajda Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 40 +-- drivers/gpu/drm/exynos/exynos_drm_drv.h

[PATCH 9/9] drm/exynos: modify goto labels to meaningful names

2014-04-13 Thread Inki Dae
Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index cdd74e2..1d1c604 100644 --- a

[PATCH 8/9] drm/exynos: fix comment to exynos_drm_device_subdrv_prove call

2014-04-13 Thread Inki Dae
subdrv_probe callback of virtual display driver will be called by exynos_drm_device_subdrv_probe() to create crtc and encoder/connector for virtual display driver. So it fixes comments to exynos_drm_device_subdrv probe call. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu

[PATCH 4/9] ARM: dts: exynos4210-trats: add super device node for exynos drm

2014-04-13 Thread Inki Dae
Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4210-trats.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 02c6768..a41c109 100644 --- a/arch/arm/boot/dts

RE: [PATCH RFC 0/2] drm/exynos: refactoring drm device init/deinit

2014-04-14 Thread Inki Dae
> -Original Message- > From: Andrzej Hajda [mailto:a.ha...@samsung.com] > Sent: Monday, April 14, 2014 5:55 PM > To: Inki Dae > Cc: dri-de...@lists.freedesktop.org; moderated list:ARM/S5P EXYNOS AR...; > Kyungmin Park; Marek Szyprowski > Subject: Re: [PATC

RE: [PATCH RFC 0/2] drm/exynos: refactoring drm device init/deinit

2014-04-14 Thread Inki Dae
Hi Tomasz, Always thanks for your opinions. > -Original Message- > From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc- > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > Sent: Monday, April 14, 2014 8:32 PM > To: Inki Dae; 'Andrzej Hajda&#

RE: [PATCH RFC 0/2] drm/exynos: refactoring drm device init/deinit

2014-04-15 Thread Inki Dae
> -Original Message- > From: Tomasz Figa [mailto:tomasz.f...@gmail.com] > Sent: Monday, April 14, 2014 11:05 PM > To: Inki Dae; 'Andrzej Hajda' > Cc: 'Kyungmin Park'; 'moderated list:ARM/S5P EXYNOS AR...'; 'Russell King'; > dri

[PATCH 3/5] drm/exynos: dpi: fix hotplug fail issue

2014-04-16 Thread Inki Dae
flag to connector->polled of parallel panel driver at connector creation. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dpi.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/driv

[PATCH 2/5] drm/exynos: add component framework support

2014-04-16 Thread Inki Dae
This patch adds component framework support to resolve the probe order issue. Until now, exynos drm had used codes specific to exynos drm to resolve that issue so with this patch, the specific codes are removed. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c | 45

[PATCH 0/5] drm/exynos: more cleanup with component framework

2014-04-16 Thread Inki Dae
://lists.freedesktop.org/archives/dri-devel/2014-January/051249.html [2]http://www.spinics.net/lists/dri-devel/msg57401.html Thanks, Ink Dae Andrzej Hajda (1): drm/exynos: separate dpi from fimd Inki Dae (4): drm/exynos: modify goto labels to meaningful names drm/exynos: add component framework support

[PATCH 4/5] drm/exynos: fix comment to exynos_drm_device_subdrv_prove call

2014-04-16 Thread Inki Dae
subdrv_probe callback of virtual display driver will be called by exynos_drm_device_subdrv_probe() to create crtc and encoder/connector for virtual display driver. So it fixes comments to exynos_drm_device_subdrv probe call. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu

[PATCH 1/5] drm/exynos: modify goto labels to meaningful names

2014-04-16 Thread Inki Dae
Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 55 +++ 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 2d27ba2..b3ba043 100644 --- a

[PATCH 5/5] drm/exynos: separate dpi from fimd

2014-04-16 Thread Inki Dae
From: Andrzej Hajda The patch separates dpi related routines from fimd. Changelog v2: - Rename ctx->dpi to ctx->display Signed-off-by: Andrzej Hajda Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 40 +-- drivers/gpu/drm/exynos/exynos_drm_drv.h

[PATCH] drm/exynos: dsi: remove unnecessary pm interfaces

2014-04-16 Thread Inki Dae
Exynos drm driver is a single driver so pm operation for kms drivers should be done by connector->dpms at top level driver. If kms driver has its own pm interfaces, single driver model would be broken so this patch removes unnecessary pm interfaces from dsi driver. Signed-off-by: Inki

[PATCH] drm/exynos: remove unnecessary runtime pm interfaces

2014-04-16 Thread Inki Dae
Exyno drm driver has no real hardware device, and runtime pm operation should be done by sub drivers. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/gpu

[PATCH 0/5] add super device node support

2014-04-17 Thread Inki Dae
This patch series adds super device node approach and relevant dt bindings, and rebased on top of below patch series, http://www.spinics.net/lists/dri-devel/msg57673.html Thanks, Inki Dae Inki Dae (5): drm/exynos: add super device support ARM: dts: exynos4210-universal: add super device

[PATCH 2/5] ARM: dts: exynos4210-universal: add super device node for exynos drm

2014-04-17 Thread Inki Dae
Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4210-universal_c210.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index 0a80a72..5351ac4 100644 --- a

[PATCH 5/5] exynos/drm: add DT bindings for super device node

2014-04-17 Thread Inki Dae
This patch adds bindings for Exynos drm display subsystem. The bindings describes ports containing a list of phandles pointing to display controller, image enhancer, and display interfaces nodes. Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- .../bindings/drm/exynos/samsung-exynos-drm.txt

[PATCH 3/5] ARM: dts: exynos4210-trats: add super device node for exynos drm

2014-04-17 Thread Inki Dae
Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4210-trats.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 02c6768..a41c109 100644 --- a/arch/arm/boot/dts

[PATCH v6 1/5] drm/exynos: add super device support

2014-04-17 Thread Inki Dae
i driver correctly. - Remove duplicated coherent_dma_mask setting. Changelog v6: - Add super device support, and remove existing specific codes. - Re-based on top of below patch series, http://www.spinics.net/lists/dri-devel/msg57673.html Signed-off-by: Inki Dae Acked-by: Kyun

[PATCH 4/5] ARM: dts: exynos4412-trats2: add super device node for exynos drm

2014-04-17 Thread Inki Dae
Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4412-trats2.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts index 53c717b..115b9ed 100644 --- a/arch/arm/boot/dts

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Inki Dae
s.net/lists/dri-devel/msg5.html [2]:http://www.spinics.net/lists/dri-devel/msg55658.html Thanks, Inki Dae more cleaner solution. [1]: http://permalink.gmane.org/gmane.linux.drivers.devicetree/61559 [2]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27044 Regards Andrzej

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Inki Dae
ferent point is that LVDS driver has some ops specific to LVDS device, not using existing ops of drm_panel commonly: we may need to consider the characteristic of LVDS device. [1]:http://www.spinics.net/lists/dri-devel/msg5.html [2]:http://www.spinics.net/lists/dri-devel/msg55658.html Thanks, Inki D

Re: [PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY

2014-05-08 Thread Inki Dae
, but thank you for your explanation. > > Is this limitation exynos4 specific, or does it also apply for the > exynos5 mixer? It seems that exynos5260/5420 mixers also have same limitation: SX/Y fields is 11 bits. > Was the limitation perhaps the number of bits in the SXY register &

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Inki Dae
On 2014년 05월 08일 19:52, Ajay kumar wrote: > +Dave > +Thierry > > On Thu, May 8, 2014 at 1:14 PM, Inki Dae wrote: >> >> Just re-sending with text mode. Sorry for this. >> >> >> On 2014년 05월 08일 15:41, Andrzej Hajda wrote: >>> On 05/05/2014 09:5

Re: [PATCH v2 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-10-28 Thread Inki Dae
Hi Rahul, I have merged the re-factoring patch set from Sean Paul to exynos-drm-next except eDP related patch set that these need more reviews. Can you re-base at top of exynos-drm-next? Thanks, Inki Dae 2013/10/22 Rahul Sharma : > Currently, exynos hdmiphy operations and configs are k

Re: [RFC 00/12] Add DRM Exynos HDMI on SoCs from Exynos4 family

2013-10-28 Thread Inki Dae
Hi Tomasz, I have merged the re-factoring patch set from Sean Paul. Can you re-base your patch set at top of exynos-drm-next? Thanks, Inki Dae 2013/10/21 Tomasz Stanislawski : > This patchset adds support for HDMI at SoCs from Exynos4 family. The patches > are rebased on kisho

Re: [RFC 00/12] Add DRM Exynos HDMI on SoCs from Exynos4 family

2013-10-28 Thread Inki Dae
2013/10/29 Kukjin Kim : > On 10/28/13 06:42, Inki Dae wrote: >> >> Hi Tomasz, >> >> I have merged the re-factoring patch set from Sean Paul. Can you >> re-base your patch set at top of exynos-drm-next? >> > Basically, RFC is not patch for merge. So To

RE: [PATCH] video: exynos_mipi_dsim: Remove unused variable

2013-11-14 Thread Inki Dae
nel.org; Sylwester Nawrocki; > InKi Dae > Subject: Re: [PATCH] video: exynos_mipi_dsim: Remove unused variable > > On Thu, Nov 14, 2013 at 5:32 PM, Greg Kroah-Hartman > wrote: > > On Thu, Nov 14, 2013 at 01:09:24PM -0800, Olof Johansson wrote: > >> commit

Re: [PATCH 2/2] drm/exynos: Fix build after removal of DRM_WAKUP

2014-01-07 Thread Inki Dae
ted by Seung-Woo link below, and I merged already them to exynos-drm-next. http://www.spinics.net/lists/dri-devel/msg50921.html Thanks, Inki Dae > Reviewed-by: Daniel Vetter >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [PATCH V2] drm/exynos: Fix multiplatform breakage for ipp/gsc

2014-01-20 Thread Inki Dae
Applied. Thanks, Inki Dae 2014/1/16 Tushar Behera : > There is no need to include "plat/map-base.h" in ipp driver. Remove > this and enable this driver for multi-platform. > > However gsc driver is not multiplatform compliant yet, so make the > compilation conditional

Re: [patch] drm/exynos: potential use after free in exynos_drm_open()

2014-01-20 Thread Inki Dae
Hi, This issue had already been reported, and fixed by Sachin. And also that patch has been merged to exynos-drm-next. Please see below link, http://www.spinics.net/lists/dri-devel/msg51889.html Thanks, Inki Dae 2014/1/21 Dan Carpenter : > If exynos_drm_subdrv_open() fails then we

Re: [PATCH] iommu/exynos: Remove driver

2014-02-06 Thread Inki Dae
;s obvious that nobody cares about it, so let's remove it. Wait, we are going to fix up this module. It seems that KyoungHo, original author, is busy with some works related to product. we can care about it if KyoungHo cannot afford to care for the time being. Thanks, Inki Dae > > Signed-o

Re: [RFC PATCH v2 00/21] Add DSI display support for Exynos based boards

2014-03-04 Thread Inki Dae
rs such as eDP and MIPI-DSI, and dt binding of LVDS bridge can be done at top level of Exynos drm. Once the binding is done, encoder of display bus driver will have drm_bridge object of LVDS bridge driver so that display bus driver can handle LVDS bridge driver. Will review your patch series soon. T

Re: [RFC PATCH v2 03/21] exynos/dsim: add DT bindings

2014-03-04 Thread Inki Dae
2014-02-12 20:31 GMT+09:00 Andrzej Hajda : > The patch adds DT bindings for Exynos DSI Master. DSIM follows rules > for DSI bus host bindings [1]. > Properties describes its resources: memory, interrupt, clocks, > phy, regulators and frequencies of clocks. > > [1]: Documentation/devicetree/bindings

Re: [RFC PATCH v2 08/21] drm/panel: add TC358764 driver

2014-03-04 Thread Inki Dae
2014-02-12 20:31 GMT+09:00 Andrzej Hajda : > The patch adds driver for Toshiba DSI/LVDS TC358764 bridge. > Driver registers itself as mipi_dsi_driver. It is exposed to the > system via drm_panel interface, it uses also drm_panel framework > to interact with LVDS panel connected to it. > Driver supp

Re: [RFC PATCH v2 19/21] ARM: dts: exynos5250-arndale: add dsi and panel nodes

2014-03-05 Thread Inki Dae
;; }; }; port@2 { ... lvds_1: endpoint { remote-endpoint=<&panel_0>; }; }; }; dsi { ... port { dsi_0: endpoint { remote-endpoint=<&lvds_0

Re: [RFC PATCH v2 00/21] Add DSI display support for Exynos based boards

2014-03-12 Thread Inki Dae
2014-03-07 19:00 GMT+09:00 Andrzej Hajda : > On 03/05/2014 03:56 AM, Inki Dae wrote: >> Hi Andrzej, >> >> Thanks for your contributions. >> >> 2014-02-12 20:31 GMT+09:00 Andrzej Hajda : >>> Hi, >>> >>> This patchset adds drivers an

Re: [RFC PATCH v2 00/21] Add DSI display support for Exynos based boards

2014-03-13 Thread Inki Dae
2014-03-12 20:16 GMT+09:00 Tomasz Figa : > On 12.03.2014 11:08, Inki Dae wrote: >> >> 2014-03-07 19:00 GMT+09:00 Andrzej Hajda : >>> >>> On 03/05/2014 03:56 AM, Inki Dae wrote: >>>> >>>> Hi Andrzej, >>>> >>>>

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-07-17 Thread Inki Dae
ver. Also it fixes a problem that the function has been mapping user >> provided address without holding mmap_sem. > > I'd like to see an Ack from one of the exynos drm driver maintainers before > I merge this. > > Inki, Marek? I already gave Ack but it seems tha

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-07-17 Thread Inki Dae
On 2015년 07월 17일 19:31, Hans Verkuil wrote: > On 07/17/2015 12:29 PM, Inki Dae wrote: >> On 2015년 07월 17일 19:20, Hans Verkuil wrote: >>> On 07/13/2015 04:55 PM, Jan Kara wrote: >>>> From: Jan Kara >>>> >>>> Convert g2d_userptr_get_dma_a

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-21 Thread Inki Dae
h_device_if_possible and then we can remove >> drm_iommu_attach_device_if_possible and clear_channels function pointer. >> >> Signed-off-by: Joonyoung Shim >> Tested-by: Marek Szyprowski >> Signed-off-by: Inki Dae >> >> :04 04 8337

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:12, Joonyoung Shim wrote: > On 07/22/2015 01:55 PM, Inki Dae wrote: >> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>>> Hi, >>>> >>>> Today's linux-next (

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Inki Dae
On 2015년 07월 22일 17:42, Joonyoung Shim wrote: > On 07/22/2015 05:22 PM, Inki Dae wrote: >> On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >>> On 07/22/2015 01:55 PM, Inki Dae wrote: >>>> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>>>> On 07/21/2015 1

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-24 Thread Inki Dae
On 2015년 07월 22일 19:08, Inki Dae wrote: > On 2015년 07월 22일 17:42, Joonyoung Shim wrote: >> On 07/22/2015 05:22 PM, Inki Dae wrote: >>> On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >>>> On 07/22/2015 01:55 PM, Inki Dae wrote: >>>>> On 2015년 07월 22일 11:0

Re: [PATCH v3 1/9] drm/exynos: pass the correct pipe number

2015-07-29 Thread Inki Dae
Hi Gustavo, On 2015년 07월 30일 05:11, Gustavo Padovan wrote: > Hi Inki, > > Any comments about this series? Will review all of them. Now we are reviewing fix-up and clean-up patches. Thanks, Inki Dae > > Thanks, > > Gustavo > > 2015-07-16 Gustavo Pa

Re: [PATCH v3 1/9] drm/exynos: pass the correct pipe number

2015-08-03 Thread Inki Dae
Hi Gustavo, For 1 through 9 merged. And I guess you have the rest we have to review but this patch series doesn't have consistency of previous, v2. So please, post the rest again re-basing on top of exynos-drm-next. Thanks, Inki Dae On 2015년 07월 30일 05:11, Gustavo Padovan wrote: >

Re: [PATCH v2] drm/exynos: clear channels only when iommu is enabled

2015-08-03 Thread Inki Dae
tree binding. Anyway, I merged below patch so let's resolve this issue with more generic way later. P.s., I removed the patch which incurred the kernel hang issue from exynos-drm-fixes, and moved it to exynos-drm-next with below patch so now there must be no any problem with exynos-drm-fixes. T

Re: [PATCH 09/11] drm/exynos: remove exynos_drm_create_enc_conn()

2015-08-04 Thread Inki Dae
On 2015년 08월 04일 04:09, Gustavo Padovan wrote: > From: Gustavo Padovan > > This functions was just hiding the encoder and connector creation in > a way that was less clean than if we get rid of it. For example, > exynos_encoder ops had .create_connector() defined only because we were > handing of

Re: [PATCH 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-04 Thread Inki Dae
On 2015년 08월 04일 04:09, Gustavo Padovan wrote: > From: Gustavo Padovan > > struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had > only a drm_encoder member and the internal exynos_drm_encoders ops that > was directly mapped to the drm_encoder helper funcs. > > So now exynos

Re: [PATCH 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-04 Thread Inki Dae
On 2015년 08월 04일 23:47, Gustavo Padovan wrote: > Hi Inki, > > 2015-08-04 Inki Dae : > >> On 2015년 08월 04일 04:09, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had &

Re: [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder

2015-08-06 Thread Inki Dae
>dpms_mode after enable/disable I don't see patch v2 10/11 and 11/11 in my mailbox. Did you miss them? Thanks, Inki Dae > > Gustavo Padovan (11): > drm/exynos: split display's .dpms() into .enable() and .disable() > drm/exynos: remove wrappers for phy_power_{on,

Re: [PATCH] drm/exynos/fimc: fix runtime pm support

2015-08-06 Thread Inki Dae
gned-off-by: Marek Szyprowski > > Gentle ping... Sorry, I missed it. Merged. Thanks, Inki Dae > >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c &

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-07 Thread Inki Dae
nd why locked up and I found the booting is locked up as soon as console_lock function is called. Can you and other guys look into this issue? Thanks, Inki Dae > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/exynos/Makefile | 7 +- > drivers/gpu/drm/exynos/exyn

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-07 Thread Inki Dae
Hi Daniel, On 2015년 08월 07일 21:28, Daniel Vetter wrote: > On Fri, Aug 7, 2015 at 1:50 PM, Inki Dae wrote: >> >> Booting is locked up here. This patch looks good to me so I tried to >> find why locked up and I found the booting is locked up as soon as >> console_lock

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-11 Thread Inki Dae
On 2015년 08월 11일 09:38, Gustavo Padovan wrote: > Hi Inki, > > 2015-08-07 Inki Dae : > >> Hi Gustavo, >> >> On 2015년 08월 06일 22:31, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> struct exynos_drm_encoder was justing wrapping str

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-11 Thread Inki Dae
On 2015년 08월 12일 00:03, Daniel Vetter wrote: > On Tue, Aug 11, 2015 at 09:13:54PM +0900, Inki Dae wrote: >> On 2015년 08월 11일 09:38, Gustavo Padovan wrote: >>> Hi Inki, >>> >>> 2015-08-07 Inki Dae : >>> >>>> Hi Gustavo, >>>> &g

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-15 Thread Inki Dae
2015-08-13 0:54 GMT+09:00 Gustavo Padovan : > 2015-08-12 Gustavo Padovan : > >> Hi Inki, >> >> 2015-08-11 Inki Dae : >> >> > On 2015년 08월 11일 09:38, Gustavo Padovan wrote: >> > > Hi Inki, >> > > >> > > 2015-08-07 Inki Dae :

Re: [PATCH 03/11] drm/exynos: add prepare and cleanup phases for planes

2015-08-24 Thread Inki Dae
epare_plane(exynos_crtc, > + exynos_plane); There is no any reason to use prepare_plane/cleanup_plane callback names. How about using atomic_begin/atomic_flush callback names instead for consistency between framework and device drivers? Thanks

Re: [PATCH 03/11] drm/exynos: add prepare and cleanup phases for planes

2015-08-27 Thread Inki Dae
On 2015년 08월 27일 00:45, Gustavo Padovan wrote: > Hi Inki, > > 2015-08-24 Inki Dae : > >> On 2015년 08월 16일 01:26, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> .prepare_plane() and .cleanup_plane() allows to perform extra operations >&g

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

2015-08-31 Thread Inki Dae
On 2015년 08월 24일 23:13, Tobias Jakobi wrote: > The amount of commands (regular and GEM) doesn't depend > on the input here. > > Signed-off-by: Tobias Jakobi > --- > exynos/exynos_fimg2d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c

Re: [PATCH 05/14] exynos/fimg2d: check buffer space in g2d_copy()

2015-08-31 Thread Inki Dae
11, 2)) > + return -ENOSPC; Above lines could be integrated with 3 and 4 patches as one patch. And you can make other codes to other one. Thanks, Inki Dae > + > + g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_BGCOLOR); > + g2d_add_cmd(ctx, DST_COLOR_M

Re: [PATCH 07/14] exynos/fimg2d: add g2d_validate_xyz() functions

2015-08-31 Thread Inki Dae
OP_DISJOINT_DST: > + case G2D_OP_CONJOINT_CLEAR: > + case G2D_OP_CONJOINT_SRC: > + case G2D_OP_CONJOINT_DST: > + return 0; Ditto, You could modify it like above. Thanks, Inki Dae > + } > + > + return 1; > +} > + > +/* > * g2d_add_c

Re: [PATCH 08/14] exynos/fimg2d: check buffer space in g2d_blend()

2015-08-31 Thread Inki Dae
gem_space = src->select_mode == G2D_SELECT_MODE_NORMAL ? 2 : 1; > + > + if (g2d_check_space(ctx, 12, gem_space)) > + return -ENOSPC; As I mentioned before, above two lines could be integrated with other patches. Thanks, Inki Dae > > bitblt.val = 0; >

Re: [PATCH 09/14] exynos/fimg2d: check buffer space in g2d_scale_and_blend()

2015-08-31 Thread Inki Dae
fprintf(stderr , "invalid select mode for source.\n"); > + return -EINVAL; > + } > + > + if (g2d_validate_blending_op(op)) { > + fprintf(stderr , "unsupported blending operation.\n"); > + return -EINVAL; > +

Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

2015-08-31 Thread Inki Dae
0, 0, 0); > - break; With this, how about changing above switch and case statement to if statement? Thanks, Inki Dae > } > > return val.val; > -- To unsubscribe from this list: send the line "unsubscribe linux-samsu

Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

2015-08-31 Thread Inki Dae
On 2015년 09월 01일 03:53, Emil Velikov wrote: > On 31 August 2015 at 14:25, Inki Dae wrote: >> On 2015년 08월 24일 23:14, Tobias Jakobi wrote: >>> We now validate the blending mode via g2d_validate_mode() >>> prior to feeding it to g2d_get_blend_op(). >>&

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

2015-08-31 Thread Inki Dae
On 2015년 09월 01일 04:57, Emil Velikov wrote: > On 31 August 2015 at 20:27, Tobias Jakobi > wrote: >> Hello! >> >> Inki Dae wrote: >>> On 2015년 08월 24일 23:13, Tobias Jakobi wrote: > >>>> +if (g2d_check_space(ctx, 7, 1)) >>>> +

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

2015-08-31 Thread Inki Dae
gt; even if we don't get too many reviewers. We better keep it around for >> a couple of weeks in case others are swamped with unrelated work atm, >> yet willing to take a look. > Sure, I'm going to wait and do some pings from time to time :) > I had a review and looks g

Re: [PATCH] drm/exynos: add cursor plane support

2015-09-03 Thread Inki Dae
9 @@ > #define MAX_PLANE5 > #define MAX_FB_BUFFER4 > > +#define DEFAULT_WIN 0 > +#define CURSOR_WIN 1 You fixed overlay number for cursor with 1. However, Display controllers of Exynos SoC have fixed overlay priority like this, win 4 > win 3 > win 2 > win 1 &g

Re: [PATCH] drm/exynos: add cursor plane support

2015-09-04 Thread Inki Dae
On 2015년 09월 04일 16:19, Daniel Vetter wrote: > On Fri, Sep 04, 2015 at 01:05:35PM +0900, Inki Dae wrote: >> Hi Gustavo, >> >> I had already a review but I didn't give any comment to you. Sorry about >> that. This patch looks good to me but one thing isn't clear

Re: [PATCH 08/10] drm/exynos: Enable DP clock directly from FIMD

2015-09-18 Thread Inki Dae
rtc); > > + fimd_dp_clock_enable(crtc, true); You are forcing FIMD driver to enable DP clock every time FIMD is enabled. Please know that in Exynos Display pipeline, Encoder device could be used according to how Display path is configured. For example, FIMD

Re: [PATCH 07/10] drm/exynos: add pm_runtime to FIMD

2015-09-18 Thread Inki Dae
a/drivers/gpu/drm/exynos/exynos7_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c > @@ -637,7 +637,6 @@ static const struct exynos_drm_crtc_ops decon_crtc_ops = { > .enable = decon_enable, > .disable = decon_disable, > .mode_fixup = decon_mode_

[PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
This patch removes unnecessary pm suspend/resume functions. All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c

Re: [PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

2015-09-30 Thread Inki Dae
sts. Thanks for your patch. However, the pm interfaces of KMS drivers aren't required because these are controlled by top of Exynos drm driver and connector dpms. So I posted a patch that it removes pm interfaces of dp driver. Thanks, Inki Dae > > Signed-off-by: Charles Keepax > ---

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
Hi Emil, On 2015년 09월 30일 21:19, Emil Velikov wrote: > Hi Inki, > > On 30 September 2015 at 12:21, Inki Dae wrote: >> This patch removes unnecessary pm suspend/resume functions. >> >> All kms sub drivers will be controlled by top of Exynos drm driver >> and co

Re: [PATCH 1/2] drm/exynos: add global macro for the default primary plane

2015-10-12 Thread Inki Dae
Hi Gustavo, Merged. Thanks, Inki Dae 2015년 09월 05일 07:05에 Gustavo Padovan 이(가) 쓴 글: > From: Gustavo Padovan > > Define DEFAULT_WIN as zero to help set the primary plane on all CRTCs. > Some CRTCs were defining a variable to store the default window, but that > is not necessary

Re: [PATCH 08/10] drm/exynos: Enable DP clock directly from FIMD

2015-10-12 Thread Inki Dae
Gustavo, please ping~~~ 2015년 09월 19일 12:51에 Inki Dae 이(가) 쓴 글: Hi Gustavo, On 2015년 09월 05일 05:15, Gustavo Padovan wrote: From: Gustavo Padovan Instead of having a .clock_enable callback enable the dp clock directly from FIMD. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos

Re: [PATCH 2/2] drm/exynos: add cursor plane support

2015-10-12 Thread Inki Dae
Merged. Thanks, Inki Dae 2015년 09월 05일 07:05에 Gustavo Padovan 이(가) 쓴 글: > From: Gustavo Padovan > > Set one of the planes for each crtc driver as a cursor plane enabled > window managers to fully work on exynos. > > Signed-off-by: Gustavo Padovan > > --- > v2: us

Re: [PATCH 07/10] drm/exynos: add pm_runtime to FIMD

2015-10-12 Thread Inki Dae
Also ping~~ 2015년 09월 19일 12:53에 Inki Dae 이(가) 쓴 글: On 2015년 09월 05일 05:15, Gustavo Padovan wrote: From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan

Re: [PATCH 00/16] drm/exynos/hdmi: refactoring/cleanup patches

2015-10-12 Thread Inki Dae
Hi Andrzej, For all patches, merged excepting patch 2 which cleans up dt binding document. Thanks, Inki Dae 2015년 09월 25일 21:48에 Andrzej Hajda 이(가) 쓴 글: > Hi, > > This is another set of cleanup/improvement patches for HDMI. > > The patchset is based on exynos-drm-next. >

Re: [PATCH] drm/exynos: fix spelling errors

2015-10-12 Thread Inki Dae
Hi, Ingi. Merged. Thanks for your first patch to drm world. :) This patch isn't trivial so will go to next. Thanks, Inki Dae 2015년 10월 02일 17:59에 Ingi Kim 이(가) 쓴 글: > This patch fixes spelling errors in drm fimc/gsc > inavild -> invaild > > Signed-off-by: Ingi Kim >

Re: [PATCH 00/10] drm/exynos: add pm_runtime support

2015-10-19 Thread Inki Dae
Hi Gustavo, Please ping~ and re-base on top of exynos-drm-next. Thanks, Inki Dae 2015년 09월 05일 05:15에 Gustavo Padovan 이(가) 쓴 글: From: Gustavo Padovan Hi, This series adds proper runtime PM suport to CRTCs and Encoders, so now instead of relying on 'suspended' or 'enabled&

Re: [PATCH 10/10] drm/exynos/decon5433: add support for DECON-TV

2015-10-23 Thread Inki Dae
s this your intention? Shouldn't ctx->planes[] have 1st, 2nd ,3rd and 4th planes so that we can use 1st ~ 4th hardware overlay for DECON TV? DECON TV for Exynos5433 SoC can use only 1st ~ 4th hardware overlays. And other thing, it may be trivial but I think it'd be better to use 'ovl' instead of 'tmp. Thanks, Inki Dae -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/10] drm/exynos/decon5433: add support for DECON-TV

2015-10-23 Thread Inki Dae
2015-10-23 22:03 GMT+09:00 Andrzej Hajda : > > On 10/23/2015 01:55 PM, Inki Dae wrote: > > Hi Andrzej, > > > > > > 2015년 10월 20일 18:22에 Andrzej Hajda 이(가) 쓴 글: > >> DECON-TV IP is responsible for generating video stream which is transferred > >> to H

Re: [PATCH 0/7] add atomic_check callback to exynos_crtc

2015-10-27 Thread Inki Dae
TV path of DECON controller transfers Display data to HDMI like MIXER IP of previous Exynos SoC did. Thanks, Inki Dae > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a mes

Re: [PATCH 3/7] ARM: exynos_defconfig: enable Exynos DRM Mixer driver

2015-10-27 Thread Inki Dae
his will go with rest of patchset through Exynos DRM tree: > Acked-by: Krzysztof Kozlowski Thanks for ack. I will pick it up. Thanks, Inki Dae > > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sams

Re: drm/exynos: when to call dma_map_sg() on a GEM object?

2015-11-02 Thread Inki Dae
case of Exynos DRM. This dma mapping API calls internally iommu_map function of iommu framework after allocating physical pages and iova space, and the iova space will be mapped with physical pages. Please, look into the dma mapping framework - arch/arm/mm/dma-mapping.c - if you want to unde

[PATCH v2 1/7] drm/exynos: do not start enabling DP at bind() phase

2015-11-03 Thread Inki Dae
From: Gustavo Padovan The DP device will be properly enabled at the enable() call just after the bind call finishes. Changelog v2: - no change Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c | 107 +++- drivers

[PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-03 Thread Inki Dae
This patch series adds pm runtime support for Exynos drm. Originally, this patch was posted by Gustavo but there was no any answer about some comments. So I rebased this patch series on top of exynos-drm-next, removed unnecessary patches and modified wrong macro. Changelog v2: - Remove patch 5 an

[PATCH v2 4/7] drm/exynos: add pm_runtime to Mixer

2015-11-03 Thread Inki Dae
From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_mixer.c | 125

[PATCH v2 6/7] drm/exynos: add pm_runtime to DECON 5433

2015-11-03 Thread Inki Dae
From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Changelog v2: - Change CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/

[PATCH v2 2/7] drm/exynos: add pm_runtime to DP

2015-11-03 Thread Inki Dae
From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Changelog v2: - no change Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_dp_core.c | 58

[PATCH v2 7/7] drm/exynos: add pm_runtime to DECON 7

2015-11-03 Thread Inki Dae
From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Changelog v2: - Modify CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/

[PATCH v2 3/7] drm/exynos: add pm_runtime to HDMI

2015-11-03 Thread Inki Dae
From: Gustavo Padovan Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Changelog v2: - Mofidy CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/

[PATCH v2 5/7] drm/exynos: add pm_runtime to FIMD

2015-11-03 Thread Inki Dae
_PM Signed-off-by: Gustavo Padovan Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 91 +--- 1 file changed, 37 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c in

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-03 Thread Inki Dae
2015년 11월 04일 16:24에 Andrzej Hajda 이(가) 쓴 글: > On 11/03/2015 04:38 PM, Inki Dae wrote: >> >> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda > <mailto:a.ha...@samsung.com>>: >>> Hi Inki, >>> >>> On 11/03/2015 11:47 AM, Inki Dae wrote: >>

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-04 Thread Inki Dae
2015년 11월 04일 19:13에 Andrzej Hajda 이(가) 쓴 글: > On 11/04/2015 08:56 AM, Inki Dae wrote: >> >> 2015년 11월 04일 16:24에 Andrzej Hajda 이(가) 쓴 글: >>> On 11/03/2015 04:38 PM, Inki Dae wrote: >>>> >>>> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda

<    1   2   3   4   5   6   >