Hello Andreas,
Thanks a lot for your feedback.
On 06/27/2014 10:06 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Hello Andreas,
On 06/27/2014 10:26 AM, Andreas Färber wrote:
Hi Javier,
Am 27.06.2014 09:53, schrieb Javier Martinez Canillas:
Hello Andreas,
On 06/27/2014 09:48 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
This patch adds a dt-binding include
Hello Lee,
On 06/27/2014 11:21 AM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
NOTE: due to wakeup
Hello Lee,
Thanks a lot for your feedback.
On 06/27/2014 11:26 AM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/30/2014 06:01 AM, Yadwinder Singh Brar wrote:
Hi Javier,
On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Maxim Integrated Power Management ICs are very similar with
regard
Hello Lee,
Thanks a lot for your feedback.
On 07/01/2014 05:15 PM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
Maxim MAX77802 is a power management chip that contains 10 high
efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
to power up application
Hello Mike,
On 07/01/2014 07:26 PM, Mike Turquette wrote:
Quoting Yadwinder Singh Brar (2014-06-29 21:01:36)
Hi Javier,
On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Maxim Integrated Power Management ICs are very similar with
regard
Hello Mike,
On 07/01/2014 07:29 PM, Mike Turquette wrote:
Quoting Javier Martinez Canillas (2014-06-26 11:15:36)
Like most clock drivers, the Maxim 77686 PMIC clock binding
follows the convention that the #clock-cells property is
used to specify the number of cells in a clock provider
Error checking across the driver is mostly consistent besides
a few exceptions, so change these exceptions for consistency.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add clock-output-names
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5:
- Use max77686,* properties instead of max77802,* since the support is
now in the max77686 driver and that IP defined the properties first
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v5: None
Changes
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
NOTE: I didn't carry previous {Review,Acked,Tested
The MAX77686 PMIC submodule has Dynamic Voltage Scaling (DVS)
support on some regulators. Now that the regulator driver has
bindings to configure it, these bindings have to be documented.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5: None
Changes since v4
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v5:
- Fix style issues and a typo on peach pit and pi DTS.
Suggested by Tushar Behera.
Changes since v4: None
Changes since v3:
- Add support
MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set
of Buck regulators. A number of GPIO are connected to these
lines and are requested by the mfd driver. Setup the GPIO
pins from the regulator driver.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5: None
Changes since v4: None
Changes since v3: None
---
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add clock-output-names as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Mike
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v5:
- Fix $SUBJECT since the patch does not actually
lines connected to them.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 115 +++
include/linux/mfd/max77686.h | 18 ---
2 files changed, 125 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd
There is no need to print out-of-memory errors since this is already
done by the memory management subsystem which even calls dump_stack().
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions
When platform data is not found an -EIO (I/O error) code is returned.
This doesn't seem to be the correct error so better return -EINVAL
(Invalid argument) which is what most drivers do in this case.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686
When the CONFIG_OF option was not enabled, a dummy function
max77686_i2c_parse_dt_pdata() was defined since this is called
unconditionally on probe(). Just always define the real function
and conditionally call it if CONFIG_OF is enabled instead.
Signed-off-by: Javier Martinez Canillas
The function max77802_i2c_parse_dt_pdata() should only be called
if there isn't already platform data for the device.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
the system
Javier Martinez Canillas (22):
mfd: max77686: Convert to use regmap_irq
mfd: max77686: Add power management support
mfd: max77686: don't define dummy function if OF isn't enabled
mfd: max77686: make platform data over-rule DT
mfd: max77686: Return correct error when pdata isn't
Hello Krzysztof,
Again, thanks a lot for taking the time to review the series.
On 07/04/2014 01:15 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
(DVS) support that allows
Hello Krzysztof,
On 07/04/2014 01:30 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
Maxim MAX77802 is a power management chip that contains 10 high
efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
to power up application
Hello Krzysztof,
Thanks a lot for your feedback.
On 07/04/2014 01:56 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
Hello Krzysztof,
On 07/04/2014 03:11 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 14:52 +0200, Javier Martinez Canillas wrote:
Hello Krzysztof,
Thanks a lot for your feedback.
On 07/04/2014 01:56 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez
) Chromebooks and it's composed of the following patches:
Doug Anderson (1):
rtc: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (23):
mfd: max77686: Convert to use regmap_irq
mfd: max77686: Add power management support
mfd: max77686: Don't define dummy
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6:
- Remove unused code
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v6: None
Changes since v5:
- Fix style issues and a typo on peach pit and pi DTS.
Suggested by Tushar Behera.
Changes since v4: None
Changes
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6: None
Changes since v5:
- Use max77686,* properties instead of max77802,* since the support is
now in the max77686 driver and that IP
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add clock
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set
of Buck regulators. A number of GPIO are connected to these
lines and are requested by the mfd driver. Setup the GPIO
pins from the regulator driver.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add clock-output-names as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas
The MAX77686 PMIC submodule has Dynamic Voltage Scaling (DVS)
support on some regulators. Now that the regulator driver has
bindings to configure it, these bindings have to be documented.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base/regmap/regmap.c b/drivers
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Mike
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since
There is no need to print out-of-memory errors since this is already
done by the memory management subsystem which even calls dump_stack().
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions
lines connected to them.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6:
- Add a comment that max77686_read_gpios() function can sleep.
Sugggested by Krzysztof Kozlowski
---
drivers/mfd
When platform data is not found an -EIO (I/O error) code is returned.
This doesn't seem to be the correct error so better return -EINVAL
(Invalid argument) which is what most drivers do in this case.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686
Error checking across the driver is mostly consistent besides
a few exceptions, so change these exceptions for consistency.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/max77686.c | 10
When the CONFIG_OF option was not enabled, a dummy function
max77686_i2c_parse_dt_pdata() was defined since this is called
unconditionally on probe(). Just always define the real function
and conditionally call it if CONFIG_OF is enabled instead.
Signed-off-by: Javier Martinez Canillas
The function max77802_i2c_parse_dt_pdata() should only be called
if there isn't already platform data for the device.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd
The driver doesn't have PM operations defined so add a suspend
and resume function handlers to allow the PMIC IRQ to wakeup
the system when it is put into a sleep state.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
Hello Krzysztof,
On 07/07/2014 08:06 AM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 22:24 +0200, Javier Martinez Canillas wrote:
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome
Hello Tushar,
On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera trbli...@gmail.com wrote:
The u-boot version is a little different on my Peach-Pi as compared to
the market release version. Not sure if that is making any difference.
Peach # version
U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for
Hello Doug,
On Wed, Jul 9, 2014 at 6:01 PM, Doug Anderson diand...@google.com wrote:
Javier,
On Wed, Jul 9, 2014 at 6:03 AM, Javier Martinez Canillas
jav...@dowhile0.org wrote:
Hello Tushar,
On Wed, Jul 9, 2014 at 2:11 PM, Tushar Behera trbli...@gmail.com wrote:
On 07/09/2014 03:44 PM
Hello Lee,
On 07/09/2014 04:52 PM, Lee Jones wrote:
On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
The function max77802_i2c_parse_dt_pdata() should only be called
if there isn't already platform data for the device.
Signed-off-by: Javier Martinez Canillas javier.marti
Hello Lee,
Thanks a lot for your feedback.
On 07/09/2014 05:13 PM, Lee Jones wrote:
I'd really like Linus Walleij to look over this if possible.
Ok, I'll cc Linus when posting the next version of the series.
On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
Some regulators
Hello Linus,
On 07/10/2014 11:46 AM, Linus Walleij wrote:
On Fri, Jul 4, 2014 at 10:24 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
(DVS) support that allows output voltage to change dynamically
Hello Amit,
On 07/10/2014 11:59 AM, amit daniel kachhap wrote:
On Sat, Jul 5, 2014 at 1:54 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
(DVS) support that allows output voltage to change dynamically
Hello Amit,
On 07/10/2014 12:08 PM, amit daniel kachhap wrote:
On Fri, Jul 4, 2014 at 3:25 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set
of Buck regulators. A number of GPIO are connected to these
lines
Hello Tomasz,
On 07/11/2014 11:43 AM, Tomasz Figa wrote:
Hi Javier,
On 11.07.2014 03:45, Javier Martinez Canillas wrote:
On 07/10/2014 11:59 AM, amit daniel kachhap wrote:
On Sat, Jul 5, 2014 at 1:54 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
[snip]
@@ -111,6
Hello Naveen and Mark,
On Mon, Jul 7, 2014 at 1:22 PM, Javier Martinez Canillas
jav...@dowhile0.org wrote:
On Mon, Jul 7, 2014 at 10:31 AM, Naveen Krishna Ch
naveenkrishna...@gmail.com wrote:
Hence, spi-s3c64xx.c is broken since Jun 21 11:26:12 2013 and
considering the time
This series are based on drivers added by Simon Glass to the Chrome OS
kernel and adds support for the Maxim 77802 Power Management IC, their
regulators, clocks, RTC and i2c interface.
This is a v8 of the patch-set that addresses issues pointed out in v7.
Individual changes are added on each
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v7:
- Remove information about DVS since that will be added as a follow up.
Changes since v6: None
Changes since v5:
- Use max77686
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v7:
- Change Buck2 and 3 regulator name to vdd_arm and vdd_int.
Suggested by Naveen Krishna Chatradhi.
- Remove DVS properties since this is going
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add clock
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
the driver was original merged in
commit fca1dd03 (rtc: max77686: add Maxim 77686 driver).
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/rtc
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add clock-output-names as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Mike
Hello Mark,
I agree that the commit message could have a better description and I
understand your concerns. I'm not an SPI expert by any means but I did
my best to review the patches and provide feedback to Naveen on the
first iterations of the series.
On Mon, Jul 14, 2014 at 7:25 PM, Mark Brown
Hello Naveen,
On 07/15/2014 07:49 PM, Tomasz Figa wrote:
In general, I liked previous version of this series much more, as it was
doing what it should as opposed to this one.
Best regards,
Tomasz
I agree with Tomasz. I think version v6 of your series was (almost) correct
while this is
to understand patch series.
The series is composed of the following patches:
Javier Martinez Canillas (1):
Revert spi: s3c64xx: Added provision for dedicated cs pin
Naveen Krishna Chatradhi (3):
spi: s3c64xx: use the generic SPI cs-gpios property
spi: samsung: Update binding documentation
ARM
]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Tomasz Figa t.f...@samsung.com
---
Documentation/devicetree/bindings/spi/spi-samsung.txt | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi
was not added to the DT binding doc:
Documentation/devicetree/bindings/spi/spi-samsung.txt
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Tomasz Figa t.f...@samsung.com
---
drivers/spi/spi-s3c64xx.c | 37 +++--
1 file changed, 11
compatibility in the first place.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
[javier.marti...@collabora.co.uk: split changes and improve commit message]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Tomasz Figa t.f...@samsung.com
---
drivers/spi/spi
On 07/16/2014 06:02 PM, Mark Brown wrote:
On Wed, Jul 16, 2014 at 05:19:06PM +0200, Javier Martinez Canillas wrote:
*sigh* Yesterday Naveen submitted another, different, patch series also
attempting to improve things which I'm not seeing any reference to here.
Please coordinate with Naveen
Hello Naveen,
On Thu, Jul 17, 2014 at 6:21 AM, Naveen Krishna Ch
naveenkrishna...@gmail.com wrote:
Can you pull the 3/4 and 4/4 patches.
Patch 4/4 depends on the max77802 support series [0] since the ADC
uses the max77802 ldo9 regulator as its voltage supply. So that patch
can't be merged
message is not shown anymore:
[2.132944] tps65090-charger tps65090-charger: Unable to get charger irq = -6
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
--
To unsubscribe from this list: send the line
Hello Mark,
On 07/17/2014 08:46 PM, Mark Brown wrote:
On Wed, Jul 16, 2014 at 05:19:07PM +0200, Javier Martinez Canillas wrote:
This reverts commit 3146beec21b64f4551fcf0ac148381d54dc41b1b.
For the benefit of those who haven't memorized the SHA1s of every commit
that's spi: s3c64xx: Added
Hello,
On 07/14/2014 09:24 PM, Doug Anderson wrote:
[WARN] [2.296011] tps65090-charger tps65090-charger: Unable to get
charger irq = -22
[WARN] [2.313705] tps65090-charger: probe of tps65090-charger
failed with error -22
I have resent the patch to fix this 4 times with no avail.
Hello,
On Tue, Jul 15, 2014 at 5:59 PM, Doug Anderson diand...@chromium.org wrote:
Is there a reason not to add more of the max77686 configs?
+CONFIG_RTC_DRV_MAX77686=y
+CONFIG_COMMON_CLK_MAX77686=y
AFAIK for the multi-platform defconfig we should try to build as a
module as many config
Hello Russell,
On Fri, Jul 18, 2014 at 12:44 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Fri, Jul 18, 2014 at 12:31:48AM +0200, Javier Martinez Canillas wrote:
In the case of the MAX77686, the mfd, regulator and clock drivers use
subsys_initcall() instead of module_init
Hello Lee,
On 07/14/2014 01:35 PM, Javier Martinez Canillas wrote:
* Patches 1-7 from v7 are not included since those were improvements to
the max77686 mfd driver and can be applied independently. Lee Jones said
that he is going to pick them from the posted v7 series.
Thanks a lot
On 07/22/2014 02:10 AM, Mark Brown wrote:
On Mon, Jul 21, 2014 at 02:44:07PM +0200, Javier Martinez Canillas wrote:
On 07/14/2014 01:35 PM, Javier Martinez Canillas wrote:
Mark, Mike and Alessandro,
This is a gentle reminder to look at the patches that touches your subsystems
and provide
3d2e6079cc8c372da946d430d43d36af99e7a582 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas javier.marti...@collabora.co.uk
Date: Tue, 22 Jul 2014 19:16:47 +0200
Subject: [RFC] regulator: tps65090: Allow regulators voltage to be
queried
The tps65090 device has some regulators with a fixed output
voltage and others
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked
101 - 200 of 1325 matches
Mail list logo
