to make this memory reservation dependent
on mfc* node being present in DTS. It's to early to use of_* functions
(because tree is not populated at this stage) but fdt_* family of functions
work just fine.
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe
-size, len);
if (!prop)
return;
lsize = of_read_ulong(prop, len/4);
...
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo
,
.dt_compat = exynos5250_dt_compat,
.restart= exynos5_restart,
+ .reserve= exynos5_reserve,
MACHINE_END
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
...@samsung.com
Looks good for me. FWIW, I could probably add
Acked-by: Karol Lewandowski k.lewando...@samsung.com
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
by platform data or DT at all?
[1]
From 5cfba526210bc596c7d14e33fea93648baa0a227 Mon Sep 17 00:00:00 2001
From: Karol Lewandowski k.lewando...@samsung.com
Date: Mon, 23 Jan 2012 17:20:25 +0100
Subject: [PATCH] max8997: Avoid spaces in regulator names
max8997-pmic instantiated from device tree uses
On 01/23/2012 07:20 PM, Mark Brown wrote:
On Mon, Jan 23, 2012 at 06:50:22PM +0100, Karol Lewandowski wrote:
Aren't these fixed? i.e. - is it really needed to configure these
either by platform data or DT at all?
[1]
From 5cfba526210bc596c7d14e33fea93648baa0a227 Mon Sep 17 00:00:00 2001
max8997-pmic instantiated from device tree uses names, not numerical
ids to distinguish between outputs.
Replace spaces with underscores in said names to make it possible to
describe these outputs as regulators in DTS.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off
On 12.01.2012 08:35, Thomas Abraham wrote:
Add device tree based discovery support for max8997.
+static int max8997_pmic_dt_parse_pdata(struct max8997_dev *iodev,
+ struct max8997_platform_data *pdata)
+{
+ pdata-regulators = rdata;
+
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/boot/dts/exynos4210.dtsi | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210.dtsi
b/arch/arm/boot/dts
On 25.01.2012 12:26, Mark Brown wrote:
On Wed, Jan 25, 2012 at 10:55:49AM +0100, Karol Lewandowski wrote:
On 12.01.2012 08:35, Thomas Abraham wrote:
Add device tree based discovery support for max8997.
+ pdata-regulators = rdata;
+ for_each_child_of_node(regulators_np, reg_np
On 25.01.2012 14:32, Mark Brown wrote:
On Wed, Jan 25, 2012 at 01:02:29PM +0100, Karol Lewandowski wrote:
On 25.01.2012 12:26, Mark Brown wrote:
However, I still find it little problematic that dt and non-dt
versions behave differently when given the same set of parameters
(previously
, that is. This is from where I
got my flawed understanding.
Looking at other drivers I see that's indeed special case not practiced
elsewhere.
Thanks for explaining this.
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line
support is still broken for unknown reason, though.
[ To use it it's also required to cherry-pick ARM: EXYNOS: fix
non-SMP builds for EXYNOS4 already found in kgene's
linux-samsung.git (branch v3.3-samsung-fixes-2) ]
Karol Lewandowski (2):
ARM: Exynos4: Make exynos4-dt compile again
ARM
Commit cc511b8d84d8 (ARM: 7257/1: EXYNOS: introduce
arch/arm/mach-exynos/common.[ch]) replaced plat/exynos4.h with
common.h, requiring all boards to be adjusted appropriately.
This commit fixes exynos4-dt.c, missed out in original patch.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Commit 4e44d2cb95bd (ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER)
converted all exynos boards but exynos4-dt.c.
This commit fixes that omission.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra
= exynos4210_dt_machine_init,
.timer =exynos4_timer,
.dt_compat = exynos4210_dt_compat,
+ .handle_irq = gic_handle_irq,
MACHINE_END
--
1.7.8.3
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line
- my email address lacks 'i' at the end, i.e. it's
k.lewandowsk@ :)
Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org
---
This patch solves the issue of boot failure with SMP enabled kernel for
Exynos4 device tree enabled machine.
Tested-by: Karol Lewandowski k.lewando...@samsung.com
spotted by Mr. Kyungmin Park
- Reorganized patch a bit as requested by Mr. Kukjin Kim
- Squashed all the fixes into one commit
[ SMP support has been fixed by Thomas Abraham in separate patch:
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/9184 ]
Karol Lewandowski (1):
ARM
hook)
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
Cc: Kukjin Kim kgene@samsung.com
---
arch/arm/mach-exynos/mach-exynos4-dt.c |8 ++--
1 files changed, 6 insertions(+), 2
On 31.01.2012 18:56, Thomas Abraham wrote:
Add device tree based discovery support for Samsung's sdhci controller
Works fine on nuri hardware using exynos4-dt (with custom dts).
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to
-by: Tushar Beheratushar.beh...@linaro.org
Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org
Tested-by: Karol Lewandowski k.lewando...@samsung.com
Fixes following Oops in i2c-s3c24xx.
Thanks
1Unable to handle kernel NULL pointer dereference at virtual address
1pgd = c0004000
1
On 31.01.2012 17:47, Karol Lewandowski wrote:
This commit brings exynos4-dt in line with recent changes to
mach-exynos tree, specifically:
- Fixes build break related to replacing plat/exynos4.h with common.h
in commit cc511b8d84d8 (ARM: 7257/1: EXYNOS: introduce
arch/arm/mach
/eints
(this [2] patchset)?
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
This driver requires standard properties only (address and irq)
which are automatically marshalled into plain old resources by OF core.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/s5p-g2d/g2d.c |9
This patchset adds initial device tree support to drivers used by
s5p-tv on Exynos4.
DT support for s5p-tv driver itself would benefit from changes to v4l
core (missing OF helper functions) and thus, will be sent later in
separate patchset.
Karol Lewandowski (3):
[media] s5p-tv: Add initial DT
---
drivers/media/video/s5p-tv/mixer_drv.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/s5p-tv/mixer_drv.c
b/drivers/media/video/s5p-tv/mixer_drv.c
index a2c0c25..6bf4a9e 100644
--- a/drivers/media/video/s5p-tv/mixer_drv.c
+++
Make it possible to instantiate driver from device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/s5p-tv/hdmiphy_drv.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions
On 01.03.2012 04:09, Thomas Abraham wrote:
Hi Karol,
Hi!
On 29 February 2012 20:21, Karol Lewandowski k.lewando...@samsung.com wrote:
Make it possible to instantiate sii9234, HDMI's MHL, from regular
device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
On 01.03.2012 04:18, Thomas Abraham wrote:
On 29 February 2012 20:21, Karol Lewandowski k.lewando...@samsung.com wrote:
---
drivers/media/video/s5p-tv/mixer_drv.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/s5p-tv/mixer_drv.c
b
/bjdooks/linux.git
Karol Lewandowski (1):
i2c-s3c2410: Rework device type handling
Tomasz Stanislawski (1):
i2c-s3c2410: Add HDMIPHY quirk for S3C2440
.../devicetree/bindings/i2c/samsung-i2c.txt| 10 ++-
drivers/i2c/busses/i2c-s3c2410.c | 90
2
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 10
-specific quirks
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 56 +
1 files changed, 20 insertions(+), 36 deletions(-)
diff --git a/drivers/i2c/busses/i2c
On 12.03.2012 06:58, Thomas Abraham wrote:
Hi Thomas!
On 9 March 2012 22:34, Karol Lewandowski k.lewando...@samsung.com wrote:
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device variants
by
exynos4210-specific I2C controller used by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol Lewandowski (3):
i2c-s3c2410: Drop unused define
i2c-s3c2410: Rework device type handling
i2c-s3c2410: Add
Use standard of_match_ptr() to avoid defining variable unused
in non device tree builds.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c |4 +---
1 files changed, 1 insertions(+), 3
-specific quirks
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 53 +++---
1 files changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/i2c/busses/i2c
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 10 -
drivers/i2c/busses/i2c-s3c2410.c
On 13.03.2012 18:27, Tomasz Stanislawski wrote:
Hi Karol,
Please refer to comments below,
Regards,
Tomasz Stanislawski
On 03/13/2012 05:54 PM, Karol Lewandowski wrote:
This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY
device on
Exynos4 platform. Some quirks
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 11 +-
drivers/i2c/busses/i2c-s3c2410.c
On 14.03.2012 18:29, Mark Brown wrote:
On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:
- replace s3c24xx_i2c_type enum with plain unsigned int that can
hold not only device type but also hw revision-specific quirks
Would it not be clearer to just have explicit flags
On 15.03.2012 13:56, Mark Brown wrote:
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
attempt to solve this issue. However, this required adding explicit
checks to driver code all over the place
On 19.03.2012 20:55, Mark Brown wrote:
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
If you consider code to be inherently less readable because of this
approach I'll rework it. If it's not a such big deal for you I would
prefer to keep it as is.
The thing
On 21.03.2012 12:50, Mark Brown wrote:
On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote:
What do you think about following changes, then?
That looks reasonable.
Thanks. I'll incorporate this change and post whole patchset again.
Regards,
--
Karol Lewandowski | Samsung
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 47 ++---
1 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses
by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol Lewandowski (3):
i2c-s3c2410: Drop unused define
i2c-s3c2410: Rework device type handling
i2c-s3c2410: Add HDMIPHY quirk for S3C2440
Use standard of_match_ptr() to avoid defining variable unused
in non device tree builds.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
drivers/i2c/busses/i2c-s3c2410.c |4
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 11 +-
drivers/i2c/busses/i2c-s3c2410.c
Add arm/trivial-devices.txt to enumerate devices for which only
basic resources are provided (compat, address and irq line).
This is based on i2c's trivial-devices.txt by Olof Johansson.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
Commit 488bf314b (i2c: Allow i2c_add_numbered_adapter() to assign a
bus id) reworked i2c-pxa driver leaving obsolete comment.
This commit simply drops it.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Wolfram Sang w.s
Avoid hard lockup when someone provides non-supported regulator
name.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
drivers/regulator/max8997.c |7 +++
1 files changed, 7
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/exynos4210-nuri.dts | 527 +
1 files changed, 527 insertions(+), 0 deletions(-)
create mode 100644
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/exynos4210.dtsi | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm
Includes v4l2/dt helper function (hdmi_of_get_i2c_subdev() that probably
should be implemented in v4l2 core itself.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
drivers/media/video/s5p-tv/hdmi_drv.c | 68
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
.../devicetree/bindings/arm/exynos/tvmixer.txt | 26
drivers/media/video/s5p-tv/mixer_drv.c
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
drivers/media/video/s5p-tv/hdmi_drv.c | 90 ++---
1 files changed, 49 insertions(+), 41 deletions(-)
diff --git a/drivers/media/video/s5p-tv/hdmi_drv.c
b
Make it possible to instantiate SiI9234, Mobile HD Link driver (MHL),
from regular device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
.../devicetree
This driver requires standard properties like (address and irq)
which are automatically marshalled for drivers by OF core.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Kamil Debski k.deb...@samsung.com
---
.../devicetree
.
This patch updates few more drivers (missed out in original patch)
to use this functionality.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Wolfram Sang w.s...@pengutronix.de
---
drivers/i2c/busses/i2c-gpio.c |7
On 21.03.2012 20:11, Karol Lewandowski wrote:
Changes since v2:
- Merge device type and flags into flat bitmask named quirks -
Consequently, treat s3c24xx as baseline hardware platform and
support all hw variations via quirks [Suggested by Mark Brown]
Changes since v1:
- Move
On 17.04.2012 19:31, Wolfram Sang wrote:
Hi,
Hi Wolfram!
On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device
, pdata-sda_delay);
of_property_read_u32(np, samsung,i2c-slave-addr, pdata-slave_addr);
of_property_read_u32(np, samsung,i2c-max-bus-freq,
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux
for
corrections (I feel kinda confident on this issue, though ;))
I'm quite happy with doing it the way you just described.
I'll resend whole patchset in a minute.
Thanks!
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe
reworks i2c-s3c2410 driver a bit to better handle
device tree-enabled platforms and adds two quirks required by
exynos4210-specific I2C controller used by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 75 +-
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt|8 --
drivers/i2c/busses/i2c-s3c2410.c
,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24.04.2012 16:44, Wolfram Sang wrote:
On Tue, Apr 24, 2012 at 10:40:49AM +0200, Karol Lewandowski wrote:
On 23.04.2012 20:20, Wolfram Sang wrote:
+ if (pdev-dev.of_node) {
+ const struct of_device_id *match;
+ match = of_match_node(s3c24xx_i2c_match, pdev-dev.of_node
67 matches
Mail list logo