RE: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-13 Thread Kukjin Kim
*/ + aquila_pmic_init(); + i2c_register_board_info(AP_I2C_GPIO_PMIC_BUS_4, i2c_gpio_pmic_devs, + ARRAY_SIZE(i2c_gpio_pmic_devs)); + /* FB */ s3c_fb_set_platdata(aquila_lcd_pdata); -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior

RE: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-13 Thread Kukjin Kim
/arch.h #include asm/mach/map.h @@ -107,9 +112,323 @@ static struct s3c_fb_platdata goni_lcd_pdata __initdata = { .setup_gpio = s5pv210_fb_gpio_setup_24bpp, }; (snip) Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development

RE: [PATCH 1/3] arm: s5pv210: GONI: add support for framebuffer

2010-07-14 Thread Kukjin Kim
void __init goni_machine_init(void) { + no need above empty line. + /* FB */ + s3c_fb_set_platdata(goni_lcd_pdata); + platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); } -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer

RE: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Ok..will apply :-) Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send

RE: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
functionality with external interrupt). Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com For the regulator API usage: Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Thanks for your ack. Best regards, Kgene. -- Kukjin

RE: [PATCH 3/3] ARM: S5PV210: GONI: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Ok..will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send

RE: [PATCH 1/3] arm: s5pv210: GONI: add support for framebuffer

2010-07-14 Thread Kukjin Kim
Kyungmin Park wrote: On Wed, Jul 14, 2010 at 4:30 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Wednesday, July 14, 2010 8:48 AM Kukjin Kim wrote: Marek Szyprowski wrote: This patch adds required platform definitions to enable s3c-fb driver on GONI board

RE: [PATCH 1/3] ARM: S5PV210: GONI: add support for framebuffer

2010-07-14 Thread Kukjin Kim
*/ + s3c_fb_set_platdata(goni_lcd_pdata); + platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices)); } -- Looks ok..will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd

[PATCH v2 0/8] ARM: S5PV310: Add support for Samsung S5PV310 SoC

2010-07-16 Thread Kukjin Kim
This patch set adds support for Samsung S5PV310/S5PC210. The S5PV310 integrates a ARM Cortex A9 microprocessor with several other peripherals to support features such as multimedia, storage, graphics and gaming. The S5PV310 can be used in products such as Netbooks and Mobile devices. Changes

[PATCH v2 4/8] ARM: S5PV310: Add IRQ support

2010-07-16 Thread Kukjin Kim
chaos.y...@samsung.com Signed-off-by: Hyuk Lee hyuk1@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv310/include/mach/irqs.h | 74 +++ arch/arm/mach-s5pv310/include/mach/regs-irq.h | 19 arch/arm/mach-s5pv310/irq-combiner.c

[PATCH v2 3/8] ARM: S5PV310: Add Clock and PLL support

2010-07-16 Thread Kukjin Kim
From: Changhwan Youn chaos.y...@samsung.com This patch adds clock and pll support for S5PV310. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv310/clock.c | 544 +++ arch/arm/mach

[PATCH v2 7/8] ARM: S5PV310: Add Board support file

2010-07-16 Thread Kukjin Kim
From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung SMDKV310 board support file. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv310/Makefile|4 ++ arch/arm/mach-s5pv310/mach-smdkv310.c | 92

[PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-16 Thread Kukjin Kim
From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung's S5PV310/S5PC210 CPU support. The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Jongpill Lee boyko@samsung.com Signed-off-by: Kukjin Kim kgene

RE: [PATCH 02/10 v2] ARM: Samsung: Add FIMC resource definition and FIMC driver platform helpers

2010-07-16 Thread Kukjin Kim
samsung_plat_fimc *fimc); +extern void s5p_fimc1_set_platdata(struct samsung_plat_fimc *fimc); +extern void s5p_fimc2_set_platdata(struct samsung_plat_fimc *fimc); + #endif /* FIMC_H_ */ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution

RE: [PATCH v2 2/5] ARM: S5P: Added default pll values for APLL 800/1000MHz

2010-07-16 Thread Kukjin Kim
: +#define PLL45XX_APLL_VAL_800 (1 31) | (10016) | (38) | (1) total: 4 errors, 0 warnings, 14 lines checked -- I already said to you about that :-( See the Documentation/SubmittingPatches... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development

[PATCH 1/3] ARM: S5P6440: Add support for I2C channel 0 and 1 on SMDK6440

2010-07-16 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds helper functions for I2C channel 0 and 1, GPIO configurations for I2C on S5P6440 and support I2C-0/1 devices on SMDK6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch

RE: [PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-18 Thread Kukjin Kim
Russell King wrote: On Fri, Jul 16, 2010 at 05:58:28PM +0900, Kukjin Kim wrote: diff --git a/arch/arm/mach-s5pv310/platsmp.c b/arch/arm/mach- s5pv310/platsmp.c new file mode 100644 index 000..9325ac2 --- /dev/null +++ b/arch/arm/mach-s5pv310/platsmp.c @@ -0,0 +1,212

RE: [PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-18 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com

RE: [PATCH 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-18 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds support I2C-0/1/2 devices to the SMDKV210/SMDKC110. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off

RE: [PATCH v2] ARM: S5P: Add PMU device

2010-07-18 Thread Kukjin Kim
. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH v2] ARM: SAMSUNG: Make WDT driver dependency SoC specific instead of machine specific

2010-07-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim kgene@samsung.com --- NOTE: now, re-submitted updated because of adding S5P6442. arch/arm/Kconfig |5 + arch/arm/mach-s3c64xx/Kconfig |1 - arch/arm/mach-s5p6440/Kconfig |1 - arch/arm/mach-s5p6442/Kconfig |1 - arch/arm/mach-s5pc100

RE: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry S5PC110_EVT0_WORKAROUND

2010-07-19 Thread Kukjin Kim
into mainline that is not going to be used. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

RE: [PATCH v3 7/7] ARM: S5PV210: Initial CPUFREQ Support

2010-07-19 Thread Kukjin Kim
/* CONFIG_CPU_S5PV210 */ +#endif /* _ARCH_ARM_MACH_S5PV210_INCLUDE_MACH_CPU_FREQ_H_ */ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux

RE: [PATCH 0/4] ARM: S5PV210: Clock Framework: powerdomain, block-gating, flags

2010-07-19 Thread Kukjin Kim
to be commented upon by a number of interested parties if it did come up for review. I am certainly not happy to see this sort of invasive change to the clock system merged. I expect others would also raise objections. ... === So need to another approach for it. Thanks. Best regards, Kgene. -- Kukjin

[PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-20 Thread Kukjin Kim
...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- Changes since v2: - Re-model platsmp.c on the Versatile Express as per Russell King's suggestion. And tested on the board. - Compared Versatile Express SMP code with Realview SMP code and modified as needed. arch/arm/mach-s5pv310

RE: [PATCH v2 5/8] ARM: S5PV310: Add Timer support

2010-07-20 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds timer support for S5PV310. Until now, all S5P SoCs use CONFIG_ARCH_USES_GETTIMEOFFSET macro as a default configuration. Instead

[PATCH 2/3] rtc: rtc-s3c: Updates driver for S3C64XX and newer SoCs

2010-07-21 Thread Kukjin Kim
writeb to writel as max_user_freq used in s3c64xx is 32768 and requires 15 bits to update the Tick Count Register. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/rtc/rtc-s3c.c | 12

[PATCH 1/2] ARM: S3C64XX: Move RTC clock from init_clocks to init_clocks_disable

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com RTC clock does not require to be enabled at boot time. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s3c64xx/clock.c | 12 ++-- 1 files changed, 6 insertions(+), 6

[PATCH 1/3] ARM: SAMSUNG: Updates RTC register for support Alarm IRQ and Time Tick.

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This patch updates RTC registers for support Alarm IRQ and Time Tick. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/plat-samsung/include

[PATCH 0/3] Updates RTC driver for Samsung S3C64XX and newer SoCs

2010-07-21 Thread Kukjin Kim
This patch updates RTC driver for Samsung S3C64XX and newer SoCs. NOTE: depends on previous RTC patch for clock enabling. [PATCH 1/3] ARM: SAMSUNG: Updates RTC register for support Alarm IRQ and Time Tick. [PATCH 2/3] rtc: rtc-s3c: Updates driver for S3C64XX and newer SoCs [PATCH 3/3] rtc:

[PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This Patch updates existing Samsung RTC driver for clock enabling support. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/rtc/rtc-s3c.c | 22 ++ 1 files changed, 22

[PATCH 0/2] Updates Samsung RTC driver for clock enabling support

2010-07-21 Thread Kukjin Kim
This patch updates RTC driver for clock enabling support. [PATCH 1/2] ARM: S3C64XX: Move RTC clock from init_clocks to init_clocks_disable [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the

[PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-21 Thread Kukjin Kim
From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/rtc/rtc-s3c.c | 14 -- 1 files changed, 12 insertions(+), 2

[PATCH 2/5] rtc: rtc-s3c: Add extra option to include RTC for Samsung SoCs

2010-07-21 Thread Kukjin Kim
-by: Kukjin Kim kgene@samsung.com --- drivers/rtc/Kconfig |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 10ba12c..c43732f 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -645,9 +645,16 @@ config

[PATCH 1/5] ARM: S3C64XX: Add RTC support for S3C64XX

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This patch adds support for RTC for SMDK6410. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s3c64xx/Kconfig |1 + arch/arm/mach-s3c64xx/mach-smdk6410.c |1 + 2 files

[PATCH 5/5] ARM: S5PV210: Add RTC support for S5PV210 and S5PC110

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This patch adds support RTC driver for Samsung S5PV210/S5PC110. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/Kconfig|4 arch/arm/mach-s5pv210/include

[PATCH 4/5] ARM: S5PC100: Add RTC support for S5PC100

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This patch adds support RTC driver for Samsung S5PC100. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pc100/Kconfig|2 ++ arch/arm/mach-s5pc100/include/mach/map.h

[PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kukjin Kim
-by: Kukjin Kim kgene@samsung.com --- arch/arm/Kconfig |3 +++ arch/arm/mach-s5p6440/Kconfig |1 - arch/arm/mach-s5pc100/Kconfig |1 - arch/arm/mach-s5pv210/Kconfig |2 -- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm

[PATCH 3/5] ARM: S5P6440: Add RTC support for S5P6440

2010-07-21 Thread Kukjin Kim
From: Atul Dahiya atul.dah...@samsung.com This patch adds support RTC driver for Samsung S5P6440. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5p6440/Kconfig|2 ++ arch/arm/mach-s5p6440/include/mach/map.h

RE: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kukjin Kim
. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 6:00 PM, Kukjin Kim kgene@samsung.com wrote: From: Atul Dahiya atul.dah...@samsung.com This patch moves the dependency of RTC driver from MACH_XXX(board) to ARCH_XXX(SoC). This will enable all machines using Samsung S5P6440, S5PC100

RE: [PATCH v2 7/8] ARM: S5PV310: Add Board support file

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung SMDKV310 board support file. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-07-21 Thread Kukjin Kim
Joonyoung Shim wrote: On 7/21/2010 5:07 PM, Dmitry Torokhov wrote: Hi Joonyoung, On Wed, Jul 21, 2010 at 02:42:22PM +0900, Joonyoung Shim wrote: Hi, Dmitry. On 7/9/2010 4:39 PM, Joonyoung Shim wrote: On 7/9/2010 4:07 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 7/7/2010 8:52

RE: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kukjin Kim
Kyungmin Park wrote: On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung S5PV310/S5PC210 CPU support. The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. Signed-off-by: Changhwan Youn

[PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- Changes since v1: - Modifed the Kconfig help comments

RE: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kukjin Kim
. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:59 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com

RE: [PATCH v4] Samsung: add new card detection methods in s3c-sdhci driver (platform part)

2010-07-22 Thread Kukjin Kim
-s5pc100/setup-sdhci-gpio.o] Error 1 and s3c64xx also. ...we need inclusion plat/sdhci.h into the ..s3c64xx/setup-sdhci-gpio.c and ..s5pc100/setup-sdhci-gpio.c. Will apply with build fix. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development

RE: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-23 Thread Kukjin Kim
Sergei Shtylyov wrote: Hello. Hi :-) Kukjin Kim wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com [...] diff

[PATCH v3 0/3] Add support WP on SMDKV210 and SDHCI_QUIRK_NO_WP_BIT quirk

2010-07-23 Thread Kukjin Kim
This patch adds support SDMMC write protection pin on SMDKV210. Changes since v2: Addressed comments from Marek Szyprowski - modified wp_gpio checking method for support gpio number 0. - removed unnecessary checking in dev-hsmmc.c Changes since v1: Addressed comments from Ben Dooks, Maurus

[PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-23 Thread Kukjin Kim
@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/mmc/host/sdhci-s3c.c | 43 ++ drivers/mmc/host/sdhci.c |3 ++ drivers/mmc/host/sdhci.h |3 ++ 3 files changed, 49 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host

RE: [PATCH v4 7/7] ARM: S5PV210: Initial CPUFREQ Support

2010-07-25 Thread Kukjin Kim
on the previous further status */ + +#endif /* CONFIG_PM */ + +#endif /* __ASM_ARCH_CPU_FREQ_H */ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line

RE: [PATCH v4 1/7] ARM: S5PV210: Allow to probe whether workaround codes are required.

2010-07-25 Thread Kukjin Kim
, -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

RE: [PATCH v3 4/8] ARM: Samsung: Add common Aquila and GONI code

2010-07-26 Thread Kukjin Kim
..f666462 --- /dev/null +++ b/arch/arm/mach-s5pv210/common-aquila-goni.h @@ -0,0 +1,2 @@ + +extern void s5pv210_common_fimc_clk_init(void); -- I do not think that we need common-aquila-goni.[ch] now to us. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

RE: [PATCH v3 5/8] ARM: s5pv210: enable FIMC on Aquila

2010-07-26 Thread Kukjin Kim
(); Hmm...really need this fimc_clk_init here not driver? } MACHINE_START(AQUILA, Aquila) -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line

RE: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-07-26 Thread Kukjin Kim
need all these definitions. Hmm... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

RE: [PATCH v2 3/8] ARM: S5PV310: Add Clock and PLL support

2010-07-27 Thread Kukjin Kim
MyungJoo Ham wrote: Hello, Hello, On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds clock and pll support for S5PV310. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin

[PATCH v4 3/8] ARM: S5PV310: Add Clock and PLL support

2010-07-27 Thread Kukjin Kim
From: Changhwan Youn chaos.y...@samsung.com This patch adds clock and pll support for S5PV310. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Jongpill Lee boyko@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- NOTE: skipped v3 to avoid confusing

RE: [PATCH v3] Samsung: sdhci-s3c: add support for new card detection methods

2010-07-27 Thread Kukjin Kim
there exists two sdhci-s3c-add-support-for-new-card-detection-methods.patch, both of them are required. So the second(?) patch [PATCH v4] Samsung: add new card detection methods in s3c-sdhci driver (platform part) has already been applied to linux-next by Kukjin Kim, along with modifications which we

RE: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 23, 2010 at 8:56 PM, Kukjin Kim kgene@samsung.com wrote: From: Hyuk Lee hyuk1@samsung.com If host controller doesn't have WP pin which should be connnected with SDMMC card WP pin, can implement get_ro function with using the allocated gpio

RE: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
Marek Szyprowski wrote: Hello, On Friday, July 23, 2010 1:57 PM Kukjin Kim wrote: From: Hyuk Lee hyuk1@samsung.com If host controller doesn't have WP pin which should be connnected with SDMMC card WP pin, can implement get_ro function with using the allocated gpio. In order

[PATCH v4 0/3] Add support WP on SMDKV210 and SDHCI_QUIRK_NO_WP_BIT quirk

2010-07-27 Thread Kukjin Kim
This patch adds support SDMMC write protection pin on SMDKV210. Changes since v3: Addressed comments from Kyungmin Park and Marek Szyprowski - Added pdata 'bool has_gpio_wp' as per Marek - Moved new WP quirk checking as per Kyungmin Changes since v2: Addressed comments from Marek Szyprowski -

[PATCH v4 1/3] ARM: SAMSUNG: Add the member of platdata to implement SDMMC Write Protection

2010-07-27 Thread Kukjin Kim
From: Hyuk Lee hyuk1@samsung.com This patch adds the members of platdata which is wp_gpio. The wp_gpio is a gpio_number which is connected with WP pin of SD Slot. Signed-off-by: Hyuk Lee hyuk1@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/plat-samsung/dev

[PATCH v4 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/mmc/host/sdhci-s3c.c | 36 drivers/mmc/host/sdhci.c |3 +++ drivers/mmc/host/sdhci.h |3 +++ 3 files changed, 42 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host

[PATCH v4 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

2010-07-27 Thread Kukjin Kim
-by: Hyuk Lee hyuk1@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/mach-smdkv210.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210

RE: [rtc-linux] [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-27 Thread Kukjin Kim
Wan ZongShun wrote: 2010/7/23 Kukjin Kim kgene@samsung.com: Wan ZongShun wrote: 2010/7/21 Kukjin Kim kgene@samsung.com: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Do you mean that the hardware register

RE: [rtc-linux] [PATCH v2 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-27 Thread Kukjin Kim
Alessandro Zummo wrote: On Tue, 27 Jul 2010 21:59:13 +0900 Kukjin Kim kgene@samsung.com wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin

RE: [rtc-linux] [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

2010-07-27 Thread Kukjin Kim
Wan ZongShun wrote: 2010/7/22 Atul Dahiya atuldahiy...@gmail.com: On Thu, Jul 22, 2010 at 11:39 AM, Wan ZongShun mcuos@gmail.com wrote: 2010/7/21 Kukjin Kim kgene@samsung.com: From: Atul Dahiya atul.dah...@samsung.com This Patch updates existing Samsung RTC driver

RE: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
Maurus Cuelenaere wrote: Op 27-07-10 13:58, Kukjin Kim schreef: Maurus Cuelenaere wrote: Op 23-07-10 13:56, Kukjin Kim schreef: From: Hyuk Lee hyuk1@samsung.com If host controller doesn't have WP pin which should be connnected with SDMMC card WP pin, can implement get_ro

RE: [rtc-linux] [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

2010-07-27 Thread Kukjin Kim
; Atul Dahiya; p_gortma...@yahoo.com; Atul Dahiya; ben-li...@fluff.org; linux-arm- ker...@lists.infradead.org Subject: Re: [rtc-linux] [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support 2010/7/28 Kukjin Kim kgene@samsung.com: Wan ZongShun wrote: 2010/7/22 Atul

RE: [PATCH v4 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
Marek Szyprowski wrote: Hello, Hi :-) On Tuesday, July 27, 2010 2:44 PM Kukjin Kim wrote: From: Hyuk Lee hyuk1@samsung.com If host controller doesn't have WP pin which should be connnected with SDMMC card WP pin, can implement get_ro function with using the allocated gpio

[PATCH v5 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Kukjin Kim
@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- Changes since v4: - Address comments from Marek. Hi Andrew, If there are no problems, could you please apply this patch? drivers/mmc/host/sdhci-s3c.c | 36 drivers

RE: [PATCH 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-28 Thread Kukjin Kim
Ben Dooks wrote: On 21/07/10 09:57, Kukjin Kim wrote: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/rtc

[PATCH v3 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-28 Thread Kukjin Kim
From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- Hi, Alessandro Zummo Just moved the routine

RE: [rtc-linux] [PATCH v3 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-07-28 Thread Kukjin Kim
Wan ZongShun wrote: 2010/7/29 Kukjin Kim kgene@samsung.com: From: Taekgyun Ko taeggyun...@samsung.com RTC needs to be initialized when BCD registers have invalid value. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben

RE: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kukjin Kim
Kyungmin Park wrote: On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver on Samsung SoCs and makes I2C bus driver dependency SoC specific instead

RE: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kukjin Kim
-Original Message- From: kyungmi...@gmail.com [mailto:kyungmi...@gmail.com] On Behalf Of Kyungmin Park Sent: Friday, July 30, 2010 11:43 AM To: Kukjin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-...@vger.kernel.org; ben-li...@fluff.org

RE: [PATCH v2] ARM: Samsung SoC: clksrc-clk: wait for the stable SRC/DIV status.

2010-07-31 Thread Kukjin Kim
clksrc_reg reg_div_stable; }; /** -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-08-01 Thread Kukjin Kim
later. Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it. Thanks. Thanks. Best regards, Kgene. -- Kukjin Kim kgene

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-08-01 Thread Kukjin Kim
Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform

RE: [PATCH v3] ARM: Samsung SoC: clksrc-clk: wait for the stable SRC/DIV status.

2010-08-01 Thread Kukjin Kim
@@ -61,6 +80,9 @@ struct clksrc_clk { struct clksrc_reg reg_src; struct clksrc_reg reg_div; + + struct clkstat_reg reg_src_stable; + struct clkstat_reg reg_div_stable; }; /** -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com

Please remind 'WARNING: about Samsung merge window over'

2010-08-01 Thread Kukjin Kim
we _will_ have time to resolve conflicts and find problems _before_ the merge window --- I have no more plan to merge s5p stuff for this merge window, but reviewed here until now. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-08-02 Thread Kukjin Kim
Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h

RE: [rtc-linux] [PATCH v3 3/3] rtc: rtc-s3c: Add BCD register initialization codes

2010-08-02 Thread Kukjin Kim
Alessandro Zummo wrote: On Thu, 29 Jul 2010 13:59:30 +0900 Kukjin Kim kgene@samsung.com wrote: Hi, Alessandro Zummo Just moved the routine to support all Samsung SoCs' RTC. Is still your ack valid? yes, it is. Thanks for your ack. And I applied it in my tree with your ack

RE: [PATCH v3] ARM: Samsung SoC: clksrc-clk: wait for the stable SRC/DIV status.

2010-08-02 Thread Kukjin Kim
MyungJoo Ham wrote: On Mon, Aug 2, 2010 at 2:30 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: Many MUX and clock dividers have a status bit so that users can wait until the status is stable. When corresponding registers are accessed while a clock is not stable, we

RE: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kukjin Kim
Kyungmin Park wrote: On Tue, Aug 3, 2010 at 8:58 AM, Kukjin Kim kgene@samsung.com wrote: Marek Szyprowski wrote: From: Sylwester Nawrocki s.nawro...@samsung.com FIMC (CAMIF) device is a camera interface embedded in S3C/S5P Samsung SOC series. It supports ITU-R BT.601/656

RE: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Kukjin Kim
. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: Please remind 'WARNING: about Samsung merge window over'

2010-08-02 Thread Kukjin Kim
] ARM: Samsung: Add register definitions for Samsung S5P http://marc.info/?l=linux-arm-kernelm=127990218613922w=2 Kukjin Kim replied to this one with a point requiring an answer, but nothing came back. Looks ok...however, I'm still thinking whether really need all these definitions

RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-08-02 Thread Kukjin Kim
Dmitry Torokhov wrote: On Mon, Aug 02, 2010 at 03:30:57PM +0900, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do

RE: [PATCH] ARM: S5PV210: Add SDHCI devices for Aquila board

2010-08-04 Thread Kukjin Kim
(aquila_lcd_pdata); -- Looks ok..will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

RE: [PATCH] ARM: S5PV210: Add SDHCI devices for GONI board

2010-08-04 Thread Kukjin Kim
...as you know, this is same patch with previous Aquila SDHCI except only name. In future, we need to sort out about that. Anyway, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd

RE: [PATCH v6 5/7] ARM: S5PV210: Access for DMCx registers

2010-08-04 Thread Kukjin Kim
, to merge your 4th(previous, just adding VA) and 5th patch to one is better...just for adding DMC map IO. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send

RE: [PATCH v6 1/7] ARM: S5PV210: Allow to probe EVT revision number.

2010-08-04 Thread Kukjin Kim
. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

RE: [PATCH v6 6/7] ARM: S5PV210: clock registers (CLK_DIV/SRC/STAT)

2010-08-04 Thread Kukjin Kim
S5P_PWR_CFG S5P_CLKREG(0xC000) #define S5P_EINT_WAKEUP_MASK S5P_CLKREG(0xC004) -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux

RE: [PATCH v6 7/7] ARM: S5PV210: Initial CPUFREQ Support

2010-08-04 Thread Kukjin Kim
*/ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH] ARM: SAMSUNG: Fix on inclusion mach/gpio.h for Samsung SoCs

2010-08-04 Thread Kukjin Kim
This patch fixes on inclusion mach/gpio.h to linux/gpio.h. Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-s3c64xx/dev-audio.c|2 +- arch/arm/mach-s3c64xx/dev-spi.c |2 +- arch/arm/mach-s3c64xx/gpiolib.c |2

RE: [PATCH] SDHCI clock source definition cleanup

2010-08-05 Thread Kukjin Kim
definitions Best regards -- Marek Szyprowski Samsung Poland RD Center Ok..will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux

RE: [PATCH] ARM: SAMSUNG: Add keypad device support

2010-08-06 Thread Kukjin Kim
patch [PATCH v6 1/3] ARM: SAMSUNG: Add keypad device support. Ok, this is better...will replace an old one with this. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. arch/arm/plat-samsung/Kconfig

[PATCH] ARM: S5PV310: update S5PV310 Kconfig for supporting multiple machines

2010-08-06 Thread Kukjin Kim
This patch updates Kconfig of mach-s5pv310 for easily dividing S5PC210 and S5PV310 boards. S5PC210(MCP) machines and S5PV310 machines can be build into one kernel, this will be provied/submitted when new defconfig can be merged. Signed-off-by: Kukjin Kim kgene@samsung.com --- NOTE: Depends

[PATCH] ARM: S5PV310: Add SMDKC210 board support file

2010-08-06 Thread Kukjin Kim
This patch adds Samsung SMDKC210 board support file. The SoC of SMDKC210, S5PC210(MCP) is one of package option of S5PV310. And because composition of SMDKC210 and SMDKV310 differs, need SMDKC210 with SMDKV310. Signed-off-by: Kukjin Kim kgene@samsung.com --- NOTE: This is for next merge

[PATCH v3] ARM: S5PV310: Add Samsung UNIVERSAL_C210 support

2010-08-06 Thread Kukjin Kim
From: Kyungmin Park kyungmin.p...@samsung.com This patch adds Samsung Mobile S5PC210 Reference Board, UNIVERSAL_C210 board support. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com [kgene@samsung.com: changed machine name] Signed-off-by: Kukjin Kim kgene@samsung.com --- Changes

[PATCH v4] ARM: S5PV310: Add Samsung UNIVERSAL_C210 support

2010-08-06 Thread Kukjin Kim
From: Kyungmin Park kyungmin.p...@samsung.com This patch adds Samsung Mobile S5PC210 Reference Board, UNIVERSAL_C210 board support. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com [kgene@samsung.com: changed machine name] Signed-off-by: Kukjin Kim kgene@samsung.com --- Kyungmin

<    3   4   5   6   7   8   9   10   11   12   >