Re: [PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-11-26 Thread Mark Brown
On Tue, Nov 27, 2012 at 09:33:43AM +0900, Kukjin Kim wrote: I checked Samsung audio driver stuff just now. If you don't mind, I will drop the patch 48a2050d (ARM: SAMSUNG: Delete the unnecessary variable) instead of applying this. That works just as well for me, thanks. Padma, as I said in

Re: [PATCH] regulator: add device tree support for max8997

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 02:04:32PM +0530, Thomas Abraham wrote: Add device tree based discovery support for max8997. Applied, thanks. signature.asc Description: Digital signature

Re: [GIT PULL] ASoC: Samsung: Updates for v3.8

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 11:21:31AM +0530, Padma Venkat wrote: On Wed, Nov 28, 2012 at 10:55 AM, Sangbeom Kim sbki...@samsung.com wrote: The requirement for an alias is also very odd, where does that come from? I don't know that Which one is odd. Please let me know. Having them at all is

Re: [PATCH V4 1/2] ASoC: Samsung: Get I2S src_clk from clock alias id.

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 04:17:48PM +0530, Padmavathi Venna wrote: As the I2S src clks are registered with clkdev using generic connection id, driver can get the clk name using generic id. So the variable representing the array of rclk src clks is deleted. Applied, thanks. signature.asc

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus. We use it to arbitrate an i2c port between the AP and the EC. Should this not be layerd on top

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-01 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass s...@chromium.org wrote: It was originally done separately but I think it was felt that this was overly complex. Olof can you please comment on this? it is indeed not controller

Re: [PATCH 1/2] ASoC: Samsung: WM8994: Add basic device tree support for machine file

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:26PM +0530, Padmavathi Venna wrote: Add the basic device tree based lookup. Signed-off-by: Padmavathi Venna padm...@samsung.com --- sound/soc/samsung/smdk_wm8994.c | 23 +++ Any new device tree bindings need binding documentation. Your

Re: [PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-12-01 Thread Mark Brown
On Fri, Nov 30, 2012 at 08:00:10PM +0900, Kukjin Kim wrote: Mark, I'm holding on Padma's changes for Samsung audio. If any updates about this from your side? Is it ok to send current next/audio-samsung in my tree to upstream for v3.8? They didn't seem to have broken anything in -next for

Re: [PATCH 2/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:27PM +0530, Padmavathi Venna wrote: sound/soc/samsung/dma.c | 24 ++-- sound/soc/samsung/dma.h |3 +++ sound/soc/samsung/i2s.c |3 +++ sound/soc/samsung/smdk_wm8994.c |7 +-- 4 files changed, 17

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-05 Thread Mark Brown
On Thu, Dec 06, 2012 at 09:31:40AM +0530, Padma Venkat wrote: On Wed, Nov 28, 2012 at 4:17 PM, Padmavathi Venna padm...@samsung.com wrote: Padmavathi Venna (2): ASoC: Samsung: Get I2S src_clk from clock alias id. ASoC: SAMSUNG: Add DT support for i2s Any comments on DT support for

Re: [PATCH V2 1/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-06 Thread Mark Brown
On Thu, Dec 06, 2012 at 09:20:36AM +0530, Padmavathi Venna wrote: Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well, since there was no separate hardware associated with this platform_device; it was a virtual device

Re: [PATCH RESEND V2 1/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-07 Thread Mark Brown
On Fri, Dec 07, 2012 at 01:59:21PM +0530, Padmavathi Venna wrote: Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well, since there was no separate hardware associated with this platform_device; it was a virtual device

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-08 Thread Mark Brown
On Sat, Dec 08, 2012 at 10:07:54AM +0530, Padma Venkat wrote: Samsung i2s driver registers the platform device twice one for the samsung-i2s.0,1 or 2 and two for samsung-i2s.4(which actually doesn't represent any H/W peripheral). The max number of I2S blocks on any Samsung SoC are 3, the

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 04:30:50PM +0530, Padma Venkat wrote: Could you please explain me in more detail about single DT link automatically expanded into two DAI links. How this can be done? The device tree should only represent the single physical link that exists and the handling of the

Re: [PATCH 1/4] regulator: s5m8767: Fix to work when platform registers less regulators

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:39PM +0530, Amit Daniel Kachhap wrote: Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/4] regulator: s5m8767: Fix to read the first DVS register.

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:40PM +0530, Amit Daniel Kachhap wrote: This patch modifies the DVS register read function to select correct DVS1 register. This change is required because the GPIO select pin is 000 in unintialized state and hence selects the DVS1 register. Applied, thanks. -- To

Re: [PATCH 3/4] regulator: s5m8767: Fix to work even if no DVS gpio present

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:41PM +0530, Amit Daniel Kachhap wrote: Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-15 Thread Mark Brown
On Fri, Dec 14, 2012 at 09:06:49AM -0700, Stephen Warren wrote: On 12/13/2012 10:50 PM, Naveen Krishna Chatradhi wrote: +The first should be an output, and is used to claim the I2C bus, +the second should be an input, and signals that the other side (Client) +wants to claim the bus. This

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padm...@samsung.com wrote: +- compatible : samsung,samsung-i2s Isn't that kind of redundant? :-) The format of the compatible strings should be vendor,part-number-i2s.

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond 2 bus masters and it seems very specific to the design of a specific piece of hardware. I don't think it is mature enough to bake into the I ought to point out

Re: [PATCH 4/4] S3C64XX DSP: Added the CPU driver for PCM controllers

2009-11-03 Thread Mark Brown
On Tue, Nov 03, 2009 at 11:42:21AM +0900, jassi brar wrote: On Mon, Nov 2, 2009 at 8:17 PM, Mark Brown +             local_irq_save(irqs); Why local_irq_save()?  On existing uniprocessor systems they should be Don't we need to protect critical mode change in PCM control register? Since

Re: [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart

2009-11-19 Thread Mark Brown
On Thu, Nov 19, 2009 at 11:44:14AM +0900, jassi brar wrote: Let each platform code(SoC specific) define names of all possible source clocks and let the board init code pass on the potential source clocks by some bit-mask(or some other mechanism) while setting the platform data. This is going

Re: [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart

2009-11-19 Thread Mark Brown
On Thu, Nov 19, 2009 at 11:38:41AM +, Russell King - ARM Linux wrote: I'm not sure what you're commenting on precisely, but the Samsung code as a whole doesn't use the clk API very well, and I suspect that is starting to cause people to have to pass clock names around. That's what I'd

Re: [PATCH 2/7] ARM: S5P6440: CPU initialization

2009-12-11 Thread Mark Brown
On Fri, Dec 11, 2009 at 12:00:11PM +0100, Marc Zyngier wrote: Kukjin Kim kgene@samsung.com wrote: +/* define the number of gpios we need to the one after the GPR() range */ +#define ARCH_NR_GPIOS (S5P6440_GPR(S5P6440_GPIO_R_NR) + 1) Doing so prevents the use of GPIO

Re: [samsung-soc] CPUfreq Linux clock API question

2009-12-11 Thread Mark Brown
On Fri, Dec 11, 2009 at 02:47:06PM +0100, Lukasz Majewski wrote: The clock API used at S3C64xx seems not to allow for setting rate of two clocks simultaneously (or am I wrong? :-) ). Yes, the Linux clock API doesn't support that. If this change would not be possible, then have anyone

Re: [PATCH 2/7] ARM: S5P6440: CPU initialization

2009-12-14 Thread Mark Brown
On Mon, Dec 14, 2009 at 08:37:24PM +0900, Kukjin Kim wrote: Ok, as I already reply another posting, I couldn't consider patch atomicity. And all(almost?) my patches need so that can support s5p6440. Of course they can be modified. Normally what's done for things like that is to arrange to put

Re: Regulator framework usage in suspend/resume contex.

2009-12-18 Thread Mark Brown
On Thu, Dec 17, 2009 at 05:54:21PM +0100, Lukasz Majewski wrote: In general if you want advice on a kernel subsystem it's best to CC the maintainers of the relevant subsystem - messages posted only to mailing lists (particularly high volume ones such as this) can easily get lost in the flow.

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Mark Brown
On Wed, Jan 20, 2010 at 02:02:02AM +, Ben Dooks wrote: I've written a git pre-commit[1] hook which stops any commits happening if checkpatch.pl reports problems with the patch. Any comments? [1] http://www.fluff.org/ben/linux/githooks/pre-commit Checkpatch does sometimes generate the

Re: [PATCH 1/3] ARM: S3C64XX: Add AC97 platform resources

2010-01-26 Thread Mark Brown
-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 02:51:40PM +0900, jassisinghb...@gmail.com wrote: This looks good overall, just a few smallish issues: +static void s3c_ac97_activate(struct snd_ac97 *ac97) +{ + u32 ac_glbctrl, stat; + + stat = readl(s3c_ac97.regs + S3C_AC97_GLBSTAT) 0x7; + switch

Re: [PATCH 3/3] ARM: SMDK64XX: Enable AC97 device

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 07:52:45PM +0900, jassi brar wrote: On Tue, Jan 26, 2010 at 7:19 PM, Mark Brown This one needs a bit more explanation - why are you changing the AC97 slot?  Is this a general problem with the S3C AC97 controller?  It'd also be better to use the symbolic register

Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 08:03:09PM +0900, jassi brar wrote: The only reason I didn't submit patch to delete s3c2443-ac97.c is that my smdk2443 didn't produce any sound. (btw the s3c2443-ac97.c also fails to do so) If they both work equally well please just go ahead and remove the old

Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 08:17:25PM +0900, jassi brar wrote: On Tue, Jan 26, 2010 at 7:47 PM, Mark Brown +     default: +             s3c_ac97_cold_reset(ac97); +             s3c_ac97_warm_reset(ac97); +             break; +     } This automatic cold and warm reset looks a bit fishy

Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 08:57:56PM +0900, jassi brar wrote: On Tue, Jan 26, 2010 at 8:09 PM, Mark Brown If they both work equally well please just go ahead and remove the old driver.  Keeping the old driver around if it doesn't work is likely to result in any fixups going into that. ok

Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

2010-01-26 Thread Mark Brown
On Tue, Jan 26, 2010 at 09:11:55PM +0900, jassi brar wrote: On Tue, Jan 26, 2010 at 8:52 PM, Mark Brown That's not addressing the problem, though - the big issue is not bringing up the AC97 link, it's the fact that you're doing an uncontrolled cold reset.  If we hit this code path it'll

Re: [PATCHv2 03/10] ARM: S3C24XX: Update AC97 platform resources

2010-01-27 Thread Mark Brown
On Wed, Jan 27, 2010 at 02:58:58PM +0900, jassisinghb...@gmail.com wrote: From: Jassi Brar jassi.b...@samsung.com Modify the AC97 platform backend so that the controller can be run by the s3c-ac97.c Signed-off-by: Jassi Brar jassi.b...@samsung.com Acked-by: Mark Brown broo

Re: [PATCHv2 06/10] ARM: SMDK64XX: Enable AC97 device

2010-01-27 Thread Mark Brown
On Wed, Jan 27, 2010 at 02:59:29PM +0900, jassisinghb...@gmail.com wrote: From: Jassi Brar jassi.b...@samsung.com Add AC97 controller to platform devices and initialize the AC97 gpios. Signed-off-by: Jassi Brar jassi.b...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [PATCHv2 08/10] ARM: SMDK2443: Enable AC97 device

2010-01-27 Thread Mark Brown
On Wed, Jan 27, 2010 at 03:01:20PM +0900, jassisinghb...@gmail.com wrote: From: Jassi Brar jassi.b...@samsung.com Add AC97 controller to platform devices and initialize the AC97 gpios. Signed-off-by: Jassi Brar jassi.b...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [Rev2]Samsung: New driver for AC97 controllers

2010-01-27 Thread Mark Brown
On Wed, Jan 27, 2010 at 02:56:55PM +0900, jassisinghb...@gmail.com wrote: A machine driver, for SMDKs with wm9713 as AC97 codec attached, has also been added. The driver is generic enough to be used as such with newer SoCs. OK, works for me with a smoke test so I've applied all the sound/soc

Re: Problems with device compilation by subsystem config

2010-01-28 Thread Mark Brown
On Thu, Jan 28, 2010 at 07:05:18AM +, Ben Dooks wrote: My first response is that this forces the user to rebuild the kernel every time they decide to change the subsytems included, which if just building things as modules isn't nice. However this wasn't a strong enough objection at the

Re: [alsa-devel] [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver

2010-01-29 Thread Mark Brown
On Fri, Jan 29, 2010 at 10:08:04AM +0900, jassi brar wrote: I will submit a patch for it, though I used exact control names and their values before every command. Normally the renumbering happens as a result of a source code change such as the addition of a new control or some change in ALSA

Re: [PATCH] ARM: S5P: Add SCLK SDHCI configuration functionality

2010-03-09 Thread Mark Brown
On Tue, Mar 09, 2010 at 07:09:18PM +0530, Thomas Abraham wrote: +#ifdef CONFIG_MMC_SDHCI_S3C +int s5p_setup_sdhci_sclk(struct platform_device *pdev, struct clk *parent) +{ + struct s3c_sdhci_platdata *pdata = pdev-dev.platform_data; + struct device *dev = pdev-dev; + struct clk

Re: [RFC] IDLE/DEEP IDLE scheduler modification for power savings

2010-04-13 Thread Mark Brown
On Mon, Apr 12, 2010 at 11:39:05AM +0200, Lukasz Majewski wrote: Some SoCs allow for entering IDLE mode when they know that the system will be inactive for some time (to be more precise it will execute the idle task - which prepares system to enter IDLE state). In that mode CPU core is not

Re: S3C6410 power management support status

2010-04-30 Thread Mark Brown
On Thu, Apr 29, 2010 at 03:45:09PM +0300, Yauhen Kharuzhy wrote: Can anybody explain current status of S3C6410 power management support in mainline? Suspend-to-RAM looks completely broken in the current Linus's git tree. What problems are you experiencing? -- To unsubscribe from this list:

Re: [PATCH 1/8] ARM: SAMSUNG: Move RTC device definitions in plat-samsung

2010-05-18 Thread Mark Brown
On Tue, May 18, 2010 at 09:03:04AM +0100, Ben Dooks wrote: it would be really helpful if you composed a covering message for patch series so that any general comments can be attached there... also it means the series doesn't end up getting fragmeneted in my mailbox. There's more going on

Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

2010-05-31 Thread Mark Brown
On Sun, May 30, 2010 at 02:04:39PM +0900, Jassi Brar wrote: I believe on most implementations, if not all, sizeof char, short and int are resp 1, 2 and 4 bytes. whereas long denotes the native capacity of the arch. This is very common for interoperability with code making the assumption that

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-06-01 Thread Mark Brown
On Tue, Jun 01, 2010 at 05:16:33AM +0100, Ben Dooks wrote: On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: It's common function. Please add it to platform init instead of each board init. I know Mark Brown would rather this be the case too, but the original intent

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-11 Thread Mark Brown
On Fri, Jun 11, 2010 at 06:24:07AM +0100, Ben Dooks wrote: Hmm, Mr Park and Co really need to learn how to handle the treatment of patches. I'm really disapointed that these patches get submitted without the proper authour accreditation. If this isn't sorted out then I for one will start

Re: SMDK6440: I2C writes fails

2010-06-28 Thread Mark Brown
On Mon, Jun 28, 2010 at 10:53:18AM +0530, Naveen Krishna Ch wrote: On 24 June 2010 22:05, Mark Brown broo...@opensource.wolfsonmicro.comwrote: That smells rather like a compiler bug to me - the two versions ought to be equivalent apart from the ordering of the comparisons. I'm not sure

Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:45AM +0200, Marek Szyprowski wrote: +static struct regulator_consumer_supply aquila_ldo3_consumers[] = { + { .supply = VMIPI_1.1V, }, +}; +static struct regulator_consumer_supply aquila_ldo8_consumers[] = { + { .supply = VADC_3.3V, }, +};

Re: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:46AM +0200, Marek Szyprowski wrote: +static struct regulator_consumer_supply goni_ldo3_consumers[] = { + { .supply = VMIPI_1.1V, }, +}; A similar issue to the previous patch applies here - you should be defining consumers using struct device based

Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 03:32:17PM +0200, Marek Szyprowski wrote: One more question - should I enable the regulators in the driver itself or in the platform callback (like a poweron() callback)? I don't understand what you mean by platform callback. Normally the driver would unconditionally

Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

2010-07-02 Thread Mark Brown
On Fri, Jul 02, 2010 at 12:25:33PM +0100, Ben Dooks wrote: On 28/06/10 12:28, Maurus Cuelenaere wrote: No need for the '? 1 : 0' I tihnk there is, IIRC there is no neccessity for a compiler to produce one for true, just that the result be !0 The compiler will *produce* 1 for true, but it

Re: [PATCH 2/3] ASoC: Add SmartQ sound driver

2010-07-04 Thread Mark Brown
On Sun, Jul 04, 2010 at 11:19:37AM +0200, Maurus Cuelenaere wrote: I don't see what power there is to save? The speaker and headphone jack are connected to the same physical pins, so when disabling the pins for one of them, the other is also disabled. Meh, so they are. That's a slightly

Re: [PATCH 2/3] ASoC: Add SmartQ sound driver

2010-07-04 Thread Mark Brown
On 4 Jul 2010, at 19:03, Maurus Cuelenaere mcuelena...@gmail.com wrote: Op 03-07-10 02:46, Maurus Cuelenaere schreef: +static struct snd_soc_jack_pin smartq_jack_pins[] = { +/* Disable speaker when headphone is plugged in */ +{ +.pin= Internal Speaker, +

Re: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Mark Brown
interrupt). Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com For the regulator API usage: Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH] regulator: MAX8998: set_voltage bugfix. ramp_up delay and min/max voltage

2010-07-16 Thread Mark Brown
On Fri, Jul 16, 2010 at 05:09:20PM +0900, MyungJoo Ham wrote: Two issues are addressed for max8998_set_voltage function. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Ideally you should've submitted this as two separate patches. -- To unsubscribe from this list: send the line

Re: [PATCH v2 5/5] ARM: S5PV210: Initial CPUFREQ Support

2010-07-16 Thread Mark Brown
: Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 7/7] ARM: S5PV210: Initial CPUFREQ Support

2010-07-19 Thread Mark Brown
Still: Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] regulator: MAX8998: set_voltage bugfix. ramp_up delay and min/max voltage

2010-07-20 Thread Mark Brown
On Tue, Jul 20, 2010 at 08:07:07AM +0200, Marek Szyprowski wrote: From: MyungJoo Ham myungjoo@samsung.com Two issues are addressed for max8998_set_voltage function. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com but as IIRC I said last time it would be nicer to fix one issue

Re: [PATCH v4 7/7] ARM: S5PV210: Initial CPUFREQ Support

2010-07-22 Thread Mark Brown
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Mark Brown
On Wed, Jul 28, 2010 at 07:06:22PM +0200, Maurus Cuelenaere wrote: Op 28-07-10 17:41, Mark Brown schreef: + if (sc-vmmc) { + int ret = regulator_disable(sc-vmmc); + if (ret) + return ret; + mdelay(2); Shouldn't these delays be handled

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Mark Brown
On Wed, Jul 28, 2010 at 04:19:57PM +0200, Marek Szyprowski wrote: static int sdhci_s3c_suspend(struct platform_device *dev, pm_message_t pm) { + int ret = 0; struct sdhci_host *host = platform_get_drvdata(dev); + struct sdhci_s3c *sc = sdhci_priv(host);

Re: [PATCHv2 4/4] sdhci: add regulator support

2010-07-29 Thread Mark Brown
-by: Kyungmin Park kyungmin.p...@samsung.com Looks good from a regulator point of view. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila

2010-07-29 Thread Mark Brown
On Wed, Jul 28, 2010 at 12:04:44PM +0900, Chanwoo Choi wrote: +static struct regulator_consumer_supply wm8994_fixed_voltage0_supplies[] = { + { + .dev_name = 5-001a, + .supply = DBVDD, + }, { + .dev_name = 5-001a, +

Re: [alsa-devel] [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila

2010-08-04 Thread Mark Brown
On Wed, Aug 04, 2010 at 03:16:51PM +0900, Chanwoo Choi wrote: Mark Brown wrote: OK, good - the fact that the connection wasn't being made with the PMIC was my main point here. Did you read writed mail about consumer supply of WM8994 by MyungJoo Ham? I saw it, yes. He is in charge

Re: [PATCH] MAX8952 PMIC Driver Initial Release

2010-08-19 Thread Mark Brown
On Thu, Aug 19, 2010 at 04:05:15PM +0900, MyungJoo Ham wrote: If MAX8952's EN is not going to be changed by this driver, the user should set gpio_en_writable as false. In S5PC210/UNIVERSL board, controlling EN pin at MAX8952 driver can be dangerous because this gpio pin is shared with another

Re: [PATCH] MAX8952 PMIC Driver Initial Release

2010-08-20 Thread Mark Brown
On Fri, Aug 20, 2010 at 02:24:22PM +0900, MyungJoo Ham wrote: However, could you please clarify more about this? They are already from platform data (pdata-ramp_speed and pdata-sync_freq). Sorry, I misread - the code is fine. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: Seems almost same between the operation of max8649 and max8952 except output voltage range. How do you think that can support max8952 with small modifying max8649? Take a look at something like the WM831x drivers for how you can

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 06:44:11PM +0900, Kukjin Kim wrote: MM...but I'm not sure if I can submit other patch for max8952... Actually, Mr. Ham's max8952 code has been applied by Liam. We can always remove that if it makes more sense to combine the code. - return (MAX8649_DCDC_VMIN +

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Mark Brown
On Wed, Sep 01, 2010 at 07:36:40PM +0900, Kyungmin Park wrote: As your word, first check the ID1 to detect the 8649 and 8952 and read ID2 again to distinguish it. But actually we pass the max8952 as platform device, so don't need to read ID2. If you can read the ID from the chip it's always

Re: [PATCH v2] regulators: add support max8952 regulator

2010-09-07 Thread Mark Brown
-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com This is OK but it should also include removal of the separate max8952 driver since the functionality is now merged into this driver. With that Acked-by: Mark

Re: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board

2010-09-10 Thread Mark Brown
point since given dev you can always use dev_name but you don't always have dev. Acked-by: Mark Brown broo...@opoensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board

2010-09-10 Thread Mark Brown
On Fri, Sep 10, 2010 at 06:55:50PM +0900, Kukjin Kim wrote: +static struct fixed_voltage_config mmc2_fixed_voltage_config = { + .supply_name= T_FLASH_EN, + .microvolts = 280, + .gpio = S5PV210_MP05(4), /* XM0ADDR_12 */ ...

Re: [PATCH] regulator: Add support samsung power domain

2010-09-20 Thread Mark Brown
On Mon, Sep 20, 2010 at 03:12:34PM +0900, Kukjin Kim wrote: The reason the implementation is located in machine-specific code is that the way to handle power domain in S5PV210 and S5PV310 is different but we can handle this using platform_device_id. Yes, I think it's reasonable to implement

Re: [PATCHv2 7/7] ARM: S5PC110: add support for MMC regulators on Goni board

2010-09-20 Thread Mark Brown
...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Mark Brown broo...@opensource.wolfsonmicro.com Looks good from a regulator API point of view: Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-09-30 Thread Mark Brown
On Fri, Oct 01, 2010 at 01:23:25PM +0900, Chanwoo Choi wrote: Additionally, I explain the constraints of the regulator of WM8994 codec. All these consumer supply of WM8994 codec connected the regulator(VCC_1.8V) on a circuit diagram. VCC_1.8V regulator is always enabled, because it is used to

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-10-01 Thread Mark Brown
On Fri, Oct 01, 2010 at 02:40:02PM +0900, Kyungmin Park wrote: FYI: now wm8994 codec is connected to I/O power directly. and there's no connection with PMIC. Presumably there's a power rail connection... Maybe you mean the I/O power LDO and use it. but it's always on in case of s5pc110.

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 09:50:04PM +0900, Chanwoo Choi wrote: Do you have additional comment on this patch? No, just what I said already. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:52:34PM +0900, Seungwhan Youn wrote: This patch add SCLK_SPDIF clock to support source clock of S/PDIF on S5PV210. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com but this looks like an example of where

Re: [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:42:25PM +0900, Seungwhan Youn wrote: This patch add SCLK_SPDIF clock to support source clock of S/PDIF on S5PC100. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com but... +static int

Re: [PATCH 1/10] ARM: S5PC100: Add S/PDIF platform device

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:31:59PM +0900, Seungwhan Youn wrote: This patch add S/PDIF platform device to support S/PDIF PCM audio on S5PC100. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe from this list: send

Re: [PATCH 6/10] ARM: S5PV210: Add audio clocks as sysclk

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 08:57:48PM +0900, Seungwhan Youn wrote: This patch adds audio clocks(SCLK_AUDIO{0,1,2} and SCLK_AUDIO) to be initial as a sysclk on boot-time. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To unsubscribe

Re: [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Mark Brown
On Mon, Oct 04, 2010 at 09:16:23PM +0900, Seungwhan Youn wrote: +/* Audio clock settings are belonged to board specific part. Every + * board can set audio source clock setting which is matched with H/W + * like this function-'set_audio_clock_heirachy'. + */ +static int

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-04 Thread Mark Brown
On Tue, Oct 05, 2010 at 02:39:00PM +0900, Jassi Brar wrote: Yes we can have a kconfig entry for 'Controllable EPLL' but that seems orthogonal to ASoC because, for SMDKs, we choose to produce accurate signals hence need to manipulate EPLL. The only point is where to do it. Well, there's two

Re: [alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

2010-10-11 Thread Mark Brown
On Sat, Oct 09, 2010 at 10:52:26AM +0900, Jassi Brar wrote: On Fri, Oct 8, 2010 at 6:07 PM, Seungwhan Youn claude.y...@gmail.com wrote: Now, I'm almost finished 2nd patch for submit except this audio clock setting. For now, I can only think that remove audio clock setting from this machine

Re: [PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning

2010-10-13 Thread Mark Brown
On Wed, Oct 13, 2010 at 04:55:55PM +0900, Kukjin Kim wrote: Seungwhan Youn wrote: This patch adds warning about changing EPLL rate to notice that other driver that controls H/W, which is using EPLL, will has unknown effects by this EPLL rate change. + printk(KERN_WARNING EPLL Rate

Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board

2010-10-14 Thread Mark Brown
On Thu, Oct 14, 2010 at 10:17:11AM +0900, Jassi Brar wrote: It's not exactly. GPIO pins are different. Maybe the GPIO differences could be handled at one place and other codes compressed ? Platform data for the audio driver, perhaps? That's being used by some other systems, and should be

Re: [PATCH v2 5/6] ASoC: SAMSUNG: Add S/PDIF CPU driver

2010-10-15 Thread Mark Brown
On Tue, Oct 12, 2010 at 08:51:23PM +0900, Seungwhan Youn wrote: This patch adds S/PDIF CPU driver for various Samsung SoCs. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Applied this and the machine driver, thanks! -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-27 Thread Mark Brown
On Wed, Dec 26, 2012 at 04:21:58PM +0530, Padma Venkat wrote: Hi, On Mon, Dec 24, 2012 at 9:33 AM, Padma Venkat padma@gmail.com wrote: Hi, You should always delete irrelevant text from mails, it makes it much easier for people to find whatever content you've added. I agree with using

Re: [PATCH v4 14/19] ARM: remove unneeded vic.h includes

2013-01-04 Thread Mark Brown
On Thu, Jan 03, 2013 at 11:54:23AM -0600, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com Numerous includes of asm/hardware/vic.h aren't needed, so remove them. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

[PATCH] spi/s3c64xx: Complain if we fail to set a transfer speed

2013-01-04 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ad93231..6495352 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c

Re: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:47AM +0100, Tomasz Figa wrote: + * The following lookup table is used to override device names when devices + * are registered from device tree. This is temporarily added to enable + * device tree support addition for the Exynos4 architecture. Cut'n'paste.

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:43AM +0100, Tomasz Figa wrote: +- interrupt-mask : Bit mask of valid interrupt sources (defaults to all valid) +- wakeup-mask : Bit mask of interrupt sources that can wake up the system + (defaults to all allowed) Should this really be configured in the VIC

Re: [RFC PATCH 3/7] ARM: s3c64xx: Add support for OF-based VIC initialization

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:45AM +0100, Tomasz Figa wrote: This patch modifies IRQ initialization code of S3C64xx to support Device Tree-based initialization of VICs. Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:10:38PM +0100, Tomasz Figa wrote: This is not the runtime interrupt/wakeup mask, but a global mask of available interrupt/wakeup lines on particular platform, which still have to be configured and enabled appropriately by user. Ah, OK. Reviewed-by: Mark Brown

[PATCH] ARM: S3C64XX: Fix up IRQ mapping for balblair on Cragganmore

2013-01-13 Thread Mark Brown
From: Dimitris Papastamos d...@opensource.wolfsonmicro.com We are using S3C_EINT(4) instead of S3C_EINT(5). Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: sta...@vger.kernel.org --- arch/arm/mach-s3c64xx/mach

Re: [PATCH V6 01/10] ASoC: Samsung: Rename samsung i2s secondary device name

2013-01-23 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:00PM +0530, Padmavathi Venna wrote: All Samsung SoCs has max 3 i2s controllers. So the i2s secondary fifo interface device id was named as samsung-i2s.4. Renaming this to samsung-i2s-sec to support device tree in i2s driver. Applied, thanks. signature.asc

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2013-01-24 Thread Mark Brown
On Thu, Jan 24, 2013 at 12:13:29PM +0100, Wolfram Sang wrote: On Sat, Dec 15, 2012 at 11:21:36PM +0900, Mark Brown wrote: also get things like read operations which appear as multiple transactions on the I2C bus so require something higher level than what multi-master provides. I don't

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2013-01-25 Thread Mark Brown
On Thu, Jan 24, 2013 at 12:39:48PM +0100, Wolfram Sang wrote: On Thu, Jan 24, 2013 at 07:18:47PM +0800, Mark Brown wrote: A read is typically implemented as a write of the register address followed by a read of the value, usually with the ability to free the bus in between. If two devices

<    1   2   3   4   5   6   7   8   9   10   >