Re: [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-05-10 Thread Russell King - ARM Linux
On Wed, May 02, 2012 at 03:53:53PM +0100, James Hogan wrote: Hi On 2 May 2012 06:07, Thomas Abraham thomas.abra...@linaro.org wrote: +       if (IS_ERR(host-biu_clk)) +               dev_info(host-dev, biu clock not available\n); In this case, should it set host-biu_clk to NULL or are

Re: [PATCH] ARM: EXYNOS: PD: Fix duplicate variable

2012-05-13 Thread Russell King - ARM Linux
On Wed, May 09, 2012 at 01:50:28PM +0100, Sangwook Lee wrote: struct generic_pm_domain already has a field for name. Use that field instead of creating another field in struct exynos_pm_domain Argh. No. @@ -99,7 +98,7 @@ static __init int exynos_pm_dt_parse_domains(void) if

Re: [PATCH] serial: samsung: Fixed wrong comparison for baudclk_rate

2012-05-15 Thread Russell King - ARM Linux
On Tue, May 15, 2012 at 07:13:28PM +0900, Kyoungil Kim wrote: port-baudclk_rate should be compared to the rate of port-baudclk, because port-baudclk_rate was assigned as the rate of port-baudclk previously. So to check that the current baudclk rate is same as previous rate, the target of

Re: [PATCH] serial: samsung: Fixed wrong comparison for baudclk_rate

2012-05-15 Thread Russell King - ARM Linux
On Tue, May 15, 2012 at 08:52:39PM +0900, Kyoungil Kim wrote: Russell King wrote: On Tue, May 15, 2012 at 07:13:28PM +0900, Kyoungil Kim wrote: port-baudclk_rate should be compared to the rate of port-baudclk, because port-baudclk_rate was assigned as the rate of port-baudclk

Re: [PATCH v2] serial: samsung: Fixed wrong comparison for baudclk_rate

2012-05-15 Thread Russell King - ARM Linux
On Tue, May 15, 2012 at 09:37:16PM +0900, Kyoungil Kim wrote: port-baudclk_rate should be compared to the rate of port-baudclk, because port-baudclk_rate was assigned as the rate of port-baudclk previously. So to check that the current baudclk rate is same as previous rate, the target of

Re: [PATCH v2 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-05-18 Thread Russell King - ARM Linux
On Thu, May 17, 2012 at 08:40:08PM +0530, Thomas Abraham wrote: +err_clk: + if (!IS_ERR(host-ciu_clk)) + clk_disable_unprepare(host-ciu_clk); + if (!IS_ERR(host-biu_clk)) + clk_disable_unprepare(host-biu_clk); + clk_put(host-ciu_clk); +

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 08:00:00PM +0900, Kukjin Kim wrote: +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy) +{ + struct clk *ref_clk; + int refclk_freq = 0; + + ref_clk = clk_get(sphy-dev, xusbxti); + if (IS_ERR(ref_clk)) { IS_ERR_OR_NULL(ref_clk)?

IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
People, This is not aimed at anyone specifically - but it is aimed at everyone who reviews patches to make them aware of this issue, and to modify their behaviour. I'm geting sick and tired of telling people about this. I've just floated the idea of removing IS_ERR_OR_NULL from the kernel tree

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 11:28:48PM +0300, Phil Carmody wrote: So, what to do? It can and has been used sensibly, so I don't think removing it is the best option. Well, the first thing that needs to be done is a full review of every user and fixes applied. The second thing is that we need eyes

Re: [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware

2012-11-12 Thread Russell King - ARM Linux
On Thu, Oct 25, 2012 at 05:22:38PM +0200, Tomasz Figa wrote: +static int exynos_do_idle(void) +{ +exynos_smc(SMC_CMD_SLEEP, 0, 0, 0); +return 0; +} This looks fine as an API - it has a defined purpose. + +static int exynos_cpu_boot(int cpu) +{ +

Re: [PATCH v3 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up

2012-11-12 Thread Russell King - ARM Linux
On Thu, Oct 25, 2012 at 05:22:40PM +0200, Tomasz Figa wrote: @@ -47,6 +48,8 @@ static inline void __iomem *cpu_boot_reg(int cpu) { void __iomem *boot_reg; + if (!call_firmware_op(cpu_boot_reg, cpu, boot_reg)) + return boot_reg; boot_reg = cpu_boot_reg_base();

Re: [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:39:28PM +0900, Kukjin Kim wrote: (+ Russell King) I think there's still an amount of work to do here; it's not a generic interface at the moment because it makes some assumptions about how things are done (eg, it assumes that there _will_ be a CPU boot register; that

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int combiner_nr, unsigned int i else max_nr = EXYNOS4_MAX_COMBINER_NR; - if

Re: [PATCH 340/493] arm: remove use of __devinitdata

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:24:49PM -0500, Bill Pemberton wrote: arch/arm/mach-sa1100/neponset.c | 2 +- For this alone, Acked-by: Russell King rmk+ker...@arm.linux.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: [PATCH] I2C: EXYNOS: Add slave support to i2c

2012-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2012 at 05:33:17PM +0530, Tushar Behera wrote: On 12/03/2012 05:46 PM, Giridhar Maruthy wrote: This patch adds slave support to i2c. The dt entry i2c-mode decides at probe time if the controller needs to work in slave mode and the controller is accordingly programmed. (I

Re: [PATCH] I2C: EXYNOS: Add slave support to i2c

2012-12-10 Thread Russell King - ARM Linux
On Mon, Dec 10, 2012 at 03:02:28PM +0530, Giridhar Maruthy wrote: Hi Russel, Thanks for review and please find my replies below. On 7 December 2012 18:03, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Dec 07, 2012 at 05:33:17PM +0530, Tushar Behera wrote: On 12/03/2012

Re: [PATCH] ARM: dts: fix split memory bank for SSDK5440

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 10:14:26PM +0100, Tomasz Figa wrote: Hi Olof, On Thursday 20 of December 2012 11:56:59 Olof Johansson wrote: Hi, On Thu, Dec 20, 2012 at 11:03 AM, Kukjin Kim kgene@samsung.com wrote: The size of memory bank should be under 256MB, because current

Re: [PATCH 01/18] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx

2009-11-19 Thread Russell King - ARM Linux
On Fri, Nov 13, 2009 at 11:19:03PM +, Ben Dooks wrote: On Thu, Nov 12, 2009 at 09:21:45AM +0100, Marek Szyprowski wrote: From: Kyungmin Park kyungmin.p...@samsung.com From: Kyungmin Park kyungmin.p...@samsung.com This one i'll keep out of the series, as it either needs to go to

Re: [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart

2009-11-19 Thread Russell King - ARM Linux
On Thu, Nov 19, 2009 at 11:08:27AM +, Mark Brown wrote: On Thu, Nov 19, 2009 at 08:05:29PM +0900, jassi brar wrote: On Thu, Nov 19, 2009 at 7:33 PM, Mark Brown This is going to set off warnings from a clock API point of view - passing clock names around in platform data is usually a

Re: [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart

2009-11-19 Thread Russell King - ARM Linux
On Thu, Nov 19, 2009 at 11:48:33AM +, Mark Brown wrote: On Thu, Nov 19, 2009 at 11:38:41AM +, Russell King - ARM Linux wrote: I'm not sure what you're commenting on precisely, but the Samsung code as a whole doesn't use the clk API very well, and I suspect that is starting

Re: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.

2009-11-19 Thread Russell King - ARM Linux
On Thu, Nov 19, 2009 at 09:03:21AM -0800, Dmitry Torokhov wrote: Why everyone thinks that it is a good idea to pile workarounds for software issues in the kernel but updating the other parts of software stack is a big no-no? It's probably because pressing 'reset' and have your board TFTP the

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Russell King - ARM Linux
On Wed, Jan 20, 2010 at 02:02:02AM +, Ben Dooks wrote: I've written a git pre-commit[1] hook which stops any commits happening if checkpatch.pl reports problems with the patch. Any comments? Very bad - checkpatch can be wrong at times. Eg 1, asm/irq.h vs linux/irq.h Eg 2, asm/memory.h vs

Re: too much memory for node

2010-01-20 Thread Russell King - ARM Linux
On Wed, Jan 20, 2010 at 04:05:25PM +, Ben Dooks wrote: On Wed, Jan 20, 2010 at 03:55:10PM +, Russell King - ARM Linux wrote: On Wed, Jan 20, 2010 at 03:34:11PM +, Ben Dooks wrote: I've been looking at support for a new machine type where the current system is using

Re: Default machine include placements

2010-01-25 Thread Russell King - ARM Linux
On Mon, Jan 25, 2010 at 04:02:56AM +, Ben Dooks wrote: Currently in the s3c/s5p familt we're seeing quite a number of the same things being repeated for items like entry-macro.S, hardware.h and so on. The first question is about adding include/mach directories to eitehr plat-s5p or

Re: [PULL] Please pull bjdooks' for-rmk/samsung2

2010-01-25 Thread Russell King - ARM Linux
On Mon, Jan 25, 2010 at 02:04:32PM +, Ben Dooks wrote: On Tue, Jan 19, 2010 at 10:12:19AM +, Ben Dooks wrote: Please pull the following tree which contains further updates since the last set of machine additions (and thus should go via RMK's trees) Hi, please hold unti i've checked

Re: current next-samsung

2010-05-12 Thread Russell King - ARM Linux
On Wed, May 12, 2010 at 09:52:02AM +0100, Ben Dooks wrote: ARM: Merge $1 ARM: Merge $1 ARM: Merge $1 This looks like a script went wrong. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-13 Thread Russell King - ARM Linux
On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote: On Thu, May 13, 2010 at 11:02 AM, Ben Dooks ben-li...@fluff.org wrote: 1) It takes two lines of code, where one is sufficient. 2) You only have to look in the relevant .c file to find out the   value instead of tracking down a

Re: [PATCH v2] ARM: S5P: Add System Timer

2010-05-14 Thread Russell King - ARM Linux
On Fri, May 14, 2010 at 05:51:30PM +0900, Kukjin Kim wrote: From: Jongpill Lee bo...@samsung.com This patch addes system timer for Samsung S5P series SoCs You really should be using the clockevents/clocksource code rather than trying to implement the old gettimeoffset stuff. -- To unsubscribe

Re: [PATCH] ARM: S5P6440: Add External Interrupt support

2010-05-24 Thread Russell King - ARM Linux
On Mon, May 24, 2010 at 04:47:00PM +0900, Kukjin Kim wrote: +#include asm/hardware/vic.h Doesn't seem to use this header. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/4] ARM: S3C64XX: Add support for Compact Flash driver on SMDK6410

2010-05-27 Thread Russell King - ARM Linux
On Thu, May 27, 2010 at 05:22:01PM +0900, Kukjin Kim wrote: +#include mach/map.h +#include mach/gpio.h shouldn't this be linux/gpio.h ? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/4] ARM: S5PV210: Add support for Compact Flash driver on SMDKV210/SMDKC110

2010-05-27 Thread Russell King - ARM Linux
On Thu, May 27, 2010 at 05:22:02PM +0900, Kukjin Kim wrote: +#include mach/gpio.h linux/gpio.h ? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] ARM: S5PV210: Add keypad device helpers

2010-05-28 Thread Russell King - ARM Linux
On Fri, May 28, 2010 at 08:51:42PM +0900, Joonyoung Shim wrote: diff --git a/arch/arm/mach-s5pv210/setup-keypad.c b/arch/arm/mach-s5pv210/setup-keypad.c new file mode 100644 index 000..03a9de1 --- /dev/null +++ b/arch/arm/mach-s5pv210/setup-keypad.c @@ -0,0 +1,34 @@ +/* + *

Re: [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support

2010-06-21 Thread Russell King - ARM Linux
On Mon, Jun 21, 2010 at 05:05:34PM +0800, Eric Miao wrote: On Mon, Jun 21, 2010 at 2:26 PM, Joonyoung Shim jy0922.s...@samsung.com wrote: +void __init samsung_keypad_set_platdata(struct samsung_keypad_platdata *pd) +{ +       struct samsung_keypad_platdata *npd; + +       if (!pd) {

Re: [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support

2010-06-21 Thread Russell King - ARM Linux
On Mon, Jun 21, 2010 at 06:39:10PM +0800, Eric Miao wrote: On Mon, Jun 21, 2010 at 5:19 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Jun 21, 2010 at 05:05:34PM +0800, Eric Miao wrote: On Mon, Jun 21, 2010 at 2:26 PM, Joonyoung Shim jy0922.s...@samsung.com wrote

Re: clock updates

2010-06-25 Thread Russell King - ARM Linux
On Fri, Jun 25, 2010 at 05:38:20PM +0900, MyungJoo Ham wrote: However, what about devices and clocks with the same name and different id numbers (i.e., platform_device.id)? Are you going to add .id lookup to clkdev's clk_find? There are multiple clocks with the same name and different id

Re: [PATCH v4] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-26 Thread Russell King - ARM Linux
On Fri, Jun 25, 2010 at 12:38:19PM +0900, Kukjin Kim wrote: Russell, How do you think? May I send this to your patch tracking system? Or...how should I handle this? If Jeff is happy, then I'm happy. However, shouldn't it also have Ben's ack? -- To unsubscribe from this list: send the line

Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

2010-07-06 Thread Russell King - ARM Linux
On Tue, Jul 06, 2010 at 01:36:47PM +0900, Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. What is the spacing of chunks of memory, and

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Russell King - ARM Linux
On Mon, Jul 12, 2010 at 07:08:11PM +0900, Kyungmin Park wrote: 27 for our board. 28 for generic. Note that I enabled HIGHMEM and modify the VMALLOC_END to 0xd000' to test HIGHMEM. If you want to test HIGHMEM, the way to do it is to specify a vmalloc= parameter to the kernel, not to

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Russell King - ARM Linux
On Mon, Jul 12, 2010 at 06:52:28PM +0900, Minchan Kim wrote: Hello. On Mon, Jul 12, 2010 at 5:32 PM, Kukjin Kim kgene@samsung.com wrote: Russell, Hi, Kukjin Kim wrote: Russell wrote: So, memory starts at 0x2000 and finishes at 0x2500.  That's fine. That doesn't

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Russell King - ARM Linux
On Mon, Jul 12, 2010 at 09:28:16PM +0900, Minchan Kim wrote: It just checks that there is a section and section_mem_map has SECTION_HAS_MEM_MAP. The first section in above case has just 80M memory but section has 256M. So, 0x2500 - 2800 is the hole. If you pass pfn whihc is

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-13 Thread Russell King - ARM Linux
On Tue, Jul 13, 2010 at 10:26:58AM +0100, Mel Gorman wrote: There is also an assumption that a section is fully populated or empty. That is absolutely absurd. So, I have a platform which has 256MB at 64MB intervals in 4 chunks. I can fit 512kB to any slot. It starts at 0x1000. Do I

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-13 Thread Russell King - ARM Linux
On Tue, Jul 13, 2010 at 10:28:52AM +0100, Mel Gorman wrote: I like this idea. It would allow memmap_valid_within to be thrown away altogether and it maintains the assumptions of the memory model and sounds cheap. It can't work. We map kernel memory with 1MB sections, not pages. -- To

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-13 Thread Russell King - ARM Linux
On Tue, Jul 13, 2010 at 10:50:35AM +0100, Mel Gorman wrote: On Tue, Jul 13, 2010 at 10:38:15AM +0100, Russell King - ARM Linux wrote: On Tue, Jul 13, 2010 at 10:26:58AM +0100, Mel Gorman wrote: There is also an assumption that a section is fully populated or empty. That is absolutely

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-13 Thread Russell King - ARM Linux
On Tue, Jul 13, 2010 at 10:53:24AM +0900, KAMEZAWA Hiroyuki wrote: yet another _very easy_ solution is, define pfn_valid() as following. We have a perfectly good and efficient pfn_valid() implementation which'll work no matter what memory model is chosen - we don't need to invent other

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-14 Thread Russell King - ARM Linux
On Wed, Jul 14, 2010 at 08:59:06AM +0900, Minchan Kim wrote: But I think Kukjin case's best solution is to make section size 16M, not 256M. Regardless of this, Your idea is the direction we should proceed, I think. So what if someone decides to fit 8MB DRAMs to the board? -- To unsubscribe from

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-14 Thread Russell King - ARM Linux
On Wed, Jul 14, 2010 at 08:04:07PM +0900, Minchan Kim wrote: On Wed, Jul 14, 2010 at 5:49 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jul 14, 2010 at 08:59:06AM +0900, Minchan Kim wrote: But I think Kukjin case's best solution is to make section size 16M, not 256M

Re: [PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-16 Thread Russell King - ARM Linux
On Fri, Jul 16, 2010 at 05:58:28PM +0900, Kukjin Kim wrote: diff --git a/arch/arm/mach-s5pv310/platsmp.c b/arch/arm/mach-s5pv310/platsmp.c new file mode 100644 index 000..9325ac2 --- /dev/null +++ b/arch/arm/mach-s5pv310/platsmp.c @@ -0,0 +1,212 @@ +/*

Re: [PATCH 3/4] ARM: SAMSUNG SoC: Clock Framework: Flag Support for struct clk.

2010-07-19 Thread Russell King - ARM Linux
On Mon, Jul 19, 2010 at 05:30:35PM +0900, MyungJoo Ham wrote: +#ifdef CONFIG_SAMSUNG_POWERDOMAIN + if ((clk-flags | CLKFLAGS_BOOT_ON) This is always true if CLKFLAGS_BOOT_ON is non-zero. + !(clk-flags | CLKFLAGS_CANNOT_DISABLE)) { This is always false

Re: [PATCH 2/4] ARM: S5PV210: Powerdomain/Clock-gating Support

2010-07-19 Thread Russell King - ARM Linux
On Mon, Jul 19, 2010 at 05:30:34PM +0900, MyungJoo Ham wrote: +static int powerdomain_set(struct powerdomain *pd, int enable) +{ + unsigned long ctrlbit; + void __iomem *reg; + void __iomem *stable_reg; + unsigned long reg_dat; + + if (pd == NULL) + return

Re: [PATCH RFC] h1940: use gpiolib for latch access

2010-07-25 Thread Russell King - ARM Linux
On Sun, Jul 25, 2010 at 07:41:12PM +0300, Vasily Khoruzhick wrote: diff --git a/arch/arm/mach-s3c2410/include/mach/h1940-latch.h b/arch/arm/mach-s3c2410/include/mach/h1940-latch.h index d8a8327..4607d5c 100644 --- a/arch/arm/mach-s3c2410/include/mach/h1940-latch.h +++

Re: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Russell King - ARM Linux
On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote: Well, some of them are indeed unused, but it's not an uncommon practice in kernel and might help future developers. On the other hand, arch/arm is getting soo big that we need to do something about this - and one solution is to avoid

Re: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Russell King - ARM Linux
On Mon, Aug 02, 2010 at 08:51:06AM -0300, Mauro Carvalho Chehab wrote: Em 02-08-2010 07:52, Russell King - ARM Linux escreveu: On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote: Well, some of them are indeed unused, but it's not an uncommon practice in kernel and might help

Re: [PATCH 1/3] h1940: use gpiolib for latch access

2010-09-02 Thread Russell King - ARM Linux
On Thu, Aug 19, 2010 at 06:00:01PM +0300, Vasily Khoruzhick wrote: diff --git a/arch/arm/mach-s3c2410/mach-h1940.c b/arch/arm/mach-s3c2410/mach-h1940.c index 779b45b..9717790 100644 --- a/arch/arm/mach-s3c2410/mach-h1940.c +++ b/arch/arm/mach-s3c2410/mach-h1940.c @@ -42,6 +42,7 @@

Re: [PATCH] ARM: SAMSUNG: Removed redunt zreladdr in Makefile.boot

2010-09-03 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 08:27:23AM +0900, Kukjin Kim wrote: Because can be calculated ZREADDR now, removed redunt zreladdr definitions in each Makefile.boot of Samsung architectures. I'd suggest holding off on this. CONFIG_ZRELADDR has a few problems at the moment that need fixing - and if

Re: [PATCH 2/2] ARM: S5PV310: Update CPU hotplug implementation

2010-09-30 Thread Russell King - ARM Linux
On Thu, Sep 30, 2010 at 10:02:37AM -0700, Colin Cross wrote: On Wed, Sep 29, 2010 at 4:58 AM, Kukjin Kim kgene@samsung.com wrote: Kukjin Kim wrote: From: Changhwan Youn chaos.y...@samsung.com This patch updates CPU hotplug implementation to reduce CPU power consumption and will

Re: [PATCH 3/3] ARM: S5PV310: Add external interrupt support

2010-10-09 Thread Russell King - ARM Linux
On Thu, Oct 07, 2010 at 08:24:58PM +0900, Jongsun Han wrote: +static unsigned int s5pv310_irq_split(unsigned int number) +{ + u32 ret; + u32 test = number; + + ret = do_div(test, IRQ_EINT_BASE); + + do_div(ret, 8); + + return ret; +} + +static unsigned int

Re: [PATCH] ARM: SAMSUNG: Bug fix spin_lock recursion in clk_enable() and clk_disable()

2010-10-19 Thread Russell King - ARM Linux
On Tue, Oct 19, 2010 at 12:09:25AM +0100, Ben Dooks wrote: I'm not sure, but I don't belive that the clk_ api has ever been callable from non-sleepable contexts such as interrupt handlers. I would welcome RMK's response (or any other response) about this issue? We have traditionally

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Russell King - ARM Linux
On Wed, Dec 26, 2012 at 05:58:32PM +0530, Vivek Gautam wrote: + if (!ret) + sphy-phyctrl_pmureg = ioremap(reg[0], reg[1]); + + of_node_put(usbphy_pmu); + + if (IS_ERR_OR_NULL(sphy-phyctrl_pmureg)) { No. Learn what the error return values are from functions. Using

Re: [PATCH 3/3] ARM: exynos5: Add clock save and restore

2013-01-09 Thread Russell King - ARM Linux
On Wed, Jan 09, 2013 at 06:24:41PM +0530, Prasanna Kumar wrote: After Suspend-Resume operation, it is observed that CLK_TOP_SRC3 register gets modified if the G-Scaler/MFC devices are power gated. The clock for G-Scaler gets set to XXTI which results in the device running very slow.This

Re: [PATCH v2 0/5] ARM: Manage the pl310 erratas in a dynamic way

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 03:40:38PM +0530, srinidhi kasagar wrote: - Added l2x0_quirks to manage the errata in cpu_idle path. Tried to address Russell's comment on this, but could not completely. Because, neither I can keep the #ifdef CONFIG_PL310_ERRATA_769419 nor remove it entirely since

Re: [PATCH v1 1/5] ARM: cache-l2x0: add 'smc' identifier

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 03:43:31PM +0530, srinidhi kasagar wrote: Add 'smc' (Secure Monitor Call) identifier to differentiates the platforms which implements this. This patch makes no sense. So, if setting 'smc' in the DT description is supposed to mean that the platform has a secure monitor

Re: [PATCH v1 1/5] ARM: cache-l2x0: add 'smc' identifier

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 05:08:53PM +0530, Srinidhi Kasagar wrote: On Tue, Jan 29, 2013 at 12:33:25 +0100, Russell King - ARM Linux wrote: On Tue, Jan 29, 2013 at 03:43:31PM +0530, srinidhi kasagar wrote: Add 'smc' (Secure Monitor Call) identifier to differentiates the platforms which

Re: [PATCH v1 1/5] ARM: cache-l2x0: add 'smc' identifier

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 05:19:27PM +0530, Srinidhi Kasagar wrote: On Tue, Jan 29, 2013 at 12:33:25 +0100, Russell King - ARM Linux wrote: On Tue, Jan 29, 2013 at 03:43:31PM +0530, srinidhi kasagar wrote: Add 'smc' (Secure Monitor Call) identifier to differentiates the platforms which

Re: question about arch/arm/mach-s3c24xx/irq.c

2013-02-24 Thread Russell King - ARM Linux
On Sun, Feb 24, 2013 at 12:45:11PM +0100, Julia Lawall wrote: The function s3c24xx_irq_map in arch/arm/mach-s3c24xx/irq.c contains the code: parent_irq_data = parent_intc-irqs[irq_data-parent_irq]; if (!irq_data) { pr_err(irq-s3c24xx: no

Re: [PATCH v2] arm: plat-samsung: check processor type before cache restoration in resume

2013-02-26 Thread Russell King - ARM Linux
On Tue, Feb 26, 2013 at 03:26:53PM +0530, Inderpal Singh wrote: Only cortex-a9 based samsung platforms have l2x0 cache controller. Hence check the same before restoring the cache in resume. Why is this patch soo complicated? Can't you read the CPUs MIDR register from assembly code? -- To

Re: [PATCH v2] arm: plat-samsung: check processor type before cache restoration in resume

2013-02-26 Thread Russell King - ARM Linux
On Tue, Feb 26, 2013 at 04:46:01PM +0530, Inderpal Singh wrote: On 26 February 2013 15:32, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 26, 2013 at 03:26:53PM +0530, Inderpal Singh wrote: Only cortex-a9 based samsung platforms have l2x0 cache controller. Hence check

Re: [PATCH] ARM: S3C24XX: drop select MACH_N35

2013-03-06 Thread Russell King - ARM Linux
On Thu, Mar 07, 2013 at 09:50:17AM +0900, Kukjin Kim wrote: Paul Bolle wrote: On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: BTW, so the machine type can be removed at arch/arm/tools/mach-types as well. Well, that file has a big comment on top, containing the line:

Re: [PATCH] ARM: S3C24XX: drop select MACH_N35

2013-03-07 Thread Russell King - ARM Linux
On Thu, Mar 07, 2013 at 10:14:19AM +0900, Kukjin Kim wrote: Russell King - ARM Linux wrote: And deleting entries from it is pointless if they've ever been in the kernel. OK, I see and agree. The issue is that the database system locks an entry into the file as soon as support is merged

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-07 Thread Russell King - ARM Linux
On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: + dvfs_info-cpu_clk = devm_clk_get(dvfs_info-dev, armclk); + if (IS_ERR_OR_NULL(dvfs_info-cpu_clk)) { devm_clk_get() return value needs to be checked with IS_ERR(),

Re: [PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 01:42:19AM +0100, Heiko Stübner wrote: + clk = clk_register(NULL, pll-hw); + if (IS_ERR(clk)) { + pr_err(%s: failed to register pll clock %s\n, __func__, + name); + kfree(pll); + } + + if

Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-25 Thread Russell King - ARM Linux
On Thu, Mar 21, 2013 at 11:06:47AM +, Mark Rutland wrote: On TC2 this series leads to using the vexpress 24MHz clock as the sched clock in preference to the architected timer: Architected local timer running at 24.00MHz (virt). Switching to timer-based delay loop Registered

Re: [PATCH] ARM: timer: Shutdown clock event device when stopping local timer

2013-03-30 Thread Russell King - ARM Linux
On Sat, Mar 30, 2013 at 05:57:38PM +0800, Ning Jiang wrote: 2013/3/30 Stephen Boyd sb...@codeaurora.org: On 03/29/13 02:24, ning.n.ji...@gmail.com wrote: From: Ning Jiang ning.n.ji...@gmail.com Currently there are two problems when we try to stop local timer. First, it calls set_mode

Re: [PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required

2013-04-08 Thread Russell King - ARM Linux
On Mon, Apr 08, 2013 at 12:27:34PM +0200, Sylwester Nawrocki wrote: On 04/08/2013 11:57 AM, Kukjin Kim wrote: Yes, this looks better. However after posting this patch I noticed linker errors in some builds due to undefined cpu_arm920_do_suspend, cpu_arm920_do_resume routines. It seems it is

Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig

2013-04-17 Thread Russell King - ARM Linux
On Wed, Apr 17, 2013 at 05:25:34PM +0800, Chen Gang wrote: CONFIG_CPU_ARM7TDMI=y CONFIG_CPU_ARM9TDMI=y CONFIG_CPU_V7=y CONFIG_CPU_32v4T=y CONFIG_CPU_32v6K=y CONFIG_CPU_32v7=y This is an invalid configuration. A single kernel can not support ARMv7 and ARMv4T simultaneously. The problem is

Re: [PATCH 1/2] ARM: EXYNOS: Add a platform bus notifier to set dma masks for Exynos5440

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 04, 2013 at 07:51:43PM +0900, Kukjin Kim wrote: +static u64 dma_mask64 = DMA_BIT_MASK(64); ... + if (event != BUS_NOTIFY_ADD_DEVICE) + return NOTIFY_DONE; + + dev-dma_mask = dma_mask64; Sharing the dma mask in this way is a potential issue should you have a

Re: [PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-19 Thread Russell King - ARM Linux
On Wed, Apr 10, 2013 at 06:56:48AM -0700, Doug Anderson wrote: Thomas, On Wed, Apr 10, 2013 at 5:48 AM, Thomas Abraham thomas.abra...@linaro.org wrote: The call to regulator_enable() is prior to the call to mmc_add_host(). Hence, call to mmc_fre_host is not required in this case. So the

Re: [PATCH v2] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.

2013-04-24 Thread Russell King - ARM Linux
On Wed, Apr 24, 2013 at 12:20:24PM +0800, Chen Gang wrote: If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, but in fact, only AT91X40 need ARM7TDMI, so need not let them visible. I'll apply it myself this evening. Can I add: Tested-by: Chen Gang gang.c...@asianux.com to

Re: [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7

2014-04-25 Thread Russell King - ARM Linux
On Sat, Apr 26, 2014 at 02:25:03AM +0200, Tomasz Figa wrote: On 25.04.2014 03:16, Chanwoo Choi wrote: This patch decide proper lowpower mode of either a15 or a9 according to own ID from Main ID register. Cc: Arnd Bergmann a...@arndb.de Cc: Marc Zynigier marc.zyng...@arm.com Signed-off-by:

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-26 Thread Russell King - ARM Linux
On Fri, Apr 25, 2014 at 04:36:01PM +0200, Andrzej Hajda wrote: On 04/23/2014 07:13 PM, Russell King - ARM Linux wrote: Let me be absolutely clear *why* I'm very interested in this - and that is because I'm presently converting TDA998x and Armada DRM to use the component helpers. If your

Re: [PATCH 00/16] Another 16 L2C patches

2014-04-28 Thread Russell King - ARM Linux
On Mon, Apr 28, 2014 at 11:27:09AM -0600, Stephen Warren wrote: On 04/28/2014 11:12 AM, Stephen Warren wrote: On 04/28/2014 10:56 AM, Russell King - ARM Linux wrote: So, in response to Matt Porter's complaint about breaking prima2, here's another 16 patches which changes the way the L2

Re: [PATCH 51/97] ARM: l2c: remove platforms/SoCs setting early BRESP

2014-04-28 Thread Russell King - ARM Linux
On Tue, Apr 29, 2014 at 09:02:27AM +0900, Simon Horman wrote: On Mon, Apr 28, 2014 at 08:30:32PM +0100, Russell King wrote: Since we now automatically enable early BRESP in core L2C-310 code when we detect a Cortex-A9, we don't need platforms/SoCs to set this bit explicitly. Instead, they

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Russell King - ARM Linux
On Wed, Apr 30, 2014 at 11:42:09PM +0200, Andrzej Hajda wrote: The main problem with component framework is that componentization significantly changes every driver and changes it in a way which is not compatible with traditional drivers, so devices which are intended to work with

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-05-01 Thread Russell King - ARM Linux
On Thu, May 01, 2014 at 09:04:19AM +0200, Andrzej Hajda wrote: 2. You replace calls of component_add and component_del with calls to interface_tracker_ifup(dev, INTERFACE_TRACKER_TYPE_COMPONENT, specific_component_ops), or interface_tracker_ifdown. Thats all for components. How does the

Exynos induced build error with recent arm-soc

2014-06-02 Thread Russell King - ARM Linux
Spotted with a randconfig today: arch/arm/mach-exynos/built-in.o: In function `exynos_set_cpu_boot_addr': pm_domains.c:(.text+0x19c): undefined reference to `sysram_ns_base_addr' arch/arm/mach-exynos/built-in.o:(.data+0x94): undefined reference to `exynos_enter_aftr' This should be fixed before

Re: Problems booting exynos5420 with 1 CPU

2014-06-06 Thread Russell King - ARM Linux
On Fri, Jun 06, 2014 at 01:49:11PM -0700, Doug Anderson wrote: This works and IMHO is much cleaner because it totally removes the U-Boot dependency. I'll cleanup to not be so insane and post: diff --git a/arch/arm/mach-exynos/mcpm-exynos.c b/arch/arm/mach-exynos/mcpm-exynos.c index

Re: Problems booting exynos5420 with 1 CPU

2014-06-07 Thread Russell King - ARM Linux
On Sat, Jun 07, 2014 at 04:53:34PM -0700, Olof Johansson wrote: You do realize that you have absolutely zero leverage over us on this, right? Our product is already shipped with kernel code that fixes this. That is never a justification for forcing /any/ code into the kernel. We've been here

Re: Problems booting exynos5420 with 1 CPU

2014-06-08 Thread Russell King - ARM Linux
On Sun, Jun 08, 2014 at 01:45:30PM +0100, Lorenzo Pieralisi wrote: Olof, it is not puritanism, it is all about upstreaming code. If we keep accepting these hacks and we end up with mach code full of them we have a problem, do you agree ? To see the kind of problem that accepting hacked up code

Re: Problems booting exynos5420 with 1 CPU

2014-06-08 Thread Russell King - ARM Linux
On Sun, Jun 08, 2014 at 02:26:43PM -0400, Nicolas Pitre wrote: On Sun, 8 Jun 2014, Russell King - ARM Linux wrote: On Sat, Jun 07, 2014 at 04:53:34PM -0700, Olof Johansson wrote: You do realize that you have absolutely zero leverage over us on this, right? Our product is already shipped

Re: Problems booting exynos5420 with 1 CPU

2014-06-08 Thread Russell King - ARM Linux
On Sun, Jun 08, 2014 at 02:55:03PM -0400, Nicolas Pitre wrote: On Sun, 8 Jun 2014, Russell King - ARM Linux wrote: No, I was specifically thinking about the various iPAQ specific things like the additional platform specific ATAGs that they invented with zero reference to mainline

Re: [PATCH] arm: exynos: Modify pm code to check for cortex A9 rather than the SoC

2014-06-24 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 09:37:14AM +0530, Abhilash Kesavan wrote: Hi Kukjin, On Fri, May 23, 2014 at 8:31 AM, Abhilash Kesavan a.kesa...@samsung.com wrote: Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com Do you have any comments on this patch ? I do. diff --git

Re: [PATCH] arm: exynos: Modify pm code to check for cortex A9 rather than the SoC

2014-06-24 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 05:11:14PM +0100, Russell King - ARM Linux wrote: Another point: exynos have taken it upon themselves to add code which saves various ARM core registers. This is a bad idea, it brings us back to the days where every platform did their own suspend implementations. CPU

Re: [PATCH] arm: exynos: Modify pm code to check for cortex A9 rather than the SoC

2014-06-24 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 06:20:56PM +0200, Tomasz Figa wrote: Hi Russell, On 24.06.2014 18:11, Russell King - ARM Linux wrote: On Mon, Jun 16, 2014 at 09:37:14AM +0530, Abhilash Kesavan wrote: Hi Kukjin, On Fri, May 23, 2014 at 8:31 AM, Abhilash Kesavan a.kesa...@samsung.com wrote

Re: [PATCH] arm: exynos: Modify pm code to check for cortex A9 rather than the SoC

2014-06-24 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 07:16:47PM +0200, Tomasz Figa wrote: I tend to disagree. The chance of a new Cortex A9 based SoC with different implementor code showing up is so close to zero that I don't see increasing of code complexity by adding yet another check justified. That's your opinion

Re: [PATCH] arm: exynos: Modify pm code to check for cortex A9 rather than the SoC

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 10:30:46AM +0530, Abhilash Kesavan wrote: I see that you have sent a patch out that ensures both part and implementor number are checked. Currently, my patch has been applied to the fixes branch of the arm-soc tree and I wanted to know how to proceed (without it there

Re: [PATCH 1/1] ARM: Kconfig.debug: Update Samsung UART config options

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 08:41:13PM +0900, Kukjin Kim wrote: Sachin Kamat wrote: + Russell In a multiplatform config, the low level debug option shows several UART port entries. Improve the user visible string so that it becomes clear to the user about Samsung UART ports. While at it

Re: [PATCH v2 0/6] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 03:37:25PM +0200, Tomasz Figa wrote: This series intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which requires certain initialization steps to be done with help of firmware, as selected registers are writable only from

Re: [PATCH v2 0/6] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 04:13:16PM +0200, Tomasz Figa wrote: On 25.06.2014 15:50, Russell King - ARM Linux wrote: On Wed, Jun 25, 2014 at 03:37:25PM +0200, Tomasz Figa wrote: This series intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which

Re: [PATCH 2/2] ARM: EXYNOS: Add support for firmware-assisted suspend/resume

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 06:18:34PM +0200, Tomasz Figa wrote: +static int exynos_suspend(void) +{ + /* Save Power control and Diagnostic registers */ + asm (mrc p15, 0, %0, c15, c0, 0\n + mrc p15, 0, %1, c15, c0, 1\n + : =r (cp15_power), =r (cp15_diag) : : cc);

Re: [PATCH 0/3] Deterministic UART numbering on Samsung SoCs

2014-06-26 Thread Russell King - ARM Linux
On Thu, Jun 26, 2014 at 01:24:32PM +0200, Tomasz Figa wrote: Current Samsung UART driver relies on probe order of particular samsung-uart instances, which makes it impossible to get proper initialization of ports when not all ports are available on board, not even saying of deterministic

Re: mainline boot: 64 boots: 62 pass, 2 fail (v3.16-rc1-2-gebe0618)

2014-06-26 Thread Russell King - ARM Linux
On Thu, Jun 26, 2014 at 07:59:19AM -0700, Kevin Hilman wrote: I agree that the u-boot bug needs to be fixed, and FWIW, I updated my u-boot and haven't seen the boot failure yet after several boots with next-20140625. That being said, since it's not always feasible/practical to update

  1   2   3   4   5   >