[PATCH 1/1] [media] platform: Deletion of unnecessary checks before two function calls

2014-11-20 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 11:44:20 +0100 The functions i2c_put_adapter() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the

[PATCH 1/1] thermal: Exynos: Deletion of unnecessary checks before two function calls

2014-11-21 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 21 Nov 2014 11:06:33 +0100 The functions cpufreq_cooling_unregister() and thermal_zone_device_unregister() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was

Re: thermal: Exynos: Deletion of unnecessary checks before two function calls

2014-11-21 Thread SF Markus Elfring
for (i = 0; i th_zone-cool_dev_size; i++) { -if (th_zone-cool_dev[i]) -cpufreq_cooling_unregister(th_zone-cool_dev[i]); +cpufreq_cooling_unregister(th_zone-cool_dev[i]); } Now you have unnecessary {} How are the chances that your

[PATCH v2] thermal: Exynos: Deletion of unnecessary checks before two function calls

2014-11-21 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 21 Nov 2014 17:11:49 +0100 The functions cpufreq_cooling_unregister() and thermal_zone_device_unregister() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was

[PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-04 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 21:54:45 +0100 The functions phy_power_on() and vunmap() perform also input parameter validation. Thus the test around their calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-06-27 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 21:54:45 +0100 The functions phy_power_on() and vunmap() perform also input parameter validation. Thus the test around their calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH] [media] gsc-m2m: Use an unsigned data type for a variable

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 15:28:37 +0100 The data type "int" was used by the variable "ret" in the gsc_m2m_poll() function despite of the aspect that the type "unsigned int" will usually be needed for the return value from a call of the