Re: [PATCH 03/12] PM / Domains: Add notifier support for power domain transitions

2014-11-04 Thread Sylwester Nawrocki
On 04/11/14 07:16, amit daniel kachhap wrote: > On Mon, Nov 3, 2014 at 11:51 PM, Sylwester Nawrocki > wrote: >> On 03/11/14 04:53, Amit Daniel Kachhap wrote: [...] >>> 4 type of notifications are added, >>> GPD_OFF_PRE - GPD state before power off >>>

Re: [PATCH 03/12] PM / Domains: Add notifier support for power domain transitions

2014-11-04 Thread Sylwester Nawrocki
On 04/11/14 07:44, amit daniel kachhap wrote: > On Mon, Nov 3, 2014 at 11:53 PM, Kevin Hilman wrote: >> "Rafael J. Wysocki" writes: >>> On Monday, November 03, 2014 09:23:01 AM Amit Daniel Kachhap wrote: These power domain transition notifiers will assist in carrying out some activity a

Re: [PATCH 03/12] PM / Domains: Add notifier support for power domain transitions

2014-11-03 Thread Sylwester Nawrocki
Now really filling in the CC list, apologies for duplicate post. On 03/11/14 19:21, Sylwester Nawrocki wrote: > Hi, > > Cc: Ulf, Kevin, Geert. > > On 03/11/14 04:53, Amit Daniel Kachhap wrote: >> These power domain transition notifiers will assist in carrying >> o

Re: [PATCH 03/12] PM / Domains: Add notifier support for power domain transitions

2014-11-03 Thread Sylwester Nawrocki
Hi, Cc: Ulf, Kevin, Geert. On 03/11/14 04:53, Amit Daniel Kachhap wrote: > These power domain transition notifiers will assist in carrying > out some activity associated with domain power on/off such as > some registers which may lose its contents and need save/restore > across domain power off/o

[GIT PULL] Samsung clock changes for 3.19

2014-10-31 Thread Sylwester Nawrocki
Hi Mike, I've collected Exynos clk patches in this pull request, as Tomasz has been busy recently. This includes addition of clock controller drivers for Exynos4415 and Exynos7 SoCs and related refactoring of the Samsung common clk API. As I mentioned in my other e-mail, it might be sensible t

[PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi

2014-10-31 Thread Sylwester Nawrocki
error log: [1.842447] ERROR: could not get clock /camera/fimc-is@1200:uart(13) [1.848529] exynos4-fimc-is 1200.fimc-is: failed to get clock: uart [1.855275] exynos4-fimc-is: probe of 1200.fimc-is failed with error -2 Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/

Re: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-31 Thread Sylwester Nawrocki
On 28/10/14 05:09, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> On 27/10/14 02:11, Chanwoo Choi wrote: >>> Chanwoo Choi (2): >>> clk: samsung: exynos4415: Add clocks using common clock framework >>> clk: samsung: Document binding for Exynos4415

Re: [PATCH v5 0/8] arch: arm64: Enable support for Samsung Exynos7 SoC

2014-10-27 Thread Sylwester Nawrocki
Hi Abhilash, On 24/10/14 16:32, Abhilash Kesavan wrote: > On Wed, Oct 8, 2014 at 11:18 AM, Abhilash Kesavan > wrote: >> On Tue, Oct 7, 2014 at 9:46 AM, Kukjin Kim wrote: >>> Tomasz Figa wrote: On 30.09.2014 17:12, Abhilash Kesavan wrote: > On Mon, Sep 22, 2014 at 2:22 PM, Tomasz Figa

Re: [PATCH v2 3/7] clk: samsung: exynos7: add clocks for RTC block

2014-10-27 Thread Sylwester Nawrocki
Hi, On 21/10/14 07:43, Abhilash Kesavan wrote: > From: Naveen Krishna Ch > > Add clock support for the RTC block in Exynos7. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Abhilash Kesavan > --- > .../devicetree/bindings/clock/exynos7-clock.txt|5 ++ > drivers/clk/samsung/clk-

Re: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-27 Thread Sylwester Nawrocki
On 27/10/14 02:11, Chanwoo Choi wrote: > Chanwoo Choi (2): > clk: samsung: exynos4415: Add clocks using common clock framework > clk: samsung: Document binding for Exynos4415 clock controller Added both to my tree, thanks. In future please put DT binding documentation first in the series, befo

Re: [PATCHv2 1/2] clk: samsung: exynos4415: Add clocks using common clock framework

2014-10-24 Thread Sylwester Nawrocki
Hi Chanwoo, On 24/10/14 16:07, Chanwoo Choi wrote: [...] >> How about prefixing the table names below with "exynos4415", rather than >> "samsung" ? > > 'struct samsung_fixed_factor_clock' is common for Exynos SoC. > > Do you means that add 'exynos4415' prefix as following: > - fixed_factor_clks

Re: [PATCH 2/5] clk: samsung: exynos4415: Add clocks using common clock framework

2014-10-24 Thread Sylwester Nawrocki
On 24/10/14 15:18, Daniel Drake wrote: > On Sun, Oct 19, 2014 at 9:32 PM, Chanwoo Choi wrote: >> > This patch adds the new clock driver of Exynos4415 SoC based on Cortex-A9 >> > using common clock framework. The CMU (Clock Management Unit) of Exynos4415 >> > controls PLLs(Phase Locked Loops) and g

Re: [PATCHv2 1/2] clk: samsung: exynos4415: Add clocks using common clock framework

2014-10-24 Thread Sylwester Nawrocki
n clocks for individual IPs. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed-off-by: Chanwoo Choi > Signed-off-by: Tomasz Figa > Signed-off-by: Seung-Woo Kim > Acked-by: Kyungmin Park Thanks for the update, there are still couple issues pointed out by checkpatch.p

Re: [PATCH 2/5] clk: samsung: exynos4415: Add clocks using common clock framework

2014-10-24 Thread Sylwester Nawrocki
n clocks for individual IPs. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed-off-by: Chanwoo Choi > Signed-off-by: Tomasz Figa > Signed-off-by: Seung-Woo Kim > Acked-by: Kyungmin Park The patch looks good to me, I've applied it to my tree and will be sending i

Re: [PATCH 3/5] clk: samsung: Document binding for Exynos4415 clock controller

2014-10-24 Thread Sylwester Nawrocki
inding is not supposed to depend on any OS. Instead I would just put here something like: "This patch adds DT binding documentation for Exynos4415 SoC system clock controllers." > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed-off-by: Chanwoo Choi > Acked-by: Kyungmi

Re: [PATCH v2 0/3] Some cleanup for samsung clock

2014-10-23 Thread Sylwester Nawrocki
Hi Pankaj, On 22/10/14 12:34, Pankaj Dubey wrote: > It there are no comments will you please pick up this patch series. I've picked up these patches and I'm planning to send a pull request to Mike this week, including any other pending samsung clk patches. Tomasz is going to be busy for few days.

[PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-07 Thread Sylwester Nawrocki
Paul Bolle Acked-by: Jingoo Han Cc: [3.17+] Signed-off-by: Sylwester Nawrocki --- Changes since v2: - updated the commit description. drivers/usb/host/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig in

Re: [PATCH v2] [media] Remove references to non-existent PLAT_S5P symbol

2014-10-07 Thread Sylwester Nawrocki
On 06/10/14 18:36, Paul Bolle wrote: > On Mon, 2014-10-06 at 18:10 +0200, Sylwester Nawrocki wrote: >> > The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 >> > ("ARM: SAMSUNG: Remove remaining legacy code"). However, there >> > are still some

Re: [PATCH] ARM: dts: Specify Odroid X2/U3 audio clock parents and rates

2014-10-06 Thread Sylwester Nawrocki
On 10/09/14 16:43, Sylwester Nawrocki wrote: > This ensures the core and the audio subsystem clocks are configured > properly, as expected by the sound machine driver. These bits are > missing to obtain proper audio sample rates in kernel v3.17, where > audio support for Odroid X2/

[PATCH v2] [media] Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code"). However, there are still some references to that symbol left, fix that by substituting them with ARCH_S5PV210. Reported-by: Paul Bolle Signed-off-by: Sylwester Nawrocki --

Re: [PATCH] [media] Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
On 06/10/14 17:52, Tomasz Figa wrote: > On 06.10.2014 17:39, Sylwester Nawrocki wrote: >> diff --git a/drivers/media/platform/exynos4-is/Kconfig >> b/drivers/media/platform/exynos4-is/Kconfig >> index 77c9512..b3b270a 100644 >> --- a/drivers/media/platform/exynos4-

[PATCH] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code"). There are still some references left, fix that by replacing them with ARCH_S5PV210. Reported-by: Paul Bolle Signed-off-by: Sylwester Nawrocki --- drivers/usb/host/Kcon

[PATCH] [media] Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code"). However, there are still some references to that symbol left, fix that by substituting them with ARCH_S5PV210. Reported-by: Paul Bolle Signed-off-by: Sylwester Nawrocki --

Re: [PATCH 2/4] [media] exynos4-is: Remove optional dependency on PLAT_S5P

2014-10-06 Thread Sylwester Nawrocki
On 06/10/14 14:37, Sergei Shtylyov wrote: >> diff --git a/drivers/media/platform/exynos4-is/Kconfig >> b/drivers/media/platform/exynos4-is/Kconfig >> index 77c951237744..775c3278d0eb 100644 >> --- a/drivers/media/platform/exynos4-is/Kconfig >> +++ b/drivers/media/platform/exynos4-is/Kconfig >> @@

Re: [PATCH] ASoC: samsung: fix CDCLK handling

2014-10-02 Thread Sylwester Nawrocki
On 2014-10-02 19:54, Mark Brown wrote: On Thu, Oct 02, 2014 at 06:16:43PM +0200, Sylwester Nawrocki wrote: [dropping unrelated addresses from Cc] You've dropped Liam who's the other ASoC maintainer. Whoops, pardon me, somewhat I thought about Liam more as the regulator API auth

Re: [PATCH] ASoC: samsung: fix CDCLK handling

2014-10-02 Thread Sylwester Nawrocki
[dropping unrelated addresses from Cc] On 30/09/14 18:40, Daniel Drake wrote: > ODROID is the only platform that uses CDCLK, and right now, > CDCLK handling is buggy. If you start pulseaudio on ODROID, > audio is broken until reboot (even after killing pulse). > > This happens because CDCLK gets

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Sylwester Nawrocki
On 02/10/14 15:30, Ulf Hansson wrote: [...] > Correct me if I am wrong, but I think in principle these exynos > drivers don't use pm_runtime_set_active() during ->probe() and are > instead relying on CONFIG_PM_RUNTIME to be enabled. Yes, pm_runtime_set_active() is not used in probe(), I believe th

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-02 Thread Sylwester Nawrocki
Hello Ulf, On 02/10/14 11:09, Ulf Hansson wrote: > On 1 October 2014 18:36, Sylwester Nawrocki wrote: >> On 01/10/14 16:41, Ulf Hansson wrote: >>> There are currently no users of this API, let's remove it. > > Hi Sylwester, > > Thanks for your reply! &g

Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API

2014-10-01 Thread Sylwester Nawrocki
On 01/10/14 16:41, Ulf Hansson wrote: > There are currently no users of this API, let's remove it. The sad fact is that removal of pm_genpd_dev_need_restore() calls from arch/arm/mach-exynos/pm_domains.c introduces regressions in multiple exynos drivers (I'm sure it breaks media drivers). I think

Re: [PATCH v2 2/4] ARM: exynos: Ensure PM domains are powered at initialization

2014-10-01 Thread Sylwester Nawrocki
On 01/10/14 16:41, Ulf Hansson wrote: > At ->probe() it's common practice for drivers/subsystems to bring their > devices to full power and without depending on CONFIG_PM_RUNTIME. > > We could also expect that drivers/subsystems requires their device's > corresponding PM domains to be powered, to

Re: [PATCH] ARM: dts: Specify default clocks for Exynos4 FIMC devices

2014-09-26 Thread Sylwester Nawrocki
On 26/09/14 15:24, Tomasz Figa wrote: > I'm not concerned specifically with Exynos4210, but with placing such > kind of data in common dtsi files. > > Notice that even on boards which have correct initialization done by > firmware, this will cause the settings to be overwritten, even if the > firm

Re: [PATCH] ARM: dts: Specify default clocks for Exynos4 FIMC devices

2014-09-26 Thread Sylwester Nawrocki
Hi Tomasz, On 25/09/14 23:58, Tomasz Figa wrote: > On 10.09.2014 18:37, Sylwester Nawrocki wrote: >> > The default mux and divider clocks are specified in device tree >> > so that the FIMC devices in Exynos4210 and Exynos4x12 SoCs are >> > clocked from recommended

Re: [PATCH] ARM: dts: Specify default clocks for Exynos4 FIMC devices

2014-09-25 Thread Sylwester Nawrocki
On 19/09/14 01:53, Daniel Drake wrote: > On Wed, Sep 10, 2014 at 10:37 AM, Sylwester Nawrocki > wrote: >> The default mux and divider clocks are specified in device tree >> so that the FIMC devices in Exynos4210 and Exynos4x12 SoCs are >> clocked from recommended clock

Re: [PATCH] ARM: dts: Specify default clocks for Exynos4 FIMC devices

2014-09-25 Thread Sylwester Nawrocki
Hi Daniel, On 18/09/14 21:27, Daniel Drake wrote: > On Wed, Sep 10, 2014 at 10:37 AM, Sylwester Nawrocki > wrote: >> > The default mux and divider clocks are specified in device tree >> > so that the FIMC devices in Exynos4210 and Exynos4x12 SoCs are >> > cloc

Re: [PATCH 17/18] [media] s3c-camif: fix dma_addr_t printks

2014-09-25 Thread Sylwester Nawrocki
t’ [-Wformat=] > static struct _ddebug __aligned(8) \ [...] > Signed-off-by: Mauro Carvalho Chehab Thanks, Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] [media] exynos4-is: fix some warnings when compiling on arm64

2014-09-25 Thread Sylwester Nawrocki
: format > ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type > ‘dma_addr_t’ [-Wformat=] > isp_dbg(2, &video->ve.vdev, [...] > Signed-off-by: Mauro Carvalho Chehab Thanks Mauro, Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the l

[PATCH] ARM: dts: Specify default clocks for Exynos4 FIMC devices

2014-09-10 Thread Sylwester Nawrocki
practice optimal in most cases. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4210.dtsi | 16 arch/arm/boot/dts/exynos4x12.dtsi | 16 2 files changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts

[PATCH v2] ARM: dts: Specify Odroid X2/U3 audio clock parents and rates

2014-09-10 Thread Sylwester Nawrocki
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added. Signed-off-by: Sylwester Nawrocki --- It would

[PATCH] ARM: dts: Specify Odroid X2/U3 audio clock parents and rates

2014-09-10 Thread Sylwester Nawrocki
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added. Signed-off-by: Sylwester Nawrocki --- It would

Re: [PATCHv2 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Sylwester Nawrocki
() couldn't simply be used, since > exynos4_jpeg_sw_reset() is called with a spinlock held. > > So, let's use ndelay() instead. > > Reported-by: Stephen Rothwell > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sylwester Nawrocki -- Thanks, Sylwester -- To unsubscribe from this list: s

Re: [PATCH] ASoC: samsung-i2s: Check secondary DAI exists before referencing

2014-09-09 Thread Sylwester Nawrocki
epax Acked-by: Sylwester Nawrocki Thanks for the patch. We had one of those occurrences fixed internally but I missed to submit the patch upstream. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Sylwester Nawrocki
On 09/09/14 16:38, Mauro Carvalho Chehab wrote: > ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] undefined! > > Yet, it sounds a bad idea to use ndelay to wait for 100 us > for the device to reset. > > Reported-by: Stephen Rothwell > Signed-off-by: Mauro Carvalho Chehab >

Re: [PATCH] videobuf2-core: make checking condition more strict

2014-08-20 Thread Sylwester Nawrocki
On 20/08/14 05:11, Zhaowei Yuan wrote: > It's also invalid that plane_no equals to vb->num_planes The patch looks good to me but I would make the summary line more specific, e.g. "vb2: fix plane index sanity check in vb2_plane_cookie()". I think this patch should be backported to the stable tree

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Sylwester Nawrocki
(dropping linux-doc ML and Randy from Cc) On 31/07/14 13:22, Humberto Silva Naves wrote: > This implements the fixed rate clocks generated either inside or > outside the SoC. It also adds a dt-binding constant for the > sclk_hdmiphy clock, which shall be later used by other drivers, > such as the

Re: [PATCH] media: s5p_mfc: Check the right pointer after allocation

2014-07-29 Thread Sylwester Nawrocki
On 23/07/14 06:05, Zhaowei Yuan wrote: > It should be bank2_virt to be checked after dma allocation > instead of dev->fw_virt_addr. This patch is not applicable to the media master branch [1]. Additionally, AFAICS dma_alloc_coherent return value should be tested for NULL, rather than for ERR_PTR()

Re: [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata()

2014-07-29 Thread Sylwester Nawrocki
On 23/07/14 06:06, Zhaowei Yuan wrote: > Since we have get vdev by calling video_devdata() at the beginning of > s5p_mfc_open(), we should just use vdev instead of calling video_devdata() > again in the following code. Applied to my tree, thanks. -- To unsubscribe from this list: send the line "un

[PATCH v3 3/9] s5p-jpeg: return error immediately after get_byte fails

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski When parsing JPEG header s5p_jpeg_parse_hdr function should return immediately in case there was an error while reading a byte. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c |4 ++-- 1 file changed

[PATCH v3 5/9] s5p-jpeg: fix g_selection op

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski V4L2_SEL_TGT_COMPOSE_DEFAULT switch case should select whole available area of the image and V4L2_SEL_TGT_COMPOSE should apply user settings. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12

[PATCH v3 2/9] s5p-jpeg: Add support for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
: Sylwester Nawrocki --- drivers/media/platform/Kconfig |5 +- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c| 527 +++- drivers/media/platform/s5p-jpeg/jpeg-core.h| 32

[PATCH v3 8/9] s5p-jpeg: add chroma subsampling adjustment for Exynos3250

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Take into account limitations specific to the Exynos3250 SoC, regarding setting the chroma subsampling control's value. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c |

[PATCH v3 4/9] s5p-jpeg: Adjust jpeg_bound_align_image to Exynos3250 needs

2014-07-25 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index a3f8862..5ef7f5b 100644

[PATCH v3 7/9] s5p-jpeg: Prevent erroneous downscaling for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski JPEG codec on Exynos3250 SoC produces broken raw image if a JPEG image is decoded to YUV420 format and downscaled by a factor greater than 2. Prevent this by asserting downscale ratio to 2. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers

[PATCH v3 6/9] s5p-jpeg: Assure proper crop rectangle initialization

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Assure proper crop_rect initialization in case the user space doesn't call S_SELECTION ioctl. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++ 1 file changed, 15 inser

[PATCH v3 9/9] ARM: dts: exynos3250: add JPEG codec device node

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski Cc: Kukjin Kim Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos3250.dtsi |9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 3e678fa

[PATCH v3 0/9] Support for Exynos3250 SoC in the s5p-jpeg driver

2014-07-25 Thread Sylwester Nawrocki
This patch series adds support for the JPEG codec IP found on the Exynos3250 SoCs. Supported raw formats are: YUYV, YVYU, UYVY, VYUY, RGB565, RGB565X, RGB32, NV12, NV21. Support for the hardware scaling and cropping features is added. Changes since v2 (only patches 1/9, 2/9, 9/9): - the IP functi

[PATCH v3 1/9] [media] s5p-jpeg: Document sclk-jpeg clock for Exynos3250 SoC

2014-07-25 Thread Sylwester Nawrocki
From: Jacek Anaszewski JPEG IP on Exynos3250 SoC requires enabling two clock gates for its operation. This patch documents this requirement. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala

Re: [PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-14 Thread Sylwester Nawrocki
On 11/07/14 14:00, Tushar Behera wrote: > @@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct > platform_device *pdev) > return PTR_ERR(reg_base); > } > > - clk_table = devm_kzalloc(&pdev->dev, > - sizeof(struct clk *) * EXYNOS_AUDSS

[PATCH] ARM: dts: Add sound nodes for Odroid-X2/U3 boards

2014-07-14 Thread Sylwester Nawrocki
Add MAX98090 audio codec, I2S interface and the sound complex nodes to enable audio on Odroid-X2/U3 boards. Signed-off-by: Sylwester Nawrocki --- This patch depends on the series from Marek [1] adding dt sources for Odroid X2/U3. My testing branch can be pulled from [2]. [1] http

Re: [PATCH V2 1/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-07-14 Thread Sylwester Nawrocki
On 30/06/14 20:46, Mark Brown wrote: > On Wed, Jun 18, 2014 at 06:22:30PM +0200, Sylwester Nawrocki wrote: > >> +struct odroidx2_drv_data odroidx2_drvdata = { >> +.dapm_widgets = odroidx2_dapm_widgets, >> +.num_dapm_widgets = ARRAY_SI

Re: [PATCH 9/9] ARM: dts: exynos3250: add JPEG codec device node

2014-07-11 Thread Sylwester Nawrocki
On 07/07/14 18:32, Jacek Anaszewski wrote: > Signed-off-by: Jacek Anaszewski > Signed-off-by: Kyungmin Park > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: devicet...@vger.kernel.org > --- > arch/arm/boot/dts/exynos3250.dtsi | 12 +++

Re: [PATCH 1/9] s5p-jpeg: Add support for Exynos3250 SoC

2014-07-11 Thread Sylwester Nawrocki
On 07/07/14 18:32, Jacek Anaszewski wrote: > +void exynos3250_jpeg_dec_scaling_ratio(void __iomem *regs, > + unsigned int sratio) > +{ > + switch (sratio) { > + case 1: > + sratio = EXYNOS3250_DEC_SCALE_FACTOR_8_8; > + brea

Re: [PATCH 8/9] Documentation: devicetree: Document sclk-jpeg clock for exynos3250 SoC

2014-07-11 Thread Sylwester Nawrocki
On 07/07/14 18:32, Jacek Anaszewski wrote: > JPEG IP on Exynos3250 SoC requires enabling two clock > gates for its operation. This patch documents this > requirement. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Kyungmin Park > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc:

Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework

2014-07-11 Thread Sylwester Nawrocki
roviders are probed in of_clk_init() is not guaranteed. Since deferred probing is not supported in of_clk_init() and the AudioSS block is not the core controller, we can initialize it later as a platform device. Signed-off-by: Andrew Bresticker Acked-by: Tomasz Figa Revie

Re: [alsa-devel] [PATCH V3 2/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-07-10 Thread Sylwester Nawrocki
Hi Daniel, On 08/07/14 11:15, Daniel Drake wrote: > Testing on ODROID-U2, v3 is not quite working for me, but v2 of the > patch was fine. > I boot up, run: > # speaker-test -c 2 -t wav > > As soon as I hear the word "front" I press ctrl+c and then run the > command again. > Now the command hangs

[PATCH] ASoC: samsung-i2s: Maintain CDCLK settings across i2s_{shutdown/startup}

2014-07-10 Thread Sylwester Nawrocki
ently configured into input mode. I.e. the output clock will always stay disabled. Fix that by saving the CDCLKCON bit state in i2s_shutdown() and and restoring it in the i2s_startup() callback. Signed-off-by: Chen Zhen Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/i2s.c | 13 +++

Re: [alsa-devel] [PATCH V3 2/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-07-09 Thread Sylwester Nawrocki
Hi, On 08/07/14 11:15, Daniel Drake wrote: > On Fri, Jul 4, 2014 at 2:13 PM, Sylwester Nawrocki > wrote: >> This patch adds the sound subsystem driver for Odroid-X2 and >> Odroid-U3 boards. The codec works in I2S master mode; there >> are two separate audio routing pat

[PATCH] ASoC: samsung: Correct I2S DAI suspend/resume ops

2014-07-04 Thread Sylwester Nawrocki
off-by: Sylwester Nawrocki --- sound/soc/samsung/i2s.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 2ac76fa..5f9b255 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -920,11 +92

[PATCH V3 2/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-07-04 Thread Sylwester Nawrocki
. Signed-off-by: Chen Zhen Signed-off-by: Sylwester Nawrocki --- Changes since v2: - clock settings moved to late_probe, odroidx2_ops removed; - added missing driver.pm ops initialization; - minor cleanups. --- sound/soc/samsung/Kconfig |8 ++ sound/soc/samsung/Makefile

[PATCH V3 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings

2014-07-04 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki --- Changes since v2: - none. --- .../bindings/sound/samsung,odroidx2-max98090.txt | 35 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt diff --git a

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-07-04 Thread Sylwester Nawrocki
On 04/07/14 13:10, Lars-Peter Clausen wrote: > On 07/04/2014 01:04 PM, Sylwester Nawrocki wrote: >> On 22/05/14 20:53, Mark Brown wrote: >>>> + ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S >>>>> +

Re: [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-07-04 Thread Sylwester Nawrocki
On 22/05/14 20:53, Mark Brown wrote: >> +ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S >> > + | SND_SOC_DAIFMT_NB_NF >> > + | SND_SOC_DAIFMT_CBM_CFM); >> > + if (ret < 0) >> > + return ret; >> > + >> > + ret

Re: ABBA deadlock in Common Clock Framework

2014-07-02 Thread Sylwester Nawrocki
On 02/07/14 13:49, Peter De Schrijver wrote: > Or if you use notifiers which use i2c... See also > http://comments.gmane.org/gmane.linux.kernel/1553699. One workaround is to > always leave the clock of the i2c controller in a prepared state. Keeping the clock always prepared might not be that bad,

Re: [PATCH 16/17] [media] exynos4-is: removes s5pc100 related fimc codes

2014-06-30 Thread Sylwester Nawrocki
: Sylwester Nawrocki Please let me know if you want me to drop this patch from the media tree. -- Regards, Sylwester > Signed-off-by: Kukjin Kim > Cc: Sylwester Nawrocki > Cc: Mauro Carvalho Chehab > --- > Documentation/video4linux/fimc.txt|2 +- > drivers/m

Re: [alsa-devel] [PATCH V2 1/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-06-26 Thread Sylwester Nawrocki
On 25/06/14 05:31, Tushar Behera wrote: > On 06/18/2014 09:52 PM, Sylwester Nawrocki wrote: >> This patch adds the sound subsystem driver for Odroid-X2 and >> Odroid-U3 boards. The codec works in I2S master mode; there are >> 2 separate audio routing paths defined as there

Re: [PATCH V2 0/2] Sound support for Exynos4412 Odroid X2, U3 board

2014-06-23 Thread Sylwester Nawrocki
On 23/06/14 18:32, Sylwester Nawrocki wrote: > On 23/06/14 11:40, Daniel Drake wrote: >> > I tested ODROID-U2's 3.5mm analog headphone jack output with: >> > >> > # speaker-test -c 2 -t wav -l 2 >> > >> > On my x86 laptop this command take

Re: [PATCH V2 0/2] Sound support for Exynos4412 Odroid X2, U3 board

2014-06-23 Thread Sylwester Nawrocki
On 23/06/14 11:40, Daniel Drake wrote: > I tested ODROID-U2's 3.5mm analog headphone jack output with: > > # speaker-test -c 2 -t wav -l 2 > > On my x86 laptop this command takes ~6 seconds and produces audible output: > "Front left, front right, front left, front right" > > When those words are

[PATCH V2 2/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings

2014-06-18 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki --- .../bindings/sound/samsung,odroidx2-max98090.txt | 35 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt diff --git a/Documentation/devicetree/bindings/sound

[PATCH V2 1/2] ASoC: samsung: Add machine driver for Odroid X2/U3

2014-06-18 Thread Sylwester Nawrocki
. Signed-off-by: Chen Zhen Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/Kconfig |8 ++ sound/soc/samsung/Makefile|2 + sound/soc/samsung/odroidx2_max98090.c | 191 + 3 files changed, 201 insertions(+) create mode 100644

[PATCH V2 0/2] Sound support for Exynos4412 Odroid X2, U3 board

2014-06-18 Thread Sylwester Nawrocki
: http://git.linuxtv.org/cgit.cgi/snawrocki/samsung.git/log/?h=v3.16-rc1-odroid-sound-clk I didn't use the simple-card since there is going to be added one more CPU interface using the secondary I2S and IDMA. Sylwester Nawrocki (2): ASoC: samsung: Add machine driver for Odroid X2/U3 do

[PATCH] clk: samsung: Register clk provider only after registering its all clocks

2014-06-18 Thread Sylwester Nawrocki
Ensure the clock provider is not registered until after all its related clocks were created and are ready to use. Currently there are races possible and any (of_)clk_get() call right after a clock provider's clk_init_cb callback call may fail. Signed-off-by: Sylwester Nawrocki --- NOTE: T

Re: [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4

2014-06-16 Thread Sylwester Nawrocki
On 16/06/14 13:43, Tushar Behera wrote: > On 06/09/2014 04:36 PM, Sylwester Nawrocki wrote: >> > On 09/06/14 12:44, Tushar Behera wrote: >>> >> IMHO, the clock entries belong here as the audss clock provider >>> >> essentially remains same for all Exyno

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Sylwester Nawrocki
On 10/06/14 22:32, Rob Herring wrote: > On Tue, Jun 10, 2014 at 1:09 PM, Doug Anderson wrote: >> Naveen / Sylwester, >> >> On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch >> wrote: Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ? After your change all DTBs us

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Sylwester Nawrocki
On 10/06/14 12:08, Naveen Krishna Chatradhi wrote: > Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be > defined under "controller-data" node under each slave node. > > &spi_x { > cs-gpios <>; > ... > slave_node { > > controller-data { >

Re: [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4

2014-06-09 Thread Sylwester Nawrocki
On 09/06/14 12:44, Tushar Behera wrote: > IMHO, the clock entries belong here as the audss clock provider > essentially remains same for all Exynos4 based systems. > > As for pin-control entry, I believe we can move them to respective SoC > dtsi files. > > Does that sound okay to you? I guess th

Re: [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4

2014-06-09 Thread Sylwester Nawrocki
Hi Tushar, On 07/06/14 11:30, Tushar Behera wrote: > I2S driver uses 3 clocks under different conditions. Added two > missing clocks. > > Additionally updated pin-control property for this node. > > Signed-off-by: Tushar Behera > --- > Based on next-20140606. > > Tested on Exynos4210-based Ori

Re: [PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings

2014-05-23 Thread Sylwester Nawrocki
On 22/05/14 20:46, Mark Brown wrote: > On Thu, May 22, 2014 at 01:55:07PM +0200, Sylwester Nawrocki wrote: > >> +sound { >> +compatible = "samsung,odroidx2-audio"; >> +samsung,i2s-controller = <&i2s0>; >

Re: [PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-05-23 Thread Sylwester Nawrocki
On 22/05/14 20:53, Mark Brown wrote: > On Thu, May 22, 2014 at 01:55:08PM +0200, Sylwester Nawrocki wrote: >> From: Chen Zhen >> >> This machine driver primary defines the audio path, the supported >> data formats and sample frequency. > > I guess it can't y

Re: [PATCH 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-22 Thread Sylwester Nawrocki
&clk_gate_ops, CLK_SET_RATE_PARENT >>>>> >>>> +| CLK_SET_RATE_NO_REPARENT); >>>> >>> >>>> >>> Would you please remove CLK_SET_RATE_NO_REPARENT flag from here? Let me >>>> &g

Re: [PATCH 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-22 Thread Sylwester Nawrocki
ARENT flag from here? Let me >>> know if you have reservations against this. >> >> The problem with clock reparenting is that there are certain parent >> clocks of CLKOUT, rate of which changes at runtime, e.g. clocks derived >> from APLL or bus clocks, which can b

[PATCH 2/2] ASoC: samsung: Add machine driver for odroidx2

2014-05-22 Thread Sylwester Nawrocki
. Signed-off-by: Chen Zhen [s.nawro...@samsung.com: coding style changes, fixed of_match table name] Signed-off-by: Sylwester Nawrocki --- The only bits missing for v3.16 for audio on the Odroid X2/U3 to work now seem to be only my clock defaults setting patches [1] and the related dts updates. [1

[PATCH 1/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings

2014-05-22 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki --- .../bindings/sound/samsung,odroidx2-max98090.txt | 32 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt diff --git a/Documentation/devicetree/bindings/sound

[PATCH] ASoC: max98090: Add NI/MI values for user pclk 19.2 MHz

2014-05-22 Thread Sylwester Nawrocki
: Chen Zhen [s.nawro...@samsung.com: edited the commit description] Signed-off-by: Sylwester Nawrocki --- sound/soc/codecs/max98090.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index f7b0b37..ea44471

[PATCH] ASoC: samsung: Handle errors when getting the op_clk clock

2014-05-22 Thread Sylwester Nawrocki
Ensure i2s->op_clk is not used when clk_get() for this clock fails. This prevents working with an incorrectly configured clock in some conditions. Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/i2s.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/

Re: [PATCH] ARM: dts: Add audio subsystem nodes to exynos4.dtsi

2014-05-21 Thread Sylwester Nawrocki
On 16/05/14 13:28, Sylwester Nawrocki wrote: > This patch adds the audio subsystem clock controller and the I2S > IP block nodes for Exynos4 SoC series. > > Signed-off-by: Sylwester Nawrocki Can this still be applied in the coming merge window ? Thanks, Sylwester > --- >

[PATCH] clk: exynos4: Improve handling of the xxti, xusbxti, fin_pll clocks

2014-05-21 Thread Sylwester Nawrocki
clock from a fixed rate clock to a proper read-only mux clock. Signed-off-by: Sylwester Nawrocki --- This patch superseeded my previous one: http://www.spinics.net/lists/arm-kernel/msg333211.html drivers/clk/samsung/clk-exynos4.c | 73 - drivers/clk/samsung

[PATCH] ARM: dts: exynos4: Remove custom fixed rate clock nodes

2014-05-20 Thread Sylwester Nawrocki
This patch specifies the XXTI and XUSBXTI clock sources as standard fixed rate clocks and removes the related Exynos custom clock nodes. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi | 14 +- arch/arm/boot/dts/exynos4210-origen.dts

[PATCH] clk: exynos4: Register custom fixed rate clocks conditionally

2014-05-20 Thread Sylwester Nawrocki
s" node removed. Signed-off-by: Sylwester Nawrocki --- drivers/clk/samsung/clk-exynos4.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c index 05fc93c..f0b8420 100644 --- a/dri

Re: [PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-20 Thread Sylwester Nawrocki
On 20/05/14 07:14, Tushar Behera wrote: > On 05/19/2014 11:00 PM, Sylwester Nawrocki wrote: >> This patch adds support for setting source clock of the "Core CLK" >> of the IIS Multi Audio Interface. >> >> Signed-off-by: Sylwester Nawrocki >> --- >&g

[PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-19 Thread Sylwester Nawrocki
This patch adds support for setting source clock of the "Core CLK" of the IIS Multi Audio Interface. Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/i2s.c |4 sound/soc/samsung/i2s.h |1 + 2 files changed, 5 insertions(+) diff --git a/sound/soc/samsung/i2s.c b

[PATCH] ARM: dts: Add audio subsystem nodes to exynos4.dtsi

2014-05-16 Thread Sylwester Nawrocki
This patch adds the audio subsystem clock controller and the I2S IP block nodes for Exynos4 SoC series. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/exynos4

<    1   2   3   4   5   6   7   8   9   10   >