Re: [PATCH v5 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-14 Thread Sylwester Nawrocki
Arun Kumar K Acked-by: Sylwester Nawrocki > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c |8 > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c |2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c > b/dri

Re: [PATCH v5 1/2] [media] v4l: Add source change event

2014-05-14 Thread Sylwester Nawrocki
a nice API enhancement. Acked-by: Sylwester Nawrocki > --- > Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 33 ++ > .../DocBook/media/v4l/vidioc-subscribe-event.xml | 20 +++ > drivers/media/v4l2-core/v4l2-event.c | 36 > ++

Re: [PATCH] phy: exynos-mipi-video: fix check on array index

2014-05-12 Thread Sylwester Nawrocki
Ténart Thanks for the fix, Acked-by: Sylwester Nawrocki > --- > drivers/phy/phy-exynos-mipi-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos-mipi-video.c > b/drivers/phy/phy-exynos-mipi-video.c > index 7f139326a642..f

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-09 Thread Sylwester Nawrocki
the driver. >> > >> > Ok, it makes more sense. >> > Just out of curiosity, what difference would this make ? > > Moreover, in case of Exynos5420 (and may be in future SoCs), where we > have 2 USB DRD PHY controllers, > we will need to have a way around to d

[PATCH V2 4/4] ARM: dts: exynos4: Remove simple-bus compatibles from the camera subsystem

2014-05-08 Thread Sylwester Nawrocki
The usage of "simple-bus" was incorrect and the drivers now will also work without it so remove it. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi|2 +- arch/arm/boot/dts/exynos4x12.dtsi |2 +- 2 files changed, 2 insert

Re: [PATCH 1/5] ARM: S5PV210: Remove camera support from mach-goni.c

2014-05-08 Thread Sylwester Nawrocki
On 02/05/14 08:07, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> > >> > S5PV210 is going to get DT support, so we can remove the camera >> > bits from the only board using camera on S5PV210. This allows to >> > clean the exynos4-is driver by dropping cod

Re: [PATCH v7 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-05-06 Thread Sylwester Nawrocki
On 28/04/14 08:17, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver and related code > use

Re: [PATCH 4/5] exynos4-is: Remove requirement for "simple-bus" compatible

2014-04-17 Thread Sylwester Nawrocki
(restoring the Cc list I cleared accidentally in previous reply) On 16/04/14 21:29, Rob Herring wrote: > On Wed, Apr 16, 2014 at 12:19 PM, Sylwester Nawrocki > wrote: >> On 16/04/14 17:34, Rob Herring wrote: >>> On Tue, Apr 15, 2014 at 12:34 PM, Sylwester Nawrocki >>

[PATCH 5/5] ARM: dts: exynos4: Remove simple-bus compatible from camera subsystem nodes

2014-04-15 Thread Sylwester Nawrocki
The usage of "simple-bus" was incorrect and the drivers now will also work without it so remove it. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi|2 +- arch/arm/boot/dts/exynos4x12.dtsi |2 +- 2 files changed, 2 insert

[PATCH 4/5] exynos4-is: Remove requirement for "simple-bus" compatible

2014-04-15 Thread Sylwester Nawrocki
This patch makes the driver instantiating its child devices itself, rather than relying on an OS to instantiate devices as children of "simple-bus". This removes an incorrect usage of "simple-bus" compatible. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park ---

[PATCH 3/5] exynos4-is: Remove support for non-dt platforms

2014-04-15 Thread Sylwester Nawrocki
All platforms supported by this driver are going to get device tree support in this kernel release so remove code that would have been actually not used any more. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Documentation/video4linux/fimc.txt | 30

[PATCH 2/5] exynos4-is: Fix compilation for !CONFIG_COMMON_CLK

2014-04-15 Thread Sylwester Nawrocki
CONFIG_COMMON_CLK is not enabled on S5PV210 platform, so include some clk API data structures conditionally to avoid compilation errors. These #ifdefs will be removed for next kernel release, when the S5PV210 platform moves to DT and the common clk API. Signed-off-by: Sylwester Nawrocki Acked-by

[PATCH 0/5] Exynos4 SoC camera subsystem driver cleanups

2014-04-15 Thread Sylwester Nawrocki
This patch series removes support for non-dt platforms from the Exynos4/S5P SoC camera interface drivers and removes (ab)use of "simple-bus" compatible string. Sylwester Nawrocki (5): ARM: S5PV210: Remove camera support from mach-goni.c exynos4-is: Fix compilation for !CONFIG_

[PATCH 1/5] ARM: S5PV210: Remove camera support from mach-goni.c

2014-04-15 Thread Sylwester Nawrocki
: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/mach-s5pv210/mach-goni.c | 51 - 1 file changed, 51 deletions(-) diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c index b41a38a..6c719ec 100644 --- a/arch/arm/mach

[PATCH] exynos4-is: Fix compilation for !CONFIG_COMMON_CLK

2014-04-15 Thread Sylwester Nawrocki
CONFIG_COMMON_CLK is not enabled on S5PV210 platform, so include some clk API data structures conditionally to avoid compilation errors. These #ifdefs will be removed for next kernel release, when the S5PV210 platform moves to DT and the common clk API. Signed-off-by: Sylwester Nawrocki Acked-by

[PATCH] clk: exynos4: Use single clock ID for CLK_MDMA gate clocks

2014-04-15 Thread Sylwester Nawrocki
driver. This ensures PL330 MDMA has correct clock assigned on Exynos4x12 SoCs. Suggested-by: Tomasz Figa Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- drivers/clk/samsung/clk-exynos4.c |2 +- include/dt-bindings/clock/exynos4.h |1 - 2 files changed, 1 insertion(+), 2

Re: [RFC PATCH 12/14] ARM: dts: exynos5: add system register support

2014-04-15 Thread Sylwester Nawrocki
On 15/04/14 10:41, Sachin Kamat wrote: > On 15 April 2014 11:17, YoungJun Cho wrote: >> This patch adds sysreg device node, and sysreg property to fimd device node >> which is required to use I80 interface. >> >> Signed-off-by: YoungJun Cho >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungmin P

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 08/04/14 16:36, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt > b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 28f9edb..6d99ba9 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindi

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 14/04/14 15:49, Vivek Gautam wrote: > True, we don't have a scope of instantiating this driver using old > platform device and > old legacy board files. > So we don't need this check then, right ? I think it can be dropped. At least IMHO there is no point to increase size of the module with an

[PATCH] ARM: dts: exynos4: Update camera nodes for Trats2 board

2014-04-11 Thread Sylwester Nawrocki
: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi |6 ++ arch/arm/boot/dts/exynos4412-trats2.dts |5 +++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 2f8bcd0

[PATCH] ARM: dts: Add rear camera nodes for Exynos4412 Trats2 board

2014-04-11 Thread Sylwester Nawrocki
This patch enables the rear facing camera (s5c73m3) on TRATS2 board by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver and the sensor's voltage regulator supply nodes. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Signed-off-by: Sylwester Nawrocki --- arch/arm

[PATCH] ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12

2014-04-11 Thread Sylwester Nawrocki
Exynos4212/4412 has different clock for the PL330 MDMA, ensure the clock is properly assigned for these newer SoCs. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4x12.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts

Re: [PATCH] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-11 Thread Sylwester Nawrocki
Hi Chanwoo, On 11/04/14 04:00, Chanwoo Choi wrote: > This patch control special clock for ADC in Exynos series's FSYS block. > If special clock of ADC is registerd on clock list of common clk framework, > Exynos ADC drvier have to control this clock. > > Exynos3250/Exynos4/Exynos5 has 'adc' clock

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
On 09/04/14 14:24, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki > wrote: >> > On 09/04/14 13:54, Vivek Gautam wrote: >>> >> Adding support to enable/disable VBUS hooked to a gpio >>> >> to enable vbus supply on the port. &g

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
Hi Vivek, On 09/04/14 13:54, Vivek Gautam wrote: > Adding support to enable/disable VBUS hooked to a gpio > to enable vbus supply on the port. Does the GPIO control a fixed voltage regulator ? If so, shouldn't it be modelled by the regulator API instead ? > Signed-off-by: Vivek Gautam [...] > +

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Sylwester Nawrocki
Hi, On 09/04/14 11:12, Rahul Sharma wrote: > Idea looks good. How about keeping compatible which is independent > of SoC, something like "samsung,exynos-simple-phy" and provide Reg > and Bit through phy provider node. This way we can avoid SoC specific > hardcoding in phy driver and don't need to

Re: [PATCH 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-03 Thread Sylwester Nawrocki
On 02/04/14 14:15, Michal Simek wrote: >> There were some patches posted for syscon to make it available in earlier >> system initialization stage: https://lkml.org/lkml/2014/2/19/218 > > I haven't finished this yet. I have to look at it again. Thanks for the information, I assume this would be al

Re: [PATCH 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-02 Thread Sylwester Nawrocki
On 02/04/14 09:50, Pankaj Dubey wrote: > From: Young-Gun Jang > > Add support for mapping Exynos Power Management Unit (PMU) base address > from device tree. Code will use existing samsung pmu binding information. > This patch also adds "get_exynos_pmubase" a helper function to return mapped > b

Re: [PATCH 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file

2014-04-02 Thread Sylwester Nawrocki
Hi, On 02/04/14 09:50, Pankaj Dubey wrote: > From: Young-Gun Jang > > While making PMU (Power Mengement Unit) implementation device tree based, > there are few offsets related with SYSREG present in regs-pmu.h, so let's > make a new header file "regs-sys.h" to keep all such SYSREG related > regi

Re: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Sylwester Nawrocki
Hi Laurent, On 19/03/14 12:59, Laurent Pinchart wrote: > On Wednesday 19 March 2014 12:55:21 Sylwester Nawrocki wrote: >> > On 19/03/14 12:31, Laurent Pinchart wrote: >>>> > >> +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >

Re: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Sylwester Nawrocki
Hi, On 19/03/14 12:31, Laurent Pinchart wrote: >> +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> > @@ -0,0 +1,24 @@ >> > +* Samsung Exynos5 SCALER device >> > + >> > +SCALER is used for scaling, blending, color fill and color space >> > +conversion on EXYNOS[5420/5410] SoCs. >

Re: [PATCH v6 05/10] V4L: s5c73m3: Add device tree support

2014-03-18 Thread Sylwester Nawrocki
On 18/03/14 11:05, Arnd Bergmann wrote: > On Thursday 06 March 2014, Sylwester Nawrocki wrote: >> This patch adds the V4L2 asynchronous subdev registration and >> device tree support. Common clock API is used to control the >> sensor master clock from within the subdev

Re: [PATCH] clk: exynos4: Add clock ID for ppmuleft/right

2014-03-12 Thread Sylwester Nawrocki
Hi Chanwoo, On 12/03/14 08:08, Chanwoo Choi wrote: > There is no gate for the PPMU Left/Right to the LEFT/RIGHTBUS block. > So, this patch add ppmuleft/right clock which is used to calculate memory bus > utilization by using PPMU(Performance Profiling Monitoring Unit). > > Signed-off-by: Chanwoo

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, Thanks for your review. On 11/03/14 13:30, Laurent Pinchart wrote: [...] >> --- >> .../devicetree/bindings/media/samsung-fimc.txt | 34 - >> 1 file changed, 26 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.

Re: [PATCH v6 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-03-07 Thread Sylwester Nawrocki
Hi Kukjin, On 06/03/14 17:20, Sylwester Nawrocki wrote: > This patch enables the rear facing camera (s5c73m3) on TRATS2 board > by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver > and the sensor's voltage regulator supply nodes. > > Signed-off-by: Andrz

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Sylwester Nawrocki
Hi, On 07/03/14 09:31, Arun Kumar K wrote: > From: avnd kiran > > Latest MFC v6 firmware requires tile mode and loop filter > setting to be done as part of Init buffer command, in sync > with v7. So, move these settings out of decode options reg. > Also, make this register definition applicable

Re: [PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor

2014-03-06 Thread Sylwester Nawrocki
Hi Phillip, On 03/06/2014 07:08 PM, Philipp Zabel wrote: +++ b/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt > @@ -0,0 +1,33 @@ > +Samsung S5K6A3(YX) raw image sensor > +- > + > +S5K6A3(YX) is a raw image sensor with MIPI CSI-2 and CCP2 image dat

[PATCH v6 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-03-06 Thread Sylwester Nawrocki
This patch enables the rear facing camera (s5c73m3) on TRATS2 board by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver and the sensor's voltage regulator supply nodes. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Signed-off-by: Sylwester Nawrocki --- Changes

[PATCH v6 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-03-06 Thread Sylwester Nawrocki
This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v5: - added a missing check if clocks provider is registered, in order to prevent

[PATCH v6 08/10] exynos4-is: Add support for asynchronous subdevices registration

2014-03-06 Thread Sylwester Nawrocki
Add support for registering external sensor subdevs using v4l2-async API. The async API is used only for sensor subdevs and only for booting from DT. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v5: - removed erroneous introduction of a redundant

[PATCH v6 10/10] ARM: dts: exynos4: Update camera clk provider and s5k6a3 sensor node

2014-03-06 Thread Sylwester Nawrocki
Remove unused /camera/clock-controller node and required clock properties to the camera node. This is required for a clock provider that will be referenced by image sensor devices. Also add required clock related changes to s5k6a3 device node and afvdd regulator supply. Signed-off-by: Sylwester

[PATCH v6 05/10] V4L: s5c73m3: Add device tree support

2014-03-06 Thread Sylwester Nawrocki
This patch adds the V4L2 asynchronous subdev registration and device tree support. Common clock API is used to control the sensor master clock from within the subdev. Signed-off-by: Andrzej Hajda Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v5: - none. Changes

[PATCH v6 04/10] V4L: Add driver for s5k6a3 image sensor

2014-03-06 Thread Sylwester Nawrocki
mware. This driver, if needed, can be updated in future into a regular subdev driver where the main CPU communicates with the sensor directly. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v5: - added missing sd->internal_ops assignment (addressing comments fro

[PATCH v6 02/10] Documentation: dt: Add binding documentation for S5C73M3 camera

2014-03-06 Thread Sylwester Nawrocki
This adds DT binding documentation for Samsung S5C73M3 camera sensor with an embedded ISP. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v5: - none. Changes since v4: - added missing unit-address at the example SPI device node; Changes

[PATCH v6 06/10] exynos4-is: Use external s5k6a3 sensor driver

2014-03-06 Thread Sylwester Nawrocki
e and retrieved from the internal table, which is selected based on the compatible property of an image sensor. To use the Exynos4x12 internal ISP the S5K6A3 sensor driver (drivers/ media/i2c/s5k6a3.c) is now required. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes sin

[PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-06 Thread Sylwester Nawrocki
frequency value can often be used. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v5: - none. Changes since v4: - dropped a requirement of specific order of values in clocks/ clock-names properties (Mark) and reference to clock-names in clock-output-name

[PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor

2014-03-06 Thread Sylwester Nawrocki
This patch adds binding documentation for the Samsung S5K6A3(YX) raw image sensor. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v5: - none. Changes since v2: - rephrased 'clocks' and 'clock-names' pro

[PATCH v6 00/10] Add device tree support for Exynos4 camera interface

2014-03-06 Thread Sylwester Nawrocki
, detailed description can be found in patches 7/10, 8/10. I'd like to ask for a DT binding maintainer review/Ack of patch 3/10. I'm going to push this series to the media tree on beginning of next week. Thanks, Sylwester Sylwester Nawrocki (10): Documentation: dt: Add binding documen

Re: [REGRESSION] Arndale Octa panics when booting 3.14-rc1

2014-03-04 Thread Sylwester Nawrocki
On 04/03/14 11:16, Javi Merino wrote: > Yes, with [1] applied I don't get a kernel panic but the kernel fails > to boot later on with an Imprecise external abort. Removing the mdma > nodes from the dts gets rid of that. I guess what's missing is what > you said: clocks for the mdma devices. Is r

Re: [REGRESSION] Arndale Octa panics when booting 3.14-rc1

2014-03-03 Thread Sylwester Nawrocki
Hi, On 03/03/2014 08:04 PM, Tomasz Figa wrote: On 03.03.2014 19:57, Javi Merino wrote: Hi, Commit fcb0ee6a3d (clk: Implement clk_unregister) added calls to kref_get() and kref_put() to __clk_get() and __clk_put() without checking if clk is not NULL: @@ -1987,6 +2097,7 @@ int __clk_get(struct

Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-25 Thread Sylwester Nawrocki
On 25/02/14 10:55, Baruch Siach wrote: > Thanks for the explanation. However, I've found no reference to the > s5k6a3_sd_internal_ops struct in the driver code. There surly has to be at > least one reference for the upper layer to access these ops. There is indeed an assignment missing to sd->in

Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-25 Thread Sylwester Nawrocki
Hi Baruch, On 24/02/14 20:38, Baruch Siach wrote: > On Mon, Feb 24, 2014 at 06:35:16PM +0100, Sylwester Nawrocki wrote: >> > This patch adds subdev driver for Samsung S5K6A3 raw image sensor. >> > As it is intended at the moment to be used only with the Exynos >> >

[PATCH v5 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-02-24 Thread Sylwester Nawrocki
This patch enables the rear facing camera (s5c73m3) on TRATS2 board by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver and the sensor's voltage regulator supply nodes. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Signed-off-by: Sylwester Nawrocki --- Changes

[PATCH v5 05/10] V4L: s5c73m3: Add device tree support

2014-02-24 Thread Sylwester Nawrocki
This patch adds the V4L2 asynchronous subdev registration and device tree support. Common clock API is used to control the sensor master clock from within the subdev. Signed-off-by: Andrzej Hajda Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v4: - none. Changes

[PATCH v5 08/10] exynos4-is: Add support for asynchronous subdevices registration

2014-02-24 Thread Sylwester Nawrocki
Add support for registering external sensor subdevs using v4l2-async API. The async API is used only for sensor subdevs and only for booting from DT. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v4: - call v4l2_async_notifier_register() only if any camera sensor

[PATCH v5 10/10] ARM: dts: exynos4: Update camera clk provider and s5k6a3 sensor node

2014-02-24 Thread Sylwester Nawrocki
Remove unused /camera/clock-controller node and required clock properties to the camera node. This is required for a clock provider that will be referenced by image sensor devices. Also add required clock related changes to s5k6a3 device node and afvdd regulator supply. Signed-off-by: Sylwester

[PATCH v5 02/10] Documentation: dt: Add binding documentation for S5C73M3 camera

2014-02-24 Thread Sylwester Nawrocki
This adds DT binding documentation for Samsung S5C73M3 camera sensor with an embedded ISP. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v4: - added missing unit-address at the example SPI device node; Changes since v3: - DT binding

[PATCH v5 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor

2014-02-24 Thread Sylwester Nawrocki
This patch adds binding documentation for the Samsung S5K6A3(YX) raw image sensor. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v4: - none. Changes since v2: - rephrased 'clocks' and 'clock-names' pro

[PATCH v5 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-24 Thread Sylwester Nawrocki
frequency value can ofen be used. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v4: - dropped a requirement of specific order of values in clocks/ clock-names properties (Mark) and reference to clock-names in clock-output-names property descrip

[PATCH v5 06/10] exynos4-is: Use external s5k6a3 sensor driver

2014-02-24 Thread Sylwester Nawrocki
e and retrieved from the internal table, which is selected based on the compatible property of an image sensor. To use the Exynos4x12 internal ISP the S5K6A3 sensor driver (drivers/ media/i2c/s5k6a3.c) is now required. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes sin

[PATCH v5 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-24 Thread Sylwester Nawrocki
This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v4: - retrieve clk parent name through __clk_get_name() on the input clock instead of

[PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-24 Thread Sylwester Nawrocki
mware. This driver, if needed, can be updated in future into a regular subdev driver where the main CPU communicates with the sensor directly. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v4: - none. Changes since v3: - clk_get() called moved from s_power() to d

[PATCH v5 00/10] Add device tree support for Exynos4 camera interface

2014-02-24 Thread Sylwester Nawrocki
changes to the clock provider DT binding. My test branch can be found at: http://git.linuxtv.org/snawrocki/samsung.git/v3.14-rc2-trats2-camera-v5 Sylwester Nawrocki (10): Documentation: dt: Add binding documentation for S5K6A3 image sensor Documentation: dt: Add binding documentation for S5C73M3

Re: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-22 Thread Sylwester Nawrocki
On 02/22/2014 11:26 PM, Tomasz Figa wrote: [Ccing Mike] On 22.02.2014 23:02, Sylwester Nawrocki wrote: On 02/21/2014 04:50 PM, Mark Rutland wrote: On Thu, Feb 20, 2014 at 07:40:30PM +, Sylwester Nawrocki wrote: +- #clock-cells: from the common clock bindings (../clock/clock-bindings.txt

Re: [PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-22 Thread Sylwester Nawrocki
On 02/21/2014 05:05 PM, Mark Rutland wrote: --- drivers/media/platform/exynos4-is/media-dev.c | 110 + drivers/media/platform/exynos4-is/media-dev.h | 19 - 2 files changed, 128 insertions(+), 1 deletion(-) ... +static int fimc_md_register_clk_provider(struc

Re: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-22 Thread Sylwester Nawrocki
On 02/21/2014 04:50 PM, Mark Rutland wrote: On Thu, Feb 20, 2014 at 07:40:30PM +, Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells

Re: [PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera

2014-02-21 Thread Sylwester Nawrocki
On 21/02/14 16:42, Mark Rutland wrote: [...] >> +++ b/Documentation/devicetree/bindings/media/samsung-s5c73m3.txt >> @@ -0,0 +1,97 @@ >> +Samsung S5C73M3 8Mp camera ISP >> +-- >> + >> +The S5C73M3 camera ISP supports MIPI CSI-2 and parallel (ITU-R BT.656) video >> +data

Re: [PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
On 21/02/14 17:41, Arnd Bergmann wrote: > On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote: >> > >> > Hmm, good point, I will modify it that way. >> > >> > For patch 1/2 I guess it should be: >> > >> > "default ARCH_S5PV

[PATCH v3 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
Instead of requiring user to figure out when PHY_EXYNOS_DP_VIDEO needs to be selected select it by default for Exynos SoCs. Also enable it when COMPILE_TEST is selected. If required the display port PHY driver can be then disabled or compiled in as module. Cc: Jingoo Han Signed-off-by: Sylwester

[PATCH v3 1/2] phy: Select PHY_EXYNOS_MIPI_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
Instead of requiring user to figure out when PHY_EXYNOS_MIPI_VIDEO needs to be selected select it by default for Exynos SoCs. Also enable it when COMPILE_TEST is selected. If required the MIPI CSIS/DPHY driver can be then disabled or compiled in as module. Signed-off-by: Sylwester Nawrocki Acked

Re: [PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
On 21/02/14 16:59, Arnd Bergmann wrote: > On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote: >> config PHY_EXYNOS_DP_VIDEO >> tristate "EXYNOS SoC series Display Port PHY driver" >> depends on OF >> + depends on ARCH_EXYNOS

[PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
Instead of requiring user to figure out when PHY_EXYNOS_DP_VIDEO needs to be selected select it by default for Exynos SoCs. Also enable it when COMPILE_TEST is selected. If required the display port PHY driver can be then disabled or compiled in as module. Cc: Jingoo Han Signed-off-by: Sylwester

[PATCH v2 1/2] phy: Select PHY_EXYNOS_MIPI_VIDEO by default for ARCH_EXYNOS

2014-02-21 Thread Sylwester Nawrocki
Instead of requiring user to figure out when PHY_EXYNOS_MIPI_VIDEO needs to be selected select it by default for Exynos SoCs. Also enable it when COMPILE_TEST is selected. If required the MIPI CSIS/DPHY driver can be then disabled or compiled in as module. Signed-off-by: Sylwester Nawrocki Acked

[PATCH v4 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-20 Thread Sylwester Nawrocki
mware. This driver, if needed, can be updated in future into a regular subdev driver where the main CPU communicates with the sensor directly. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - clk_get() called moved from s_power() to driver probe() callback. Ch

[PATCH v4 08/10] exynos4-is: Add support for asynchronous subdevices registration

2014-02-20 Thread Sylwester Nawrocki
Add support for registering external sensor subdevs using v4l2-async API. The async API is used only for sensor subdevs and only for DT platforms. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 233

[PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-20 Thread Sylwester Nawrocki
This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - use clock-output-names DT property instead of hard coding names of registered

[PATCH v4 05/10] V4L: s5c73m3: Add device tree support

2014-02-20 Thread Sylwester Nawrocki
This patch adds the V4L2 asynchronous subdev registration and device tree support. Common clock API is used to control the sensor master clock from within the subdev. Signed-off-by: Andrzej Hajda Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - move clk_get

[PATCH v4 06/10] exynos4-is: Use external s5k6a3 sensor driver

2014-02-20 Thread Sylwester Nawrocki
e and retrieved from the internal table, which is selected based on the compatible property of an image sensor. To use the Exynos4x12 internal ISP the S5K6A3 sensor driver (drivers/ media/i2c/s5k6a3.c) is now required. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- drivers/media/pla

[PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera

2014-02-20 Thread Sylwester Nawrocki
This adds DT binding documentation for Samsung S5C73M3 camera sensor with an embedded ISP. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- Changes since v3: - DT binding documentation separated into this patch; Changes since v2: - rephrased 'clocks' and 'clock-na

[PATCH v4 01/10] Documentation: dt: Add DT binding documentation for S5K6A3 image sensor

2014-02-20 Thread Sylwester Nawrocki
This patch adds binding documentation for the Samsung S5K6A3(YX) raw image sensor. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park Acked-by: Mark Rutland --- Changes since v3: -none. Changes since v2: - rephrased 'clocks' and 'clock-names' pro

[PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-20 Thread Sylwester Nawrocki
far as in-kernel dts files are concerned. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- .../devicetree/bindings/media/samsung-fimc.txt | 36 +++- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/med

[PATCH v4 10/10] ARM: dts: exynos4: Update clk provider part of the camera subsystem

2014-02-20 Thread Sylwester Nawrocki
Remove unused /camera/clock-controller node and required clock properties to the camera node. This is required for a clock provider that will be referenced by image sensor devices. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi |6 ++ 1

[PATCH v4 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board

2014-02-20 Thread Sylwester Nawrocki
This patch enables the rear facing camera (s5c73m3) on TRATS2 board by adding the I2C0 bus controller, s5c73m3 sensor, MIPI CSI-2 receiver and the sensor's voltage regulator supply nodes. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4412-trats2.dts | 86 +++

[PATCH v4 00/10] Add device tree support for Exynos4 SoC camera subsystem

2014-02-20 Thread Sylwester Nawrocki
ainer reviewed patches 2/11, 3/11. With an Ack I could finally push these things upstream. Sylwester Nawrocki (10): Documentation: dt: Add DT binding documentation for S5K6A3 image sensor Documentation: dt: Add DT binding documentation for S5C73M3 camera Documentation: devicetree: Update Sa

[PATCH v4 00/10] Add device tree support for Exynos4 SoC camera subsystem

2014-02-20 Thread Sylwester Nawrocki
ainer reviewed patches 2/10, 3/10. With an Ack I could finally push these things upstream. Sylwester Nawrocki (10): Documentation: dt: Add DT binding documentation for S5K6A3 image sensor Documentation: dt: Add DT binding documentation for S5C73M3 camera Documentation: devicetree: Update Sa

Re: [PATCH] V4L: s5k6a3: Add DT binding documentation

2014-02-20 Thread Sylwester Nawrocki
On 19/02/14 18:47, Mark Rutland wrote: > On Tue, Feb 18, 2014 at 03:43:11PM +0000, Sylwester Nawrocki wrote: >> > On 22/12/13 22:27, Sylwester Nawrocki wrote: >>> > > This patch adds DT binding documentation for the Samsung S5K6A3(YX) >>> > > raw im

Re: [PATCH] V4L: s5k6a3: Add DT binding documentation

2014-02-18 Thread Sylwester Nawrocki
On 22/12/13 22:27, Sylwester Nawrocki wrote: > This patch adds DT binding documentation for the Samsung S5K6A3(YX) > raw image sensor. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > This patch adds missing documentation [1] for the "sa

Re: [PATCH] clk: Correct handling of NULL clk in __clk_{get, put}

2014-02-10 Thread Sylwester Nawrocki
On 30/01/14 05:50, Sachin Kamat wrote: > On 10 January 2014 15:34, Sylwester Nawrocki wrote: >> > On 08/01/14 05:44, Sachin Kamat wrote: >>> >> Hi Sylwester, >>> >> >>> >> On 7 January 2014 17:33, Sylwester Nawrocki >>> >&g

Re: [PATCH v2 0/9] Samsung PM consolidation part 1 (clocks)

2014-02-07 Thread Sylwester Nawrocki
- >> > drivers/clk/samsung/clk-exynos5440.c | 2 +- >> > drivers/clk/samsung/clk-s3c64xx.c| 79 +--- >> > drivers/clk/samsung/clk.c| 71 ++- >> > drivers/clk/samsung/clk.h| 14 ++- >> > 8

Re: [PATCH v2 2/9] clk: samsung: Provide common helpers for register save/restore

2014-02-07 Thread Sylwester Nawrocki
iven list of registers of clock controller. > > Signed-off-by: Tomasz Figa > Acked-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.o

Re: [PATCH v2 1/9] clk: exynos4: Remove remnants of non-DT support

2014-02-07 Thread Sylwester Nawrocki
On 06/02/14 19:16, Tomasz Figa wrote: > This patch simplifies a bit clock initialization code by removing > remnants of non-DT clock initialization, such as reg_base and xom values > passed in function parameters. > > Signed-off-by: Tomasz Figa > Acked-by: Kyungmin Park Revi

Re: [PATCH] clk: samsung: Initialize clock table with error pointers

2014-02-06 Thread Sylwester Nawrocki
). Signed-off-by: Tomasz Figa Acked-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Sylwester Nawrocki
On 23/01/14 18:41, Mark Rutland wrote: >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >>> > > index 93cddeb..2da5617 100644 >>> > > --- a/drivers/crypto/s5p-sss.c >>> > > +++ b/drivers/crypto/s5p-sss.c >>> > > @@ -22,6 +22,7 @@ >>> > > #include >>> > > #include >>> > > #i

Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-23 Thread Sylwester Nawrocki
Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: > Hello All, > > On 15 January 2014 14:47, Naveen Krishna Chatradhi > wrote: >> This patch set adds use of clk_prepare/clk_unprepare as >> required by generic clock framework. >> >> Signed-off-by: Naveen Krishna Chatradhi >> Reviewed-by: Tomasz Fi

Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support

2014-01-23 Thread Sylwester Nawrocki
Hi, (Adding missing devicetre ML list at CC.) On 15/01/14 10:14, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S.

Re: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-23 Thread Sylwester Nawrocki
Hi, On 23/01/14 11:11, Kamil Debski wrote: >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > index 4ff3b6c..a02e7b8 100644 >> > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c >> > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_e

Re: s3c-camif question

2014-01-13 Thread Sylwester Nawrocki
Hi Emad, (adding linux-media at Cc) On 01/13/2014 10:43 PM, Emad Hosseini Moghadam wrote: Dear Mr. Nawrocki, I am writing a driver for an image sensor, using i2c-s3c2410 and s3c-camif platforms,in order to initialize the registers of the image sensor. My cpu is s3c2440 . I have some questions

Re: [PATCH] clk: Correct handling of NULL clk in __clk_{get, put}

2014-01-10 Thread Sylwester Nawrocki
On 08/01/14 05:44, Sachin Kamat wrote: > Hi Sylwester, > > On 7 January 2014 17:33, Sylwester Nawrocki wrote: >> Ensure clk->kref is dereferenced only when clk is not NULL. >> >> Signed-off-by: Sylwester Nawrocki >> --- >> Hi Sachin, >> >> p

Re: Looking for example to use samsung jpeg v4l2 mem2mem driver

2014-01-08 Thread Sylwester Nawrocki
Hi, On 01/01/2014 12:39 AM, m silverstri wrote: Hi, I am looking for an example which uses samsung jpeg v4l2 mem2mem driver. For example the 'Exynos4 JPEG codec v4l2 driver' described here http://lwn.net/Articles/468547 I am new to linux v4l2 driver. I am looking for example to pass an input

[PATCH] exynos4-is: Compile runtime PM callbacks in conditionally

2014-01-07 Thread Sylwester Nawrocki
used drivers/media/platform/exynos4-is/fimc-core.c:1057:12: warning: ‘fimc_runtime_suspend’ defined but not used Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/fimc-core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/platform

<    1   2   3   4   5   6   7   8   9   10   >