Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 12:03 PM, Inki Dae wrote: > > Also looks good to me. But what if power domain was disabled without pm > > runtime? In this case, you must enable the power domain at machine code > or > > bootloader somewhere. This way would not only need some hard codes to > turn > >

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Sylwester Nawrocki
On 04/22/2013 11:56 AM, Tomasz Figa wrote: > On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: >> On 21 April 2013 20:13, Tomasz Figa wrote: >>> 3) after those two changes, all that remains is to fix compliance with >>> Common Clock Framework, in other words: >>> >>> s/clk_enable/clk_prepare

Re: [PATCH] cpufreq: exynos: allow disabling cpufreq drivers

2013-04-19 Thread Sylwester Nawrocki
On 04/19/2013 10:43 PM, Arnd Bergmann wrote: On Friday 19 April 2013, Sylwester Nawrocki wrote: It could also be working by chance on EXYNOS4, since the register definitions were not actually removed from the regs-clk.h header for those. That's most likely what happened. Ok. I think

Re: [PATCH] cpufreq: exynos: allow disabling cpufreq drivers

2013-04-19 Thread Sylwester Nawrocki
On 04/19/2013 08:59 PM, Arnd Bergmann wrote: Maybe you just didn't have CPUFREQ enabled? I also didn't notice this bug at first because it is turned off in the defconfigs. I certainly had it enabled. Since I remember I needed to turn it off temporarily after someone has introduced an incorrect

Re: [PATCH] cpufreq: exynos: allow disabling cpufreq drivers

2013-04-19 Thread Sylwester Nawrocki
el builds again with the cpufreq subsystem enabled > but ARM_EXYNOS_CPUFREQ disabled. I assume that this was the intention > behind this Kconfig symbol anyway. > > Signed-off-by: Arnd Bergmann > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Kukjin Ki

Re: [PATCH v3 00/10] ARM: exynos multiplatform series, part 1

2013-04-19 Thread Sylwester Nawrocki
> I've tested this on the Arndale board and am putting it into > the next/multiplatform branch now as a stepping stone for > part two, which will be a late branch at best, if we decide > to merge it in 3.10. I've reviewed this patch series and nothing concerning jumps. Please fe

Re: [PATCH 3/5] ARM: dts: Add clock entries to G2D node for exynos4210

2013-04-18 Thread Sylwester Nawrocki
On 04/18/2013 01:54 PM, Sachin Kamat wrote: >>> diff --git a/arch/arm/boot/dts/exynos4210.dtsi >>> b/arch/arm/boot/dts/exynos4210.dtsi >>> index 66e6b03..50ab9d4 100644 >>> --- a/arch/arm/boot/dts/exynos4210.dtsi >>> +++ b/arch/arm/boot/dts/exynos4210.dtsi >>> @@ -117,6 +117,8 @@ >>>

Re: [PATCH 3/5] ARM: dts: Add clock entries to G2D node for exynos4210

2013-04-18 Thread Sylwester Nawrocki
Hi Sachin, On 04/18/2013 01:15 PM, Sachin Kamat wrote: > Added clock entries to G2D node. > > Signed-off-by: Sachin Kamat > --- > arch/arm/boot/dts/exynos4210.dtsi |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi > b/arch/arm/boot/dts/exynos4210.

[PATCH v2 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-17 Thread Sylwester Nawrocki
from the device tree. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/Kconfig |2 +- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++--- drivers/gpu/drm/exynos/regs-fimc.h |7 +-- 3 files changed, 53

[PATCH v2 2/3] drm/exynos: Rework fimc clocks handling

2013-04-17 Thread Sylwester Nawrocki
ting up parent clocks on DT platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 167 +- 1 file changed, 97 insertions(+), 70 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/driv

[PATCH v2 1/3] drm/exynos: Remove redundant devm_kfree()

2013-04-17 Thread Sylwester Nawrocki
There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. Remove the redundant devm_kfree() calls from probe() and remove() callbacks. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/e

[PATCH v2 0/3] drm/exynos: Add device tree support for IPP driver

2013-04-17 Thread Sylwester Nawrocki
operation of the DRM FIMC and the camera ISP on Exynos4x12. Changes since v1: - removed devm_kfree() that got erroneously re-added in patch 2/3 during rebase. Thanks, Sylwester Sylwester Nawrocki (3): drm/exynos: Remove redundant devm_kfree() drm/exynos: Rework fimc clocks handling drm

Re: [PATCH 2/3] drm/exynos: Rework fimc clocks handling

2013-04-17 Thread Sylwester Nawrocki
On 04/17/2013 06:02 AM, Sachin Kamat wrote: > Hi Sylwester, > > On 16 April 2013 23:01, Sylwester Nawrocki wrote: >> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev) >> ret = exynos_drm_ippdrv_register(ippdrv); &

Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support

2013-04-16 Thread Sylwester Nawrocki
board Tested-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-16 Thread Sylwester Nawrocki
from the device tree. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/Kconfig |2 +- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 101 +++--- drivers/gpu/drm/exynos/regs-fimc.h |7 +-- 3 files changed, 53

[PATCH 2/3] drm/exynos: Rework fimc clocks handling

2013-04-16 Thread Sylwester Nawrocki
ting up parent clocks on DT platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 168 +- 1 file changed, 98 insertions(+), 70 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/driv

[PATCH 1/3] drm/exynos: Remove redundant devm_kfree()

2013-04-16 Thread Sylwester Nawrocki
There is no need for explicit calls of devm_kfree(), as the allocated memory will be freed during driver's detach. Remove the redundant devm_kfree() calls from probe() and remove() callbacks. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/gpu/drm/e

[PATCH 0/3] drm/exynos: Add device tree support for IPP driver

2013-04-16 Thread Sylwester Nawrocki
operation of the DRM FIMC and the camera ISP on Exynos4x12. Thanks, Sylwester Sylwester Nawrocki (3): drm/exynos: Remove redundant devm_kfree() drm/exynos: Rework fimc clocks handling drm/exynos: Add device tree support for fimc ipp driver drivers/gpu/drm/exynos/Kconfig |2

Re: [PATCH 1/7] clk: exynos: prepare for multiplatform

2013-04-15 Thread Sylwester Nawrocki
On 04/15/2013 10:35 AM, Arnd Bergmann wrote: > On Monday 15 April 2013, Thomas Abraham wrote: >> On 12 April 2013 19:33, Arnd Bergmann wrote: >>> The new common clock drivers for exynos are using compile >>> time constants and soc_is_exynos* macros to provide backwards >>> compatibility for pre-DT

Re: [PATCH v3] pinctrl: Add pinctrl-s3c24xx driver

2013-04-13 Thread Sylwester Nawrocki
keep the same 4 eints in the main interrupt controller and eintpend register and requiring ack operations to happen in both. This is solved by using different compatible properties for the wakeup eint node which set a property accordingly. Signed-off-by: Heiko Stuebner Reviewed-by: Sylwester

Re: [PATCH] ARM: S3C24XX: add devicetree support for smdk2416

2013-04-13 Thread Sylwester Nawrocki
. Reviewed-by: Sylwester Nawrocki --- This patch depends on the not yet merged s3c24xx pinctrl support and the samsung-time muliplatform support. arch/arm/boot/dts/Makefile |1 + arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 173 +++ arch/arm/boot/dts

Re: [PATCH 11/30] [media] exynos: remove unnecessary header inclusions

2013-04-11 Thread Sylwester Nawrocki
On 04/11/2013 02:13 AM, Mauro Carvalho Chehab wrote: > Em Thu, 11 Apr 2013 02:04:53 +0200 > Arnd Bergmann escreveu: > >> In multiplatform configurations, we cannot include headers >> provided by only the exynos platform. Fortunately a number >> of drivers that include those headers do not actuall

Re: [PATCH RESEND] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-10 Thread Sylwester Nawrocki
On 04/10/2013 02:59 PM, Arnd Bergmann wrote: > On Wednesday 10 April 2013, Sylwester Nawrocki wrote: >> On 04/10/2013 12:34 PM, Kukjin Kim wrote: >>> Kukjin Kim wrote: >>>> >>>> From: Kukjin Kim >>>> >>>> As we discussed in ma

[PATCH 6/7] exynos4-is: Remove meaningless test before bit setting

2013-04-10 Thread Sylwester Nawrocki
There is no need to check same bit before setting it, since we always end up with a bit set. Remove some of the tests and make set unconditional, in every place where all that needs to be done is just setting a bit. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers

[PATCH 7/7] exynos4-is: Disable debug trace by default in fimc-isp.c

2013-04-10 Thread Sylwester Nawrocki
Make sure the debug level is properly set initially so any debug information is not printed to the kernel log without explicitly enabling it. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-isp.c |2 +- 1 file changed, 1 insertion

[PATCH 5/7] exynos4-is: Rename the ISP chain configuration data structure

2013-04-10 Thread Sylwester Nawrocki
More appropriate names for the ISP chain data structure. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-param.c | 191 ++--- drivers/media/platform/exynos4-is/fimc-is-regs.c | 14 +- drivers/media/platform

[PATCH 4/7] exynos4-is: Improve the ISP chain parameter count calculation

2013-04-10 Thread Sylwester Nawrocki
Instead of incrementing p_region_num field each time we set a bit in the parameter mask calculate the number of bits set only when this information is needed. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-param.c | 86

[PATCH 3/7] exynos4-is: Make fimc-lite independent on struct fimc_sensor_info

2013-04-10 Thread Sylwester Nawrocki
-lite module in the exynos5-is driver, which should similarly store a pointer to struct fimc_source_info instance in the sensor's subdev host_data. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-capture.c |7 +- drivers/medi

[PATCH 2/7] exynos4-is: Make fimc-lite independent of the pipeline->subdevs array

2013-04-10 Thread Sylwester Nawrocki
Get the sensor subdev by walking media graph in both cases: when the device is used as a subdev only and through video node. This allows to not dereference the pipeline->subdevs[] array and makes the module more generic and easier to re-use in other media driver. Signed-off-by: Sylwester Nawro

[PATCH 1/7] exynos4-is: Move the subdev group ID definitions to public header

2013-04-10 Thread Sylwester Nawrocki
Move the sub-device group ID definitions to the driver's public header so they are available to other media drivers that need to share modules found in exynos4-is. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.h |

[PATCH 0/7] exynos4-is cleanups and improvements

2013-04-10 Thread Sylwester Nawrocki
This patch series includes some cleanups of the recently added FIMC-IS driver and prerequisite patches for the FIMC-LITE module to make it easier to reuse in the future exynos5-is driver. Sylwester Nawrocki (7): exynos4-is: Move the subdev group ID definitions to public header exynos4-is

Re: [PATCH RESEND] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-10 Thread Sylwester Nawrocki
On 04/10/2013 12:34 PM, Kukjin Kim wrote: > Kukjin Kim wrote: >> >> From: Kukjin Kim >> >> As we discussed in mailing list, non-DT for EXYNOS SoCs will not be >> supported from v3.10. This patch removes regarding files for non-DT >> including board files. >> >> Signed-off-by: Kukjin Kim It looks

Re: [PATCH] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-10 Thread Sylwester Nawrocki
s Vivek. Reviewed-by: Sylwester Nawrocki > --- > > The v1 of this patch is pretty old, but the change needs to be merged to > avoid getting those needless WARN_ON() dumps on console. > > Changes from v1: > - Not using clk_disable_unprepare() at the end of s3c_rtc_probe(), since &g

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 03:34 PM, Vivek Gautam wrote: >> Aah !! actually missed a similar patch from Thomas Abraham :( >> > doing the same as suggested by you. >> > Its available at: >> > http://patchwork.ozlabs.org/patch/188687/ > There's a change required in the above mentioned patch, so possibly > Thomas

Re: [GIT PULL 10/10] devel-samsung for v3.10

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 01:20 PM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: > > [...] > >>> Sylwester Nawrocki (2): >>> ARM: SAMSUNG: Export MIPI CSIS/DSIM PHY control functions >> >> This one was supposed to be a fix for 3.8-rc IIRC. But anyway the whole >

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 11:45 AM, Vivek Gautam wrote: > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework, to get rid of > WARN_ON on prepare_count. Hmm, do you think warnings like below are any better that WARN_ON() on wrong clock's pre

Re: [GIT PULL 10/10] devel-samsung for v3.10

2013-04-08 Thread Sylwester Nawrocki
suspend Sylwester Nawrocki (2): ARM: SAMSUNG: Export MIPI CSIS/DSIM PHY control functions This one was supposed to be a fix for 3.8-rc IIRC. But anyway the whole file this patch touches is going to be removed in 3.11. ARM: S3C24XX: Correct NR_IRQS definition for s3c2440 And this one is needed

[PATCH] ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

2013-04-08 Thread Sylwester Nawrocki
The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt storm and the system hang as soon as any external interrupt is requested. Signed-off-by: Sylwester Nawrocki

Re: [PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required

2013-04-08 Thread Sylwester Nawrocki
On 04/08/2013 01:00 PM, Russell King - ARM Linux wrote: > On Mon, Apr 08, 2013 at 12:27:34PM +0200, Sylwester Nawrocki wrote: >> On 04/08/2013 11:57 AM, Kukjin Kim wrote: [...] > > Sigh. This stuff looks rather screwed up now: > > $ grep -B1 'ENTRY.*do_suspend' ar

Re: [PATCH 1/3] clk: exynos: register audio subsystem clocks using common clock framework

2013-04-08 Thread Sylwester Nawrocki
Hi, On 04/06/2013 12:13 PM, Padma Venkat wrote: > On Fri, Apr 5, 2013 at 7:23 PM, Sylwester Nawrocki > wrote: >> On 04/05/2013 08:23 AM, Padmavathi Venna wrote: >>> Audio subsystem is introduced in exynos platforms. This has seperate >>> clock controller which ca

Re: [PATCH 0/3] clk: Exynos: Register audio subsytem clocks using common clk framework

2013-04-08 Thread Sylwester Nawrocki
Hi, On 04/06/2013 12:16 PM, Padma Venkat wrote: > On Fri, Apr 5, 2013 at 6:24 PM, Sylwester Nawrocki > wrote: >> >> From a brief look Exynos4 and Exynos5 Audio Subsystem CLKCON very similar. >> I've just found bit 2 of 0x0381_0008 register is not used on Exynos5250.

Re: [PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required

2013-04-08 Thread Sylwester Nawrocki
On 04/08/2013 11:57 AM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: [...] > Yes, right. The pm.c in plat-samsung should be built with > arch/arm/kernel/sleep.S and suspend.c. > > BTW it should be shown in alphabetical order and we don't need more > following in mach

Re: [PATCH] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

2013-04-07 Thread Sylwester Nawrocki
On 04/07/2013 10:35 PM, Heiko Stübner wrote: Am Sonntag, 7. April 2013, 22:22:50 schrieb Sylwester Nawrocki: [...] Thanks for testing the irq changes on another subarchitecture and fixing the glitch. And thanks for your effort in adding DT support for s3c24xx! I'm still debugging one

[PATCH] ARM: S3C24XX: Remove unused GPIO drive strength register definitions

2013-04-07 Thread Sylwester Nawrocki
There is currently no users of these definitions so remove them. Signed-off-by: Sylwester Nawrocki --- arch/arm/mach-s3c24xx/regs-dsc.h | 203 +- 1 files changed, 4 insertions(+), 199 deletions(-) diff --git a/arch/arm/mach-s3c24xx/regs-dsc.h b/arch/arm

[PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required

2013-04-07 Thread Sylwester Nawrocki
0, however this patch applies without conflicts only back to v3.7. Signed-off-by: Sylwester Nawrocki Cc: sta...@vger.kernel.org --- arch/arm/plat-samsung/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconf

[PATCH] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

2013-04-07 Thread Sylwester Nawrocki
selected, so the subintc IRQ domain gets properly registered. Cc: Heiko Stübner Signed-off-by: Tomasz Figa Signed-off-by: Sylwester Nawrocki --- arch/arm/mach-s3c24xx/include/mach/irqs.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c24xx/include/mach

[PATCH] clk: exynos4: export clocks required for fimc-is

2013-04-05 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/ kgene/linux-samsung.git for-next .../devicetree/bindings/clock/exynos4-clock.txt| 42 +--- drivers/clk/samsung/clk-exynos4.c | 20

Re: [PATCH 1/3] clk: exynos: register audio subsystem clocks using common clock framework

2013-04-05 Thread Sylwester Nawrocki
On 04/05/2013 08:23 AM, Padmavathi Venna wrote: > Audio subsystem is introduced in exynos platforms. This has seperate > clock controller which can control i2s0 and pcm0 clocks. This patch > registers the audio subsystem clocks with the common clock framework. > > Signed-off-by: Padmavathi Venna

Re: [PATCH 0/3] clk: Exynos: Register audio subsytem clocks using common clk framework

2013-04-05 Thread Sylwester Nawrocki
Hi Padmavathi, On 04/05/2013 08:40 AM, Padmavathi Venna wrote: > Samsung Exynos SoC has a separate subsystem for audio. This subsystem > has a internal clock controller which controls i2s0 and pcm0 clocks. > This patch series adds the Samsung Exynos SoC audio subsytem clock code > to the common cl

Re: [PATCH 2/2] ARM: dts: Update MFC documentation for clock entries

2013-04-04 Thread Sylwester Nawrocki
s property. Please note there is a white space before the first colon, that makes it really an important improvement... Please feel free to add my Reviewed-by: Sylwester Nawrocki with those issues addressed. >- samsung,mfc-r : Base address of the first memory bank used by MFC >

Re: [PATCH 1/2] ARM: dts: Add MFC clock entries for exynos4

2013-04-04 Thread Sylwester Nawrocki
On 04/04/2013 08:26 AM, Sachin Kamat wrote: > Added MFC related clock entries in exynos4.dtsi file. > > Signed-off-by: Sachin Kamat Reviewed-by: Sylwester Nawrocki > --- > Based on Kukjin's for-next. > Dependent on the below patch: > https://patchwork.kernel.org/pa

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-04-03 Thread Sylwester Nawrocki
Hi Arun, On 03/13/2013 05:09 AM, Arun Kumar K wrote: > Hi Sylwester, > >>> >>> /* Interrupt mask */ >>> #define S5PCSIS_INTMSK 0x10 >>> -#define S5PCSIS_INTMSK_EN_ALL0xf000103f >>> +#define S5PCSIS_INTMSK_EN_ALL0xfc00103f >> >> Do you know w

[PATCH v4 7/7] exynos4-is: Create media links for the FIMC-IS entities

2013-04-02 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 79 +++-- 1 file changed, 60 insertions

[PATCH v4 6/7] exynos4-is: Add fimc-is subdevs registration

2013-04-02 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki Signed-off-by

[PATCH v4 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree binding documentation

2013-04-02 Thread Sylwester Nawrocki
This patch adds DT binding documentaton for the Imaging Subsystem (camera ISP) found on Samsung Exynos4x12 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - specified order of the interrupts, - added a note about image sensor device nodes. Changes

[PATCH v4 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-04-02 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - dropped unused headers. --- drivers/media/platform/exynos4-is/Kconfig | 11 + drivers/media/platform/exynos4-is/Makefile |3 + drivers/media/platform/exynos4-is/fimc-is-senso

[PATCH v4 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-04-02 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - dropped unused headers, - removed get_is_cfg() macro which was temporary only. --- drivers/media/platform/exynos4

[PATCH v4 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-04-02 Thread Sylwester Nawrocki
S ARM CPU. The image sensor drivers can be standard I2C client driver, as in case of most existing image sensor driver. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - corrected I2C bus driver remove() function, - added missing EXPORT_SYMBOL() for the d

[PATCH v4 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-04-02 Thread Sylwester Nawrocki
e. And this is just a basic set of futures this patch series addresses. Others include input/output DMA support for the DRC and FD blocks, support for more ISP controls, etc. Full git tree with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2

[PATCH] exynos4-is: Correct clock properties description at the DT binding documentation

2013-04-02 Thread Sylwester Nawrocki
bus clock parent clock was being set by the driver. A better solution is needed to have e.g. clocks driver setting all required parent clocks, before clock consumers start using the clocks. Currently this binding doesn't describe the parent clocks setup, it needs to be specified and handled

[PATCH] exynos4-is: Remove dependency on SYSCON for non-dt platforms

2013-04-02 Thread Sylwester Nawrocki
. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/Kconfig |7 ++- drivers/media/platform/exynos4-is/fimc-core.c |3 +-- drivers/media/platform/exynos4-is/fimc-core.h | 10 ++ drivers/media/platform/exynos4-is/fimc-reg.c

Re: [PATCH 10/23] [media] exynos: remove unnecessary header inclusions

2013-04-02 Thread Sylwester Nawrocki
On 03/05/2013 06:42 PM, Arnd Bergmann wrote: > In multiplatform configurations, we cannot include headers > provided by only the exynos platform. Fortunately a number > of drivers that include those headers do not actually need > them, so we can just remove the inclusions. > > Signed-off-by: Arnd

Re: EXYNOS will support only DT from v3.10

2013-04-02 Thread Sylwester Nawrocki
On 03/25/2013 12:01 PM, Kukjin Kim wrote: > Hi all, > > As we discussed before, it's time to decide to support non-DT for EXYNOS > SoCs. > > If everybody else agrees to drop non-DT support from v3.10, I will. Feel > free to talk your opinion about that. I'm fine with supporting Exynos as dt-only

Re: [PATCH v10 2/3] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts

2013-04-01 Thread Sylwester Nawrocki
27;@0' part, since there is only one node. And if you decide to keep it, then this node should contain 'reg' property AFAICT. Otherwise the series looks good to me. With the above issue addressed feel free to add Reviewed-by: Sylwester Nawrocki +

[PATCH v3 7/7] exynos4-is: Create media links for the FIMC-IS entities

2013-03-29 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v2: - none. --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 79

[PATCH v3 6/7] exynos4-is: Add FIMC-IS subdevs registration

2013-03-29 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki Signed-off-by

[PATCH v3 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree binding documentation

2013-03-29 Thread Sylwester Nawrocki
This patch adds DT binding documentaton for the Imaging Subsystem (camera ISP) found on Samsung Exynos4x12 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v2: - added missing clocks at the binding documentation; - added clocks/clock-names properties to

[PATCH v3 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-03-29 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v2: - added delay needed for sensor initialization in s_power callback, this delay was actually moved from fimc-isp.c from sensor/IS initialization function (fimc_is_hw_initialize()) --- drivers/media/platform/

[PATCH v3 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-03-29 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v3: - fixed a few issues found with checkpatch.pl --- drivers/media/platform/exynos4-is/fimc-is-param.c | 971

[PATCH v3 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-03-29 Thread Sylwester Nawrocki
S ARM CPU. The image sensor driver can be a standard I2C client driver, as in case of most existing image sensors. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Changes since v2: - added ISP I2C bus controler gate clock handling and enabled runtime PM. --- drivers/

[PATCH v3 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-29 Thread Sylwester Nawrocki
for the DRC and FD blocks, support for more ISP controls, etc. Full git tree with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2 -- Sylwester Nawrocki (7): exynos4-is: Add Exynos4x12 FIMC-IS driver exynos4

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-28 Thread Sylwester Nawrocki
Hi Arun, On 03/28/2013 06:10 AM, Arun Kumar K wrote: On Wed, Mar 27, 2013 at 7:17 PM, Sylwester Nawrocki wrote: On 03/27/2013 05:31 AM, Arun Kumar K wrote: On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki wrote: On 03/26/2013 01:17 PM, Arun Kumar K wrote: [...] Only issue is with

Re: [PATCH] [media] s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

2013-03-27 Thread Sylwester Nawrocki
Such differences could be easily handled in the device tree. The DT binding documentation just needs to specify the meaning of each clock name. [1] http://www.spinics.net/lists/arm-kernel/msg233521.html Regards, -- Sylwester Nawrocki Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-27 Thread Sylwester Nawrocki
On 03/27/2013 05:31 AM, Arun Kumar K wrote: > On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki > wrote: >> On 03/26/2013 01:17 PM, Arun Kumar K wrote: [...] > Only issue is with the context sharing. > Right now you can see that the fimc-is context is shared between all >

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 01:17 PM, Arun Kumar K wrote: +Sensor sub-nodes: + +FIMC-IS IP supports custom built sensors to be controlled exclusively by +the FIMC-IS firmware. These sensor properties are to be defined here. [snip] Defining image sensor nodes in a standard way as ISP I2C bus controller node

Re: [PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 07:38 PM, Sylwester Nawrocki wrote: > This patch series includes YUV order handling fix for the FIMC > and FIMC-LITE, a fix for media entity ref_count issue, minor > refactoring and removal of some static data that will no longer > be needed since starting from 3.10 Exy

[PATCH v2 5/5] exynos4-is: Ensure proper media pipeline state on device close

2013-03-26 Thread Sylwester Nawrocki
: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-capture.c | 18 +- drivers/media/platform/exynos4-is/fimc-core.h|1 + drivers/media/platform/exynos4-is/fimc-lite.c| 18 ++ drivers/media/platform/exynos4-is/fimc

[PATCH v2 4/4] exynos4-is: Ensure proper media pipeline state on device close

2013-03-26 Thread Sylwester Nawrocki
: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-capture.c | 18 +- drivers/media/platform/exynos4-is/fimc-core.h|1 + drivers/media/platform/exynos4-is/fimc-lite.c| 18 ++ drivers/media/platform/exynos4-is/fimc

[PATCH v2 4/5] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
| CR Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-core.c | 16 drivers/media/platform/exynos4-is/fimc-reg.c |3 ++- drivers/media/platform/exynos4-is/fimc-reg.h | 16 3 files changed, 18

[PATCH v2 3/4] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
| CR Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-core.c | 16 drivers/media/platform/exynos4-is/fimc-reg.c |3 ++- drivers/media/platform/exynos4-is/fimc-reg.h | 16 3 files changed, 18

[PATCH v2 3/5] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
| Y | CB| Y YCRYCB | CB| Y | CR| Y CBYCRY | Y | CR| Y | CB CRYCBY | Y | CB| Y | CR Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-lite-reg.c |4 +- drivers/media/platform/exynos4-is

[PATCH v2 2/5] exynos4-is: Use common driver data for all FIMC-LITE IP instances

2013-03-26 Thread Sylwester Nawrocki
There is no need to use separate variant data structure for each FIMC-LITE IP instance. According to my knowledge there are no differences across them on Exynos4 as well as Exynos5 SoCs. Drop flite_variant data structure and use struct flite_drvdata instead. Signed-off-by: Sylwester Nawrocki

[PATCH v2 2/4] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
| Y | CB| Y YCRYCB | CB| Y | CR| Y CBYCRY | Y | CR| Y | CB CRYCBY | Y | CB| Y | CR Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-lite-reg.c |4 +- drivers/media/platform/exynos4-is

[PATCH v2 1/4] exynos4-is: Use common driver data for all FIMC-LITE IP instances

2013-03-26 Thread Sylwester Nawrocki
There is no need to use separate variant data structure for each FIMC-LITE IP instance. According to my knowledge there are no differences across them on Exynos4 as well as Exynos5 SoCs. Drop flite_variant data structure and use struct flite_drvdata instead. Signed-off-by: Sylwester Nawrocki

[PATCH v2 1/5] exynos4-is: Remove static driver data for Exynos4210 FIMC variants

2013-03-26 Thread Sylwester Nawrocki
All Exynos4210 based boards files using FIMC are going to be removed in 3.10 and corresponding device trees are to be used instead. The FIMC variant data will be parsed directly form the device tree for those SoCs as well. Hence now unused static data is removed. Signed-off-by: Sylwester Nawrocki

[PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
are available at: git://linuxtv.org/snawrocki/samsung.git exynos4-fimc-is-v2 Sylwester Nawrocki (5): exynos4-is: Remove static driver data for Exynos4210 FIMC variants exynos4-is: Use common driver data for all FIMC-LITE IP instances exynos4-is: Allow colorspace conversion at fimc-lite

[PATCH v2 6/7] s5p-fimc: Add fimc-is subdevs registration

2013-03-26 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki Signed-off-by

[PATCH v2 7/7] s5p-fimc: Create media links for the FIMC-IS entities

2013-03-26 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 83 +++-- 1 file changed, 64 insertions

[PATCH v2 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree bindings documentation

2013-03-26 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- .../devicetree/bindings/media/exynos4-fimc-is.txt | 45 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/exynos4-fimc-is.txt diff --git a/Documentation

[PATCH v2 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-03-26 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/Kconfig | 13 + drivers/media/platform/exynos4-is/Makefile |3 + drivers/media/platform/exynos4-is/fimc-is-sensor.c | 307 drivers/media/platform/exyno

[PATCH v2 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-03-26 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-param.c | 971 drivers/media/platform/exynos4-is/fimc-is-param.h | 1022

[PATCH v2 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-03-26 Thread Sylwester Nawrocki
S ARM CPU. The image sensor drivers can be standard I2C client driver, as in case of most existing image sensor driver. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/fimc-is-i2c.c | 81 +++ drivers/media/platform/exyno

[PATCH v2 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-26 Thread Sylwester Nawrocki
tp://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2 Sylwester Nawrocki (7): exynos4-is: Add Exynos4x12 FIMC-IS driver exynos4-is: Add FIMC-IS ISP I2C bus driver exynos4-is: Add FIMC-IS parameter region definitions exynos4-is: Add common FIMC-IS image sensor driver exynos4-is: Add

[PATCH v2 03/10] s5p-fimc: Update graph traversal for entities with multiple source pads

2013-03-26 Thread Sylwester Nawrocki
roper handling of FIMC, FIMC-LITE and FIMC-IS-ISP subdevs that have more than one sink and one source pad. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 24 +++- 1 file changed, 15 insertions(+), 9 dele

[PATCH v2 05/10] s5p-fimc: Add support for ISP Writeback data input bus type

2013-03-26 Thread Sylwester Nawrocki
orm/s5p-fimc/fimc-mdevice.c @@ -267,6 +267,11 @@ static struct v4l2_subdev *fimc_md_register_sensor(struct fimc_md *fmd, if (!s_info || !fmd) return NULL; + /* + * If FIMC bus type is not Writeback FIFO assume it is same +* as sensor_bus_type. +

[PATCH v2 10/10] s5p-fimc: Change the driver directory name to exynos4-is

2013-03-26 Thread Sylwester Nawrocki
modules will find their home in drivers/media/platform/exynos5-is. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/Kconfig |2 +- drivers/media/platform/Makefile|2 +- .../platform/{s5p-fimc => exynos4

[PATCH v2 09/10] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

2013-03-26 Thread Sylwester Nawrocki
Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin

[PATCH v2 08/10] s5p-fimc: Ensure proper s_power() call order in the ISP datapaths

2013-03-26 Thread Sylwester Nawrocki
from a table, rather than doing the op call based on increasing/decreasing indexes. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 26 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 07/10] s5p-fimc: Ensure proper s_stream() call order in the ISP datapaths

2013-03-26 Thread Sylwester Nawrocki
, rather than doing the op call based on increasing/decreasing indexes. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/media

[PATCH v2 06/10] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

2013-03-26 Thread Sylwester Nawrocki
x27;s operation. This affect processing pipelines like: - sensor -> FIMC-LITE -> memory - sensor -> MIPI-CSIS -> FIMC-LITE -> memory Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 18 ++ d

<    4   5   6   7   8   9   10   11   12   13   >