Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI config

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: Thierry Reding wrote: On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: Thierry Reding wrote: On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] Yeah, your pointing out is correct, but in this case, it should be 'bool' not 'tristate' because the PWM driver cannot support

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
- will be called pwm-samsung. - config PWM_TEGRA tristate NVIDIA Tegra PWM support depends on ARCH_TEGRA Acked-by: Thierry Reding thierry.red...@avionic-design.de pgpND2fOJVTrn.pgp Description: PGP signature

Re: [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip

2012-08-08 Thread Thierry Reding
On Fri, Aug 03, 2012 at 03:45:56PM +0900, Jingoo Han wrote: This patch adds missing device pointer to struct pwm_chip. If the device pointer is NULL, pwmchip_add() will return error. Signed-off-by: Jingoo Han jg1@samsung.com Thanks, applied to for-next and master. Thierry

Re: [PATCH] ARM: EXYNOS: Use generic pwm driver in Origen board

2012-08-09 Thread Thierry Reding
On Thu, Aug 09, 2012 at 02:33:55PM +0530, Tushar Behera wrote: Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- arch/arm/mach-exynos/mach-origen.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-origen.c

Re: [PATCH] ARM: EXYNOS: Use generic pwm driver in Origen board

2012-08-09 Thread Thierry Reding
On Thu, Aug 09, 2012 at 04:54:27PM +0530, Tushar Behera wrote: + linux-ker...@vger.kernel.org - linux-ker...@lists.infradead.org On 08/09/2012 02:45 PM, Thierry Reding wrote: On Thu, Aug 09, 2012 at 02:33:55PM +0530, Tushar Behera wrote: Signed-off-by: Tushar Behera tushar.beh

Re: [PATCH 0/3] ARM: EXYNOS: Add generic PWM lookup support

2012-09-12 Thread Thierry Reding
On Wed, Sep 12, 2012 at 05:03:29PM +0530, Sachin Kamat wrote: This series adds support for generic PWM framework which requires that the board setup code register a static mapping that can be used to match PWM consumers to providers. This series is based on for-next branch of Kukjin's tree.

Re: [PATCH] pwm: samsung: add missing s3c-pwm_id

2012-12-13 Thread Thierry Reding
On Fri, Dec 14, 2012 at 01:20:09PM +0900, Joonyoung Shim wrote: The s3c-pwm_id is used to calculate offset of related register. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/pwm/pwm-samsung.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2] pwm: samsung: add missing s3c-pwm_id

2012-12-13 Thread Thierry Reding
On Fri, Dec 14, 2012 at 03:58:58PM +0900, Joonyoung Shim wrote: The s3c-pwm_id is used to calculate offset of related register. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com I've modified the subject a bit to make it clear the assignment of s3c-pwm_id was missing, not the s3c-pwm_id

Re: [PATCH] pwm: add Exynos PWM driver

2013-01-09 Thread Thierry Reding
On Thu, Dec 13, 2012 at 07:16:36PM +0900, Joonyoung Shim wrote: This is PWM driver to support 4 pwm for Exynos SoCs. Also this supports device tree node. Maybe something like the following would read better: This is a PWM driver to support 4 PWM devices for Exynos SoCs. The

Re: [PATCH 00/23] RFC: exynos multiplatform support

2013-03-06 Thread Thierry Reding
On Wed, Mar 06, 2013 at 10:50:42AM +, Arnd Bergmann wrote: On Tuesday 05 March 2013, Tomasz Figa wrote: On Tuesday 05 of March 2013 19:19:02 Arnd Bergmann wrote: If none of these are needed for DT-based systems, we should probably build that code conditionally based on the

Re: [PATCH 00/23] RFC: exynos multiplatform support

2013-03-06 Thread Thierry Reding
On Thu, Mar 07, 2013 at 03:02:46AM +, Arnd Bergmann wrote: On Wednesday 06 March 2013, Thierry Reding wrote: Option 2 would probably come down to having a trivial MFD driver exposing a regmap. You can probably reuse drivers/mfd/syscon.c for this and make the node compatible

Re: [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator

2013-03-20 Thread Thierry Reding
On Wed, Mar 20, 2013 at 12:00:10PM -0600, Stephen Warren wrote: On 03/19/2013 12:59 PM, Andrew Chew wrote: Many backlights need to be explicitly enabled. Typically, this is done with a GPIO. For flexibility, we generalize the enable mechanism to a regulator. If an enable regulator is

Re: [PATCH V4 8/9] ARM: tegra: Provide regulator to pwm-backlight

2013-03-22 Thread Thierry Reding
On Tue, Mar 19, 2013 at 11:59:32AM -0700, Andrew Chew wrote: The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. Signed-off-by: Andrew Chew ac...@nvidia.com ---

Re: [PATCH V5 8/9] ARM: tegra: Provide regulator to pwm-backlight

2013-03-26 Thread Thierry Reding
On Mon, Mar 25, 2013 at 06:21:52PM -0700, Andrew Chew wrote: The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. Signed-off-by: Andrew Chew ac...@nvidia.com Acked-by: Alexandre Courbot

Re: [PATCH V5 9/9] pwm_bl: Add mandatory backlight power regulator

2013-03-26 Thread Thierry Reding
On Mon, Mar 25, 2013 at 06:21:53PM -0700, Andrew Chew wrote: [...] diff --git a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt index 1e4fc72..cb2d46a 100644 ---

Re: [PATCH v3] of/pci: Provide support for parsing PCI DT ranges property

2013-03-27 Thread Thierry Reding
Petazzoni thomas.petazz...@free-electrons.com Tested-by: Thierry Reding thierry.red...@avionic-design.de pgpLwdxq2rPcK.pgp Description: PGP signature

Re: [PATCH 17/30] pwm: samsung: repair the worst MMIO abuses

2013-04-12 Thread Thierry Reding
the proper driver, so: Acked-by: Thierry Reding thierry.red...@avionic-design.de pgpedplha6TqS.pgp Description: PGP signature

Re: [PATCH V2 2/9] drm/panel: add pre_enable and post_disable routines

2014-04-24 Thread Thierry Reding
On Thu, Apr 24, 2014 at 12:56:02AM +0530, Ajay kumar wrote: Thierry, On Wed, Apr 23, 2014 at 1:12 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Apr 23, 2014 at 09:29:15AM +0200, Daniel Vetter wrote: [...] Imo this makes sense, especially if we go through with the idea talked

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-28 Thread Thierry Reding
On Sun, Apr 27, 2014 at 08:23:06PM +0200, Arnd Bergmann wrote: On Sunday 27 April 2014 13:07:43 Shaik Ameer Basha wrote: +- mmu-masters: A phandle to device nodes representing the master for which + the System MMU can provide a translation. Any additional values +

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-28 Thread Thierry Reding
On Mon, Apr 28, 2014 at 12:56:03PM +0200, Arnd Bergmann wrote: On Monday 28 April 2014 12:39:20 Thierry Reding wrote: On Sun, Apr 27, 2014 at 08:23:06PM +0200, Arnd Bergmann wrote: On Sunday 27 April 2014 13:07:43 Shaik Ameer Basha wrote: +- mmu-masters: A phandle to device nodes

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-28 Thread Thierry Reding
On Mon, Apr 28, 2014 at 02:05:30PM +0200, Arnd Bergmann wrote: On Monday 28 April 2014 13:18:03 Thierry Reding wrote: On Mon, Apr 28, 2014 at 12:56:03PM +0200, Arnd Bergmann wrote: On Monday 28 April 2014 12:39:20 Thierry Reding wrote: And possibly with a iommu-names property to go along

Re: [RFC v2 PATCH v3 10/14] drm/panel: add S6E3FA0 driver

2014-04-28 Thread Thierry Reding
On Mon, Apr 28, 2014 at 05:05:24PM +0200, Laurent Pinchart wrote: Hi YoungJun, On Tuesday 22 April 2014 10:24:39 YoungJun Cho wrote: On 04/22/2014 08:00 AM, Laurent Pinchart wrote: Hi YoungJun, Thank you for the patch. On Monday 21 April 2014 21:28:37 YoungJun Cho wrote:

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-13 Thread Thierry Reding
On Fri, May 09, 2014 at 08:23:01PM +0530, Ajay Kumar wrote: implement basic panel controls as a drm_bridge so that the existing bridges can make use of it. The driver assumes that it is the last entity in the bridge chain. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com ---

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-14 Thread Thierry Reding
On Tue, May 13, 2014 at 10:19:33PM +0530, Ajay kumar wrote: On Tue, May 13, 2014 at 1:35 PM, Thierry Reding thierry.red...@gmail.com wrote: On Fri, May 09, 2014 at 08:23:01PM +0530, Ajay Kumar wrote: implement basic panel controls as a drm_bridge so that the existing bridges can make use

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Thierry Reding
On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt [...] +For samsung,exynos4210-simple-phy compatible PHYs the second cell in +the PHY specifier

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: Hi Thierry, On 15 May 2014 03:44, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] +#define HDMI_PHY 0 +#define DAC_PHY 1 +#define ADC_PHY 2

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-15 Thread Thierry Reding
On Wed, May 14, 2014 at 11:39:30PM +0530, Ajay kumar wrote: [...] diff --git a/Documentation/devicetree/bindings/drm/bridge/bridge_panel.txt b/Documentation/devicetree/bindings/drm/bridge/bridge_panel.txt [...] + -led-en-gpio: + eDP panel LED enable GPIO. +

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 01:47:33PM +0530, Rahul Sharma wrote: On 15 May 2014 13:12, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: On 15 May 2014 03:44, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 12

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-15 Thread Thierry Reding
On Thu, May 08, 2014 at 02:28:12PM -0400, Rob Clark wrote: On Thu, May 8, 2014 at 7:57 AM, Inki Dae inki@samsung.com wrote: [...] And more thing, we would need to consider image enhancer device placed between crtc and connector/encoder devices. And it'd better to rename drm_hw_block to

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-15 Thread Thierry Reding
On Fri, May 09, 2014 at 09:59:34AM -0400, Rob Clark wrote: On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda a.ha...@samsung.com wrote: [...] 4. And the last thing, it is more about the concept/design. drm_bridge, drm_hw_block suggests that those interfaces describes the whole device: bridge,

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-05-15 Thread Thierry Reding
On Mon, Apr 28, 2014 at 02:05:30PM +0200, Arnd Bergmann wrote: [...] let me clarify by example: iommu@1 { compatible = some,simple-iommu; reg = 1; #iommu-cells = 0; /* supports only one master */ }; iommu@2 {

[PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the Exynos System MMU and Tegra SMMU as discussed here: https://lkml.org/lkml/2014

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-17 Thread Thierry Reding
On Sat, May 17, 2014 at 05:04:55PM +0900, Cho KyongHo wrote: On Fri, 16 May 2014 14:23:18 +0200, Thierry Reding wrote: [...] +Examples: += + +Single-master IOMMU: + + + iommu { + #iommu-cells = 0; + }; + + master

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-17 Thread Thierry Reding
On Thu, May 15, 2014 at 05:10:16PM +0530, Ajay kumar wrote: On Thu, May 15, 2014 at 1:43 PM, Thierry Reding thierry.red...@gmail.com wrote: [...] I still don't see how controlling the enable GPIO from the panel will be in any way better, or different for that matter, from simply enabling

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-19 Thread Thierry Reding
On Mon, May 19, 2014 at 12:26:35PM +0200, Arnd Bergmann wrote: On Friday 16 May 2014 14:23:18 Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-19 Thread Thierry Reding
On Sun, May 18, 2014 at 01:50:36PM +0530, Ajay kumar wrote: On Sun, May 18, 2014 at 2:44 AM, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 05:10:16PM +0530, Ajay kumar wrote: On Thu, May 15, 2014 at 1:43 PM, Thierry Reding thierry.red...@gmail.com wrote

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-05-19 Thread Thierry Reding
On Tue, May 20, 2014 at 12:37:38AM +0530, Ajay kumar wrote: On 5/19/14, Thierry Reding thierry.red...@gmail.com wrote: On Sun, May 18, 2014 at 01:50:36PM +0530, Ajay kumar wrote: On Sun, May 18, 2014 at 2:44 AM, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 05:10

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-19 Thread Thierry Reding
On Mon, May 19, 2014 at 06:22:31PM +0100, Dave Martin wrote: On Mon, May 19, 2014 at 01:53:37PM +0100, Thierry Reding wrote: [...] My understanding here is mostly based on the OpenFirmware working group proposal for the dma-ranges property[0]. I'll give another example to try and clarify

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-19 Thread Thierry Reding
On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 14:53:37 Thierry Reding wrote: On Mon, May 19, 2014 at 12:26:35PM +0200, Arnd Bergmann wrote: On Friday 16 May 2014 14:23:18 Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote: On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 14:53:37 Thierry Reding wrote: On Mon, May 19, 2014 at 12:26:35PM +0200, Arnd Bergmann

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 01:15:48PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 13:05:37 Thierry Reding wrote: On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote: On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Couldn't a single-master IOMMU be windowed? Ah, yes. That would actually be like an IBM pSeries, which has a windowed IOMMU but uses one window per virtual machine

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 15:17:43 Thierry Reding wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Couldn't a single-master IOMMU be windowed

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Multiple-master IOMMU

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: On Wednesday 21 May 2014 10:16:09 Thierry Reding wrote: On Tue, May 20, 2014 at 10:31:29PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 16:00:02 Thierry Reding wrote: On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd

Re: [PATCH] pwm: samsung: do not set manual update bit in pwm_samsung_config

2014-05-21 Thread Thierry Reding
On Mon, May 12, 2014 at 08:26:21PM +0530, Ajay Kumar wrote: pwm_samsung_config sets manual update bit via call to pwm_samsung_enable even when the channel is already running. This causes noticable flickers on display if we try to change the backlight value from 0 to MAX, continiously. So,

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 11:36:32AM +0200, Arnd Bergmann wrote: On Wednesday 21 May 2014 11:00:38 Thierry Reding wrote: On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: For determining dma masks, it is the output

Re: [PATCH v2 04/18] video: add command mode and command mode display timing

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 01:42:56PM +0900, YoungJun Cho wrote: This patch is based on videomode and display_timing relevant codes. To support command mode panel, it does not need to guide its timing information to the display controller like video mode panel, but it requires signal timings to

Re: [PATCH] drm/exynos: Make exynos_drm_init() call late during the bootup

2014-05-21 Thread Thierry Reding
On Wed, May 14, 2014 at 05:09:45PM +0530, Naveen Krishna Chatradhi wrote: exynos_drm_init() does probing of various drivers like dp_panel, hdmi, fimd, mixer, etc in an order and finally binds them together. Some of the drm devices (Eg: dp_panel) try to do regulator_get() and enable few

Re: [PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Thierry Reding
On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: On 22 May 2014 11:51, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Rahul, [snip] + clk_prepare_enable(ctx-bus_clk); Probably a check for its success? + clk_prepare_enable(ctx-lcd_clk); Generally we

Re: [PATCH v2 04/18] video: add command mode and command mode display timing

2014-05-22 Thread Thierry Reding
On Thu, May 22, 2014 at 10:07:50PM +0900, Inki Dae wrote: On 2014년 05월 21일 20:41, YoungJun Cho wrote: Hi Therry On 05/21/2014 08:02 PM, Thierry Reding wrote: On Wed, May 21, 2014 at 01:42:56PM +0900, YoungJun Cho wrote: This patch is based on videomode and display_timing relevant codes

[PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-23 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the Exynos System MMU and Tegra SMMU as discussed here: https://lkml.org/lkml/2014

Re: [PATCH v2 04/18] video: add command mode and command mode display timing

2014-05-26 Thread Thierry Reding
On Wed, May 21, 2014 at 01:42:56PM +0900, YoungJun Cho wrote: This patch is based on videomode and display_timing relevant codes. To support command mode panel, it does not need to guide its timing information to the display controller like video mode panel, but it requires signal timings to

Re: [PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-26 Thread Thierry Reding
On Wed, May 21, 2014 at 01:43:05PM +0900, YoungJun Cho wrote: This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources, display timings and cpu mode timings. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by:

Re: [PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-27 Thread Thierry Reding
On Tue, May 27, 2014 at 08:28:52AM +0200, Andrzej Hajda wrote: Hi Thierry, On 05/26/2014 03:41 PM, Thierry Reding wrote: On Wed, May 21, 2014 at 01:43:05PM +0900, YoungJun Cho wrote: This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources, display timings

Re: [PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-27 Thread Thierry Reding
On Tue, May 27, 2014 at 11:24:49PM +0900, Inki Dae wrote: 2014-05-27 16:53 GMT+09:00 Thierry Reding thierry.red...@gmail.com: On Tue, May 27, 2014 at 08:28:52AM +0200, Andrzej Hajda wrote: Hi Thierry, On 05/26/2014 03:41 PM, Thierry Reding wrote: On Wed, May 21, 2014 at 01:43:05PM

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Thierry Reding
On Thu, May 29, 2014 at 09:52:22AM -0600, Stephen Warren wrote: On 05/23/2014 02:36 PM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: Hi, On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
On Sun, Jun 01, 2014 at 10:55:46AM +0100, Will Deacon wrote: On Fri, May 30, 2014 at 08:54:37PM +0100, Arnd Bergmann wrote: On Friday 30 May 2014 22:29:13 Hiroshi Doyu wrote: Tegra,SMMU has a similar problem and we have used a fixed size bitmap(64 bit) to afford 64 stream IDs so that a

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
On Fri, May 30, 2014 at 09:54:37PM +0200, Arnd Bergmann wrote: On Friday 30 May 2014 22:29:13 Hiroshi Doyu wrote: IIUC the original problem, a master with 8 streamIDs means something like below, where some devices have multiple IDs but some have a single. A sinle #address-cells cannot

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
wrote: On Fri, May 23, 2014 at 3:33 PM, Thierry Reding thierry.red...@gmail.com wrote: From: Thierry Reding tred...@nvidia.com +IOMMU master node: +== + +Devices that access memory through an IOMMU are called masters. A device can +have

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 05:41:32PM +0100, Will Deacon wrote: On Wed, Jun 04, 2014 at 03:35:10PM +0100, Thierry Reding wrote: On Mon, Jun 02, 2014 at 11:41:04AM +0100, Dave Martin wrote: In the strictest sense, no. But for a large set of sane configurations, this probably works

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
On Fri, May 30, 2014 at 12:27:28PM +0100, Dave Martin wrote: On Fri, May 30, 2014 at 08:30:08AM +0100, Thierry Reding wrote: [...] Arnd, can you take another look at this binding and see if there's anything else missing? If not I'll go through the document again and update all #address

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-04 Thread Thierry Reding
On Fri, May 30, 2014 at 09:01:19PM +0200, Arnd Bergmann wrote: On Friday 30 May 2014 12:22:32 Dave Martin wrote: + +Examples: += + +Single-master IOMMU: + + + iommu { + #address-cells = 0; + #size-cells = 0; + }; +

Re: [PATCH v4 00/14] drm/exynos: support LCD I80 interface display

2014-06-05 Thread Thierry Reding
On Thu, Jun 05, 2014 at 05:14:45PM +0900, Inki Dae wrote: Hi all, Is there anyone who are reviewing this patch series? If there is no any comment, I'd like to pick them up after test. What's with the rush? You should at least give people a day or two to get a chance to even see the

Re: [PATCH v4 00/14] drm/exynos: support LCD I80 interface display

2014-06-05 Thread Thierry Reding
On Thu, Jun 05, 2014 at 05:43:10PM +0900, Inki Dae wrote: On 2014년 06월 05일 17:20, Thierry Reding wrote: On Thu, Jun 05, 2014 at 05:14:45PM +0900, Inki Dae wrote: Hi all, Is there anyone who are reviewing this patch series? If there is no any comment, I'd like to pick them up after

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-06 Thread Thierry Reding
This is somewhat off-topic, but given the various concepts discussed in this thread I'm beginning to wonder how they will be implemented. The current implementation hooks the IOMMU API into the DMA mapping API, and the way this is done is by setting a single IOMMU (or rather a set of IOMMU

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Thierry Reding
On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote: On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam gautam.vi...@samsung.com wrote

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-09 Thread Thierry Reding
On Sat, Jun 07, 2014 at 03:22:13PM +0200, Arnd Bergmann wrote: On Saturday 07 June 2014 00:45:45 Thierry Reding wrote: This is somewhat off-topic, but given the various concepts discussed in this thread I'm beginning to wonder how they will be implemented. I think it's good you raised

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Thierry Reding
On Mon, Jun 16, 2014 at 01:57:04PM +0100, Will Deacon wrote: On Wed, Jun 04, 2014 at 10:12:38PM +0100, Thierry Reding wrote: On Fri, May 30, 2014 at 12:27:28PM +0100, Dave Martin wrote: On Fri, May 30, 2014 at 08:30:08AM +0100, Thierry Reding wrote: [...] Arnd, can you take another

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Thierry Reding
On Tue, Jun 17, 2014 at 01:18:11PM +0100, Will Deacon wrote: On Tue, Jun 17, 2014 at 12:58:30PM +0100, Thierry Reding wrote: On Mon, Jun 16, 2014 at 01:57:04PM +0100, Will Deacon wrote: On Wed, Jun 04, 2014 at 10:12:38PM +0100, Thierry Reding wrote: It can easily be argued

Re: [PATCH] arm/arm64: DT: Fix GICv2 CPU interface size

2014-06-25 Thread Thierry Reding
-ca15_a7.dts | 2 +- arch/arm64/boot/dts/apm-storm.dtsi | 2 +- arch/arm64/boot/dts/foundation-v8.dts | 2 +- arch/arm64/boot/dts/rtsm_ve-aemv8a.dts | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) For the Tegra114 and Tegra124 patches: Tested-by: Thierry Reding tred

[PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-23 Thread Thierry Reding
to take all these patches through the PWM tree, so I'll need acks from OMAP, PXA, Samsung, shmobile and Unicore32 maintainers. Thierry Thierry Reding (10): pwm-backlight: Refactor backlight power on/off pwm-backlight: Add optional enable GPIO ARM: OMAP: Initialize PWM backlight enable_gpio

[PATCH 10/10] pwm-backlight: Allow backlight to remain disabled on boot

2013-09-23 Thread Thierry Reding
introduces a new boot_off field in the platform data (and also implements getting the same information from device tree). When set the initial backlight power mode will be set to off. Signed-off-by: Thierry Reding tred...@nvidia.com --- Note: Perhaps it would be more useful to make

[PATCH 09/10] pwm-backlight: Use an optional power supply

2013-09-23 Thread Thierry Reding
Many backlights require a power supply to work properly. This commit uses a power-supply regulator, if available, to power up and power down the panel. Signed-off-by: Thierry Reding tred...@nvidia.com --- .../bindings/video/backlight/pwm-backlight.txt | 2 ++ drivers/video/backlight

[PATCH 08/10] pwm-backlight: Use new enable_gpio field

2013-09-23 Thread Thierry Reding
Make use of the new enable_gpio field and allow it to be set from DT as well. Now that all legacy users of platform data have been converted to initialize this field to an invalid value, it is safe to use the field from the driver. Signed-off-by: Thierry Reding tred...@nvidia.com

[PATCH 04/10] ARM: pxa: Initialize PWM backlight enable_gpio field

2013-09-23 Thread Thierry Reding
-by: Thierry Reding tred...@nvidia.com --- arch/arm/mach-pxa/cm-x300.c | 1 + arch/arm/mach-pxa/colibri-pxa270-income.c | 1 + arch/arm/mach-pxa/ezx.c | 1 + arch/arm/mach-pxa/hx4700.c| 1 + arch/arm/mach-pxa/lpd270.c| 1 + arch/arm

[PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field

2013-09-23 Thread Thierry Reding
The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. Signed-off-by: Thierry Reding tred...@nvidia.com --- arch/arm/mach-s3c24xx/mach-h1940.c| 1 + arch/arm/mach-s3c24xx/mach-rx1950.c | 1 + arch/arm/mach-s3c64xx/mach-crag6410.c | 1 + arch

[PATCH 06/10] ARM: shmobile: Initialize PWM backlight enable_gpio field

2013-09-23 Thread Thierry Reding
The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. Signed-off-by: Thierry Reding tred...@nvidia.com --- arch/arm/mach-shmobile/board-armadillo800eva.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-shmobile/board

[PATCH 07/10] unicore32: Initialize PWM backlight enable_gpio field

2013-09-23 Thread Thierry Reding
The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. Signed-off-by: Thierry Reding tred...@nvidia.com --- arch/unicore32/kernel/puv3-nb0916.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/unicore32/kernel/puv3-nb0916.c b/arch

[PATCH 03/10] ARM: OMAP: Initialize PWM backlight enable_gpio field

2013-09-23 Thread Thierry Reding
The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. Signed-off-by: Thierry Reding tred...@nvidia.com --- arch/arm/mach-omap2/board-zoom-peripherals.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/board-zoom

[PATCH 01/10] pwm-backlight: Refactor backlight power on/off

2013-09-23 Thread Thierry Reding
In preparation for adding an optional regulator and enable GPIO to the driver, split the power on and power off sequences into separate functions to reduce code duplication at the multiple call sites. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/video/backlight/pwm_bl.c | 59

[PATCH 02/10] pwm-backlight: Add optional enable GPIO

2013-09-23 Thread Thierry Reding
to ease the introduction of the optional enable GPIO, make it available in the platform data first, so that existing users can be converted. Once that has happened a second patch will add code to make use of it in the driver. Signed-off-by: Thierry Reding tred...@nvidia.com --- include/linux

Re: [PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-24 Thread Thierry Reding
On Tue, Sep 24, 2013 at 05:14:46PM +0900, Simon Horman wrote: [ Cc: Olof Johansson, Kevin Hilman and Arnd Bergman: arm-soc maintainers ] On Mon, Sep 23, 2013 at 11:40:57PM +0200, Thierry Reding wrote: This series adds the ability to specify a GPIO and a power supply to enable a backlight

Re: [PATCH 01/10] pwm-backlight: Refactor backlight power on/off

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:26:07PM -0600, Stephen Warren wrote: On 09/23/2013 03:40 PM, Thierry Reding wrote: In preparation for adding an optional regulator and enable GPIO to the driver, split the power on and power off sequences into separate functions to reduce code duplication

Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:31:04PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. static void __init smdkv210_map_io(void) @@ -70,6 +70,7 @@ static

Re: [PATCH 08/10] pwm-backlight: Use new enable_gpio field

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:39:36PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: Make use of the new enable_gpio field and allow it to be set from DT as well. Now that all legacy users of platform data have been converted to initialize this field to an invalid

Re: [PATCH 09/10] pwm-backlight: Use an optional power supply

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:43:57PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: Many backlights require a power supply to work properly. This commit uses a power-supply regulator, if available, to power up and power down the panel. I think that all

Re: [PATCH 10/10] pwm-backlight: Allow backlight to remain disabled on boot

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:50:51PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: The default for backlight devices is to be enabled immediately when registering with the backlight core. This can be useful for setups that use a simple framebuffer device and where

Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 02:58:22PM -0600, Stephen Warren wrote: On 10/01/2013 02:43 PM, Thierry Reding wrote: On Tue, Oct 01, 2013 at 12:31:04PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: The GPIO API defines 0 as being a valid GPIO number, so this field

Re: [PATCH 09/10] pwm-backlight: Use an optional power supply

2013-10-01 Thread Thierry Reding
On Tue, Oct 01, 2013 at 02:59:43PM -0600, Stephen Warren wrote: On 10/01/2013 02:53 PM, Thierry Reding wrote: On Tue, Oct 01, 2013 at 12:43:57PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: Many backlights require a power supply to work properly. This commit

Re: [PATCH 10/10] pwm-backlight: Allow backlight to remain disabled on boot

2013-10-02 Thread Thierry Reding
On Tue, Oct 01, 2013 at 12:50:51PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: [...] + if (gpio_is_valid(pb-enable_gpio)) { + if (pb-enable_gpio_flags PWM_BACKLIGHT_GPIO_ACTIVE_LOW) + gpio_set_value(pb-enable_gpio, 0

Re: [PATCH 1/1] pwm: samsung: Fix kernel warning while unexporting a channel

2013-11-01 Thread Thierry Reding
On Tue, Oct 29, 2013 at 10:27:43AM +0530, Sachin Kamat wrote: PWM channel data was set to NULL before freeing it. This caused the following kernel warning while unexporting the channel. Set the channel data to NULL after freeing it. [ 70.495000] WARNING: CPU: 0 PID: 1 at

Re: [PATCH 1/1] Documentation/pwm: Update supported SoC name for pwm-samsung

2013-11-11 Thread Thierry Reding
On Wed, Oct 30, 2013 at 10:09:41AM +0530, Sachin Kamat wrote: Updated supported SoC name for pwm-samsung. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- .../devicetree/bindings/pwm/pwm-samsung.txt|2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.

Re: [PATCH 1/1] pwm: samsung: avoid setting manual update bit unnecessarily

2013-11-28 Thread Thierry Reding
On Wed, Oct 30, 2013 at 10:21:44AM +0530, Sachin Kamat wrote: From: Andrew Bresticker abres...@chromium.org When possible, avoid setting the manual update bit and starting/stopping the PWM when adjusting the PWM as it causes noticable flickering when setting the backlight brightness.

Re: [PATCH] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers

2013-12-12 Thread Thierry Reding
-off-by: Bjorn Helgaas bhelg...@google.com --- MAINTAINERS | 31 +++ 1 file changed, 31 insertions(+) Looks good to me: Acked-by: Thierry Reding tred...@nvidia.com pgp0vbvHlZ08n.pgp Description: PGP signature

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-25 Thread Thierry Reding
On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: [...] +/* Keystone PCIe driver does not allow module unload */ +static int __init ks_pcie_init(void) +{ + return platform_driver_probe(ks_pcie_driver, ks_pcie_probe);

  1   2   3   4   >