exynos4412: porting hdmiddc and hdmiphy node entries

2014-04-26 Thread Tobias Jakobi
Hello, I'm trying to get the HDMI port working on a Exynos4412 based board. Attached is a snippet of a dts. This config was supposed to work in the past. However with 3.15-rc1 some things changed. samsung,exynos4210-hdmiddc and samsung,exynos4212-hdmiphy have no function anymore, the code that

Re: exynos4412: porting hdmiddc and hdmiphy node entries

2014-05-05 Thread Tobias Jakobi
Hello Tomasz, thanks a lot for the support! The meaning of hdmiphy is ambiguous. In exynos4 spec there are _TWO_ components named HDMIPHY. The first one is a PLL that generates a clock for HDMI subsystem. This PLL is controlled by I2C. You can find an example of its bindings at:

Re: exynos4412: porting hdmiddc and hdmiphy node entries

2014-05-18 Thread Tobias Jakobi
Hello, I made some progress with the HDMI output on the board. I updated to v4 of the exynos-simple-phy driver. @Rahul: You can add a tested-by from me, if you want. My dts now looks like this:

exynos4412: powerdomain issues with HDMI PHY and VP

2014-05-24 Thread Tobias Jakobi
Hello, I'm still working on getting HDMI output on my ODROID-X2 board (based on Exynos4412 Prime) working. My tree is a 3.15-rc6 with some patches on top to get it boot on the board. You can find the tree here: https://github.com/tobiasjakobi/linux-odroid/commits/odroid-3.15.y Here is the DTS:

Aw: Re: [PATCH] ARM: dts: Initial ODROID U2 support

2014-06-12 Thread Tobias Jakobi
Hello Marek, since you pointed out HDMI support on the ODROID, I assume you've looked into that. I've posted about some issues with HDMI PHY and mixer some days ago here: http://www.spinics.net/lists/linux-samsung-soc/msg31643.html Tomasz already suggested on IRC to CC some more people, who

Re: [PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Tobias Jakobi
Hello Kamil, this looks very good. I just tested the patchset on my ODROID-X2 (Exynos4412-based board) and the USB stability issues I mentioned to you before (with the older patchset) seem to be gone. All devices on the USB behave normally (mass storage, ethernet and bluetooth). With best

Re: [PATCH v10 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-07 Thread Tobias Jakobi
2 files changed, 39 insertions(+) Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de USB PHY was tested on an ODROID-X2 (Exynos4412 SoC) with patches from Kamil's previous patchset to enable the usage of the new PHY in EHCI and OCHI. With best wishes, Tobias -- To unsubscribe from

Re: [PATCH v10 1/4] phy: core: Add an exported of_phy_get function

2014-03-07 Thread Tobias Jakobi
changed, 42 insertions(+), 9 deletions(-) Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de USB PHY was tested on an ODROID-X2 (Exynos4412 SoC) with patches from Kamil's previous patchset to enable the usage of the new PHY in EHCI and OCHI. With best wishes, Tobias -- To unsubscribe from

Re: [PATCH v10 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-07 Thread Tobias Jakobi
create mode 100644 drivers/phy/phy-exynos4210-usb2.c create mode 100644 drivers/phy/phy-exynos4x12-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.c create mode 100644 drivers/phy/phy-samsung-usb2.h Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de USB PHY was tested on an ODROID

Re: [PATCH v10 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-07 Thread Tobias Jakobi
(+) create mode 100644 drivers/phy/phy-exynos5250-usb2.c Tested-by: Tobias Jakobi tjak...@math.uni-bielefeld.de USB PHY was tested on an ODROID-X2 (Exynos4412 SoC) with patches from Kamil's previous patchset to enable the usage of the new PHY in EHCI and OCHI. With best wishes, Tobias -- To unsubscribe

Re: [PATCH 1/7] clk: exynos4: add support for MOUT_HDMI and MOUT_MIXER clocks

2014-07-01 Thread Tobias Jakobi
Hello Marek, I think this particular clock setup should already be handled by this patch: http://www.spinics.net/lists/arm-kernel/msg320013.html Or am I missing something here? With best wishes, Tobias Marek Szyprowski wrote: This patch adds support for exporting mout_hdmi and mout_mixer to

Re: [PATCH 4/7] Exynos: add support for 'domain-always-on' property

2014-07-01 Thread Tobias Jakobi
Hello Marek, I think you had a similar patch in the tizen tree, but according to Tomasz Figa, it was considered a hack. I don't quite see how this is different. Also, if I have been following the discussion correctly, then the powerdomain issue essentially is about the question which SoC block

Re: [PATCH 1/7] clk: exynos4: add support for MOUT_HDMI and MOUT_MIXER clocks

2014-07-01 Thread Tobias Jakobi
Hi, Marek Szyprowski wrote: Hello, On 2014-07-01 10:46, Tobias Jakobi wrote: Hello Marek, I think this particular clock setup should already be handled by this patch: http://www.spinics.net/lists/arm-kernel/msg320013.html Or am I missing something here? The patch you have pointed

Re: [PATCH 4/7] Exynos: add support for 'domain-always-on' property

2014-07-01 Thread Tobias Jakobi
Hi, Marek Szyprowski wrote: Hello, On 2014-07-01 10:52, Tobias Jakobi wrote: Hello Marek, I think you had a similar patch in the tizen tree, but according to Tomasz Figa, it was considered a hack. I don't quite see how this is different. Also, if I have been following the discussion

Re: [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-19 Thread Tobias Jakobi
are not used. I wonder this happens? Is there some kind of limit enforced? With best wishes, Tobias Jakobi -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] drm/exynos: g2d: add exynos4212 as a compatible device.

2014-07-19 Thread Tobias Jakobi
From: Alban Browaeys pra...@yahoo.com Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 8001587

[exynos/g2d] enable g2d block on more SoCs

2014-07-19 Thread Tobias Jakobi
Currently there is just a compatibility string for exynos5250, but the G2D also works satisfactory on my exynos4412. Since the block is the same (HW version 4.1), introduce exynos4212-g2d which can be used for the G2D on the exynos4 series SoCs. -- To unsubscribe from this list: send the line

[libdrm/exynos] small fixes and enhancements for the g2d

2014-07-19 Thread Tobias Jakobi
Hello, this is a resend of the patches I posted a while back. Patches touch the exynos part of libdrm, in particular the g2d part. No big changes, just small stuff. Please review and let me know if I should change anything! Thanks, Tobias -- To unsubscribe from this list: send the line

[PATCH 1/3] tests/exynos: fimg2d: add a checkerboard test

2014-07-19 Thread Tobias Jakobi
This makes it easier to see corruption which e.g. occurs when using the userptr functionality to copy buffers allocated via plain malloc. One of the reasons why this is currently just used with GEM buffer mode. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos

[PATCH 2/3] exynos: replace G2D_DOUBLE_TO_FIXED macro with documented function

2014-07-19 Thread Tobias Jakobi
This also avoids the floating point conversion steps and just uses pure integer arithmetic. Also the G2D hardware scaling factor is a bit unintuitive, so explain it in the function. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 19

[PATCH 3/3] tests/exynos: fix typos and change wording

2014-07-19 Thread Tobias Jakobi
No functional changes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 8 tests/exynos/exynos_fimg2d_test.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

Re: [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-19 Thread Tobias Jakobi
Tomasz Figa wrote: Tobias, On 19.07.2014 21:20, Tobias Jakobi wrote: Hello, I have a question concerning an older version of this patchset, the one which still included exynos4x12 support and where the clocking data was provided through DT. I tried to get this working for my ODROID-X2

[PATCH] drm/exynos: g2d: let exynos_g2d_get_ver_ioctl fail

2014-07-23 Thread Tobias Jakobi
, leading to a segfault later. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 5fa1bb6

Aw: [PATCH] drm/exynos: g2d: let exynos_g2d_get_ver_ioctl fail

2014-07-23 Thread Tobias Jakobi
Sorry for the noise! Please disregard the patch for now, it causes more trouble than it solves! - Tobias   Gesendet: Mittwoch, 23. Juli 2014 um 15:57 Uhr Von: Tobias Jakobi tjak...@math.uni-bielefeld.de An: linux-samsung-soc@vger.kernel.org Cc: dri-de...@lists.freedesktop.org, t.f

[PATCH 2/2] drm/exynos: g2d: let exynos_g2d_get_ver_ioctl fail

2014-07-23 Thread Tobias Jakobi
, leading to a segfault later. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 8c62423

[drm/exynos] g2d: error handling and other things

2014-07-23 Thread Tobias Jakobi
Again, sorry for the noise. These two patches should now really fix what they're supposed to fix. - Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 1/2] drm/exynos: g2d: make ioctls more robust

2014-07-23 Thread Tobias Jakobi
is not available. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 5fa1bb6..8c62423

[v2] [drm/exynos] g2d: error handling and other things

2014-07-23 Thread Tobias Jakobi
I blame it on the heat... *sigh* - Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2: 1/2] drm/exynos: g2d: make ioctls more robust

2014-07-23 Thread Tobias Jakobi
is not available. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 5fa1bb6..929c6d7

Re: [PATCH 1/2] drm/exynos: g2d: make ioctls more robust

2014-08-03 Thread Tobias Jakobi
Inki Dae wrote: It seems that you have no build test because above line incurs build error. Anyway I fixed it up. That's why I have sent v2 of the patch. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: [PATCH 1/2] drm/exynos: g2d: make ioctls more robust

2014-08-04 Thread Tobias Jakobi
On 2014-08-04 02:28, Inki Dae wrote: Oops, sorry. I didn't check v2. No problem :) It would be good if you could also check the libdrm patches that I've resent some while ago. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

[PATCH] clocksource: exynos_mct: fix exynos4_mct_write

2014-10-21 Thread Tobias Jakobi
a refactoring of the MCT code. Fix this by putting the inversion at the correct position again. Reported-by: GP Orcullo kinsama...@gmail.com Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/clocksource/exynos_mct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] clocksource: exynos_mct: fix exynos4_mct_write

2014-10-22 Thread Tobias Jakobi
, haven't encountered anything 'strange' yet. With best wishes, Tobias On 2014-10-22 17:57, Doug Anderson wrote: Tobias, On Tue, Oct 21, 2014 at 6:37 PM, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: EXYNOS4_MCT_L_MASK is defined as 0xff00, so applying this bitmask produces a number outside

Re: [PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-11-18 Thread Tobias Jakobi
Inki Dae wrote: Hi Tomasz, Yes, of course. We will fix it soon. For this, I mentioned earlier, http://web.archiveorange.com/archive/v/hhSc574WhqJAKgdBq7KL Thanks, Inki Dae Hello, it looks like libdrm git master is still using the EXYNOS_GEM_MMAP ioctl that was removed by this patch.

Re: [PATCH 2/2] drm/exynos: use drm generic mmap interface

2014-11-18 Thread Tobias Jakobi
Inki Dae wrote: Hello, it looks like libdrm git master is still using the EXYNOS_GEM_MMAP ioctl that was removed by this patch. Is there any news on the patches for libdrm? The patch set already was posted. You can refer to below link,

Re: [PATCH] clocksource: exynos_mct: fix exynos4_mct_write

2014-11-29 Thread Tobias Jakobi
Hello, just a short note that I still don't see this patch applied anywhere. Anything else I need to do here? With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: drm: exynos: mixer: fix using usleep() in atomic context

2014-12-01 Thread Tobias Jakobi
On 2014-12-01 16:54, Thierry Reding wrote: On Sun, Nov 30, 2014 at 01:35:25AM +0100, tjak...@math.uni-bielefeld.de wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com This patch fixes calling usleep_range() after taking reg_slock using spin_lock_irqsave(). The mdelay() is used instead.

Re: drm/exynos: some small forgotten patch

2014-12-09 Thread Tobias Jakobi
On 2014-12-09 13:09, Inki Dae wrote: That might be a patch I missed. Can you tell me the Subject? Uhm, I think that is obvious from the mail? http://www.spinics.net/lists/linux-samsung-soc/msg39811.html Anyway, I'm still waiting for Thierry's reply on that matter. With best wishes, Tobias --

exynos4412: misc issues on Hardkernel Odroid boards

2015-02-07 Thread Tobias Jakobi
Hello, I've collected some of the more serious remaining problems on the Hardkernel Odroid boards (here on an X2). 1) When using cpufreq-exynos and having selected the 'ondemand' governor, the system shutdown/reboot process doesn't complete and hangs before the end. I'm currently hotfixing this

[PATCH 15/15] exynos: fimg2d: introduce G2D_OP_INTERPOLATE

2015-02-03 Thread Tobias Jakobi
This sets up the blending equation in the following way: out = src * src_alpha + dst * (1 - src_alpha) Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 4 exynos/exynos_fimg2d.h | 1 + 2 files changed, 5 insertions(+) diff --git a/exynos

[libdrm] improvements to userspace exynos component

2015-02-03 Thread Tobias Jakobi
Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of

[PATCH 11/15] exynos: add exynos prefix to fimg2d header

2015-02-03 Thread Tobias Jakobi
Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am| 2 +- exynos/exynos_fimg2d.c| 2 +- exynos/exynos_fimg2d.h| 328 ++ exynos/fimg2d.h | 328

[PATCH 14/15] exynos: fimg2d: unify register style

2015-02-03 Thread Tobias Jakobi
Register defines all use uppercase hex codes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/fimg2d_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/fimg2d_reg.h b/exynos/fimg2d_reg.h index 5782488..07dd634 100644 --- a/exynos/fimg2d_reg.h

[PATCH 01/15] tests/exynos: fimg2d: add a checkerboard test

2015-02-03 Thread Tobias Jakobi
This makes it easier to spot memory corruptions which don't become visible when using a plain buffer filled with a solid color (so corruptions that are just a permutation of the bytes in the buffer). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

[PATCH 08/15] exynos: introduce g2d_add_base_addr helper function

2015-02-03 Thread Tobias Jakobi
In almost all functions the base address register is written, so it makes sense to have a helper function for this. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 87 +++--- 1 file changed, 33 insertions(+), 54

[PATCH 05/15] exynos: add g2d_scale_and_blend

2015-02-03 Thread Tobias Jakobi
This is a combination of g2d_copy_with_scale and g2d_scale. It is a pretty common operation to scale one buffer and then blend it on top of another, so provide a direct way to that operation. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 129

[PATCH 03/15] tests/exynos: fix typos and change wording

2015-02-03 Thread Tobias Jakobi
No functional changes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 8 tests/exynos/exynos_fimg2d_test.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

[PATCH 09/15] exynos: use structure initialization instead of memset

2015-02-03 Thread Tobias Jakobi
Keeps the code cleaner, since the structs have to be initialized once anyway. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 4 +--- tests/exynos/exynos_fimg2d_test.c | 15 --- 2 files changed, 5 insertions(+), 14 deletions

[PATCH 02/15] exynos: replace G2D_DOUBLE_TO_FIXED macro with function

2015-02-03 Thread Tobias Jakobi
This also avoids the floating point conversion steps and just uses pure integer arithmetic. Since the G2D hardware scaling approach is a bit unintuitive, document it in the function as well. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 19

[PATCH 10/15] tests/exynos: improve error handling

2015-02-03 Thread Tobias Jakobi
Check for a useable connector and also if the resolution is sane (width and height are both non-zero). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/exynos

[PATCH 04/15] tests/exynos: disable the G2D userptr/blend test

2015-02-03 Thread Tobias Jakobi
the kernel code has been sanitized. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index aa140e5..48dfe97 100644 --- a/tests

[PATCH 13/15] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR

2015-02-03 Thread Tobias Jakobi
The coefficient mode enables use of global color, not alpha. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.h b/exynos/exynos_fimg2d.h index bd116cf..78cff47 100644

[PATCH 07/15] exynos: honor the repeat mode in g2d_copy_with_scale

2015-02-03 Thread Tobias Jakobi
. Scaling with 'pad' mode would then just do the right thing and also produces nice borders on the output. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 5 + 1 file changed, 5 insertions(+) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

[PATCH 12/15] exynos: add fimg2d header to common includes

2015-02-03 Thread Tobias Jakobi
The reason for this change is to let userspace use the header. Currently 'make install' does not install it. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exynos/Makefile.am b/exynos

[PATCH 06/15] tests/exynos: introduce wait_for_user_input

2015-02-03 Thread Tobias Jakobi
Currently getchar() is used to pause execution after each test. The user isn't informed if one is supposed to do anything for the tests to continue, so print a simple message to make this more clear. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-15 Thread Tobias Jakobi
Hello! Marek Szyprowski wrote: I hope that HDMI display works fine for you. I checked with my panel just now and played around a bit with the DRM (opening, vsync, etc.). However on deinitialization the entire system locked up. I currently haven't hooked the board up to the serial console,

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-15 Thread Tobias Jakobi
Hello, while looking through the patchset I noticed the following. In patch 07/16 code is added to drivers/cpufreq/exynos-cpufreq.c, which reminded me of the cpufreq patchset by Thomas Abraham. If I remember correctly then the ultimate goal of the cpufreq 'conversion' is to get rid of the

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-19 Thread Tobias Jakobi
Marek Szyprowski wrote: Please check the following kernel tree - instead of hacking around hdmi clock I've added handling of it directly to drm mixer driver: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog/refs/heads/v3.19-odroid-hdmi I hope that this will finally

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-19 Thread Tobias Jakobi
Hello! Marek Szyprowski wrote: Thanks for you tests and pointing this issue. I turned out that the initial fix proposed by Andrzej Hajda (http://www.spinics.net/lists/linux-samsung-soc/msg38915.html) worked fine, while the final version merged to clock fixes ('clk: samsung: exynos4: set

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-19 Thread Tobias Jakobi
Hello! Lukasz Majewski wrote: We all know that this code is floating around - early version of this work was posted in the Q3 2013. To be fair - this code is both needed and welcome, but new problems with it are found (please search for recent comment from Kevin Hilman). From my side, I

Re: drm: exynos: mixer: fix using usleep() in atomic context

2015-01-21 Thread Tobias Jakobi
Hello! Inki Dae wrote: The use of spin lock, reg_slock, has been used for a long time and we hadn't some cleanups to spin lock codes so far. The spin lock is also used in here and there of mixer driver. And at least, it seems that the use of spin lock isn't required in mixer_win_reset. I

Re: [PATCH v4 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-21 Thread Tobias Jakobi
Hello, just some warnings I encountered when compiling this today: drivers/iommu/exynos-iommu.c: In function ‘exynos_iommu_of_setup’: drivers/iommu/exynos-iommu.c:1177:2: warning: passing argument 2 of ‘of_iommu_set_ops’ discards ‘const’ qualifier from pointer target type [enabled by default]

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-16 Thread Tobias Jakobi
Hello, so OK, this doesn't look too good. Tobias Jakobi wrote: I checked with my panel just now and played around a bit with the DRM (opening, vsync, etc.). However on deinitialization the entire system locked up. I currently haven't hooked the board up to the serial console, otherwise I

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-16 Thread Tobias Jakobi
Tobias Jakobi wrote: Hello, so OK, this doesn't look too good. Tobias Jakobi wrote: I checked with my panel just now and played around a bit with the DRM (opening, vsync, etc.). However on deinitialization the entire system locked up. I currently haven't hooked the board up to the serial

libdrm/exynos: fix usage of removed ioctls

2015-01-16 Thread Tobias Jakobi
Hello, these two patches are needed for the exynos component of libdrm to properly work again. With the current stable 3.18.x the 'exynos_bo_map' call is broken, making it impossible to get data from userspace into a DRM buffer. The patches were sent by Hyungwon Hwang some while ago, but the

Re: power: reset: add driver for Hardkernel's Odroid boards

2015-01-14 Thread Tobias Jakobi
Hello, I've applied the two patches of this set onto torvalds/master (together with some other patches), but I now encounter an 'internal error' when doing a system reboot. Here's the corresponding part of the kernel log: http://www.math.uni-bielefeld.de/~tjakobi/archive/odroid_power_reset.txt

Re: power: reset: add driver for Hardkernel's Odroid boards

2015-01-15 Thread Tobias Jakobi
Marek Szyprowski wrote: Right. This patch was posted some time ago and reboot handling on ARM SoCs have been changed recently in v3.19-rc1. I will post an updated version of this patch soon. Best regards Thanks for the update! Going to wait for the new version then. Wish best wishes,

Re: [PATCH v2 0/6] Enable HDMI support on Exynos platforms

2015-01-15 Thread Tobias Jakobi
Marek Szyprowski wrote: This is on a ODROID-X2. The issues with FIMC / DRM FIMC are not related to HDMI patches. They will be handled separately. For the time being simply please disable Exynos IPP (or Exynos DRM FIMC) feature in your kernel configuration. I hope that HDMI display works

Re: [v3,06/16] arm: dts: Adding CPU cooling binding for Exynos SoCs

2015-01-15 Thread Tobias Jakobi
Hello, I noticed that this patch mixes spaces and tabs a lot for indentation. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 04/15] tests/exynos: disable the G2D userptr/blend test

2015-02-10 Thread Tobias Jakobi
Hello Joonyoung! Joonyoung Shim wrote: Hi, On 02/03/2015 10:53 PM, Tobias Jakobi wrote: The blend test uses the userptr functionality of exynos-drm, which is currently not safe to use. If the kernel hasn't been build with exynos-iommu support, then the blend test is going to produce

Re: [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver

2015-02-18 Thread Tobias Jakobi
Hello again, Tobias Jakobi wrote I've tested the series on my Odroid-X2 (by adapting the TRATS2 changes), and so far I haven't seen any issues. With the system being idle one can see that the 'simple_ondemand' devfreq governor clocks down both memory busses to the lowest state. looks I

Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2015-02-17 Thread Tobias Jakobi
Hello! Lukasz Majewski wrote: Hi Krzysztof, Thomas, 2015-01-08 22:17 GMT+01:00 Kevin Hilman khil...@kernel.org: Hi Thomas, Do you plan to continue with this work? It would be very helpful. +1 from me. I also wonder if Exynos 4412 could be re-added (without the boost if these

[PATCH v2 14/15] exynos: fimg2d: unify register style

2015-02-16 Thread Tobias Jakobi
Register defines all use uppercase hex codes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/fimg2d_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/fimg2d_reg.h b/exynos/fimg2d_reg.h index 5782488..07dd634 100644 --- a/exynos/fimg2d_reg.h

[PATCH v2 15/15] exynos: fimg2d: introduce G2D_OP_INTERPOLATE

2015-02-16 Thread Tobias Jakobi
This sets up the blending equation in the following way: out = src * src_alpha + dst * (1 - src_alpha) Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 4 exynos/exynos_fimg2d.h | 1 + 2 files changed, 5 insertions(+) diff --git a/exynos

[PATCH v2 05/15] exynos: add g2d_scale_and_blend

2015-02-16 Thread Tobias Jakobi
This is a combination of g2d_copy_with_scale and g2d_scale. It is a pretty common operation to scale one buffer and then blend it on top of another, so provide a direct way to that operation. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 129

[PATCH v2 06/15] tests/exynos: introduce wait_for_user_input

2015-02-16 Thread Tobias Jakobi
Currently getchar() is used to pause execution after each test. The user isn't informed if one is supposed to do anything for the tests to continue, so print a simple message to make this more clear. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

[PATCH v2 11/15] exynos: add exynos prefix to fimg2d header

2015-02-16 Thread Tobias Jakobi
Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am| 2 +- exynos/exynos_fimg2d.c| 2 +- exynos/exynos_fimg2d.h| 328 ++ exynos/fimg2d.h | 328

[PATCH v2 10/15] tests/exynos: improve error handling

2015-02-16 Thread Tobias Jakobi
Check for a useable connector and also if the resolution is sane (width and height are both non-zero). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/exynos

[PATCH v2 01/15] tests/exynos: fimg2d: add a checkerboard test

2015-02-16 Thread Tobias Jakobi
This makes it easier to spot memory corruptions which don't become visible when using a plain buffer filled with a solid color (so corruptions that are just a permutation of the bytes in the buffer). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

[PATCH v2 08/15] exynos: introduce g2d_add_base_addr helper function

2015-02-16 Thread Tobias Jakobi
In almost all functions the base address register is written, so it makes sense to have a helper function for this. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 87 +++--- 1 file changed, 33 insertions(+), 54

[PATCH v2 04/15] tests/exynos: disable the G2D userptr/blend test

2015-02-16 Thread Tobias Jakobi
v2: Move the commit description into the patch itself. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index aa140e5

[PATCH v2 03/15] tests/exynos: fix typos and change wording

2015-02-16 Thread Tobias Jakobi
No functional changes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 8 tests/exynos/exynos_fimg2d_test.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

[PATCH v2 07/15] exynos: honor the repeat mode in g2d_copy_with_scale

2015-02-16 Thread Tobias Jakobi
. Scaling with 'pad' mode would then just do the right thing and also produces nice borders on the output. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 5 + 1 file changed, 5 insertions(+) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

[v2] libdrm: improvements to userspace exynos component

2015-02-16 Thread Tobias Jakobi
Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of

[PATCH v2 13/15] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR

2015-02-16 Thread Tobias Jakobi
The coefficient mode enables use of global color, not alpha. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.h b/exynos/exynos_fimg2d.h index bd116cf..78cff47 100644

[PATCH v2 02/15] exynos: replace G2D_DOUBLE_TO_FIXED macro with function

2015-02-16 Thread Tobias Jakobi
This also avoids the floating point conversion steps and just uses pure integer arithmetic. Since the G2D hardware scaling approach is a bit unintuitive, document it in the function as well. v2: Explicitly mention the normalization constant. Signed-off-by: Tobias Jakobi tjak...@math.uni

[PATCH v2 09/15] exynos: use structure initialization instead of memset

2015-02-16 Thread Tobias Jakobi
Keeps the code cleaner, since the structs have to be initialized once anyway. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 4 +--- tests/exynos/exynos_fimg2d_test.c | 15 --- 2 files changed, 5 insertions(+), 14 deletions

[PATCH v2 12/15] exynos: add fimg2d header to common includes

2015-02-16 Thread Tobias Jakobi
The reason for this change is to let userspace use the header. Currently 'make install' does not install it. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exynos/Makefile.am b/exynos

Re: [PATCH 1/2] mmc: dw_mmc-exynos: add support for controlling emmc reset pin

2015-01-28 Thread Tobias Jakobi
Ulf Hansson wrote: On 28 January 2015 at 13:41, Tobias Jakobi liquid.a...@gmx.net wrote: Hello! Jaehoon Chung wrote: mmc core supported to hw_reset function. So i think we can use it. It's called at only initial time to clear the previous status. But i think it can be called at reboot

Re: [PATCH 1/2] mmc: dw_mmc-exynos: add support for controlling emmc reset pin

2015-01-28 Thread Tobias Jakobi
Hello! Jaehoon Chung wrote: mmc core supported to hw_reset function. So i think we can use it. It's called at only initial time to clear the previous status. But i think it can be called at reboot time. (it needs to implement codes.) how about? I don't think that's going the work. The

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-23 Thread Tobias Jakobi
Eduardo Valentin wrote: The reason is that hwmon sensor device drivers also register via of-thermal. So, adding hwmon interface by default will create a cyclic problem. Hmm, I see. Would it still be possible to flag some thermal zones so that hwmon nodes are created for them? With best

Re: [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks

2015-01-23 Thread Tobias Jakobi
Hello, I've tested the series on my X2 and so far I haven't encountered any obvious issues with it. I have a small question though. With the move to simple-audio-card the old driver (selected by SND_SOC_ODROIDX2) is probably going away after some time. Currently SND_SOC_ODROIDX2 also selects

Aw: [PATCH v6 05/18] arm: dts: odroid: Enable TMU at Exynos4412 based Odroid U3 device

2015-01-23 Thread Tobias Jakobi
Hello, just a small nit concerning the patch subject. Shouldn't it be Enable TMU on Exynos4412 based Odroid devices (since it's not just for the U3)? With best wishes, Tobias   Gesendet: Freitag, 23. Januar 2015 um 13:09 Uhr Von: Lukasz Majewski l.majew...@samsung.com An: Eduardo Valentin

Re: exynos4412: misc issues on Hardkernel Odroid boards

2015-02-14 Thread Tobias Jakobi
Hello! Marek Szyprowski wrote: 4) Spinlock BUGs triggered by the sdhci subsystem (so for the people using the system with a SD card). This is also a known problem, I think first mentioned here: http://www.spinics.net/lists/linux-mmc/msg27277.html Currently fixing this with this patch:

Re: [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver

2015-02-14 Thread Tobias Jakobi
Hello, I've tested the series on my Odroid-X2 (by adapting the TRATS2 changes), and so far I haven't seen any issues. With the system being idle one can see that the 'simple_ondemand' devfreq governor clocks down both memory busses to the lowest state. With best wishes, Tobias -- To unsubscribe

Re: exynos4412: misc issues on Hardkernel Odroid boards

2015-02-09 Thread Tobias Jakobi
Hello! Marek Szyprowski wrote: I didn't observe any issues with 'ondemand' governor. I've just tested it on next-20150204 with [PATCH v2 0/3] Add support for hardware reset of eMMC card on reboot patches added (http://www.spinics.net/lists/linux-mmc/msg30621.html) and reboot works fine.

Re: [PATCH] exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

2015-02-09 Thread Tobias Jakobi
Marek Szyprowski wrote: PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC. Tested on my Odroid-X2 and it seems to solve the 'heating issue' when the system is shut down but left on the AC adapter. With best wishes, Tobias -- To unsubscribe from

[rtc-s3c.c] add .needs_src_clk to s3c6410 RTC data / break exynos4

2015-03-18 Thread Tobias Jakobi
rtc source clock [1.616740] s3c-rtc: probe of 1007.rtc failed with error -2 With best wishes, Tobias Jakobi -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/5] tests/exynos: add fimg2d performance analysis

2015-03-22 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: Might I suggest that we treat this (and your follow up utility) as a test ? I.e. use if HAVE_INSTALL_TESTS bin_PROGRAMS = \ exynos_fimg2d_perf else noinst_PROGRAMS = \ exynos_fimg2d_perf endif and amend the block below appropriately ?

Re: [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent

2015-03-22 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: I fear we are not (yet) allowed to do either of these changes. The exynos/exynos_drm.h header is (supposed to) be in sync/come from the kernel. And changes here are to be reflected only when the corresponding patch lands in drm-next (as per RELEASING). the

  1   2   3   4   >