Re: [PATCH v5 4/4] USB: ohci-exynos: Add phy driver support

2012-12-18 Thread Vivek Gautam
CC: Doug Anderson. On Tue, Dec 18, 2012 at 8:13 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked

Re: [PATCH v5 0/4] Adding usb2.0 host-phy support for exynos5250

2012-12-18 Thread Vivek Gautam
CC: Doug Anderson On Tue, Dec 18, 2012 at 8:13 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Changes from v4: - Moved architecture side changes out of this patch-set. - Added support for multiple usbphy phandle parsing and doing all pmu_isolation() and phy_cfg_sel() related changes

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-18 Thread Vivek Gautam
Hi Felipe, On Wed, Dec 19, 2012 at 11:14 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: CC: Doug Anderson On Tue, Dec 18, 2012 at 8:43 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Dec 18, 2012 at 08:40:26PM +0530, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-19 Thread Vivek Gautam
Hi Sylwester, On Wed, Dec 19, 2012 at 11:05 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: CC: Doug Anderson On Wed, Dec 19, 2012 at 4:49 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Vivek, On 12/18/2012 02:56 PM, Vivek Gautam wrote: Adding support to parse device

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam gautam.vi...@samsung.com wrote: Using chip specific compatible string as it should be. So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos

Re: [PATCH 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 9:39 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: On Thu, Dec 13, 2012 at 8:22 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list

Re: [PATCH 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 9:40 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: CC: LKML On Thu, Dec 13, 2012 at 8:22 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using specific chip in compatible strings. Newer SOCs can claim device by using older string

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam gautam.vi...@samsung.com wrote: Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed

Re: [PATCH v3] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 10:17 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v2

Re: [PATCH v5 1/4] ARM: EXYNOS: Update move usb-phy types to generic include layer

2012-12-19 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson diand...@chromium.org wrote: Vivek, On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE USB_PHY_TYPE_HOST; and further update

Re: [PATCH v5 1/4] ARM: EXYNOS: Update move usb-phy types to generic include layer

2012-12-20 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 10:23 PM, Doug Anderson diand...@chromium.org wrote: Vivek, On Wed, Dec 19, 2012 at 9:51 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Doug, On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson diand...@chromium.org wrote: Vivek, Since you're changing

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
/2012-November/134476.html - http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/131763.html Vivek Gautam (1): usb: phy: samsung: Add support to set pmu isolation .../devicetree/bindings/usb/samsung-usbphy.txt | 28 drivers/usb/phy/samsung-usbphy.c

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/samsung-usbphy.txt | 28 drivers/usb/phy/samsung-usbphy.c | 145

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: CC: Doug Anderson On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam gautam.vi...@samsung.com wrote: Using chip specific

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: CC: Doug Anderson On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam gautam.vi...@samsung.com wrote: Adding EHCI device

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-21 Thread Vivek Gautam
Hi Felipe, On Wed, Dec 19, 2012 at 1:25 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct platform_device *pdev) sphy-clk = clk; - return

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-24 Thread Vivek Gautam
Hi Kukjin, On Mon, Dec 24, 2012 at 4:45 AM, Kukjin Kim kgene@samsung.com wrote: Kukjin Kim wrote: Re-sending due to e-mail client problem... Doug Anderson wrote: On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: On Wed, Dec 19, 2012 at 7:16 PM

Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Hi Doug, On Fri, Dec 21, 2012 at 10:35 PM, Doug Anderson diand...@chromium.org wrote: Vivek, Nothing really serious below and things look good to me, but figured I'd put a few nits in (sorry!). On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam gautam.vi...@samsung.com wrote: diff --git

[PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
/pipermail/linux-arm-kernel/2012-November/134476.html - http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/131763.html Vivek Gautam (1): usb: phy: samsung: Add support to set pmu isolation .../devicetree/bindings/usb/samsung-usbphy.txt | 31 drivers/usb/phy/samsung-usbphy.c

[PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/samsung-usbphy.txt | 31 drivers/usb/phy/samsung-usbphy.c | 145

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Vivek Gautam
Hi Sylwester, On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Hope these changes align

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-27 Thread Vivek Gautam
Hi Russell, On Thu, Dec 27, 2012 at 5:56 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 26, 2012 at 05:58:32PM +0530, Vivek Gautam wrote: + if (!ret) + sphy-phyctrl_pmureg = ioremap(reg[0], reg[1]); + + of_node_put(usbphy_pmu

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-27 Thread Vivek Gautam
Hi Sylwester, On Thu, Dec 27, 2012 at 4:00 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 12/26/2012 01:28 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek

[PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2012-12-28 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v4: - Added 'ranges' property to usbphy node, to iomap the child nodes's address space. - Using offset

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-03 Thread Vivek Gautam
Hi, On Fri, Dec 28, 2012 at 2:43 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Any further comments on this ? Or does

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-10 Thread Vivek Gautam
Hi Sylwester, On Thu, Jan 10, 2013 at 3:12 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi, On 12/28/2012 10:13 AM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-11 Thread Vivek Gautam
Hi Sylwester, On Fri, Jan 11, 2013 at 2:51 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 01/11/2013 09:08 AM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Vivek Gautam
, Vivek Gautam gautam.vi...@samsung.com wrote: This patch adds host phy support to samsung-usbphy.c and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings

[PATCH v6 1/4] ARM: EXYNOS: Update move usb-phy types to generic include layer

2013-01-11 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v5: - None drivers/usb/host

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-13 Thread Vivek Gautam
Hi Doug, On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson diand...@chromium.org wrote: Vivek, On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: +#define HOST_CTRL0_REFCLKSEL_MASK (0x3) +#define HOST_CTRL0_REFCLKSEL_XTAL (0x0 19

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
Hi Doug, On Mon, Jan 14, 2013 at 11:15 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Doug, On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson diand...@chromium.org wrote: Vivek, On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: +#define

[PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v6: - Changing macro names from

[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-14 Thread Vivek Gautam
or not. - Restructuring probe sequence for USB 3.0 phy, such that we are initializing only when device has usb3.0 type phy. Vivek Gautam (2): usb: phy: samsung: Common out the generic stuff usb: phy: samsung: Add PHY support for USB 3.0 controller drivers/usb/phy/Kconfig |8

[PATCH v3 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3.c | 349

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
in USB land. ;) In general things look pretty good here. :) One last comment below... On Fri, Jan 11, 2013 at 12:08 AM, Vivek Gautam gautam.vi...@samsung.com wrote: +static int samsung_usbphy_parse_dt(struct samsung_usbphy *sphy) +{ + struct device_node *usbphy_sys

[PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org --- Changes from v6

[PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250

2013-01-15 Thread Vivek Gautam
the patch ARM: Exynos5250: Enabling dwc3-exynos drive into clock patch and device enabling patch. - Rebased on top of 'for-next' of linux-samsung tree. Vivek Gautam (4): ARM: Exynos5250: Enabling ehci-s5p driver ARM: Exynos5250: Enabling ohci-exynos driver ARM: Exynos5250: Add clock

[PATCH v4 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- .../devicetree/bindings/usb/exynos-usb.txt

[PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-15 Thread Vivek Gautam
Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- .../devicetree/bindings/usb/exynos-usb.txt | 15

[PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-15 Thread Vivek Gautam
Adding necessary device clock to exynos5 needed for the DWC3 controller. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/mach-exynos/clock-exynos5.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/clock

[PATCH v4 4/4] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-01-15 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Also enabling XHCI support on exynos5250. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/exynos-usb.txt | 14 ++ arch/arm/boot/dts/exynos5250.dtsi

Re: [PATCH v4 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
On Tue, Jan 15, 2013 at 7:08 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant

[PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- Changes from v4: - Added gpio line for VBUS

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-16 Thread Vivek Gautam
Vivek Gautam wrote: Adding necessary device clock to exynos5 needed for the DWC3 controller. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/mach-exynos/clock-exynos5.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/arm

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-16 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 1:14 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote: Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com

Re: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Vivek Gautam
HI Kukjin, On Fri, Jan 18, 2013 at 6:46 AM, Kukjin Kim kgene@samsung.com wrote: Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Sylwester

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
Hi Felipe, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
HI Balbi, On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: Hi Felipe, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Vivek Gautam
Hi Alan, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: Adding the phy driver to ehci-s5p. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek

Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-20 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for Samsung's SoCs. - Moving the register definitions and strcuture definitions

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Fri, Jan 18, 2013 at 8:37 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: HI Balbi, On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: Hi Felipe

[PATCH] usb: phy: samsung: Remove __devinit, __devexit_p and __exit annotations

2013-01-21 Thread Vivek Gautam
Dropping __devinit, __devexit_p, __exit annotations since they are nop and no longer supported. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/samsung-usbphy.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/samsung-usbphy.c

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim kgene@samsung.com wrote: Sylwester Nawrocki wrote: On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug Andersondiand...@chromium.org Well, I have another idea

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Tue, Jan 22, 2013 at 10:36 AM, Kukjin Kim kgene@samsung.com wrote: Felipe Balbi wrote: On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: Hi, On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: This patch-set enables the samsung-usbphy driver

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Hi Felipe, On Tue, Jan 22, 2013 at 3:02 PM, Felipe Balbi ba...@ti.com wrote: HI, On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote: On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote

[PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
() -- keeping the place of clk_get intact and requesting driver data before that. Vivek Gautam (4): ARM: EXYNOS: Update move usb-phy types to generic include layer usb: phy: samsung: Add host phy support to samsung-phy driver USB: ehci-s5p: Add phy driver support USB: ohci-exynos

[PATCH v8 1/4] ARM: EXYNOS: Update move usb-phy types to generic include layer

2013-01-22 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com --- drivers

[PATCH v8 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-22 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com --- .../devicetree/bindings/usb

[PATCH v8 3/4] USB: ehci-s5p: Add phy driver support

2013-01-22 Thread Vivek Gautam
Adding the phy driver to ehci-s5p. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Kukjin Kim kgene

[PATCH v8 4/4] USB: ohci-exynos: Add phy driver support

2013-01-22 Thread Vivek Gautam
Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Kukjin Kim

[PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-22 Thread Vivek Gautam
- Aligning as per the patch: usb: phy: samsung: Add support to set pmu isolation - Replaced phy-handle approach for PHY CONTROL registers to child nodes. - Removing AUX data entry from exynos5250 dt file. Vivek Gautam (2): ARM: Exynos5250: Enabling samsung-usbphy driver ARM: Exynos5250

[PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-22 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi all, On Wed, Jan 23, 2013 at 3:20 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: Felipe Balbi wrote: Hi, Hi Felipe, [...] Right, DWC has version number, but that being the kind of USB controller (USB 2.0 and USB 3.0)

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-23 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Tomasz, On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Don't you need also some clkdev lookup entry to make the clock available in the driver? This clock

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi Sylwester, On Wed, Jan 23, 2013 at 6:10 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: - { .compatible = samsung,exynos-dwc3 }, + { .compatible = samsung,synopsis-dwc3 } You're both missing a point here. The synopsys IP

[PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-24 Thread Vivek Gautam
-dwusb3 as per discussion happened in thread: [PATCH 0/2] usb: exynos: Fix compatible strings used for device. Vivek Gautam (2): usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device usb: dwc3-exynos: Fix compatible strings for the device drivers/usb/dwc3/dwc3-exynos.c

[PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device

2013-01-24 Thread Vivek Gautam
Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Doug Anderson diand...@chromium.org --- drivers/usb/host/ehci

[PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2013-01-24 Thread Vivek Gautam
Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Doug Anderson diand...@chromium.org --- drivers/usb/dwc3/dwc3

Re: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-24 Thread Vivek Gautam
On Thu, Jan 24, 2013 at 7:15 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using chip specific compatible string as it should be. So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos which till now used a generic 'exynos' in their compatible strings. Changes from v1

[PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-28 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file samsung-usbphy.c. Also renaming the usb 2.0 phy driver to samsung-usb2.c Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v3: - Using

[PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v3: - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since dwc3 controller also looks for USB2

[PATCH 0/4] usb: dwc3/xhci: Enable runtime power management

2013-01-28 Thread Vivek Gautam
: Add PHY support for USB 3.0 controller Vivek Gautam (4): usb: xhci: Enable runtime pm in xhci-plat USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend usb: dwc3: exynos: Enable runtime power management usb: phy: samsung: Enable runtime power management on samsung-usb3

[PATCH 1/4] usb: xhci: Enable runtime pm in xhci-plat

2013-01-28 Thread Vivek Gautam
By enabling runtime pm in this driver is allows users of xhci-plat to enter into runtime pm. This is not full runtime pm support (AKA xhci-plat doesn't actually power anything off when in runtime suspend mode) but just basic enablement. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Signed

[PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
on the DWC3 device in that the port isn't put into a lower power mode when not used. However it does allow users of dwc3 (like dwc3-exynos) to do some amount of runtime power management. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Signed-off-by: Doug Anderson diand...@chromium.org --- drivers

[PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Enabling runtime power management on dwc3-exynos to save power and allow its PHY's power to be managed at runtime. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/dwc3/dwc3-exynos.c | 47 1 files changed, 47 insertions(+), 0

[PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Enabling runtime power management support on samsung-usb3 phy and further adding support to turn off the PHY ref_clk PLL. It thereby requires PHY ref_clk to be switched between internal core clock and external PLL clock. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Hi Balbi, On Mon, Jan 28, 2013 at 5:17 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jan 28, 2013 at 05:12:27PM +0530, Vivek Gautam wrote: Enabling runtime power management on dwc3-exynos to save power and allow its PHY's power to be managed at runtime. Signed-off-by: Vivek Gautam gautam.vi

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
On Mon, Jan 28, 2013 at 5:42 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote: +static int dwc3_exynos_runtime_resume(struct device *dev) +{ + struct dwc3_exynos *exynos = dev_get_drvdata(dev); + struct platform_device

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:39 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jan 28, 2013 at 05:12:28PM +0530, Vivek Gautam wrote: Enabling runtime power management support on samsung-usb3 phy and further adding support to turn off the PHY ref_clk PLL. It thereby requires PHY

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 6:37 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote: @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct samsung_usbphy *sphy) return reg; } -static int

Re: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote: The current code in the dwc3 probe effectively disables runtime pm from ever working because it calls a get() that was never put() until device removal

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
CC: Doug Anderson On Mon, Jan 28, 2013 at 3:56 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v3: - Making SAMSUNG_USB3PHY dependent

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-28 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Tomasz, On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Don't you need also some clkdev lookup entry to make the clock available in the driver? This clock

[PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
This change de-asserts vbus_gpio on suspend and re-asserts on resume in order to save power. NOTE, this change means no USB charging in suspend mode. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com CC: Doug Anderson diand...@chromium.org --- Based on 'usb-next'. drivers/usb/host/ehci

Re: [PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
Hi Oliver, On Tue, Jan 29, 2013 at 5:07 PM, Oliver Neukum oneu...@suse.de wrote: On Tuesday 29 January 2013 16:22:45 Vivek Gautam wrote: This change de-asserts vbus_gpio on suspend and re-asserts on resume in order to save power. NOTE, this change means no USB charging in suspend mode

Re: [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-29 Thread Vivek Gautam
On Tue, Jan 22, 2013 at 9:01 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Changes from v1: - Putting separate device nodes for usb 2.0 phy and usb 3.0 phy based on separate driver for samsung usb 3.0 phy and samsung usb 2.0 phy: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-30 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 10:36 AM, Kukjin Kim kgene@samsung.com wrote: Vivek Gautam wrote: Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 15

[PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
platform specific device tree node. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Based on 'usb-next'. drivers/usb/dwc3/core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 094..75439c0 100644

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Kishon, On Thu, Jan 31, 2013 at 5:04 PM, kishon kis...@ti.com wrote: Hi, Thanks for your quick help. On Thursday 31 January 2013 04:50 PM, Vivek Gautam wrote: With device tree support in place for dwc3-core layer, it gets PHY from synopsis-dwc3 node. Some controllers may not have

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Felipe, On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: Moreover, SoCs having multiple dwc3 controllers will have multiple PHYs, which eventually be added using usb_add_phy_dev(), and not using

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Kishon, On Fri, Feb 1, 2013 at 10:51 AM, kishon kis...@ti.com wrote: Hi, On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: Hi Felipe, On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi ba...@ti.com wrote: Hi

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Balbi, On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Kishon, On Fri, Feb 1, 2013 at 10:51 AM, kishon kis...@ti.com wrote: Hi, On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-01 Thread Vivek Gautam
On Fri, Feb 1, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Feb 01, 2013 at 11:54:01AM +0530, Vivek Gautam wrote: Hi Balbi, On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Kishon, On Fri, Feb 1, 2013 at 10:51 AM, kishon kis...@ti.com

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Fri, Feb 1, 2013 at 3:56 AM, Kukjin Kim kgene@samsung.com wrote: Tomasz Figa wrote: Hi Vivek, [...] + usb@1212 { + compatible = samsung,exynos4210-ohci; + reg = 0x1212 0x100; + interrupts = 0 71 0; For Samsung platforms we

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:31 AM, Kukjin Kim kgene@samsung.com wrote: Vivek Gautam wrote: Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v3: - Making SAMSUNG_USB3PHY dependent

[PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-05 Thread Vivek Gautam
to samsung-usb3phy.c - Removing dependencies for SAMSUNG_USB2PHY and SAMSUNG_USB3PHY. - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select SAMSUNG_USBPHY, which is the usb-phy helper driver. Vivek Gautam (2): usb: phy: samsung: Common out the generic stuff usb: phy: samsung: Add PHY support

[PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-05 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common phy helper driver under SAMSUNG_USBPHY, and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb

[PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-05 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c | 349

[PATCH v3 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-02-05 Thread Vivek Gautam
] Adding usb2.0 host-phy support for exynos5250 - Aligning as per the patch: usb: phy: samsung: Add support to set pmu isolation - Replaced phy-handle approach for PHY CONTROL registers to child nodes. - Removing AUX data entry from exynos5250 dt file. Vivek Gautam (2): ARM: Exynos5250

[PATCH v3 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 3.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff

<    1   2   3   4   5   6   7   >