Re: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD

2016-01-06 Thread Bjorn Helgaas
q cascade handlers IRQF_NO_THREAD explicitly. > > [1] https://lkml.org/lkml/2015/11/20/356 > > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Jingoo Han <jingooh...@gmail.com> > Cc: Kukjin Kim <kg...@

Re: [PATCH] PCI: designware: bail out if host_init failed

2015-11-25 Thread Bjorn Helgaas
Hi Jisheng, On Thu, Nov 12, 2015 at 09:48:45PM +0800, Jisheng Zhang wrote: > There's no reason to continue the initialization such as configure > register, scan root bus etc. if customized host_init() failed. This > patch tries to check the host_init result, bail out if failed. This patch

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-06-03 Thread Bjorn Helgaas
On Tue, Jun 3, 2014 at 7:22 AM, Lucas Stach l.st...@pengutronix.de wrote: Hello Bjorn, Am Freitag, den 30.05.2014, 11:30 -0600 schrieb Bjorn Helgaas: On Mon, May 12, 2014 at 10:59:43AM +0200, Lucas Stach wrote: Hi Bjorn, just a friendly reminder. It would be nice if you could pull those

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-05-30 Thread Bjorn Helgaas
there was enough discussion that I expected a re-post, so it wasn't on my radar screen anymore. Bjorn Am Dienstag, den 29.04.2014, 14:31 +0200 schrieb Lucas Stach: Hi Bjorn, Am Freitag, den 25.04.2014, 08:39 -0600 schrieb Bjorn Helgaas: [...] PCI: designware: split Exynos and i.MX bindings

Re: [PATCH 1/1] PCI: exynos: Fix section mismatch warning

2014-05-29 Thread Bjorn Helgaas
On Wed, May 28, 2014 at 03:18:45PM +0530, Sachin Kamat wrote: add_pcie_port is called from probe which is annotated with __init. add_pcie_port calls dw_pcie_host_init which is also annotated with __init. Thus it makes sense to annotate add_pcie_port with __init to avoid the following section

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-04-25 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 4:21 AM, Lucas Stach l.st...@pengutronix.de wrote: Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: While working on MSI support for the i.MX6 PCIe host driver it has been discovered

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-04-24 Thread Bjorn Helgaas
On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: While working on MSI support for the i.MX6 PCIe host driver it has been discovered that the binding for this host controller is broken in many ways (refer to the patch descriptions for more info) and was introduced without proper

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

2014-04-16 Thread Bjorn Helgaas
On Wed, Apr 16, 2014 at 10:20:45AM +0200, Lucas Stach wrote: Am Dienstag, den 15.04.2014, 12:30 -0600 schrieb Bjorn Helgaas: On Tue, Apr 15, 2014 at 12:07:34PM +0200, Lucas Stach wrote: Hi Bjorn, Am Freitag, den 04.04.2014, 10:55 -0600 schrieb Bjorn Helgaas: On Wed, Mar 05, 2014

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

2014-04-15 Thread Bjorn Helgaas
On Tue, Apr 15, 2014 at 12:07:34PM +0200, Lucas Stach wrote: Hi Bjorn, Am Freitag, den 04.04.2014, 10:55 -0600 schrieb Bjorn Helgaas: On Wed, Mar 05, 2014 at 02:25:47PM +0100, Lucas Stach wrote: This is the recommended method of doing the IRQ mapping. For old devicetrees we fall back

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

2014-04-04 Thread Bjorn Helgaas
On Wed, Mar 05, 2014 at 02:25:47PM +0100, Lucas Stach wrote: This is the recommended method of doing the IRQ mapping. For old devicetrees we fall back to the previous practice. Signed-off-by: Lucas Stach l.st...@pengutronix.de Acked-by: Arnd Bergmann a...@arndb.de Applied with Stephen's

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-04 Thread Bjorn Helgaas
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: - return pp-irq; + irq = of_irq_parse_and_map_pci(dev, slot, pin); + if (!irq) + irq = pp-irq; In light of the two bugs that Tim found, it might

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-04 Thread Bjorn Helgaas
On Fri, Apr 04, 2014 at 11:03:41AM -0600, Bjorn Helgaas wrote: On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote: On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote: - return pp-irq; + irq = of_irq_parse_and_map_pci(dev, slot, pin); + if (!irq) + irq

Re: [PATCH] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers

2013-12-12 Thread Bjorn Helgaas
On Thu, Dec 12, 2013 at 12:00 AM, Shawn Guo shawn@linaro.org wrote: Hi Bjorn, On Wed, Dec 11, 2013 at 11:32:37AM -0700, Bjorn Helgaas wrote: +PCI DRIVER FOR IMX6 +M: Shawn Guo shawn@linaro.org Thanks for the nomination. But I think a better person for this position would

[PATCH v2] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers

2013-12-12 Thread Bjorn Helgaas
[+cc Thomas] On Wed, Dec 11, 2013 at 11:32:37AM -0700, Bjorn Helgaas wrote: If this looks reasonable, I'll merge it via the PCI tree for v3.13. OK, here's another try. I'm not actually trying to nominate anybody; I just tried to write down the list we came up with in an earlier discussion [1

[PATCH] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers

2013-12-11 Thread Bjorn Helgaas
If this looks reasonable, I'll merge it via the PCI tree for v3.13. Bjorn MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers Add entries for PCI host controller drivers in drivers/pci/host/. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- MAINTAINERS | 31

Re: [PATCH V2] PCI: designware: Add irq_create_mapping()

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 6:32 AM, Jingoo Han jg1@samsung.com wrote: From: Pratyush Anand pratyush.an...@st.com Without irq_create_mapping(), the correct irq number cannot be provided. In this case, it makes problems such as NULL deference. Thus, irq_create_mapping() should be added for MSI.

Re: [PATCH] PCI: exynos: missing clk_disable_unprepare() on error in exynos_pcie_probe()

2013-10-04 Thread Bjorn Helgaas
On Sun, Sep 29, 2013 at 10:29:11AM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing clk_disable_unprepare() before return from exynos_pcie_probe() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Applied with

Re: [PATCH] MAINTAINERS: add maintainer entry for Samsung Exynos PCIe driver

2013-09-27 Thread Bjorn Helgaas
On Thu, Sep 12, 2013 at 5:29 AM, Jingoo Han jg1@samsung.com wrote: Add myself as maintainer for Samsung Exynos PCIe driver. Signed-off-by: Jingoo Han jg1@samsung.com Applied to my pci/host-exynos branch for v3.13. Thanks! --- MAINTAINERS |6 ++ 1 file changed, 6

Re: [PATCH V3] PCI: exynos: add support for MSI

2013-09-27 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 12:54 AM, Jingoo Han jg1@samsung.com wrote: This patch adds support for Message Signaled Interrupt in the Exynos PCIe diver using Synopsys designware PCIe core IP. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Srikanth T Shivanand

Re: [PATCH] PCI: exynos: turn off power of phy block when link failed

2013-09-27 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 2:21 AM, Jingoo Han jg1@samsung.com wrote: When link failed, there is no need to turn on phy block. Also, turning on phy block is added, in order to turn on phy block regardless of the default value of phy registers. Signed-off-by: Jingoo Han jg1@samsung.com

Re: [PATCH V3] PCI: exynos: add support for MSI

2013-09-25 Thread Bjorn Helgaas
...@samsung.com Signed-off-by: Srikanth T Shivanand ts.srika...@samsung.com Signed-off-by: Jingoo Han jg1@samsung.com Cc: Pratyush Anand pratyush.an...@st.com Cc: Mohit KUMAR mohit.ku...@st.com Hi Bjorn Helgaas, There is no comment for last 3 weeks. Would you merge this patch to your tree

Re: [PATCH V5] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-08-07 Thread Bjorn Helgaas
Hi Bjorn Helgaas, There is no comment for last 2 weeks. Will you accept this patch? I don't have any problem with this, since it's really arch code. Do you want me to merge it, or do you have a standard path for merging Exynos and/or Designware changes? Bjorn In case you need it: Acked

Re: [PATCH V10 1/4] pci: Add PCIe driver for Samsung Exynos

2013-06-24 Thread Bjorn Helgaas
siva.kal...@samsung.com Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Bjorn Helgaas bhelg...@google.com Please merge this through arm-soc as you discussed. --- .../devicetree/bindings/pci/designware-pcie.txt| 73 ++ drivers/pci/host