Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-26 Thread D Krishna Mohan
FYI your Suggestion was: You need to add an ifdef around the struct (or perhaps a __maybey_unused type annotation if there's something suitable) for such configurations. Following your suggestion I have sent a patch (187024b36c635bd454c1b1587b58c9439d3a46ad on your git, branch: rt5631 )

Re: [PATCH 2/4 V3] ASoC: Samsung: Add arndale_rt5631 machine driver

2014-11-23 Thread D Krishna Mohan
machine DT binding file added and patch sent. -Krishna -- From: Mark Brown broo...@kernel.org Sent: Wednesday, November 19, 2014 11:21 PM To: Krishna Mohan Dani krishna...@samsung.com Cc: linux-samsung-soc@vger.kernel.org;

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-23 Thread D Krishna Mohan
Attaching the patch with changes suggested by Uwe. Though there is another patch which I submitted, but I leave it to Mark Brown as to which patch to pick. Previous patch : From 80b55f898d0a31b63fd6ed3bd82c548a0559b07b Mon Sep 17 00:00:00 2001 From: Krishna Mohan Dani krishna...@samsung.com

Re: [PATCH 2/4 V2] ASoC: Samsung: Add arndale_rt5631 machine driver

2014-11-13 Thread D Krishna Mohan
-- From: Mark Brown broo...@kernel.org Sent: Thursday, November 13, 2014 3:59 AM To: Krishna Mohan Dani krishna...@samsung.com Cc: linux-samsung-soc@vger.kernel.org; linux-arm-ker...@lists.infradead.org; alsa-de...@alsa-project.org;

Re: [PATCH 1/4] ASoC: ALC5631: Add device tree binding documentation

2014-11-10 Thread D Krishna Mohan
Hi Mark Brown, The codec driver is present in mainline as rt5631.c., Its realtek's alc5631 so retained that name. Similarly machine driver also is named as arndale_rt5631.c but inside that driver I have used alc5631 naming as the audio daughter card on arndale board mentions alc5631 so I