driver.
For both patches:
Reviewed-by: Daniel Kurtz
> ---
> drivers/spi/spi-s3c24xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c
> index f747ca2..f36bc32 100644
> --- a/drivers/spi/spi-s3c24xx.c
> +++ b/dri
On Fri, Jun 20, 2014 at 7:59 AM, Siarhei Siamashka
wrote:
>
> On Fri, 4 Apr 2014 17:22:01 +0800
> Daniel Kurtz wrote:
>
> > Kernel access to the eyxnos fbdev framebuffer is via its gem object's
> > kernel mapping (kvaddr, stored in info->screen_base).
> >
Hi YoungJun,
I am not famiilar with i80. Reading through this patch, it looks like
it works something like below for a page flip...
-> page_flip ioctl
exynos_drm_crtc_page_flip()
exynos_drm_crtc_mode_set_commit()
exynos_plane_mode_set()
exynos_drm_crtc_commit()
exynos_plane_commi
On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma wrote:
>
> Hi Inki,
>
> Please review this patch.
>
> Regards,
> Rahul Sharma
>
> On 23 May 2014 17:17, Rahul Sharma wrote:
> > From: Rahul Sharma
> >
> > Fimd probe is accessing fimd Registers without enabling the fimd
> > gate clocks. If FIMD clock
On Wed, May 21, 2014 at 2:28 PM, YoungJun Cho wrote:
> Hi Daniel
>
>
> On 05/21/2014 03:01 PM, Daniel Kurtz wrote:
>>
>> On Wed, May 21, 2014 at 12:42 PM, YoungJun Cho
>> wrote:
>>>
>>> There could be the case that the page flip operation isn
On Wed, May 21, 2014 at 12:42 PM, YoungJun Cho wrote:
> There could be the case that the page flip operation isn't finished correctly
> with some abnormal condition such as panel reset. So this patch replaces
> wait_event() with wait_event_timeout() to avoid waiting for page flip
> completion
> i
On Wed, May 14, 2014 at 2:26 PM, YoungJun Cho wrote:
>
> There could be the case that the page flip operation isn't finished correctly
> with some abnormal condition such as panel reset. So this patch replaces
> wait_event() with wait_event_timeout() to avoid waiting for page flip
> completion
>
On Thu, May 8, 2014 at 12:33 PM, Seung-Woo Kim wrote:
>
> Hello Daniel,
>
> On 2014년 05월 07일 23:14, Daniel Kurtz wrote:
> > On Wed, May 7, 2014 at 1:14 PM, Seung-Woo Kim
> > wrote:
> >> Hi Daniel,
> >>
> >> On 2014년 05월 05일 00:26, Daniel Kurtz
On Wed, May 7, 2014 at 1:14 PM, Seung-Woo Kim wrote:
> Hi Daniel,
>
> On 2014년 05월 05일 00:26, Daniel Kurtz wrote:
>> Mixer hardware supports offsetting dma from start of source buffer using
>> the MXR_GRP_SXY register.
>>
>> Signed-off-by: Daniel Kurtz
These constants directly define register values, so move them to the
register definition header.
Also, the logic used for setting fmt from bpp is either/or, so just use
if/else.
** No functional change
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_mixer.c | 19
Mixer hardware supports offsetting dma from start of source buffer using
the MXR_GRP_SXY register.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers
the driver does not actually supported single-buffer formats,
buf_num will always be 2, and we drop the broken 1-buffer case.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_mixer.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/
AFAICT, the only difference between NV12 and NV21 is Cr:Cb vs Cb:Cr.
Since the video processor can handle either order, it should be able to
handle both formats.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 1 +
drivers/gpu/drm/exynos/exynos_mixer.c | 12
I don't actually have a way of testing the video processor changes, but they
seem correct from looking at the code. Hopefully someone has a way of testing
them.
Daniel Kurtz (4):
drm/exynos/mixer: move format definitions to regs-mixer
drm/exynos/mixer: use MXR_GRP_SXY_SY
drm/exynos/
y to set fix->smem_{start,len} or
fix->mmio_{start,len} fields.
This avoids leaking kernel, physical and dma mapped addresses to user
space via the ioctls FBIOGET_VSCREENINFO and FBIOGET_FSCREENINFO.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 7 ---
1 f
o this is just wrong.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 2dcc589..3270a36 100644
--- a/drivers/gpu/drm/exynos/exyn
On Tue, Mar 18, 2014 at 2:08 PM, Inki Dae wrote:
> 2014-03-18 14:45 GMT+09:00 Kukjin Kim :
>> Inki Dae wrote:
>>>
>>> Applied.
>>>
>>> Thanks,
>>> Inki Dae
>>>
>>> 2014-03-17 12:28 GMT+09:00 Daniel Kurtz :
>>>
The following commit [0] fixed a use-after-free, but left the subdrv open
in the error path.
[0] commit 6ca605f7c70895a35737435f17ae9cc5e36f1466
drm/exynos: Fix freeing issues in exynos_drm_drv.c
Signed-off-by: Daniel Kurtz
---
Hi, I noticed this when reviewing some recent patches.
I am only
The following commit [0] fixed a use-after-free, but left the subdrv open
in the error path.
[0] commit 6ca605f7c70895a35737435f17ae9cc5e36f1466
drm/exynos: Fix freeing issues in exynos_drm_drv.c
Change-Id: I452e944bf090fb11434d9e34213c890c41c15d73
Signed-off-by: Daniel Kurtz
---
drivers/gpu
e non-sync blank period to the back porch, and the remainder to the
front porch.
With your follow-on commit message added, this is:
Reviewed-by: Daniel Kurtz
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 ---
>> 1 file changed, 4 insertions(+), 7 deletions(-)
>&
On Tue, Dec 17, 2013 at 11:12 PM, Daniel Drake wrote:
>
> On Mon, Dec 16, 2013 at 5:40 PM, Daniel Vetter wrote:
> > Have a bit of logic in the exynos ->detect function to re-try a 2nd
> > round of edid probing after each hdp interrupt if the first one
> > returns an -ENXIO. Only tricky part is to
Hi Tomasz,
Thank you for the reviews.
On Dec 9, 2013 5:15 AM, "Tomasz Figa" wrote:
>
> Hi Daniel,
>
> On Thursday 21 of November 2013 02:21:24 Daniel Kurtz wrote:
> > These tables are all immutable, make them const to save 4416 bytes of RAM.
> >
> > siz
The clksrc tables are constant, they are not used to store register values
at suspend.
size arch/arm/mach-exynos/pm.o
textdata bss
1591 212 12// Before
1671 132 12// After
Signed-off-by: Daniel Kurtz
---
arch/arm/mach-exynos/pm.c | 4 ++--
1 file
The restore functions do not modify the passed in struct sleep_save,
so that parameter can be const.
This allows us to pass in const struct. This allows us to use const
structs sleep_save to define system registers that will always be
restored to a constant value.
Signed-off-by: Daniel Kurtz
These tables are all immutable, make them const to save 4416 bytes of RAM.
size arch/arm/mach-exynos/pmu.o
textdata bss
8484420 4 // before
5264 4 4 // after
Signed-off-by: Daniel Kurtz
---
arch/arm/mach-exynos/pmu.c | 14
Hi Mark,
On Tue, Nov 20, 2012 at 12:49 PM, Mark Brown
wrote:
>
> On Thu, Nov 15, 2012 at 05:43:32PM +0530, Naveen Krishna Chatradhi wrote:
>
> > + iicstat = readl(i2c->regs + S3C2410_IICSTAT);
> > + delay = 1;
> > + while ((iicstat & S3C2410_IICSTAT_START) &&
> > +ktime_us
chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
There is no need to also explicitly do it in the handler.
Signed-off-by: Daniel Kurtz
---
arch/arm/mach-exynos/common.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-ex
27 matches
Mail list logo