Re: [PATCHv8 07/15] cec: add HDMI CEC framework

2015-08-18 Thread Dmitry Torokhov
On Tue, Aug 18, 2015 at 11:00:20AM +0100, Russell King - ARM Linux wrote: On Tue, Aug 18, 2015 at 10:26:32AM +0200, Hans Verkuil wrote: + /* Part 2: Initialize and register the character device */ + cdev_init(cecdev-cdev, cec_devnode_fops); + cecdev-cdev.owner = owner; + + ret =

Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes

2015-06-30 Thread Dmitry Torokhov
On Tue, Jun 30, 2015 at 09:36:49AM +0200, Hans Verkuil wrote: On 06/29/15 21:25, Dmitry Torokhov wrote: On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil

Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes

2015-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski ka...@wypas.org Signed-off-by: Hans Verkuil hans.verk...@cisco.com Could you please describe the intended

Re: [PATCHv7 05/15] input.h: add BUS_CEC type

2015-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2015 at 12:14:50PM +0200, Hans Verkuil wrote: Inputs can come in over the HDMI CEC bus, so add a new type for this. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- include/uapi/linux/input.h | 1 + 1 file changed

Re: [PATCH 01/10] Input: s3c2410_ts: fix S3C_ADC dependency

2015-03-04 Thread Dmitry Torokhov
a...@arndb.de Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 58917525126e..3b4cd9ab1af0 100644 --- a/drivers

Re: [PATCH 06/10] iio: exynos-adc: add experimental touchscreen support

2015-03-04 Thread Dmitry Torokhov
support for s3c64xx, so any help in testing is very much appreciated. The current version uses the IS_REACHABLE() that is going to be introduced in the linux-media tree, please comment this out for testing. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Dmitry Torokhov dmitry.torok

Re: [PATCH 00/10] ARM: s3c64xx multiplatform, help needed

2015-03-02 Thread Dmitry Torokhov
On Mon, Mar 02, 2015 at 01:35:53PM +0100, Arnd Bergmann wrote: Hi everyone, I've had these patches in a private git tree for a while, and have finally gotten around to clean them up some more for submission. Hopefully we can get all of it merged into 4.1. I've done this to the best of my

[PATCH] mmc: dw_mmc: exynos: remove incorrect __exit_p()

2015-01-23 Thread Dmitry Torokhov
dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/mmc/host/dw_mmc-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc

Re: [PATCH v7 1/3] Input: add regulator haptic driver

2014-12-17 Thread Dmitry Torokhov
of yours? Thanks. -- Dmitry Input: regulator-haptics - misc changes From: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/misc/Kconfig|4 - drivers/input/misc/regulator-haptic.c | 164

Re: [PATCH v7 1/3] Input: add regulator haptic driver

2014-12-17 Thread Dmitry Torokhov
On Thursday, December 18, 2014 10:17:42 AM Jaewon Kim wrote: Hi Dmity, 2014년 12월 18일 07:06에 Dmitry Torokhov 이(가) 쓴 글: HI Jaewon, On Wed, Dec 17, 2014 at 12:35:06PM +0900, Jaewon Kim wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver

[PATCH] cpufreq: exynos5440: protect call to dev_pm_opp_get_opp_count with RCU lock

2014-12-15 Thread Dmitry Torokhov
dev_pm_opp_get_opp_count() must be called with RCU lock held. Signed-off-by: Dmitry Torokhov d...@chromium.org --- Again, not tested... drivers/cpufreq/exynos5440-cpufreq.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq

Re: [PATCH v6 1/2] Input: add regulator haptic driver

2014-12-15 Thread Dmitry Torokhov
On Tue, Dec 16, 2014 at 10:09:25AM +0900, Jaewon Kim wrote: Hi Dmitry, 2014년 12월 14일 04:56에 Dmitry Torokhov 이(가) 쓴 글: Hi Jaewon, On Fri, Dec 12, 2014 at 07:32:28PM +0900, Jaewon Kim wrote: ... +static int __maybe_unused regulator_haptic_suspend(struct device *dev) +{ + struct

Re: [PATCH v6 1/2] Input: add regulator haptic driver

2014-12-13 Thread Dmitry Torokhov
Hi Jaewon, On Fri, Dec 12, 2014 at 07:32:28PM +0900, Jaewon Kim wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework Signed-off-by: Jaewon Kim jaewon02@samsung.com Signed-off-by:

Re: [PATCH v4 1/2] Input: add regulator haptic driver

2014-12-02 Thread Dmitry Torokhov
Hi Jaewon, On Mon, Dec 01, 2014 at 11:11:12AM +0900, Jaewon Kim wrote: This patch adds support for haptic driver controlled by voltage of regulator. And this driver support for Force Feedback interface from input framework Signed-off-by: Jaewon Kim jaewon02@samsung.com Signed-off-by:

Re: [PATCH 1/3] PM / Domains: Initial PM clock support for genpd

2014-11-19 Thread Dmitry Torokhov
On Wed, Nov 19, 2014 at 03:00:36PM +0100, Ulf Hansson wrote: It's quite common for PM domains to use PM clocks. Typically from SOC specific code, the per device PM clock list is created and pm_clk_suspend|resume() are invoked to handle clock gating/ungating. A step towards consolidation is

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 11:13:28AM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: However, is it allowed to call pm_runtime_get_sync() on devices that didn't issue pm_runtime_enable()? Yes. But the bus has to issue pm_runtime_enable() before probing

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question then: pm_runtime_get_noresume() does literally this: atomic_inc(dev-power.usage_count); So who is responsible for actually waking up parent device

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 09:55:15 AM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 12:44:22PM -0500, Alan Stern wrote: On Tue, 18 Nov 2014, Dmitry Torokhov wrote: OK. Another question

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 12:04:38 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 09:14:56PM +0100, Rafael J. Wysocki wrote: On Tuesday, November

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 10:58:17PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 01:02:29 PM Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 10:17:46PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 18, 2014 10:03:18 PM Rafael J. Wysocki wrote: On Tuesday, November

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 11:06 AM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 17 Nov 2014, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The amba bus, amba drivers and a vast amount of platform drivers which enables runtime PM, don't invoke a

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler. The bus does _get_noresume() to make sure the device won't be runtime suspended while the probe routine is running

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 03:49:14PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: For devices that aren't part of a power domain, things are simpler

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 04:44:56PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: When the runtime PM core invokes a power domain's callback routine, what does the domain's routine usually do? Does it go ahead and invoke the driver's callback? Or does it try

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call pm_generic_runtime_resume() which ends up fetching driver's callbacks. Maybe pm_generic_runtime_*() need be a bit smarter? No, the bus subsystem

Re: [PATCH] PM / Domains: Power on the PM domain right after attach completes

2014-11-17 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 12:28:26AM +0100, Rafael J. Wysocki wrote: On Monday, November 17, 2014 02:17:00 PM Dmitry Torokhov wrote: On Mon, Nov 17, 2014 at 05:12:35PM -0500, Alan Stern wrote: On Mon, 17 Nov 2014, Dmitry Torokhov wrote: Except buses usually call

[PATCH] [media] exynos4-is: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org --- Not tested, found by casual code inspection. drivers/media/platform/exynos4-is/fimc-is.c | 4 ++-- 1 file changed

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Dmitry Torokhov
On Mon, Nov 10, 2014 at 04:18:50PM +0100, Ulf Hansson wrote: [...] I guess we do need it for 3.18, but when we are talking about 3.19, before we make any more changes can we outline how power domains are supposed to work? 1. How do we attach a device to power domain? Right now it

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Dmitry Torokhov
On November 10, 2014 11:39:31 AM PST, Mark Brown broo...@kernel.org wrote: On Mon, Nov 10, 2014 at 10:32:24AM -0800, Dmitry Torokhov wrote: - I do not see why sirincling platform specific code around i2c, spi, etc bus code (which is not platform-specific) is OK, but a no-no for the driver

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Dmitry Torokhov
On Fri, Nov 07, 2014 at 11:47:53AM -0800, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The initial state of the device's need_restore flag should'nt depend on the current state of the PM domain. For example it should be perfectly valid to attach an inactive device to a

Re: [PATCH 03/21] thermal: of: Extend of-thermal.c to provide number of non critical trip points

2014-11-07 Thread Dmitry Torokhov
Hi Lukasz, On Fri, Nov 7, 2014 at 2:05 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Eduardo, On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote: This patch extends the of-thermal.c to provide information about number of available non critical (i.e. non HW) trip points

Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot

2014-11-04 Thread Dmitry Torokhov
On Tue, Nov 04, 2014 at 09:54:19AM +0100, Ulf Hansson wrote: [...] Generally, there are two or even three levels of runtime PM handling, driver, (possibly) bus type and (possibly) PM domain (and multiple levels of these are possible in principle). All of them have to be initialized at

Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot

2014-11-04 Thread Dmitry Torokhov
On Tue, Nov 04, 2014 at 06:01:44PM +0100, Ulf Hansson wrote: Devices that are created while discoverable buses are being probed can't be attached to a PM domain before the probing is done, because those simply doesn't exist. Honestly, I'm not sure what you're talking about. Devices

Re: [PATCH] PM / Domains: Change prototype for the -attach_dev() callback

2014-11-04 Thread Dmitry Torokhov
On Thu, Oct 30, 2014 at 01:38:30PM -0700, Kevin Hilman wrote: Rafael J. Wysocki r...@rjwysocki.net writes: On Thursday, October 30, 2014 01:02:49 PM Ulf Hansson wrote: Convert the prototype to return and int. This is just an initial step, needed to support error handling.

Re: [PATCH] PM / Domains: Change prototype for the -attach_dev() callback

2014-11-04 Thread Dmitry Torokhov
On Wed, Nov 05, 2014 at 08:43:29AM +0100, Geert Uytterhoeven wrote: On Wed, Nov 5, 2014 at 2:33 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Oct 30, 2014 at 01:38:30PM -0700, Kevin Hilman wrote: Rafael J. Wysocki r...@rjwysocki.net writes: On Thursday, October 30, 2014

Re: [PATCH v3 4/9] drivercore / platform: Keep PM domain powered during -probe()

2014-10-30 Thread Dmitry Torokhov
On Thu, Oct 30, 2014 at 01:47:27PM -0700, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: To sucessfully probe some devices their corresponding PM domains may need to be powered. Isn't that what pm_runtime_get*() is supposed to be doing? Why isn't that working? Also, I

Re: [PATCH 2/2] input: cros_ec_keyb: Add of match table

2014-10-08 Thread Dmitry Torokhov
On Fri, Sep 19, 2014 at 10:08:13AM +0200, Sjoerd Simons wrote: To enable the cros_ec_keyb driver to be auto-loaded when build as module add an of match table (and export it) to match the modalias information passed on to userspace as the Cros EC MFD driver registers the MFD subdevices with an

Re: [PATCH] Input: atmel_mxt_ts - fix merge in DT documentation

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 03:52:46PM +0100, Nick Dyer wrote: On 15/08/14 17:13, Stephen Warren wrote: Any comments on this? I would really appreciate if you can expand on how this DT property is supposed to be used so I can re-spin the atmel support patch for Peach boards. The below patch

Re: [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad

2014-09-10 Thread Dmitry Torokhov
but adapted to use the mainline Atmel maXTouch DT binding. Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Changes since v3: - Use KEY_RESERVED

Re: [PATCH v4 2/3] ARM: dts: Add Peach Pi dts entry for Atmel touchpad

2014-09-10 Thread Dmitry Torokhov
binding. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk This one looks fine to me as well. Reviewed-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH v2 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm.

2014-09-03 Thread Dmitry Torokhov
On Mon, Aug 25, 2014 at 03:40:08PM +0200, Javier Martinez Canillas wrote: From: Todd Broch tbr...@chromium.org Previous algorithm was a bit conservative and complicating with respect to identifying key ghosting. This CL uses the bitops hamming weight function (hweight8) to count the number

Re: [PATCH v2 0/7] Second batch of cleanups for cros_ec

2014-08-25 Thread Dmitry Torokhov
On Mon, Aug 25, 2014 at 03:40:01PM +0200, Javier Martinez Canillas wrote: This is a second batch of cleanups patches for the mfd cros_ec driver and its subdevices drivers. The first batch of cleanups was posted by Doug Anderson [0] and have already been merged. The patches were picked from the

Re: [PATCH v2 0/7] Second batch of cleanups for cros_ec

2014-08-25 Thread Dmitry Torokhov
On Mon, Aug 25, 2014 at 07:28:01PM +0200, Javier Martinez Canillas wrote: Hello Dmitry, On 08/25/2014 07:05 PM, Dmitry Torokhov wrote: Patches #1, #2, #6 and #7 do not depend of others so they can be merged independently but patches #3, #4 and #5 have to be merged in that specific

Re: [PATCH v2 1/1] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-08 Thread Dmitry Torokhov
On Fri, Aug 08, 2014 at 03:07:33PM +0100, Nick Dyer wrote: On 07/08/14 08:44, Javier Martinez Canillas wrote: The Atmel maXTouch driver assumed that the IRQ type flags will always be passed using platform data but this is not true when booting using Device Trees. In these setups the

Re: [PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting

2014-08-07 Thread Dmitry Torokhov
On Thu, Aug 07, 2014 at 09:49:49AM +0200, Javier Martinez Canillas wrote: Hello Dmitry, On 08/07/2014 08:09 AM, Dmitry Torokhov wrote: irq_of_parse_and_map() already sets up IRQ trigger type based on DT data, by calling irq_create_of_mapping() which in turn calls irq_set_irq_type

Re: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare

2014-07-23 Thread Dmitry Torokhov
Hi Vasily, On Wed, Jul 09, 2014 at 12:13:41PM +0300, Vasily Khoruzhick wrote: On 8 July 2014 18:00:49 Dmitry Torokhov wrote: Hi Dmitry, - clk_disable(ts.clock); + clk_disable_unprepare(ts.clock); Do we really need to unprepare on suspend? Why simply disabling is not enough

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

2014-07-22 Thread Dmitry Torokhov
-by: Dmitry Torokhov dmitry.torok...@gmail.com + has_ts = of_property_read_bool(pdev-dev.of_node, has-touchscreen); + if (has_ts) + ret = exynos_adc_ts_init(info); + if (ret) + goto err_iio; + ret = of_platform_populate(np, exynos_adc_match

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-21 Thread Dmitry Torokhov
On Mon, Jul 21, 2014 at 12:23:58PM +0200, Arnd Bergmann wrote: On Sunday 20 July 2014 13:28:42 Dmitry Torokhov wrote: On Sun, Jul 20, 2014 at 02:51:37PM +0100, Jonathan Cameron wrote: + +do { +ret =exynos_read_s3c64xx_ts(dev, NULL, x, y, IIO_CHAN_INFO_RAW); = exynos

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-21 Thread Dmitry Torokhov
On Mon, Jul 21, 2014 at 05:11:27PM +0200, Arnd Bergmann wrote: On Monday 21 July 2014 07:44:42 Dmitry Torokhov wrote: It would be nice to actually close the device even if someone is touching screen. Please implement open/close methods and have them set a flag that you would

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

2014-07-20 Thread Dmitry Torokhov
On Sun, Jul 20, 2014 at 02:51:37PM +0100, Jonathan Cameron wrote: On 20/07/14 14:49, Jonathan Cameron wrote: On 18/07/14 20:29, Arnd Bergmann wrote: This adds support for the touchscreen on Samsung s3c64xx. The driver is completely untested but shows roughly how it could be done, following

Re: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare

2014-07-08 Thread Dmitry Torokhov
On Mon, Jun 30, 2014 at 10:09:37PM +0300, Vasily Khoruzhick wrote: Use clk_prepare_enable/clk_disable_unprepare to make the driver work properly with common clock framework. Signed-off-by: Vasily Khoruzhick anars...@gmail.com --- drivers/input/touchscreen/s3c2410_ts.c | 8 1 file

Re: [PATCH v2 07/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-27 Thread Dmitry Torokhov
Reviewed-by: Simon Glass s...@chromium.org For the I2C part: Acked-by: Wolfram Sang w...@the-dreams.de I'm good with input bits as well. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH V2] regulator: fixed: update to devm_* API

2014-01-27 Thread Dmitry Torokhov
Hi Manish, On Tue, Jan 28, 2014 at 08:42:00AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. Updated driver to use devm_kzalloc to kstrdup. 2.

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Dmitry Torokhov
Hi Manish, On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and desc-supply_name while regulator structures are still alive and can

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Torokhov
On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of #if define CONFIG_OF use

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Torokhov
On Mon, Jan 27, 2014 at 02:31:59AM +0400, Dmitry Eremin-Solenikov wrote: On Mon, Jan 27, 2014 at 1:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may get changed in the future to not dump stack (that was added

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-19 Thread Dmitry Torokhov
On Wed, Sep 18, 2013 at 12:41:11AM +0530, Manish Badarkhe wrote: Hi Dmitry, On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Dmitry Torokhov
Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. And the benefit of this would be...? There are still resources that are managed in traditional way and I really dislike mixing the 2

Re: [PATCH 0/2] input: touchscreen: atmel_mxt_ts: Add Device Tree support

2013-04-04 Thread Dmitry Torokhov
Hi Tomasz, On Thu, Apr 04, 2013 at 06:14:24PM +0200, Tomasz Figa wrote: This series is an attempt to add Device Tree support to Atmel maXtouch touchscreen driver. First patch adds support for VDD voltage regulator to get operating voltage using regulator API instead of a driver specific

Re: [PATCH] input: keyboard: gpio-keys: Try to parse IRQ from device tree

2012-10-05 Thread Dmitry Torokhov
Hi Tomasz, On Wed, Oct 03, 2012 at 01:20:00PM +0200, Tomasz Figa wrote: On modern platforms using device tree and non-legacy IRQ domains there is usually no way to perform direct translation between GPIO and IRQ, because the IRQ of interest is not mapped yet into sparse IRQ namespace. This

Re: [PATCH] input: samsung-keypad: add clk_prepare and clk_unprepare

2012-10-04 Thread Dmitry Torokhov
On Wed, Oct 03, 2012 at 08:31:52AM +0900, Thomas Abraham wrote: Add calls to clk_prepare and clk_unprepare as required by commom clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Applied, thank you Thomas. --- drivers/input/keyboard/samsung-keypad.c | 11

Re: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option

2011-09-07 Thread Dmitry Torokhov
Hi Thomas, On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: Samsung keyboard driver could be used with platforms using device tree. So the inclusion of samsung keyboard driver cannot be based on SAMSUNG_DEV_KEYPAD. A new config option HAVE_SAMSUNG_KEYPAD is added which device

Re: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option

2011-09-07 Thread Dmitry Torokhov
On Wed, Sep 07, 2011 at 11:22:48AM -0700, Dmitry Torokhov wrote: Hi Thomas, On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: Samsung keyboard driver could be used with platforms using device tree. So the inclusion of samsung keyboard driver cannot be based

Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver

2010-08-02 Thread Dmitry Torokhov
On Mon, Aug 02, 2010 at 03:30:57PM +0900, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i

Re: [PATCH] ARM: S3C64XX: Add s3c64xx support to touchscreen driver

2010-06-29 Thread Dmitry Torokhov
On Mon, Jun 28, 2010 at 11:11:11PM +0200, Maurus Cuelenaere wrote: Op 28-06-10 20:30, Dmitry Torokhov schreef: On Fri, May 07, 2010 at 01:40:30AM +0100, Ben Dooks wrote: On Thu, May 06, 2010 at 11:50:29AM +0200, Maurus Cuelenaere wrote: Add support for the s3c64xx touchscreen

Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver

2010-06-28 Thread Dmitry Torokhov
On Mon, Jun 28, 2010 at 05:39:39PM +0900, Joonyoung Shim wrote: Hi, Dmitry. On 6/25/2010 5:30 PM, Dmitry Torokhov wrote: Hi Joonyoung, On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver

Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver

2010-06-25 Thread Dmitry Torokhov
and ensure race-free shutdown/unbind. I think it was based on v4 of your driver and I'd appreciate if you could give it a try. Thank you. -- Dmitry Input: samsung-keypad - updates From: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- arch/arm

Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

2010-05-30 Thread Dmitry Torokhov
On Sun, May 30, 2010 at 05:42:37AM +0200, Marek Vasut wrote: Dne Ne 30. května 2010 05:06:20 Joonyoung Shim napsal(a): + */ +struct samsung_kp_platdata { + const struct matrix_keymap_data *keymap_data; + unsigned introws; + unsigned intcols; + unsigned

Re: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.

2009-11-19 Thread Dmitry Torokhov
On Thu, Nov 19, 2009 at 01:52:36PM +, Daniel Silverstone wrote: On Thu, Nov 19, 2009 at 11:34:40AM +, Ben Dooks wrote: + input_report_key(ts.input, BTN_TOUCH, 1); + input_report_abs(ts.input, ABS_PRESSURE, 1); No fake pressure events please, BTN_TOUCH should be

Re: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.

2009-11-18 Thread Dmitry Torokhov
Hi Ben, On Wed, Nov 18, 2009 at 11:29:40PM +, Ben Dooks wrote: From: Arnaud Patard arnaud.pat...@rtp-net.org S3C24XX touchscreen driver, originally written by Arnaud Patard and other contributors. This driver is the version from the Simtec Electronics tree, and as such is the best place