Re: [PATCH] thermal: exynos: use of_property_read_u8()

2015-11-23 Thread Eduardo Valentin
On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote: > use of_property_read_u8() for u8 variables, > also changed the return type to void as this function return type > is nowhere used. > I would be good if you could split both changes into two patches. Also, I still do not

[PATCHv2 07/10] thermal: exynos: allow compile test

2015-09-13 Thread Eduardo Valentin
Adding COMPILE_TEST flag to exynos driver to facilitate maintenance. Cc: Lukasz Majewski <l.majew...@samsung.com> Cc: Zhang Rui <rui.zh...@intel.com> Cc: linux...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Vale

[PATCH 14/17] thermal: exynos: allow compile test

2015-09-09 Thread Eduardo Valentin
Adding COMPILE_TEST flag to exynos driver to facilitate maintenance. Cc: Lukasz Majewski <l.majew...@samsung.com> Cc: Zhang Rui <rui.zh...@intel.com> Cc: linux...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Vale

Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases

2015-03-24 Thread Eduardo Valentin
()). Cc: Kukjin Kim kg...@kernel.org Cc: Arnd Bergmann a...@arndb.de Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Fixes: 8b2b4a4e5366 (cpufreq: exynos: allow modular build) Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-06 Thread Eduardo Valentin
will be happened. But I couldn't get Eduardo's topic branch. Specifically, the developer, while migrating the driver to support DT and OF thermal, decided to create a header with constants. The header is used by DT files and the driver code. The header was the dependency. BR, Eduardo Valentin http

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Eduardo Valentin
, since Viresh has ACK'ed it. Do we have any dependency with something which is only in the thermal tree(s)? If not, I suggest the cpufreq changes go via cpufreq tree(s). BR, Eduardo Valentin --- Changes for v2: - Remove superfluous *np pointer --- drivers/cpufreq/exynos-cpufreq.c

Re: [PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
platform_device *pdev) despite the above two minor issues, you may add my Acked-by: Eduardo Valentin edubez...@gmail.com + if (IS_ERR(cdev)) { + dev_err(pdev-dev, + Failed to register pwm-fan as cooling device); + pwm_disable

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 02:28:15PM +0100, Lukasz Majewski wrote: Hi Eduardo, On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski

Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-25 Thread Eduardo Valentin
, Eduardo Valentin Thanks, Guenter signature.asc Description: Digital signature

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-25 Thread Eduardo Valentin
because exynos7_tmu_control() always enables the power down detection mode regardless 'on' parameter. Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 3 ++- 1

Re: [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:19PM +0100, Lukasz Majewski wrote: With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 03:11:24PM -0400, Eduardo Valentin wrote: On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew

Re: [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 04:34:17PM +0100, Lukasz Majewski wrote: Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to

Re: [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:33AM +0100, Lukasz Majewski wrote: With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values property to

Re: [PATCH 1/2] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-24 Thread Eduardo Valentin
: Eduardo Valentin edubez...@gmail.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Lukasz, Any objections to this code? BR, Eduardo Valentin --- drivers/thermal/samsung/exynos_tmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/samsung

Re: [PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:30AM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL{_OF|} disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore, the

Re: [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:29AM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL_OF disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore, the

Re: [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-24 Thread Eduardo Valentin
On Wed, Feb 18, 2015 at 11:07:31AM +0100, Lukasz Majewski wrote: Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to

[PATCH 14/14] cpufreq: exynos-cpufreq: release resources by using managed allocation

2015-02-02 Thread Eduardo Valentin
...@kernel.org Cc: linux...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos-cpufreq.c | 99 +--- drivers

[PATCH 06/14] cpufreq: exynos4x12: use devm_clk_get

2015-02-02 Thread Eduardo Valentin
@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4x12-cpufreq.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/exynos4x12-cpufreq.c b/drivers/cpufreq/exynos4x12

[PATCH 01/14] cpufreq: exynos4210: properly put of node

2015-02-02 Thread Eduardo Valentin
...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4210-cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-cpufreq.c index 843ec82..dba48f0 100644 --- a/drivers/cpufreq/exynos4210

[PATCH 08/14] cpufreq: exynos5250: iounmap in error path

2015-02-02 Thread Eduardo Valentin
...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos5250-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c index 50b0cdf..e61d149 100644 --- a/drivers/cpufreq

[PATCH 11/14] cpufreq: exynos4210: remove unused symbol cpufreq

2015-02-02 Thread Eduardo Valentin
: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4210-cpufreq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-cpufreq.c index

[PATCH 13/14] cpufreq: exynos5250: remove unused symbol cpufreq

2015-02-02 Thread Eduardo Valentin
: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos5250-cpufreq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c index

Re: [PATCHv2 1/1] cpufreq: exynos: allow modular build

2015-02-02 Thread Eduardo Valentin
On Mon, Feb 02, 2015 at 09:33:09AM +0530, Viresh Kumar wrote: On 1 February 2015 at 00:29, Eduardo Valentin edubez...@gmail.com wrote: From: Arnd Bergmann a...@arndb.de big cut Acked-by: Viresh Kumar viresh.ku...@linaro.org Thanks! Now as these are all compilable as modules, should

[PATCH 03/14] cpufreq: exynos4210: use devm_clk_get

2015-02-02 Thread Eduardo Valentin
@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4210-cpufreq.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210

[PATCH 09/14] cpufreq: exynos5250: use devm_clk_get

2015-02-02 Thread Eduardo Valentin
@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos5250-cpufreq.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250

[PATCH 04/14] cpufreq: exynos4x12: properly put of node

2015-02-02 Thread Eduardo Valentin
...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4x12-cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/exynos4x12-cpufreq.c b/drivers/cpufreq/exynos4x12-cpufreq.c index 9e78a85..3d067f2 100644 --- a/drivers/cpufreq/exynos4x12

[PATCH 02/14] cpufreq: exynos4210: iounmap in error path

2015-02-02 Thread Eduardo Valentin
...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos4210-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-cpufreq.c index dba48f0..8a25dce 100644 --- a/drivers/cpufreq

[PATCH 10/14] cpufreq: exynox-cpufreq: pass exynos_dvfs_info to .set_freq callback

2015-02-02 Thread Eduardo Valentin
Kim kg...@kernel.org Cc: linux...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/exynos-cpufreq.c | 2 +- drivers/cpufreq/exynos-cpufreq.h

Re: [PATCH v4 2/2] thermal: exynos: Add TMU support for Exynos7 SoC

2015-01-31 Thread Eduardo Valentin
On Tue, Jan 27, 2015 at 11:18:22AM +0530, Abhilash Kesavan wrote: Add registers, bit fields and compatible strings for Exynos7 TMU (Thermal Management Unit). Following are a few of the differences in the Exynos7 TMU from earlier SoCs: - 8 trigger levels - Different bit offsets

[PATCHv2 1/1] cpufreq: exynos: allow modular build

2015-01-31 Thread Eduardo Valentin
tree to determine if cpufreq cooling should be registered) Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/Kconfig.arm | 44 ++-- drivers/cpufreq/Makefile| 9 + 2 files changed

Re: [PATCH 3/3] cpufreq: exynos: allow modular build

2015-01-30 Thread Eduardo Valentin
On Fri, Jan 30, 2015 at 10:24:12PM +0100, Arnd Bergmann wrote: On Thursday 29 January 2015 18:21:51 Eduardo Valentin wrote: Hello Arnd and Viresh, On Thu, Jan 29, 2015 at 01:42:32PM +0100, Arnd Bergmann wrote: On Thursday 29 January 2015 15:40:15 Viresh Kumar wrote: obj

Re: [PATCH 3/3] cpufreq: exynos: allow modular build

2015-01-29 Thread Eduardo Valentin
exynos_dvfs_info *info) return -EOPNOTSUPP; } #endif -#ifdef CONFIG_ARM_EXYNOS5250_CPUFREQ +#if IS_ENABLED(CONFIG_ARM_EXYNOS5250_CPUFREQ) extern int exynos5250_cpufreq_init(struct exynos_dvfs_info *); #else static inline int exynos5250_cpufreq_init(struct exynos_dvfs_info *info) Eduardo Valentin

Re: [PATCH 1/3] exynos: config: Remove CONFIG_EXYNOS_THERMAL_CORE define (exynos_defconfig)

2015-01-29 Thread Eduardo Valentin
On Wed, Jan 28, 2015 at 04:28:38PM +0100, Lukasz Majewski wrote: After Exynos TMU rework to use device tree for configuration this flag can be removed. It is not used anymore. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked-by: Eduardo

Re: [PATCH 2/3] exynos: config: Enable thermal emulation for Exynos TMU (exynos_defconfig)

2015-01-29 Thread Eduardo Valentin
On Wed, Jan 28, 2015 at 04:28:39PM +0100, Lukasz Majewski wrote: Enabling thermal emulation on Exynos SoCs. New sysfs attribute - emul_temp is created. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked-by: Eduardo Valentin edubez...@gmail.com

Re: [PATCH 1/2] thermal: exynos: Reorder exynos_map_dt_data() function

2015-01-29 Thread Eduardo Valentin
On Thu, Jan 22, 2015 at 06:02:07PM +0530, Abhilash Kesavan wrote: Hi Lukasz, On Thu, Jan 22, 2015 at 2:31 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Abhilash, Hi Lukasz, On Mon, Jan 19, 2015 at 5:14 PM, Lukasz Majewski l.majew...@samsung.com wrote: The

Re: [PATCH 3/3] exynos: config: Enable support for cpufreq on Exynos SoCs (exynos_defconfig)

2015-01-29 Thread Eduardo Valentin
On Wed, Jan 28, 2015 at 04:28:40PM +0100, Lukasz Majewski wrote: This commit enables the cpufreq subsystem. Moreover, support for using CPU as a cooling device is provided. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked-by: Eduardo Valentin

Re: [PATCH 3/3] cpufreq: exynos: allow modular build

2015-01-28 Thread Eduardo Valentin
On Wed, Jan 28, 2015 at 02:16:55PM +0100, Arnd Bergmann wrote: The exynos cpufreq driver code recently gained a dependency on the cooling code, which may be a loadable module. This breaks an ARM allmodconfig build: drivers/built-in.o: In function `exynos_cpufreq_probe': :(.text+0x1748e8):

Re: [PATCH] thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE

2015-01-27 Thread Eduardo Valentin
On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote: After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE is not needed anymore. This patch removes this entry from Kconfig. Reported-by: Paul Bolle pebo...@tiscali.nl Signed-off-by: Lukasz Majewski

Re: [PATCH v4 00/17] thermal: exynos: Thermal code rework to use device tree

2015-01-23 Thread Eduardo Valentin
. Because your patches touch most of exynos DT stuff and that's why DT changes should be handled in Samsung tree if there is no problem ;) Let's wait for thermal guys. Let's target the latest version (v6) of this series. You can add my Acked-by: Eduardo Valentin edubez...@gmail.com in the DTS

Re: [PATCH v3 14/16] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-22 Thread Eduardo Valentin
On Wed, Jan 21, 2015 at 09:10:15AM +0100, Lukasz Majewski wrote: Hi Eduardo, On Thu, Jan 15, 2015 at 04:17:52PM +0100, Lukasz Majewski wrote: Hi Eduardo, On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via

Re: [PATCH v3 00/16] thermal: exynos: Thermal code rework to use device tree

2015-01-22 Thread Eduardo Valentin
On Thu, Jan 22, 2015 at 02:06:10AM +0100, Tobias Jakobi wrote: Hello! Lukasz Majewski wrote: The point is that I'm still working with a rather old version of the cpufreq series, a version which still had the Exynos4x12 code in it (this was removed later, if I remember correctly because

Re: [PATCH v5 15/18] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-22 Thread Eduardo Valentin
On Wed, Jan 21, 2015 at 09:40:55AM +0100, Lukasz Majewski wrote: Hi Eduardo, On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via device tree. Previously this data has been hardcoded in the exynos_tmu_data.c file.

Re: [PATCH v3 14/16] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-20 Thread Eduardo Valentin
On Thu, Jan 15, 2015 at 04:17:52PM +0100, Lukasz Majewski wrote: Hi Eduardo, On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via device tree. Previously this data has been hardcoded in the exynos_tmu_data.c file.

Re: [PATCH v5 00/18] thermal: exynos: Thermal code rework to use device tree

2015-01-20 Thread Eduardo Valentin
Hello Arnd, On Mon, Jan 19, 2015 at 12:20:44PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal framework on Exynos devices. The main goal was to use a generic code for reading thermal configuration (of-thermal.c).

Re: [PATCH v5 15/18] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-20 Thread Eduardo Valentin
On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via device tree. Previously this data has been hardcoded in the exynos_tmu_data.c file. Such approach was not scalable and very often required copying the whole data.

Re: [PATCH v5 18/18] thermal: exynos: Remove not needed exynos_tmu_init_data declarations from exynos_tmu.h

2015-01-20 Thread Eduardo Valentin
On Mon, Jan 19, 2015 at 12:21:02PM +0100, Lukasz Majewski wrote: After switching to device tree based configuration those declarations are not needed anymore. Reported-by: Abhilash Kesavan a.kesa...@samsung.com Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v5: -

Re: [PATCH v5 07/18] thermal: exynos: Modify exynos thermal code to use device tree for cpu cooling configuration

2015-01-20 Thread Eduardo Valentin
On Mon, Jan 19, 2015 at 12:20:51PM +0100, Lukasz Majewski wrote: Up till now exynos_tmu_data.c was used for storing CPU cooling configuration data. Now the Exynos thermal core code uses device tree to get this data. For this purpose generic thermal code for configuring CPU cooling was used.

Re: [PATCH v5 15/18] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-20 Thread Eduardo Valentin
On Mon, Jan 19, 2015 at 12:20:59PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via device tree. Previously this data has been hardcoded in the exynos_tmu_data.c file. Such approach was not scalable and very often required copying the whole data.

Re: [PATCH v3 06/16] arm: dts: Adding CPU cooling binding for Exynos SoCs

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:04PM +0100, Lukasz Majewski wrote: Presented patch aims to move data necessary for correct CPU cooling device configuration from exynos_tmu_data.c to device tree. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - None Changes for v3:

Re: [PATCH v3 13/16] thermal: exynos: dts: Provide device tree bindings identical to the one in exynos_tmu_data.c

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:11PM +0100, Lukasz Majewski wrote: Presented device tree bindings provide data already hardcoded in the exynos_tmu_data.c file. After this commit, it should be possible to reuse common thermal core framework in Exynos SoCs. Signed-off-by: Lukasz Majewski

Re: [PATCH v3 14/16] thermal: samsung: core: Exynos TMU rework to use device tree for configuration

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:12PM +0100, Lukasz Majewski wrote: This patch brings support for providing configuration via device tree. Previously this data has been hardcoded in the exynos_tmu_data.c file. Such approach was not scalable and very often required copying the whole data.

Re: [PATCH v3 09/16] dts: Documentation: Extending documentation entry for exynos-thermal

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote: Properties necessary for providing Exynos thermal configuration via device tree. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v3: - New patch ---

Re: [PATCH v3 09/16] dts: Documentation: Extending documentation entry for exynos-thermal

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:52:25PM -0400, Eduardo Valentin wrote: On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote: Properties necessary for providing Exynos thermal configuration via device tree. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v3

Re: [PATCH v3 05/16] thermal: dts: Enable TMU at Exynos4412 based Odroid U3 device

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:03PM +0100, Lukasz Majewski wrote: This commit enables TMU IP block on the Exynos4412 Odroid U3 device. The comment about the patch subject applies here too. I would use arm: dts: ... instead of thermal: dts Signed-off-by: Lukasz Majewski

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 04:01:06PM +0100, Lukasz Majewski wrote: Hi Eduardo, On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device

Re: [PATCH v2 06/17] thermal: cpu_cooling: dts: Define device tree bindings for Exynos cpu cooling functionality

2015-01-12 Thread Eduardo Valentin
On Mon, Jan 12, 2015 at 03:09:16PM +0100, Lukasz Majewski wrote: Hi Eduardo, Presented patch aims to move data necessary for correct CPU cooling device configuration from exynos_tmu_data.c to device tree. I believe the patch title is misleading. Looks like you are changing

Re: [PATCH v2 00/17] thermal: exynos: Thermal code rework to use device tree

2015-01-05 Thread Eduardo Valentin
. Cheers, Eduardo Valentin Cheers, Eduardo Valentin. Best regards, Lukasz Majewski signature.asc Description: Digital signature

Re: [PATCH v2 12/17] thermal: exynos: dts: Provide device tree bindings identical to one in exynos_tmu_data.c

2015-01-02 Thread Eduardo Valentin
Lukasz On Wed, Dec 10, 2014 at 01:09:51PM +0100, Lukasz Majewski wrote: Presented device tree bindings provide data already hardcoded in the exynos_tmu_data.c file. After this commit, it should be possible to reuse common thermal core framework in Exynos SoCs. Signed-off-by: Lukasz

Re: [PATCH v2 06/17] thermal: cpu_cooling: dts: Define device tree bindings for Exynos cpu cooling functionality

2015-01-02 Thread Eduardo Valentin
On Wed, Dec 10, 2014 at 01:09:45PM +0100, Lukasz Majewski wrote: Presented patch aims to move data necessary for correct CPU cooling device configuration from exynos_tmu_data.c to device tree. I believe the patch title is misleading. Looks like you are changing something at cpu cooling, but in

Re: [PATCH v2 08/17] thermal: exynos: dts: Add default definition of the TMU sensor parameter

2015-01-02 Thread Eduardo Valentin
Lukasz, On Wed, Dec 10, 2014 at 01:09:47PM +0100, Lukasz Majewski wrote: Exynos 4 and 5 family of SoCs uses almost identical TMU sensor to measure the on chip temperature. For this reason it is possible to group TMU configuration parameters in one dts file. Signed-off-by: Lukasz Majewski

Re: [PATCH v2 00/17] thermal: exynos: Thermal code rework to use device tree

2015-01-02 Thread Eduardo Valentin
100644 drivers/thermal/samsung/exynos_thermal_common.h delete mode 100644 drivers/thermal/samsung/exynos_tmu_data.c create mode 100644 include/dt-bindings/thermal/thermal_exynos.h -- 2.0.0.rc2 Apologize for late answer. Cheers, Eduardo Valentin. signature.asc Description: Digital

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
On Fri, Jan 02, 2015 at 02:54:28PM -0400, Eduardo Valentin wrote: On Mon, Dec 22, 2014 at 05:27:41PM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL_OF disabled). In this situation it can be controlled via PWM entry

Re: [PATCH v2 08/17] thermal: exynos: dts: Add default definition of the TMU sensor parameter

2015-01-02 Thread Eduardo Valentin
On Fri, Jan 02, 2015 at 02:11:41PM -0400, Eduardo Valentin wrote: Lukasz, On Wed, Dec 10, 2014 at 01:09:47PM +0100, Lukasz Majewski wrote: Exynos 4 and 5 family of SoCs uses almost identical TMU sensor to measure the on chip temperature. For this reason it is possible to group TMU

Re: [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-01-02 Thread Eduardo Valentin
, the thermal_of_cooling_device_register() function needs a stub to allow clean compilation. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - None --- include/linux/thermal.h | 14 +++--- 1 file changed, 11 insertions(+), 3

Re: [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:42PM +0100, Lukasz Majewski wrote: Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL_OF disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore, the thermal_cdev_update()

Re: [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2015-01-02 Thread Eduardo Valentin
On Mon, Dec 22, 2014 at 05:27:43PM +0100, Lukasz Majewski wrote: Several new properties to allow PWM fan working as a cooling device have been combined into this single commit. Patch prefix should look something like 'dt-bindings: ...', or better 'Documentation: devicetree: ...', or

Re: [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-01-02 Thread Eduardo Valentin
Patch subject should use a prefix like: 'arm: dts:' On Mon, Dec 22, 2014 at 05:27:45PM +0100, Lukasz Majewski wrote: With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes

Re: [PATCH v2 07/17] thermal: cpu_cooling: Modify exynos thermal code to use device tree for cpu cooling configuration

2015-01-02 Thread Eduardo Valentin
On Wed, Dec 10, 2014 at 01:09:46PM +0100, Lukasz Majewski wrote: Up till now exynos_tmu_data.c was used for storing CPU cooling configuration data. Now the Exynos thermal core code uses device tree to get this data. For this purpose generic thermal code for configuring CPU cooling was used.

Re: [PATCH v2 00/17] thermal: exynos: Thermal code rework to use device tree

2014-12-10 Thread Eduardo Valentin
On Wed, Dec 10, 2014 at 01:09:39PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal framework on Exynos devices. The main goal was to use a generic code for reading thermal configuration (of-thermal.c). Due to that

Re: [PATCHv2 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
Hello Folks, On Fri, Nov 28, 2014 at 11:18:24AM +0100, Lukasz Majewski wrote: On Fri, 28 Nov 2014 13:35:49 +0530 Viresh Kumar viresh.ku...@linaro.org wrote: On 27 November 2014 at 19:42, Eduardo Valentin edubez...@gmail.com wrote: (I'm sorry VireshK, I am still using my normal

[PATCHv3 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Zhang Rui rui.zh...@intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/thermal/cpu_cooling.c

Re: [PATCHv3 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-28 Thread Eduardo Valentin
Russel, On Fri, Nov 28, 2014 at 05:10:24PM +, Russell King - ARM Linux wrote: On Fri, Nov 28, 2014 at 10:53:30AM -0400, Eduardo Valentin wrote: diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c index 3f5ad25..d4eaa1b 100644

Re: [PATCH 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-27 Thread Eduardo Valentin
Hello Viresh, On Thu, Nov 27, 2014 at 09:38:39AM +0530, Viresh Kumar wrote: Few nits.. On 26 November 2014 at 23:20, Eduardo Valentin edubez...@gmail.com wrote: Signed-off-by: Eduardo Valentin edubez...@gmail.com --- The normal practice is to write the non-commitable part here

[PATCHv2 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-27 Thread Eduardo Valentin
...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Zhang Rui rui.zh...@intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/thermal/cpu_cooling.c

[PATCH 1/1] thermal: cpu_cooling: check for the readiness of cpufreq layer

2014-11-26 Thread Eduardo Valentin
...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Zhang Rui rui.zh...@intel.com Signed-off-by: Eduardo Valentin edubez...@gmail.com --- drivers/thermal/cpu_cooling.c | 5 + drivers/thermal

Re: [PATCH 03/21] thermal: of: Extend of-thermal.c to provide number of non critical trip points

2014-11-18 Thread Eduardo Valentin
Hello Lukasz, On Wed, Nov 12, 2014 at 10:42:41AM +0100, Lukasz Majewski wrote: Hi Eduardo, Hello Lukasz, On Fri, Nov 07, 2014 at 11:05:51AM +0100, Lukasz Majewski wrote: Hi Eduardo, On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote: This patch extends

Re: [PATCH 04/21] thermal: of: Extend current of-thermal.c code to allow setting emulated temp

2014-11-18 Thread Eduardo Valentin
Lukasz, On Fri, Nov 07, 2014 at 12:20:35PM +0100, Lukasz Majewski wrote: Hi Eduardo, Hello, On Thu, Oct 09, 2014 at 06:38:40PM +0200, Lukasz Majewski wrote: Before this change it was only possible to set get_temp() and get_trend() methods to be used in the common code handling

Re: [PATCH v2 00/33] thermal: exynos: convert the driver to use per-SoC type operations

2014-11-15 Thread Eduardo Valentin
Hello Bartlomiej, On Thu, Nov 13, 2014 at 04:00:55PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series replaces the hardware registers abstractions in the Exynos thermal driver by the usage of per-SoC type operations. Good! I think the driver is a bit confusing because it has

Re: [PATCH 03/21] thermal: of: Extend of-thermal.c to provide number of non critical trip points

2014-11-07 Thread Eduardo Valentin
Hello Lukasz, On Fri, Nov 07, 2014 at 11:05:51AM +0100, Lukasz Majewski wrote: Hi Eduardo, On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote: This patch extends the of-thermal.c to provide information about number of available non critical (i.e. non HW) trip points in

Re: [PATCH] thermal: exynos: use correct offset for TMU_CONTROL register on Exynos5260

2014-11-07 Thread Eduardo Valentin
: Lukasz Majewski l.majew...@samsung.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Zhang Rui rui.zh...@intel.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/thermal/samsung/exynos_tmu_data.c |1

Re: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

2014-11-06 Thread Eduardo Valentin
Hello Yadwinder, On Thu, Nov 06, 2014 at 04:26:27PM +0530, Yadwinder Singh Brar wrote: Hello Eduardo Valentin, On Thursday, November 06, 2014 2:17 AM, Eduardo Valentin wrote: Hello Yadwinder, On Wed, Nov 05, 2014 at 05:46:25PM +0530, Yadwinder Singh Brar wrote: Existing code updates

Re: [PATCH 01/21] thermal: of: Extend of-thermal.c to provide number of trip points

2014-11-06 Thread Eduardo Valentin
Hello Lukasz, On Thu, Oct 09, 2014 at 06:38:37PM +0200, Lukasz Majewski wrote: This patch extends the of-thermal.c to provide information about number of available trip points. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal/of-thermal.c | 6 ++

Re: [PATCH 02/21] thermal: of: Extend of-thermal.c to provide check if trip point is enabled

2014-11-06 Thread Eduardo Valentin
Hello Lukasz, On Thu, Oct 09, 2014 at 06:38:38PM +0200, Lukasz Majewski wrote: This patch extends the of-thermal.c to provide check if trip point is enabled. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal/of-thermal.c | 9 +

Re: [PATCH 03/21] thermal: of: Extend of-thermal.c to provide number of non critical trip points

2014-11-06 Thread Eduardo Valentin
On Thu, Oct 09, 2014 at 06:38:39PM +0200, Lukasz Majewski wrote: This patch extends the of-thermal.c to provide information about number of available non critical (i.e. non HW) trip points in the system. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal/of-thermal.c

Re: [PATCH 04/21] thermal: of: Extend current of-thermal.c code to allow setting emulated temp

2014-11-06 Thread Eduardo Valentin
Hello, On Thu, Oct 09, 2014 at 06:38:40PM +0200, Lukasz Majewski wrote: Before this change it was only possible to set get_temp() and get_trend() methods to be used in the common code handling passing parameters via device tree to cpu-thermal CPU thermal zone device. Now it is possible to

Re: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

2014-11-05 Thread Eduardo Valentin
cpufreq_dev_list when there is any policy update. OK. Please give real examples of when the current code fails to catch the event. BR, Eduardo Valentin Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/thermal/cpu_cooling.c | 37 - 1 files

Re: [PATCH 00/33] thermal: exynos: convert the driver to use per-SoC type operations

2014-10-29 Thread Eduardo Valentin
Bartlomiej, On Thu, Sep 18, 2014 at 05:27:17PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series replaces the hardware registers abstractions in the Exynos thermal driver by the usage of per-SoC type operations. Such solution provides simpler, easier to understand code and

Re: [PATCHv6 0/2] thermal: exynos: Add support for TRIMINFO feature of Exynos3250

2014-09-03 Thread Eduardo Valentin
Hi, On Wed, Sep 03, 2014 at 12:09:01PM +0900, Chanwoo Choi wrote: This patchset add the support of TRIMINFO_RELOAD feature for Exynos3250. But Exynos3250 has two TRIMINFO_CTRL register instead other Exynos has only one TRIMINFO_CTRL register. So, this patchset support the some Exynos SoC

Re: [PATCH v3 0/8] thermal: exynos: various cleanups

2014-09-02 Thread Eduardo Valentin
On Mon, Sep 01, 2014 at 07:05:27AM -0400, edubez...@gmail.com wrote: Amit On Mon, Sep 1, 2014 at 6:53 AM, amit daniel kachhap amit.dan...@samsung.com wrote: On Thu, Aug 28, 2014 at 8:19 PM, Eduardo Valentin edubez...@gmail.com wrote: Amit, On Thu, Jul 31, 2014 at 07:10:58PM +0200

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-09-02 Thread Eduardo Valentin
Chanwoo, On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: Dear Eduardo, On 08/28/2014 11:53 PM, Eduardo Valentin wrote: On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch

Re: [PATCH v3 0/8] thermal: exynos: various cleanups

2014-08-28 Thread Eduardo Valentin
Amit, On Thu, Jul 31, 2014 at 07:10:58PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series contains various cleanups for EXYNOS thermal driver. Overall it decreases driver's LOC by 9%. It is based on next-20140731 kernel. It should not cause any functionality changes. Did

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-28 Thread Eduardo Valentin
Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Amit Daniel Kachhap amit.dan...@samsung.com Reviewed-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

Re: [PATCH] thermal: samsung: Exynos5260 and Exynos5420 should not use TRIM_RELOAD flag

2014-08-20 Thread Eduardo Valentin
Hello Bartlomiej, On Wed, Aug 20, 2014 at 02:04:18PM +0200, Bartlomiej Zolnierkiewicz wrote: Currently these SoCs claim TRIM_RELOAD support but don't have triminfo_ctrl register address defined in their struct exynos_tmu_registers entries. This causes incorrect write of value 1 to data-base

Re: [PATCH v2 0/9] thermal: exynos: various cleanups

2014-07-29 Thread Eduardo Valentin
of Rui's tree. For now I am dropping this series from my -next branch. :-( Thanks, Amit D On Mon, Jul 28, 2014 at 8:07 PM, Eduardo Valentin edubez...@gmail.com wrote: On Tue, Jun 17, 2014 at 07:27:16PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series contains various

Re: [PATCH 1/3] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250

2014-07-29 Thread Eduardo Valentin
On Tue, Jul 29, 2014 at 11:17:10AM +0900, Chanwoo Choi wrote: This patch add TMU (Thermal Management Unit) dt node to monitor the high temperature for Exynos3250. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Eduardo Valentin

Re: [RESEND PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-29 Thread Eduardo Valentin
On Tue, Jul 22, 2014 at 11:41:56AM +0530, amit daniel kachhap wrote: On Mon, Jul 21, 2014 at 11:34 AM, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2014-07-18 at 09:00 +0900, Chanwoo Choi wrote: This patch adds the registers, bit fields and compatible strings required to support for the 1

Re: [PATCH v2 0/9] thermal: exynos: various cleanups

2014-07-28 Thread Eduardo Valentin
On Tue, Jun 17, 2014 at 07:27:16PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series contains various cleanups for EXYNOS thermal driver. Overall it decreases driver's LOC by 12%. It is based on next-20140617 kernel. It should not cause any functionality changes. Changes

Re: [PATCH 02/10] thermal: exynos: remove unused defines

2014-05-15 Thread Eduardo Valentin
On Mon, May 05, 2014 at 01:15:31PM +0200, Bartlomiej Zolnierkiewicz wrote: There should be no functional changes caused by this patch. This patch can be merged to patch 01. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/thermal/samsung/exynos_tmu_data.h |

  1   2   3   >