Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-10-04 Thread Greg KH
On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on struct

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-09 Thread Greg KH
On Wed, Sep 09, 2015 at 10:14:46AM -0300, Emilio López wrote: > On 09/09/15 01:12, Guenter Roeck wrote: > >On 09/08/2015 08:58 PM, Greg KH wrote: > >>On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: > >>>Hi Emilio, > >>> > >>>On

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: > Emilio, > > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: > Hi Emilio, > > On 09/08/2015 05:51 PM, Emilio López wrote: > >Hi Greg & Guenter, > > > [ ... ] > > Unless I am missing something, this is not explained anywhere, but it is > not entirely trivial to understand. I think

Re: [PATCH stable-4.0] ARM: EXYNOS: Fix failed second suspend on Exynos4

2015-06-20 Thread Greg KH
On Sat, Jun 20, 2015 at 06:32:46PM +0900, Krzysztof Kozlowski wrote: Hi Greg, I backported the patch below for stable 4.0. It seems it was missed or maybe I sent it the wrong way? The backport was mailed to sta...@vger.kernel.org Is the patch queued for next 4.0 stable release? Should I

Re: [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7

2014-11-17 Thread Greg KH
On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote: From: Pankaj Dubey pankaj.du...@samsung.com Exynos7 has a similar serial controller to that present in older Samsung SoCs. To re-use the existing serial driver on Exynos7 we need to have SERIAL_SAMSUNG_UARTS_4 and

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-04 Thread Greg KH
On Tue, Nov 04, 2014 at 08:21:04PM +0100, Paul Bolle wrote: On Tue, 2014-11-04 at 19:33 +0100, Sylwester Nawrocki wrote: On 04/11/14 00:24, Greg KH wrote: This isn't a stable issue... Sorry for disturbing then, let me go and read the documentation again. If I remember correctly, I

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

2014-11-03 Thread Greg KH
On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote: The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code). There are still some references left, fix that by replacing them with ARCH_S5PV210. Fixes: d78c16ccde96 (ARM:

Re: [PATCH v5 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-29 Thread Greg KH
On Thu, Sep 25, 2014 at 10:50:22AM +0530, Vivek Gautam wrote: Hi Greg, On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on

Re: [PATCH 0/2] Add support for sii9234 chip

2014-05-03 Thread Greg KH
On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote: Hi everyone, This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used to convert HDMI signal into MHL. The driver enables HDMI output on Trats and Trats2 boards. The code is based on the driver

Re: [PATCH 1/2] misc: add sii9234 driver

2014-05-03 Thread Greg KH
On Fri, Apr 11, 2014 at 01:48:29PM +0200, Tomasz Stanislawski wrote: diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 1cb7408..3b7f266 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -515,6 +515,14 @@ config SRAM the genalloc API. It is supposed to be

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: uart_register_driver call binds the driver to a specific device node through tty_register_driver call. This should typically happen during device probe

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Thu, Feb 13, 2014 at 06:15:59PM +, Russell King - ARM Linux wrote: On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: uart_register_driver

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: On Thu, Feb 13, 2014 at 10:27:01AM -0800, Greg KH wrote: On Thu, Feb 13, 2014 at 06:15:59PM +, Russell King - ARM Linux wrote: On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 10

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Fri, Feb 14, 2014 at 12:07:17AM +, Russell King - ARM Linux wrote: On Thu, Feb 13, 2014 at 03:26:06PM -0800, Greg KH wrote: On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: We went through this before, and I stated the paths, and no one disagreed

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-20 Thread Greg KH
On Mon, Jan 20, 2014 at 10:05:30AM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 02:32:34PM +0530, Tushar Behera wrote: uart_register_driver call binds the driver to a specific device node through tty_register_driver call. This should typically happen during device probe

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-20 Thread Greg KH
On Mon, Jan 20, 2014 at 09:32:06PM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 01:16:01PM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 10:05:30AM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 02:32:34PM +0530, Tushar Behera wrote: uart_register_driver

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-20 Thread Greg KH
On Mon, Jan 20, 2014 at 11:16:03PM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 03:11:41PM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 09:32:06PM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 01:16:01PM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 10

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-20 Thread Greg KH
On Tue, Jan 21, 2014 at 12:07:06AM +, Russell King - ARM Linux wrote: On Mon, Jan 20, 2014 at 03:51:28PM -0800, Greg KH wrote: On Mon, Jan 20, 2014 at 11:16:03PM +, Russell King - ARM Linux wrote: I don't believe the driver model has any locking to prevent a drivers -probe

Re: [PATCH] tty: Fallback to use dynamic major number

2014-01-16 Thread Greg KH
On Thu, Jan 16, 2014 at 10:33:22AM +0530, Tushar Behera wrote: In a multi-platform scenario, the hard-coded major/minor numbers in serial drivers may conflict with each other. A typical scenario is observed with amba-pl011 and samsung-uart drivers, both of these drivers use same set of

Re: [PATCH] tty: Fallback to use dynamic major number

2014-01-16 Thread Greg KH
On Thu, Jan 16, 2014 at 05:08:14PM +, Mark Brown wrote: On Thu, Jan 16, 2014 at 08:18:41AM -0800, Greg KH wrote: On Thu, Jan 16, 2014 at 10:33:22AM +0530, Tushar Behera wrote: In a multi-platform scenario, the hard-coded major/minor numbers in serial drivers may conflict with each

Re: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 05:01:00AM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Hi, I'm starting work downstream on combining the DWC2 host driver and the s3c-hsotg gadget driver into a dual-role OTG driver. Before I go further, I was hoping to solicit

Re: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 08:57:12PM +, Paul Zimmerman wrote: From: Dinh Nguyen [mailto:dingu...@altera.com] Sent: Tuesday, January 14, 2014 12:46 PM On Tue, 2014-01-14 at 06:21 -0800, Greg KH wrote: On Tue, Jan 14, 2014 at 05:01:00AM -0600, dingu...@altera.com wrote: From: Dinh

Re: [PATCH] serial: samsung: Remove hard-coded major/minor numbers

2013-12-27 Thread Greg KH
On Fri, Dec 27, 2013 at 03:47:31PM +0530, Tushar Behera wrote: On 27 December 2013 12:08, Greg KH gre...@linuxfoundation.org wrote: On Fri, Dec 27, 2013 at 12:00:20PM +0530, Tushar Behera wrote: On 27 December 2013 10:48, Greg KH gre...@linuxfoundation.org wrote: On Fri, Dec 27, 2013 at 10

Re: [PATCH] serial: samsung: Remove hard-coded major/minor numbers

2013-12-26 Thread Greg KH
On Fri, Dec 27, 2013 at 12:00:20PM +0530, Tushar Behera wrote: On 27 December 2013 10:48, Greg KH gre...@linuxfoundation.org wrote: On Fri, Dec 27, 2013 at 10:37:28AM +0530, Tushar Behera wrote: The hard-coded values clash with the values set for amba-pl011 serial driver. Because

Re: [PATCH] serial: samsung: Remove hard-coded major/minor numbers

2013-12-26 Thread Greg KH
On Fri, Dec 27, 2013 at 10:43:23AM +0400, Alexander Shiyan wrote: Hello. On Fri, Dec 27, 2013 at 12:00:20PM +0530, Tushar Behera wrote: On 27 December 2013 10:48, Greg KH gre...@linuxfoundation.org wrote: On Fri, Dec 27, 2013 at 10:37:28AM +0530, Tushar Behera wrote: The hard-coded

Re: [PATCH] usb: ohci-exynos: Change to use phy provided by the generic phy framework

2013-12-09 Thread Greg KH
On Wed, Nov 06, 2013 at 10:27:49AM +0900, Jingoo Han wrote: Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. Signed-off-by: Jingoo Han jg1@samsung.com Cc: Kamil Debski k.deb...@samsung.com --- Exynos OHCI driver also uses Exynos

Re: [PATCH 0/7] video phy's adaptation to *generic phy framework*

2013-10-16 Thread Greg KH
On Wed, Oct 16, 2013 at 09:58:09PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, This series includes video PHY adaptation to Generic PHY Framework. With the adaptation they were able to get rid of plat data callbacks. Since you've taken the Generic PHY Framework, I think this series

Re: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-09-26 Thread Greg KH
On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. The omap-usb2 driver is also moved to driver/phy. However using the

Re: [PATCH v11 0/8] PHY framework

2013-09-20 Thread Greg KH
On Fri, Sep 20, 2013 at 11:04:40AM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 17 September 2013 09:11 PM, Felipe Balbi wrote: On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: On Tue, Sep 03, 2013

Re: [PATCH v11 0/8] PHY framework

2013-09-03 Thread Greg KH
On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: Hi, On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote:

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-08-01 Thread Greg KH
On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote: +static int phy_get_id(void) +{ + int ret; + int id; + + ret = ida_pre_get(phy_ida, GFP_KERNEL); + if (!ret) + return -ENOMEM; + + ret = ida_get_new(phy_ida, id); + if (ret 0) +

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-08-01 Thread Greg KH
On Wed, Jul 31, 2013 at 04:44:43PM -0400, Alan Stern wrote: On Wed, 31 Jul 2013, Tomasz Figa wrote: Alan, Greg, On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here.

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 09:58:34PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in the first place, right? IMHO it would be better if you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.) I got copied in very late so don't have most of the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: That's not so bad, as long as you let the phy core use whatever name it wants for the device when it registers it with sysfs. Yes, in regulator core consumer names are completely separated from this. Regulator core simply

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-22 Thread Greg KH
On Mon, Jul 22, 2013 at 12:55:18PM +0530, Kishon Vijay Abraham I wrote: The issue (or one of the issues) in this discussion is that Greg does not like the idea of using names or IDs to associate PHYs with controllers, because they are too prone to duplications or other

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 08:49:32AM +0530, Kishon Vijay Abraham I wrote: Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you can get to, then put the pointer there, don't use a name

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module *owner, struct phy * (*of_xlate)(struct device *dev, + struct of_phandle_args *args)); +struct phy_provider

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. However using the old USB PHY library cannot be completely removed

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: +ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy anywhere in it? You rely on the sender to never send a duplicate name.id pair? Why not create your own ids based on the

Re: [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2013-01-24 Thread Greg KH
On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote: Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH 1/2] serial: samsung: Remove NULL checking for baud clock

2012-06-20 Thread Greg KH
On Wed, Jun 20, 2012 at 01:28:36PM +0900, Kukjin Kim wrote: Kukjin Kim wrote: Kyoungil Kim wrote: Kyoungil Kim wrote: I missed following. Russell King suggested: As I said, drivers have no business interpreting anything but IS_ERR(clk) as being an error. They

Re: [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate

2012-06-20 Thread Greg KH
On Wed, Jun 20, 2012 at 01:28:40PM +0900, Kukjin Kim wrote: Kyoungil Kim wrote: port-baudclk_rate should be compared to the rate of port-baudclk, because port-baudclk_rate was assigned as the rate of port-baudclk previously. So to check that the current baudclk rate is same as previous

Re: [PATCH] serial: samsung: protect NULL dereference of clock name

2012-06-20 Thread Greg KH
On Wed, Jun 20, 2012 at 01:28:47PM +0900, Kukjin Kim wrote: Kyoungil Kim wrote: From: KeyYoung Park keyyoung.p...@samsung.com When priting the serial clock source, if clock source name is null, kernel reference NULL point. Signed-off-by: KeyYoung Park keyyoung.p...@samsung.com

Re: [GIT PULL] Samsung usb stuff for v3.5

2012-05-17 Thread Greg KH
On Thu, May 17, 2012 at 03:45:55PM +0900, Kukjin Kim wrote: Hi Greg and Felipe, Please pull Samsung 's3c-hsotg' UDC support for EXYNOS4210 and S5PV210 from: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.5-for-usb Since it has a dependency on 'usb: hsotg:

Re: [PATCH 2/3] USB: SET SEL request definition

2012-02-06 Thread Greg KH
On Mon, Feb 06, 2012 at 05:12:33PM +0900, Anton Tikhomirov wrote: Cc: Kukjin Kim kgene.kim at samsung.com Cc: Greg Kroah-Hartman gregkh at suse.de Cc: Felipe Balbi balbi at ti.com What is that mess? It belongs, with real email addresses, below your signed-off-by line, if at all. Adds SET

Re: Re: [PATCH 0/3] Support Samsung S5P OHCI device and driver

2011-12-21 Thread Greg KH
On Wed, Dec 21, 2011 at 01:38:24PM +0900, Kukjin Kim wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Saturday, December 10, 2011 8:58 AM To: Kukjin Kim Cc: 'Jingoo Han'; linux-arm-ker...@lists.infradead.org; linux- u...@vger.kernel.org; linux-samsung

Re: Re: [PATCH 0/3] Support Samsung S5P OHCI device and driver

2011-12-09 Thread Greg KH
On Thu, Dec 01, 2011 at 07:10:17PM +0900, Kukjin Kim wrote: Greg KH wrote: On Mon, Nov 21, 2011 at 11:57:16AM +, Jingoo Han wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Friday, November 18, 2011 4:12 AM To: Jingoo Han Cc: linux-arm-ker

Re: Re: [PATCH 0/3] Support Samsung S5P OHCI device and driver

2011-11-21 Thread Greg KH
On Mon, Nov 21, 2011 at 11:57:16AM +, Jingoo Han wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Friday, November 18, 2011 4:12 AM To: Jingoo Han Cc: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux-samsung-soc@vger.kernel.org

Re: [PATCH 0/3] Support Samsung S5P OHCI device and driver

2011-11-17 Thread Greg KH
On Tue, Nov 15, 2011 at 06:49:58AM +, Jingoo Han wrote: Hello. This patch series adds USB OHCI device and initial driver for Samsung S5P SoCs and is based from Linux 3.2-rc1. I have tested on SMDKV310 board using EXYNOS4. This is to be sent through some arm tree, not the usb tree,

Re: [PATCH v2 0/9] serial: samsung: rework clock lookup and add device tree support

2011-10-24 Thread Greg KH
100644 drivers/tty/serial/s3c2410.c delete mode 100644 drivers/tty/serial/s3c2412.c delete mode 100644 drivers/tty/serial/s3c2440.c delete mode 100644 drivers/tty/serial/s3c6400.c delete mode 100644 drivers/tty/serial/s5pv210.c (Cc'ed Greg KH) Looks good for me, and I need to get

Re: [GIT PULL] Samsung Fixes for v3.1-rc7

2011-09-16 Thread Greg KH
On Fri, Sep 16, 2011 at 08:50:51PM +0900, Kukjin Kim wrote: Arnd Bergmann wrote: On Thursday 15 September 2011, Kukjin Kim wrote: This is Samsung fixes for v3.1 Please pull from: git://github.com/kgene/linux-samsung.git samsung-fixes-2 As you know,

Re: [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART

2011-05-28 Thread Greg KH
On Fri, May 27, 2011 at 07:04:03PM -0700, Kukjin Kim wrote: From: Boojin Kim boojin@samsung.com This patch fixes the way of comparison for handling of two or more clock sources for UART. For example, if just only one clock source is defined even though there are two clock sources for

Re: [PATCH v4 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-16 Thread Greg KH
On Sat, Apr 16, 2011 at 12:00:31PM +0200, Heiko Stübner wrote: Am Donnerstag 14 April 2011, 19:15:23 schrieb Alan Stern: On Thu, 14 Apr 2011, Greg KH wrote: On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote: On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote: From

Re: [PATCH RESEND v3 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2011-04-13 Thread Greg KH
On Wed, Mar 23, 2011 at 10:39:28PM +0100, Heiko Stübner wrote: From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx

Re: [PATCH 3/4] ARM: EXYNOS4: Add usb ehci device to the NURI board

2011-04-13 Thread Greg KH
On Fri, Apr 08, 2011 at 01:22:11PM +0900, Joonyoung Shim wrote: This patch is to support usb ehci device to the NURI board. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Note, I had to apply this one by hand, I don't know what

Re: USB: Gadget: COMPOSITE: Debug interface number

2011-02-04 Thread Greg KH
On Fri, Feb 04, 2011 at 06:50:27PM +0900, Jassi Brar wrote: Hi, The commit 'avoid access beyond array max length' incorrectly compares w_index with MAX_CONFIG_INTERFACES. Whereas only lower 8bits of w_index refer to the interface number. So, use 'intf' rather than 'w_index' for comparison.

Re: s3c-hsotg patches

2010-07-14 Thread Greg KH
On Wed, Jul 14, 2010 at 11:39:50AM +0200, Marek Szyprowski wrote: Hello, On Wednesday, July 07, 2010 5:13 PM Greg KH wrote: On Wed, Jul 07, 2010 at 01:02:12AM +0100, Ben Dooks wrote: Re-send of previous set, with corrected patches. Hm, what tree are these going through? Do you

Re: [PATCH 1/6] USB: s3c_hsotg: Add support for external USB clock

2010-06-01 Thread Greg KH
On Tue, May 25, 2010 at 05:36:48AM +0100, Ben Dooks wrote: From: Maurus Cuelenaere mcuelena...@gmail.com The PLL that drives the USB clock supports 3 input clocks: 12, 24 and 48Mhz. This patch adds support to the USB driver for setting the correct register bit according to the given clock.