[PATCH v2] drm/exynos: fix kernel panic issue at drm releasing

2016-01-05 Thread Inki Dae
event objects belonging to the request process, increment event space and decrease pending_update when cancelling the event Signed-off-by: Inki Dae <inki@samsung.com> Reviewed-by: Daniel Stone <dani...@collabora.com> --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 18 +++

Re: [PATCH] drm/exynos: fix kernel panic issue at drm releasing

2016-01-05 Thread Inki Dae
Hi Daniel, 2016년 01월 05일 05:24에 Daniel Stone 이(가) 쓴 글: > Hi Inki, > > On 4 January 2016 at 12:57, Inki Dae <inki@samsung.com> wrote: >> 2015년 12월 24일 22:32에 Daniel Stone 이(가) 쓴 글: >>> On 24 December 2015 at 09:10, Inki Dae <inki..

Re: [PATCH] drm/exynos: fix kernel panic issue at drm releasing

2016-01-05 Thread Inki Dae
+ Rob Clark, Hi Daniel and Rob, 2016년 01월 05일 20:08에 Daniel Vetter 이(가) 쓴 글: > On Tue, Jan 05, 2016 at 07:55:52PM +0900, Inki Dae wrote: >> Hi Daniel, >> >> 2016년 01월 05일 05:24에 Daniel Stone 이(가) 쓴 글: >>> Hi Inki, >>> >>> On 4 January 2016

Re: [PATCH v3 1/7] drm/exynos: rename zpos to index

2016-01-04 Thread Inki Dae
Hi Marek, 2015년 12월 28일 21:34에 Marek Szyprowski 이(가) 쓴 글: > Hello, > > On 2015-12-24 09:15, Inki Dae wrote: >> Seems this patch could be more cleaned up. >> >> Each ctx object of each crtc driver has its own plane config object which >> includes already zpos

[PATCH] drm/exynos: crtc: do not wait for the scanout completion

2015-12-24 Thread Inki Dae
This patch removes exynos_drm_crtc_complete_scanout function call which makes sure for overlay data to be updated to real hardware when drm driver is released. With atomic modeset support, it doesn't need the function anymore because atomic modeset interface makes sure that. Signed-off-by: Inki

[PATCH] drm/exynos: fix kernel panic issue at drm releasing

2015-12-24 Thread Inki Dae
flip if the drm_file object was removed by drm_release and there was a pended page flip event which was already committed to hardware. So this patch makes the pended page flip event to be cancelled by preclose callback which is called at front of drm_release function. Signed-off-by: Inki Dae <i

Re: [PATCH v3 1/7] drm/exynos: rename zpos to index

2015-12-24 Thread Inki Dae
mixer_cfg_layer(mixer_ctx, plane->index, 0, false); + mixer_cfg_layer(mixer_ctx, plane->config->index, 0, false); mixer_vsync_set_update(mixer_ctx, true); spin_unlock_irqrestore(>reg_slock, flags); @@ -1189,7 +1189,7 @@ static int mixer_bind(struct device *dev, struct de

Re: [PATCH v3 1/7] drm/exynos: rename zpos to index

2015-12-24 Thread Inki Dae
E_I80) > set_bit(BIT_WIN_UPDATED, >flags); > @@ -502,7 +502,7 @@ static int decon_bind(struct device *dev, struct device > *master, void *data) > ctx->configs[win].zpos = win; > ctx->configs[win].type = decon_win_types[tmp]; > > -

Re: [PATCH v2 06/22] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

2015-12-11 Thread Inki Dae
Hi Marek, 2015년 12월 11일 18:26에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2015-12-11 10:02, Inki Dae wrote: >> Hi Marek, >> >> I found out why NULL point access happened. That was incurred by below your >> patch, >> [PATCH] drm/exynos: move dma_addr a

Re: [PATCH v2 06/22] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

2015-12-11 Thread Inki Dae
Hi Marek, 2015-12-11 20:27 GMT+09:00 Marek Szyprowski <m.szyprow...@samsung.com>: > Hi Inki, > > > On 2015-12-11 10:57, Inki Dae wrote: >> >> Hi Marek, >> >> 2015년 12월 11일 18:26에 Marek Szyprowski 이(가) 쓴 글: >>> >>> Hi Inki, >

Re: [PATCH] drm/exynos: atomic check only enabled crtc states

2015-12-11 Thread Inki Dae
artinez Canillas <jav...@osg.samsung.com> >> > > This patch was never picked but fixes and important > bug introduced in the v4.4 merge window so it should > be sent during the v4.4-rc cycle. Don't worry about that. Thanks, Inki Dae > > Best regards,

Re: [PATCH v2 14/22] drm/exynos: fimd: fix dma burst size setting for small plane size

2015-12-11 Thread Inki Dae
2015년 12월 10일 21:59에 Marek Szyprowski 이(가) 쓴 글: > Hello, > > On 2015-12-10 12:35, Inki Dae wrote: >> Hi Marek, >> >> 2015년 11월 30일 22:53에 Marek Szyprowski 이(가) 쓴 글: >>> This patch fixes trashed display of buffers cropped to very small width. >>> Ev

Re: [PATCH v2 06/22] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

2015-12-11 Thread Inki Dae
ned out. Anyway, I can fix it like below if you are ok. Thanks, Inki Dae --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -137,7 +137,7 @@ static void vidi_update_plane(struct exynos_drm_crtc *crtc, if (ctx->suspended)

Re: [PATCH v2 10/22] drm/exynos: introduce exynos_drm_plane_config structure

2015-12-10 Thread Inki Dae
1 << ctx->pipe, type, formats, > - ARRAY_SIZE(formats), zpos); > + plane_config.pixel_formats = formats; > + plane_config.num_pixel_formats = ARRAY_SIZE(formats); > + > + for (i = 0; i < WINDOWS_NR; i

Re: [PATCH v2 14/22] drm/exynos: fimd: fix dma burst size setting for small plane size

2015-12-10 Thread Inki Dae
different from above description. I think below patch is just cleanup, which passes each member necessary instead of passing a drm_framebuffer object. Thanks, Inki Dae > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- > drivers/gpu/drm/ex

Re: [PATCH v2 06/22] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

2015-12-10 Thread Inki Dae
24 (d7900101) When vidi driver is intiated by triggering a connection sysfs file, vidi driver tries modeset binding by calling drm_fb_helper_hotplug_event. However, at this time it seems there is a case that plan->state->crtc exists but plane->fb is NULL, which would be related to vi

Re: [PATCH v2 03/22] drm/exynos: gsc: add device tree support and remove usage of static mappings

2015-12-09 Thread Inki Dae
CCing Mr. Kukjin and Krzysztof Hi Kukjin and Krzysztof, Below patch includes dt binding about gsc device but it'd be nice this patch to exynos drm tree with others. So could you give me Acked-by so that I can merge it to exynos drm tree? Thanks, Inki Dae 2015년 11월 30일 22:53에 Marek Szyprowski

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Inki Dae
Hi Javier, 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello Inki, > > On 12/07/2015 09:52 AM, Inki Dae wrote: >> From: Javier Martinez Canillas <jav...@osg.samsung.com> >> > > Thanks a lot for posting this patch. > &g

[PATCH v2 3/4] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-07 Thread Inki Dae
-by: Inki Dae <inki@samsung.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- .../bindings/display/exynos/exynos_dp.txt | 41 +++--- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/di

[PATCH v2 2/4] drm/exynos: dp: fix wrong return type

2015-12-07 Thread Inki Dae
if getting a port node failed. Signed-off-by: Inki Dae <inki@samsung.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_

[PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Inki Dae
ch Pit that has a eDP to LVDS chip and uses OF graph too. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Inki Dae <inki@samsung.com> --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 15

[PATCH v3 1/4] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-07 Thread Inki Dae
. Changelog v2: - return -EINVAL if getting a port node failed. Signed-off-by: Inki Dae <inki@samsung.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 21 - 1 file changed, 20 insertions(+)

[PATCH v2 0/4] drm/exynos: dp: consider port node outbound for panel

2015-12-07 Thread Inki Dae
and Javier. - update description about eDP device. Thanks, Inki Dae Inki Dae (3): drm/exynos: dp: add of_graph dt binding support for panel drm/exynos: dp: fix wrong return type dt-bindings: exynos-dp: update ports node binding for panel Javier Martinez Canillas (1): ARM: dts: Use OF graph

[PATCH] drm/exynos: decon: remove unused variables

2015-12-07 Thread Inki Dae
This patch just removes unused variables, i and ret. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Inki Dae
2015년 12월 08일 09:48에 Krzysztof Kozlowski 이(가) 쓴 글: > On 08.12.2015 00:36, Inki Dae wrote: >> Hi Javier, >> >> 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >>> Hello Inki, >>> >>> On 12/07/2015 09:52 AM, In

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Inki Dae
2015년 12월 08일 10:47에 Krzysztof Kozlowski 이(가) 쓴 글: > On 08.12.2015 10:33, Javier Martinez Canillas wrote: >> Hello Krzysztof, >> >> On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote: >>> On 07.12.2015 21:52, Inki Dae wrote: >>>> From: Javier

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-06 Thread Inki Dae
Hi Javier, 2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > > Hello Inki, > > On 12/02/2015 11:11 PM, Inki Dae wrote: >> Hi Javier, >> >> 2015년 12월 03일 00:04에 Javier Martinez Canillas 이(가) 쓴 글: >>> Hello Inki, &

Re: [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-04 Thread Inki Dae
Hi Javier, 2015년 12월 03일 22:29에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On 12/03/2015 06:30 AM, Inki Dae wrote: >> This patch updates a ports node binding for panel. >> >> With this, dp node can have a ports node which describes >> a remote en

Re: [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Inki Dae
l be merged to exynos-drm-next. > > On 12/03/2015 06:30 AM, Inki Dae wrote: >> This patch adds of_graph dt binding support for panel device >> and also keeps the backward compatibility. >> >> i.e., >> The dts file for Exynos5800 based peach pi board >> has

Re: [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-04 Thread Inki Dae
Hi Rob, 2015년 12월 04일 08:38에 Rob Herring 이(가) 쓴 글: > On Thu, Dec 03, 2015 at 06:30:10PM +0900, Inki Dae wrote: >> This patch updates a ports node binding for panel. >> >> With this, dp node can have a ports node which describes >> a remote endpoint node that can be c

Re: [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Inki Dae
Hi Javier, 2015-12-04 21:38 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello Inki, > > On 12/04/2015 06:00 AM, Inki Dae wrote: >> Hi Javier, >> >> 2015년 12월 03일 22:55에 Javier Martinez Canillas 이(가) 쓴 글: >>> Hello Inki, >>>

[PATCH v2 2/3] drm/exynos: dp: fix wrong return type

2015-12-03 Thread Inki Dae
if getting a port node failed. Signed-off-by: Inki Dae <inki@samsung.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_

[PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-03 Thread Inki Dae
This patch updates a ports node binding for panel. With this, dp node can have a ports node which describes a remote endpoint node that can be connected to panel or bridge node. Signed-off-by: Inki Dae <inki@samsung.com> --- .../bindings/display/exynos/exynos_dp.txt

[PATCH 0/3] drm/exynos: dp: consider port node outbound for panel

2015-12-03 Thread Inki Dae
on google.com so couldn't link it. Thanks, Inki Dae [1] [PATCH 0/2] drm/exynos: dp: add of_graph dt binding for panel device Inki Dae (3): drm/exynos: dp: add of_graph dt binding support for panel drm/exynos: dp: fix wrong return type dt-bindings: exynos-dp: update ports node binding for panel

[PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-03 Thread Inki Dae
. Changelog v2: - return -EINVAL if getting a port node failed. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/d

[PATCH] drm/exynos: dsi: modify a error type when getting a node failed

2015-12-02 Thread Inki Dae
This patch makes it to return -EINVAL instead of -ENXIO when getting a port or endpoint node failed. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-02 Thread Inki Dae
It seems that below patch should be modifed for only one of two outbound nodes - panel and bridge - to be bound because in case of using bridge device, the bridge driver will bind the panel. I will fix and post it again. Thanks, Inki Dae 2015년 12월 02일 20:57에 Inki Dae 이(가) 쓴 글: > This pa

[PATCH v2 2/2] drm/exynos: dp: fix wrong return type

2015-12-02 Thread Inki Dae
if getting a port node failed. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 0b53045..c

[PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-02 Thread Inki Dae
-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 94f02a0..0b53045

Re: [PATCH 2/2] drm/exynos: dp: fix wrong return type

2015-12-02 Thread Inki Dae
Hi Javier, 2015년 11월 26일 22:35에 Javier Martinez Canillas 이(가) 쓴 글: > [adding Ajay Kumar who added the bridge support] > > Hello Inki, > > On 11/26/2015 09:47 AM, Inki Dae wrote: >> This patch fixes wrong return type when dt binding of bridge device >> failed. &g

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-02 Thread Inki Dae
Hi Javier, 2015년 12월 03일 00:04에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On 12/02/2015 08:57 AM, Inki Dae wrote: >> This patch adds of_graph dt binding support for panel device >> and also keeps the backward compatibility. >> > > You have to als

Re: [PATCH] drm/exynos: simplify sleep PM ops

2015-12-01 Thread Inki Dae
zej Hajda <a.ha...@samsung.com> > --- > Hi Inki, > > This is the patch I have promised during our discussion about > PM callbcks in components. Thanks for your patch. I will check it. Thanks, Inki Dae > > Regards > Andrzej > > drivers/gpu/drm/exynos/exynos_drm_d

[PATCH v3] drm/exynos: add pm_runtime to Mixer

2015-11-26 Thread Inki Dae
change Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_mixer.c | 106 -- 1 file changed, 64 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH v3] drm/exynos: add pm_runtime to HDMI

2015-11-26 Thread Inki Dae
Mofidy CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 49 +--- 1 file changed, 40 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v3] drm/exynos: add pm_runtime to DP

2015-11-26 Thread Inki Dae
ed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 51 +++-- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp

[PATCH v3] drm/exynos: add pm_runtime to DECON 7

2015-11-26 Thread Inki Dae
_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 93 ++ 1 file changed, 55 insertions(+), 38 deletions(-) diff --git a/d

[PATCH v3] drm/exynos: add pm_runtime to FIMD

2015-11-26 Thread Inki Dae
Remove unnecessary changes which removed commit callback from decon drivers and modify CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/e

[PATCH 0/2] drm/exynos: dp: add of_graph dt binding for panel device

2015-11-26 Thread Inki Dae
This patch series adds of_graph dt binding for panel device and fixes wrong return type when the dt binding of bridge device failed. Inki Dae (2): drm/exynos: dp: add of_graph dt binding support for panel drm/exynos: dp: fix wrong return type drivers/gpu/drm/exynos/exynos_dp_core.c | 27

[PATCH 2/2] drm/exynos: dp: fix wrong return type

2015-11-26 Thread Inki Dae
This patch fixes wrong return type when dt binding of bridge device failed. If a board has a bridge device then of_graph_get_remote_port_parent function shouldn't be NULL. So this patch will return a proper error type so that the deferred probe isn't triggered. Signed-off-by: Inki Dae <i

[PATCH 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-11-26 Thread Inki Dae
This patch adds of_graph dt binding support for panel device and also keeps the backward compatibility. i.e., The dts file for Exynos5800 based peach pi board has a panel property so we need to keep the backward compatibility. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/g

Re: [PATCH v2 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

2015-11-25 Thread Inki Dae
2015-11-24 2:44 GMT+09:00 Tobias Jakobi <tjak...@math.uni-bielefeld.de>: > Hey Inki, > > > Inki Dae wrote: >> >> >> 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >>> This analyses the current layer configuration (which layers >>> are e

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-25 Thread Inki Dae
Hi Javier, 2015-11-24 22:19 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello Inki, > > On 11/23/2015 11:28 PM, Inki Dae wrote: >> Hi Javier, >> >> 2015년 11월 24일 03:38에 Javier Martinez Canillas 이(가) 쓴 글: >>> Hello Inki, >>> &g

Re: [PATCH v2 1/5] drm/exynos: mixer: refactor layer setup

2015-11-25 Thread Inki Dae
2015-11-24 2:44 GMT+09:00 Tobias Jakobi <tjak...@math.uni-bielefeld.de>: > Hey Inki, > > > Inki Dae wrote: >> Hi Tobias, >> >> 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >>> First step in allowing a more generic way to setup complex >>>

Re: [PATCH v2 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

2015-11-25 Thread Inki Dae
2015-11-24 2:44 GMT+09:00 Tobias Jakobi <tjak...@math.uni-bielefeld.de>: > Hey Inki, > > > Inki Dae wrote: >> >> >> 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >>> This updates the blending setup when the layer configuration >>> changes (trig

Re: [PATCH v2 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

2015-11-23 Thread Inki Dae
erstood correctly, if (cfg->index == 2) { val = 0; mixer_reg_write(res, MXR_VIDEO_CFG, val); } else { mixer_general_layer(ctx, >layer_cfg[i]); } It'd be better to use a macro

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-23 Thread Inki Dae
Hi Javier, 2015년 11월 24일 03:38에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On 11/23/2015 01:47 PM, Inki Dae wrote: >> 2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >>> Hello, >>> >>> On 11/

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-23 Thread Inki Dae
2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello, > > On 11/21/2015 11:59 AM, Inki Dae wrote: >> Hi Daniel, >> >> >> 2015-11-21 22:40 GMT+09:00 Daniel Stone <dan...@fooishbar.org>: >>> Hi Inki, >>>

Re: [PATCH v2 1/5] drm/exynos: mixer: refactor layer setup

2015-11-22 Thread Inki Dae
+{ > + u32 val = 0; > + unsigned int i, priority; > + > + for (i = 0; i < ctx->num_layer; ++i) { > + priority = ctx->layer_cfg[i].priority; > + BUG_ON(priority > 15); What doesn constant, 15 mean? You need to clarify the meanin

Re: [PATCH v2 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

2015-11-22 Thread Inki Dae
er_blending() > + * below can use it. > + */ > + ctx->layer_state = new_layer_state; It may be trivial but I think it'd be better to move above line to most bottom of this function. > + > switch (win) { > case 0: > mixer_reg_writemask(res, MXR_CFG, val, MXR_CFG_G

Re: [PATCH v2 00/13] drm/exynos: async G2D and g2d_move()

2015-11-22 Thread Inki Dae
Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> Acked-by: Inki Dae <inki@samsung.com> Thanks, Inki Dae > > BRs, > Hyungwon Hwang > > On Sun, 22 Nov 2015 19:48:30 +0100 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> Hello

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-21 Thread Inki Dae
Hi Daniel, 2015-11-21 22:40 GMT+09:00 Daniel Stone <dan...@fooishbar.org>: > Hi Inki, > > On 21 November 2015 at 09:38, Inki Dae <daei...@gmail.com> wrote: >> 2015-11-21 1:44 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >>> On 11/20/20

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-21 Thread Inki Dae
Hi Javier, 2015-11-21 1:44 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello Inki, > > On 11/20/2015 08:13 AM, Inki Dae wrote: >> >> >> 2015년 11월 20일 19:59에 Inki Dae 이(가) 쓴 글: >>> Hi Javier, >>> >>> 2015년 11월 20일 00:

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-21 Thread Inki Dae
2015-11-21 1:23 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: > Hello Inki, > > On 11/20/2015 07:59 AM, Inki Dae wrote: >> Hi Javier, >> >> 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >>> On 11/19/201

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Inki Dae
2015년 11월 20일 19:59에 Inki Dae 이(가) 쓴 글: > Hi Javier, > > 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>>>> >>>> >>>> This series causes a boot failure on at least

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Inki Dae
Exynos5800 Peach Pi board. :( For this, I pushed it to below exynos-drm/for-next branch, https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm/for-next=e84f43e2b2c3388694b0b3a58c2c4447f1fbae7c If the issue is resolved by the change then I will modify other

[PATCH] drm/exynos: dsi: add runtime pm support

2015-11-16 Thread Inki Dae
This patch adds runtime pm interfaces to dsi driver. Each sub driver should control not only its own clocks and regulator but also its power domain. For this, it removes existing exynos_dsi_poweron/poweroff interfaces and uses runtime pm interfaces instead. Signed-off-by: Inki Dae <i

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-04 Thread Inki Dae
2015년 11월 04일 19:13에 Andrzej Hajda 이(가) 쓴 글: > On 11/04/2015 08:56 AM, Inki Dae wrote: >> >> 2015년 11월 04일 16:24에 Andrzej Hajda 이(가) 쓴 글: >>> On 11/03/2015 04:38 PM, Inki Dae wrote: >>>> >>>> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda <a

[PATCH v2 6/7] drm/exynos: add pm_runtime to DECON 5433

2015-11-03 Thread Inki Dae
gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 54 +++ 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/d

[PATCH v2 2/7] drm/exynos: add pm_runtime to DP

2015-11-03 Thread Inki Dae
k> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 58 ++--- 1 file changed, 46 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index e4d32

[PATCH v2 7/7] drm/exynos: add pm_runtime to DECON 7

2015-11-03 Thread Inki Dae
gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 125 - 1 file changed, 53 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/d

[PATCH v2 3/7] drm/exynos: add pm_runtime to HDMI

2015-11-03 Thread Inki Dae
gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 56 1 file changed, 38 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exyno

[PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-03 Thread Inki Dae
This patch series adds pm runtime support for Exynos drm. Originally, this patch was posted by Gustavo but there was no any answer about some comments. So I rebased this patch series on top of exynos-drm-next, removed unnecessary patches and modified wrong macro. Changelog v2: - Remove patch 5

[PATCH v2 4/7] drm/exynos: add pm_runtime to Mixer

2015-11-03 Thread Inki Dae
From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: In

[PATCH v2 1/7] drm/exynos: do not start enabling DP at bind() phase

2015-11-03 Thread Inki Dae
From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> The DP device will be properly enabled at the enable() call just after the bind call finishes. Changelog v2: - no change Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki.

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-03 Thread Inki Dae
2015년 11월 04일 16:24에 Andrzej Hajda 이(가) 쓴 글: > On 11/03/2015 04:38 PM, Inki Dae wrote: >> >> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda <a.ha...@samsung.com >> <mailto:a.ha...@samsung.com>>: >>> Hi Inki, >>> >>> On 11/03/2015 11:4

[PATCH v2 5/7] drm/exynos: add pm_runtime to FIMD

2015-11-03 Thread Inki Dae
rivers and modify CONFIG_PM_SLEEP -> CONFIG_PM Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 91 +--- 1 file changed, 37 insertions(+), 54 del

Re: drm/exynos: when to call dma_map_sg() on a GEM object?

2015-11-02 Thread Inki Dae
This dma mapping API calls internally iommu_map function of iommu framework after allocating physical pages and iova space, and the iova space will be mapped with physical pages. Please, look into the dma mapping framework - arch/arm/mm/dma-mapping.c - if you want to understand. I think you

Re: [PATCH 3/7] ARM: exynos_defconfig: enable Exynos DRM Mixer driver

2015-10-28 Thread Inki Dae
zlowski <k.kozlow...@samsung.com> > > I guess this will go with rest of patchset through Exynos DRM tree: > Acked-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Thanks for ack. I will pick it up. Thanks, Inki Dae > > > Best regards, > Krzysztof > > --

Re: [PATCH 0/7] add atomic_check callback to exynos_crtc

2015-10-27 Thread Inki Dae
ath of DECON controller transfers Display data to HDMI like MIXER IP of previous Exynos SoC did. Thanks, Inki Dae > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message

Re: [PATCH 10/10] drm/exynos/decon5433: add support for DECON-TV

2015-10-23 Thread Inki Dae
r intention? Shouldn't ctx->planes[] have 1st, 2nd ,3rd and 4th planes so that we can use 1st ~ 4th hardware overlay for DECON TV? DECON TV for Exynos5433 SoC can use only 1st ~ 4th hardware overlays. And other thing, it may be trivial but I think it'd be better to use 'ovl' instead of 'tmp. Thanks, Inki Dae -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/10] drm/exynos/decon5433: add support for DECON-TV

2015-10-23 Thread Inki Dae
2015-10-23 22:03 GMT+09:00 Andrzej Hajda <a.ha...@samsung.com>: > > On 10/23/2015 01:55 PM, Inki Dae wrote: > > Hi Andrzej, > > > > > > 2015년 10월 20일 18:22에 Andrzej Hajda 이(가) 쓴 글: > >> DECON-TV IP is responsible for generating video stream which is tr

Re: [PATCH 07/10] drm/exynos: add pm_runtime to FIMD

2015-10-12 Thread Inki Dae
Also ping~~ 2015년 09월 19일 12:53에 Inki Dae 이(가) 쓴 글: On 2015년 09월 05일 05:15, Gustavo Padovan wrote: From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled

Re: [PATCH] drm/exynos: fix spelling errors

2015-10-12 Thread Inki Dae
Hi, Ingi. Merged. Thanks for your first patch to drm world. :) This patch isn't trivial so will go to next. Thanks, Inki Dae 2015년 10월 02일 17:59에 Ingi Kim 이(가) 쓴 글: > This patch fixes spelling errors in drm fimc/gsc > inavild -> invaild > > Signed-off-by: Ingi Kim <ing

Re: [PATCH 1/2] drm/exynos: add global macro for the default primary plane

2015-10-12 Thread Inki Dae
Hi Gustavo, Merged. Thanks, Inki Dae 2015년 09월 05일 07:05에 Gustavo Padovan 이(가) 쓴 글: > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > > Define DEFAULT_WIN as zero to help set the primary plane on all CRTCs. > Some CRTCs were defining a variable to store

Re: [PATCH 08/10] drm/exynos: Enable DP clock directly from FIMD

2015-10-12 Thread Inki Dae
Gustavo, please ping~~~ 2015년 09월 19일 12:51에 Inki Dae 이(가) 쓴 글: Hi Gustavo, On 2015년 09월 05일 05:15, Gustavo Padovan wrote: From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Instead of having a .clock_enable callback enable the dp clock directly from FIMD. Signed-off-by: G

Re: [PATCH 2/2] drm/exynos: add cursor plane support

2015-10-12 Thread Inki Dae
Merged. Thanks, Inki Dae 2015년 09월 05일 07:05에 Gustavo Padovan 이(가) 쓴 글: > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > > Set one of the planes for each crtc driver as a cursor plane enabled > window managers to fully work on exynos. > > Signed

Re: [PATCH 00/16] drm/exynos/hdmi: refactoring/cleanup patches

2015-10-12 Thread Inki Dae
Hi Andrzej, For all patches, merged excepting patch 2 which cleans up dt binding document. Thanks, Inki Dae 2015년 09월 25일 21:48에 Andrzej Hajda 이(가) 쓴 글: > Hi, > > This is another set of cleanup/improvement patches for HDMI. > > The patchset is based on exynos-drm-next.

Re: [PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

2015-09-30 Thread Inki Dae
sts. Thanks for your patch. However, the pm interfaces of KMS drivers aren't required because these are controlled by top of Exynos drm driver and connector dpms. So I posted a patch that it removes pm interfaces of dp driver. Thanks, Inki Dae > > Signed-off-by: Ch

[PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
This patch removes unnecessary pm suspend/resume functions. All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

2015-09-30 Thread Inki Dae
Hi Emil, On 2015년 09월 30일 21:19, Emil Velikov wrote: > Hi Inki, > > On 30 September 2015 at 12:21, Inki Dae <inki@samsung.com> wrote: >> This patch removes unnecessary pm suspend/resume functions. >> >> All kms sub drivers will be controlled by top of Exynos

Re: [PATCH 08/10] drm/exynos: Enable DP clock directly from FIMD

2015-09-18 Thread Inki Dae
fimd_enable_vblank(ctx->crtc); > > + fimd_dp_clock_enable(crtc, true); You are forcing FIMD driver to enable DP clock every time FIMD is enabled. Please know that in Exynos Display pipeline, Encoder device could be used according to how Display path is configured. For example

Re: [PATCH 07/10] drm/exynos: add pm_runtime to FIMD

2015-09-18 Thread Inki Dae
.disable = decon_disable, > .mode_fixup = decon_mode_fixup, > - .commit = decon_commit, Ditto. Thanks, Inki Dae > .enable_vblank = decon_enable_vblank, > .disable_vblank = decon_disable_vblank, > .wait_for_vblank = decon_wait_for_vblank, >

Re: [PATCH] drm/exynos: add cursor plane support

2015-09-04 Thread Inki Dae
On 2015년 09월 04일 16:19, Daniel Vetter wrote: > On Fri, Sep 04, 2015 at 01:05:35PM +0900, Inki Dae wrote: >> Hi Gustavo, >> >> I had already a review but I didn't give any comment to you. Sorry about >> that. This patch looks good to me but one thing isn't cl

Re: [PATCH] drm/exynos: add cursor plane support

2015-09-03 Thread Inki Dae
5 > #define MAX_FB_BUFFER4 > > +#define DEFAULT_WIN 0 > +#define CURSOR_WIN 1 You fixed overlay number for cursor with 1. However, Display controllers of Exynos SoC have fixed overlay priority like this, win 4 > win 3 > win 2 > win 1 > win 0 so if we fix the ov

Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

2015-08-31 Thread Inki Dae
On 2015년 09월 01일 03:53, Emil Velikov wrote: > On 31 August 2015 at 14:25, Inki Dae <inki@samsung.com> wrote: >> On 2015년 08월 24일 23:14, Tobias Jakobi wrote: >>> We now validate the blending mode via g2d_validate_mode() >>> prior to feeding it to g2d_g

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

2015-08-31 Thread Inki Dae
On 2015년 09월 01일 04:57, Emil Velikov wrote: > On 31 August 2015 at 20:27, Tobias Jakobi <tjak...@math.uni-bielefeld.de> > wrote: >> Hello! >> >> Inki Dae wrote: >>> On 2015년 08월 24일 23:13, Tobias Jakobi wrote: > >>>> +if (g2d_ch

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

2015-08-31 Thread Inki Dae
owledge of the kernel module I'm inclined to pull this in >> even if we don't get too many reviewers. We better keep it around for >> a couple of weeks in case others are swamped with unrelated work atm, >> yet willing to take a look. > Sure, I'm going to wait and do some p

Re: [PATCH 05/14] exynos/fimg2d: check buffer space in g2d_copy()

2015-08-31 Thread Inki Dae
if (g2d_check_space(ctx, 11, 2)) > + return -ENOSPC; Above lines could be integrated with 3 and 4 patches as one patch. And you can make other codes to other one. Thanks, Inki Dae > + > + g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_BGCOLOR); > + g2d_add

Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

2015-08-31 Thread Inki Dae
NE, 0, 0, 0, G2D_COEFF_MODE_ZERO, > - 0, 0, 0); > - break; With this, how about changing above switch and case statement to if statement? Thanks, Inki Dae > } > > return val.val; > -- To unsubscribe from this list: send the line

Re: [PATCH 07/14] exynos/fimg2d: add g2d_validate_xyz() functions

2015-08-31 Thread Inki Dae
_SRC: > + case G2D_OP_DISJOINT_DST: > + case G2D_OP_CONJOINT_CLEAR: > + case G2D_OP_CONJOINT_SRC: > + case G2D_OP_CONJOINT_DST: > + return 0; Ditto, You could modify it like above. Thanks, Inki Dae > + } > + > + return 1; > +} >

  1   2   3   4   5   6   >