Re: [PATCH v2] [media] media-device: handle errors at media_device_init()

2015-12-21 Thread Javier Martinez Canillas
Mauro Carvalho Chehab <mche...@osg.samsung.com> > --- I agree with your patch, in fact the first version of the media split patch did exactly this and later media_device_init() was converted to void and the BUG_ON() introduced to address some feedback I got during the patches review. Review

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-21 Thread Javier Martinez Canillas
0] but he had a strong opinion about it and I didn't mind too much so I decided at the end to just change it to a BUG_ON() so I could get his ack for this set. > For sure, this is not the case here. Also, all drivers have already > a logic that checks if the device init happened. So, they

Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties

2015-12-10 Thread Javier Martinez Canillas
3 (Cortex-A7) and cpu4-7 (Cortex-A15) So the OPP tables are set in this DTSI file, to prevent the OPP tables in the Exynos5422 to be inverted for the cluster 0 and 1. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drm/exynos: atomic check only enabled crtc states

2015-12-09 Thread Javier Martinez Canillas
Hello Inki, On 11/27/2015 10:00 AM, Javier Martinez Canillas wrote: > Hello Andrzej, > > On 11/27/2015 03:57 AM, Andrzej Hajda wrote: >> Since atomic check is called also for disabled crtcs it should skip >> mode checking as it can be uninitialized. The patch fixes

Re: [PATCH v4 0/8] cpufreq: add generic cpufreq driver support for Exynos542x/5800 platforms

2015-12-09 Thread Javier Martinez Canillas
board. > I tested on an Exynos5800 Peach Pi and all governors are working as expected on both the Cortex-A7 and Cortex-A15 cores. So for the whole series: Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Researc

Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables

2015-12-08 Thread Javier Martinez Canillas
e exynos5800 devicetree, which has the CPU clusters >> reversed compared to the 5422. This results in the A15 cores only >> reaching 1.4GHz, the maximum rate of the KFC clock. >> >> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> >> Signed-off-by: Ben G

Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables

2015-12-08 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/08/2015 09:34 PM, Krzysztof Kozlowski wrote: > On 08.12.2015 22:41, Javier Martinez Canillas wrote: >> On 12/08/2015 05:13 AM, Krzysztof Kozlowski wrote: >>> >>> This looks like a very-non-atomic way of handling a change. You added >>>

Re: [PATCH] drm/exynos: decon: remove unused variables

2015-12-07 Thread Javier Martinez Canillas
_swreset(struct decon_context *ctx) > static void decon_enable(struct exynos_drm_crtc *crtc) > { > struct decon_context *ctx = crtc->ctx; > - int ret; > - int i; > > if (!test_and_clear_bit(BIT_SUSPENDED, >flags)) > return; >

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Inki, On 12/07/2015 09:52 AM, Inki Dae wrote: > From: Javier Martinez Canillas <jav...@osg.samsung.com> > Thanks a lot for posting this patch. > The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent > since it uses a phandle to describe the connect

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-07 Thread Javier Martinez Canillas
[adding Krzysztof and Kukjin to cc list] Hello Inki, On 12/06/2015 01:25 PM, Inki Dae wrote: > Hi Javier, > > 2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >> >> Hello Inki, >> >> On 12/02/2015 11:11 PM, Inki Dae wrote: >

Re: [PATCH] ARM: multi_v7_defconfig: Enable fan, sensors and audio for Odroid XU3

2015-12-07 Thread Javier Martinez Canillas
b/arch/arm/configs/multi_v7_defconfig > index f6a2557b55df..419f9413402c 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Gro

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/07/2015 09:48 PM, Krzysztof Kozlowski wrote: > On 08.12.2015 00:36, Inki Dae wrote: >> Hi Javier, >> >> 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >>> Hello Inki, >>> >>> On 12/07/201

Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote: > On 07.12.2015 21:52, Inki Dae wrote: >> From: Javier Martinez Canillas <jav...@osg.samsung.com> >> >> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent >> si

Re: [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Javier Martinez Canillas
Hello Inki, On 12/04/2015 06:00 AM, Inki Dae wrote: > Hi Javier, > > 2015년 12월 03일 22:55에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> I found that v2 of this patch is alredy in your exynos-drm for-next branch so >> so I had to revert it in linux-ne

Re: [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Javier Martinez Canillas
Hello Inki, On 12/04/2015 11:57 AM, Inki Dae wrote: > Hi Javier, > > 2015-12-04 21:38 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >> Hello Inki, >> >> On 12/04/2015 06:00 AM, Inki Dae wrote: >>> Hi Javier, >>> >>

Re: [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-03 Thread Javier Martinez Canillas
reg = <0>; > + ... > + port { > + dp_in: endpoint { > + remote-endpoint = <_out>; > }; > }; > }; > The rest looks good to me so with the two changes feel free

Re: [PATCH] drm/exynos: dsi: modify a error type when getting a node failed

2015-12-03 Thread Javier Martinez Canillas
dsi->bridge_node = of_graph_get_remote_port_parent(ep); > if (!dsi->bridge_node) { > - ret = -ENXIO; > + ret = -EINVAL; > goto end; > } > end: > Yes, I also think that -EINVAL is a better error code in this case. Reviewed-

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-03 Thread Javier Martinez Canillas
Hello Inki, On 12/02/2015 11:11 PM, Inki Dae wrote: > Hi Javier, > > 2015년 12월 03일 00:04에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> On 12/02/2015 08:57 AM, Inki Dae wrote: >>> This patch adds of_graph dt binding support for panel de

Re: [PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-03 Thread Javier Martinez Canillas
t;of_node, NULL); > if (endpoint) { > bridge_node = of_graph_get_remote_port_parent(endpoint); > @@ -1423,6 +1441,7 @@ static int exynos_dp_probe(struct platform_device *pdev) > return -EPROBE_DEFER; > } > > +out: > pm_runtime_enable(dev);

Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-02 Thread Javier Martinez Canillas
ay/exynos/exynos_dp.txt > i.e., > The dts file for Exynos5800 based peach pi board > has a panel property so we need to keep the backward compatibility. > How did you test this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe

Re: [PATCH v2 2/2] drm/exynos: dp: fix wrong return type

2015-12-02 Thread Javier Martinez Canillas
error > type so that the deferred probe isn't triggered. > > Changelog v2: > - return -EINVAL if getting a port node failed. > > Signed-off-by: Inki Dae <inki....@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards -- Javier Mart

Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards

2015-11-30 Thread Javier Martinez Canillas
Hi Alim, On 11/30/2015 01:59 PM, Alim Akhtar wrote: > Hi Javier, > > On Mon, Nov 30, 2015 at 7:31 PM, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> Hello Alim, >> >> On 10/12/2015 09:37 AM, Alim Akhtar wrote: >>> Since commit 2fad

Re: [PATCH] ARM: exynos_defconfig: Set recommended options for systemd

2015-11-30 Thread Javier Martinez Canillas
msung.com> > --- > arch/arm/configs/exynos_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe

Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards

2015-11-30 Thread Javier Martinez Canillas
akes sense or not. Also, do you know if the "simple-audio-card" can be used instead for snow and peachs as it is used for other Exynos5 boards or a specific ASoC machine driver is really needed for these Chromebooks? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Resea

Re: [PATCH] drm/exynos: atomic check only enabled crtc states

2015-11-27 Thread Javier Martinez Canillas
el Vetter <daniel.vet...@ffwll.ch> > --- > Hi Javier, > > Could you check with this patch. > The patch fixes the issue I reported. The display mode is correctly set with and without a HDMI monitor plugged. So on an Exynos5800 Peach Pi: Tested-by: Javier Martinez Canillas <jav.

Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

2015-11-26 Thread Javier Martinez Canillas
Is it possible to share them? > > There are test apps at: > http://git.linuxtv.org/cgit.cgi/snawrocki/samsung-utils.git/ > v4l2-mfc-example - MFC decoder, > v4l2-mfc-encoder - MFC encoder, > Great, thanks a lot for the information. > > Regards > Andrzej > Best regards

Re: [PATCH 2/2] drm/exynos: dp: fix wrong return type

2015-11-26 Thread Javier Martinez Canillas
} else { > + DRM_ERROR("no port node for bridge device.\n"); > + return -ENXIO; > + } > } > As I mentioned in the other thread, I wonder if -ENXIO is the best errno code in this case. Shouldn't -EINVAL be more appropriate since is abou

Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

2015-11-26 Thread Javier Martinez Canillas
Hello Marek, On 11/26/2015 11:29 AM, Marek Szyprowski wrote: > Hello, > > On 2015-11-24 05:32, Javier Martinez Canillas wrote: >> Hello Krzysztof, >> >> On 11/24/2015 12:50 AM, Krzysztof Kozlowski wrote: >>> On 23.11.2015 22:56, Javier Martinez

Re: [PATCH] ARM: exynos_defconfig: Enable NFSv4 client

2015-11-25 Thread Javier Martinez Canillas
testing kernel in automated > environments (network boot with network file system). > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, --- Javier Martinez Canillas Open S

[PATCH] ARM: dts: Remove unneeded GPIO include in exynos4412-odroidu3

2015-11-25 Thread Javier Martinez Canillas
The header is already included in the exynos4412-odroid-common DTSI so there's no need to do it again in the DTS file. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/ar

Re: [PATCH 2/7] drm/exynos/mixer: replace direct cross-driver call with drm mode validation

2015-11-24 Thread Javier Martinez Canillas
Hello Andrzej, On Mon, Oct 26, 2015 at 9:03 AM, Andrzej Hajda wrote: > HDMI driver called directly function from MIXER driver to invalidate modes > not supported by MIXER. The patch replaces the hack with proper .atomic_check > callback. > > Signed-off-by: Andrzej Hajda

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-24 Thread Javier Martinez Canillas
Hello Inki, On 11/23/2015 11:28 PM, Inki Dae wrote: > Hi Javier, > > 2015년 11월 24일 03:38에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> On 11/23/2015 01:47 PM, Inki Dae wrote: >>> 2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas >

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-23 Thread Javier Martinez Canillas
Hello Inki, On 11/23/2015 01:47 PM, Inki Dae wrote: > 2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >> Hello, >> >> On 11/21/2015 11:59 AM, Inki Dae wrote: >>> Hi Daniel, >>> >>> >>> 2015-11-21 22

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-23 Thread Javier Martinez Canillas
Hello, On 11/21/2015 11:59 AM, Inki Dae wrote: > Hi Daniel, > > > 2015-11-21 22:40 GMT+09:00 Daniel Stone <dan...@fooishbar.org>: >> Hi Inki, >> >> On 21 November 2015 at 09:38, Inki Dae <daei...@gmail.com> wrote: >>> 2015-11-21 1:44 GMT+09:

Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

2015-11-23 Thread Javier Martinez Canillas
gards, > Krzysztof > > [0]: https://lkml.org/lkml/2015/2/17/163 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord.

Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

2015-11-23 Thread Javier Martinez Canillas
Hello Krzysztof, On 11/24/2015 12:50 AM, Krzysztof Kozlowski wrote: > On 23.11.2015 22:56, Javier Martinez Canillas wrote: >> Hello Krzysztof, >> >> On 11/10/2015 09:43 PM, Krzysztof Kozlowski wrote: >> >> [snip] >> >>> >>> >>> BT

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2015 08:13 AM, Inki Dae wrote: > > > 2015년 11월 20일 19:59에 Inki Dae 이(가) 쓴 글: >> Hi Javier, >> >> 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >>> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>>>

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2015 07:59 AM, Inki Dae wrote: > Hi Javier, > > 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>>>> >>>> >>>> This series causes a boot failure on a

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-11-19 Thread Javier Martinez Canillas
Hello Alim, On Thu, Nov 19, 2015 at 3:06 PM, Alim Akhtar wrote: [snip] >> >> Javier, Alim, Ulf, >> >> I am not grabbing any more patches for v4.4 because I doubt that they >> could be merged to arm-soc for this cycle. My last pull requests for >> v4.4 is still pending...

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>> >> >> This series causes a boot failure on at least an Exynos5800 Peach Pi >> Chromebook (tested myself) and seems to be the cause of other Exynos >> boards failing to boot: http://kernelci.org/boot/

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
bootable state again, the sha1 hash for these patches in next-20151119 are: 045febd5f813 drm/exynos: add pm_runtime to FIMD dd766fb8479b drm/exynos: add pm_runtime to Mixer Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: sen

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
On 11/19/2015 11:51 AM, Javier Martinez Canillas wrote: > [adding Kevin and Tyler to cc list] > > Hello Inki and Gustavo, I didn't notice before that Gustavo was not cc'ed in the original email from Inki so I'm adding him as well. Sorry to others for the noise. > > On 11/03/2015

[RESEND PATCH v2 5/6] ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi

2015-11-18 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Reviewed-by: Alim Akhtar <alim.akh...@samsung.com> Tested-by: Alim Akhtar <alim.akh...@samsung.com> --- arch

[RESEND PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
The eMMC is non-removable so mark it using the non-removable DT property to avoid having to redetect it after a suspend/resume. Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by:

[RESEND PATCH v2 3/6] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Tomeu Vizoso <tomeu.viz...@coll

[RESEND PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-11-18 Thread Javier Martinez Canillas
-by tags that were previously collected. [0]: https://lkml.org/lkml/2015/10/15/640 Best regards, Javier Javier Martinez Canillas (6): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit ARM: dts: Mark SDIO as non-removable

[RESEND PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi

2015-11-18 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <

[RESEND PATCH v2 4/6] ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi

2015-11-18 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Reviewed-by: Alim Akhtar <alim.akh...@samsung.com> Tested-by: Alim Akhtar <alim.akh...@samsung.com> --- arch

[RESEND PATCH v2 2/6] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit

2015-11-18 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Krzysztof Kozlowski <

Re: [RESEND PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
Hello, On 11/18/2015 10:23 AM, Javier Martinez Canillas wrote: > The eMMC is non-removable so mark it using the non-removable DT > property to avoid having to redetect it after a suspend/resume. > > Also remove the card-detect-delay property that is not needed with > non-removab

[PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules

2015-11-17 Thread Javier Martinez Canillas
Since the multi_v7_defconfig is used to build an image for different platforms, the options should be enabled as module whenever possible. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- The patch was tested on an Exynos5800 Peach Pi Chromebook and the drivers' module

Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-11-08 Thread Javier Martinez Canillas
Hello Kukjin, On 10/19/2015 12:04 AM, Alim Akhtar wrote: > Hi Javier, > > On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: >> Hello, >> >> The Exynos Chromebooks DTS don't use the correct card detection properties >> since these were carried from the vendo

Re: [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-02 Thread Javier Martinez Canillas
.dts > @@ -405,8 +405,8 @@ > _0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > cap-mmc-highspeed; > + mmc-hs200-1_8v; > non-removable; > card-detect-delay = <200>; > clock-frequency = <80000>;

Re: [PATCH 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-02 Thread Javier Martinez Canillas
regulator-name = "vdd_ldo1"; > + regulator-min-microvolt = <50>; > + regulator-max-microvolt = <90>; > + regulator-always-on; I see that all regulators are marked as regulator-

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-28 Thread Javier Martinez Canillas
Hello Ulf, On 10/27/2015 11:10 AM, Ulf Hansson wrote: > On 21 October 2015 at 17:15, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Doug, On 10/22/2015 07:33 PM, Doug Anderson wrote: > On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas [snip] >> >> Do you know why the priority 200 was chosen for veyron gpi-restart ooi? > > In David Riley's original patch the example had 200: > http

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Anand, On 10/22/2015 07:03 AM, Anand Moon wrote: > Hi Javier, > > On 22 October 2015 at 08:22, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> Hello Krzysztof, >> >> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >>> On 22.

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Marek, On 10/22/2015 12:07 PM, Marek Szyprowski wrote: > On 2015-10-22 06:14, Alim Akhtar wrote: >> On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote: >>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >>>> On 22.10.2015 10:20, Javier Martinez Ca

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
ndlers use 128 and that's the reason why gpio-restart and mmc-pwrseq-emmc use 129 and other restart handlers that can be registered via DT use 192 (which is in the middle of 128 and 255). So I actually thought to use a number in between 192 and 255 (i.e: 220) but then there could be another platform that

[PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
the priority 128, there are other restart handlers (such as the syscon-reboot one) that use a higher priority. So, use the highest priority to make sure that the eMMC hw is reset before a system reboot. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Markus Reichl

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
Hello Alim, On 10/21/2015 04:50 PM, Alim Akhtar wrote: [snip] >> >> [0]: >> From c9b250ee03bae338339b70693e906145c719f783 Mon Sep 17 00:00:00 2001 >> From: Javier Martinez Canillas <jav...@osg.samsung.com> >> Date: Wed, 21 Oct 2015 11:59:44 +0200 >> Sub

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks for your feedback. On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 00:15, Javier Martinez Canillas wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don

Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2015 02:43 PM, Krzysztof Kozlowski wrote: > 2015-10-21 17:45 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >> >> Hello Krzysztof, >> >> Patch looks good to me, I've only one comment. >> >> On 10/21/2015 03

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
rio 128 and the watchdog handlers to 0. Best regards, [0]: http://lxr.free-electrons.com/source/kernel/reboot.c#L113 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in th

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
s the issue, reboot works now on U3. >>> >> Good to know that. >> Thanks >>> >>> Tested-by: Markus Reichl <m.rei...@fivetechno.de> >>> >>> Thanks, >>> -- >>> Markus >>> >>> >>>> >>>> Bes

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, >> >> Thanks for your feedback. >> >> On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: >>> On 22.10.201

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
be left in an unknown state. So the problem here is not that the system is not being reset (that I think that works) but that on reboot, the system is not able to boot again since the ROM is not able to read the second stage bootloader. Markus, Can you please test following patch [0] on top of Alim'

Re: [PATCH 1/2] dt-bindings: Consolidate Exynos SoC bindings under Samsung directory

2015-10-21 Thread Javier Martinez Canillas
f-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Cc: Kukjin Kim <kg...@kernel.org> > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To un

Re: [PATCH 2/2] dt-bindings: EXYNOS: Document compatibles from other vendors

2015-10-21 Thread Javier Martinez Canillas
t;kg...@kernel.org> > Cc: Javier Martinez Canillas <jav...@osg.samsung.com> > Cc: Hakjoo Kim <ruppi@hardkernel.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research A

Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings

2015-10-21 Thread Javier Martinez Canillas
drivers/spi/spi-s3c* > F: sound/soc/samsung/* > +F: Documentation/arm/Samsung/ That there is also a Documentation/arm/Samsung-S3C24XX/ so I think this should be Documentation/arm/Samsung*/ instead. > +F: Documentation/devicetree/bindings/arm/samsung/ > N: exynos >

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-20 Thread Javier Martinez Canillas
d XU. Reboot and poweroff are working correctly on both boards with these patches. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord..

Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-20 Thread Javier Martinez Canillas
Hello Yakir, On 10/20/2015 04:10 AM, Yakir Yang wrote: > Hi Javier, > > On 10/19/2015 06:40 PM, Javier Martinez Canillas wrote: >> Hello Yakir, >> >> On 10/10/2015 05:35 PM, Yakir Yang wrote: >>> Hi all, >>> >>> The Samsung Exynos eDP c

Re: [PATCH v2 5/6] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF

2015-10-20 Thread Javier Martinez Canillas
off} drivers depends on it. > > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> > --- > Patch looks good to me. Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, --

Re: [PATCH v2 6/6] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-20 Thread Javier Martinez Canillas
with older dtbs > with a newer kernel. > > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> > Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> > --- > arch/arm/mach-exynos/pmu.c | 43

Re: [PATCH v2 3/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5

2015-10-20 Thread Javier Martinez Canillas
nkaj Dubey <pankaj.du...@samsung.com> > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> > Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> > --- > arch/arm/boot/dts/exynos5.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > Tested-by

Re: [RFC PATCH] ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

2015-10-19 Thread Javier Martinez Canillas
om> > --- I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch: Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> > Every time I build exynos_defconfig, I need to manua

Re: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-19 Thread Javier Martinez Canillas
s true that select should only be used for non-visible symbols but there are others user visible symbols that are selected by ARCH_EXYNOS such as EXYNOS_THERMAL. So I think selecting the regmap syscon reset stuff there is a sensible option. > Best regards, > Krzysztof > Best regards, -- Jav

Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-19 Thread Javier Martinez Canillas
est this series, I suggest you applied this > series on tag-20150918, just need to fix some light conflicts with the 01 & 02 > patches (or just email me, I can send you directly). > > Thanks, Do you have a branch that I can use to test this series? Best regards, -- Javier

Re: [PATCH 5/7] ARM: exynos_defconfig: Normalize exynos defconfig

2015-10-19 Thread Javier Martinez Canillas
CONFIG_PL330_DMA=y > -CONFIG_CHROME_PLATFORMS=y > CONFIG_CROS_EC_CHARDEV=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_MAX77802=y > @@ -190,7 +187,6 @@ CONFIG_PWM_SAMSUNG=y > CONFIG_PHY_EXYNOS5250_SATA=y > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y > -CONFIG_EXT4_FS

Re: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-19 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/19/2015 03:28 PM, Krzysztof Kozlowski wrote: > 2015-10-19 18:56 GMT+09:00 Javier Martinez Canillas <jav...@osg.samsung.com>: >> Hello, >> >> On 10/19/2015 09:00 AM, Krzysztof Kozlowski wrote: >>> On 19.10.2015 15:03, Alim Akhtar wrote: &g

Re: [PATCH 5/7] ARM: exynos_defconfig: Normalize exynos defconfig

2015-10-19 Thread Javier Martinez Canillas
Hello Alim, On 10/19/2015 05:58 PM, Alim Akhtar wrote: > Hi Javier, > > On Mon, Oct 19, 2015 at 6:55 PM, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> Hello Alim, >> >> On 10/19/2015 08:03 AM, Alim Akhtar wrote: >>> make savedefcon

Re: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-19 Thread Javier Martinez Canillas
Hello Alim, On 10/19/2015 06:13 PM, Alim Akhtar wrote: > Hi Javier, > > On Mon, Oct 19, 2015 at 7:37 PM, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> Hello Krzysztof, >> >> On 10/19/2015 03:28 PM, Krzysztof Kozlowski wrote: >>> 2015-1

Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks

2015-10-17 Thread Javier Martinez Canillas
exynos5420: Add IDs for clocks used in DISP1 power domain") ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > Both patches (with Stephen's ack) are in my recent pull request but as > usual feel free to cherry pick. I'll drop them from next branch then. >

Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-10-16 Thread Javier Martinez Canillas
Hello Alim, On 10/16/2015 01:37 PM, Alim Akhtar wrote: > Hi Javier, > > On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: >> Hello, >> >> The Exynos Chromebooks DTS don't use the correct card detection properties >> since these were carried from the vendo

[RFT PATCH 3/3] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common

2015-10-15 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ar

[PATCH 0/3] ARM: dts: Mark SDIO as non-removable for Exynos Chromebooks

2015-10-15 Thread Javier Martinez Canillas
[0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad348e1e2381 [1]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5995363523de Best regards, Javier Javier Martinez Canillas (3): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: M

[PATCH 2/3] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit

2015-10-15 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/bo

[PATCH 1/3] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi

2015-10-15 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/bo

Re: [RFT PATCH 3/3] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common

2015-10-15 Thread Javier Martinez Canillas
Hello Tomeu, On 10/15/2015 02:30 PM, Tomeu Vizoso wrote: > On 15 October 2015 at 12:55, Javier Martinez Canillas > <jav...@osg.samsung.com> wrote: >> The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which >> can't neither be removed nor be detected. B

[PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi

2015-10-15 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes since v1: - Remove card-detect

[RFT PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common

2015-10-15 Thread Javier Martinez Canillas
The eMMC is non-removable so mark it using the non-removable DT property to avoid having to redetect it after a suspend/resume. Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes

[PATCH v2 5/6] ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi

2015-10-15 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes since v1: - None, new patch. arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/ar

[PATCH v2 2/6] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit

2015-10-15 Thread Javier Martinez Canillas
warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes since v1: - Remove card-detect

[PATCH v2 4/6] ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi

2015-10-15 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Changes since v1: - None, new patch. arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/ar

[PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-10-15 Thread Javier Martinez Canillas
com/chromiumos/third_party/kernel/+/5995363523de [2]: https://lkml.org/lkml/2015/10/15/294 Best regards, Javier Javier Martinez Canillas (6): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit ARM: dts: Mark SDIO as non-remova

Re: [PATCH] dt-bindings: Correct the example for Exynos power domain clocks

2015-10-14 Thread Javier Martinez Canillas
< CLK_FIN_PLL>, < CLK_MOUT_SW_ACLK333>, > - < CLK_MOUT_USER_ACLK333>; > - clock-names = "oscclk", "pclk0", "clk0"; > + clocks = < CLK_FIN_PLL>, < CLK_MOUT_USER_ACLK333>; > +

Re: [PATCH 3/4] ARM: multi_v7_defconfig: Enable Maxim 8997 family drivers

2015-10-14 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/13/2015 03:18 PM, Krzysztof Kozlowski wrote: > W dniu 13.10.2015 o 17:36, Javier Martinez Canillas pisze: >> Hello Krzysztof, >> >> On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski >> <k.kozlow...@samsung.com> wrote: >>> En

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable Maxim 77693 LED and haptic drivers

2015-10-13 Thread Javier Martinez Canillas
kozlow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message

Re: [PATCH 2/4] ARM: exynos_defconfig: Enable Maxim 77693 LED and haptic drivers

2015-10-13 Thread Javier Martinez Canillas
kozlow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message

Re: [PATCH 1/4] ARM: exynos_defconfig: Enable Maxim 8997 family drivers

2015-10-13 Thread Javier Martinez Canillas
rds with exynos config. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsub

  1   2   3   4   5   6   7   8   9   10   >