Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-14 Thread Laurent Pinchart
Hi Marek, On Monday 14 December 2015 10:20:22 Marek Szyprowski wrote: > On 2015-12-13 20:57, Laurent Pinchart wrote: > > On Wednesday 09 December 2015 14:58:19 Marek Szyprowski wrote: > >> Add a helper function for device drivers to set DMA's max_seg_size. > >> Set

Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-13 Thread Laurent Pinchart
ude/media/videobuf2-dma-contig.h > +++ b/include/media/videobuf2-dma-contig.h > @@ -26,6 +26,7 @@ vb2_dma_contig_plane_dma_addr(struct vb2_buffer *vb, > unsigned int plane_no) > > void *vb2_dma_contig_init_ctx(struct device *dev); > void vb2_dma_contig_cleanup_ctx(void *alloc_ctx); > +i

Re: [PATCH v2 0/7] Exynos: MFC driver: reserved memory cleanup and IOMMU support

2015-12-13 Thread Laurent Pinchart
| 31 - > include/media/videobuf2-dma-contig.h | 1 + > 29 files changed, 533 insertions(+), 248 deletions(-) > delete mode 100644 arch/arm/mach-exynos/mfc.h > delete mode 100644 arch/arm/mach-exynos/s5p-dev-mfc.c > create mode 100644 drivers/media/platform/s5p-mfc/s5p_mfc_iommu.h -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-05 Thread Laurent Pinchart
struct v4l2_subdev_format *fmt) > { > - if (media_entity_type(pad->entity) == MEDIA_ENT_T_V4L2_SUBDEV) { > + if (is_media_entity_v4l2_subdev(pad->entity)) { > struct v4l2_subdev *sd = > media_entity_to_v4l2_

Re: [PATCH v2 9/9] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2015-11-09 Thread Laurent Pinchart
Number of the configuration associated with the data. > */ > struct omap3isp_stat_data { > +#ifdef __KERNEL__ > + struct v4l2_timeval ts; > +#else > struct timeval ts; > +#endif > void __user *buf; > __u32 buf_size; > __u16 frame_nu

Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-13 Thread Laurent Pinchart
Hi Shawn, On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote: > On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote: > > Laurent Pinchart (37): > ... > > > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property > > ... > > > ARM: dt

[PATCH 05/37] ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property

2015-10-12 Thread Laurent Pinchart
The property name should be "gpio", not "gpios". Fix it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/s5pv210-aquila.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Cc: linux-samsung-soc@vger.kernel.org Cc: Kukjin

[PATCH 06/37] ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property

2015-10-12 Thread Laurent Pinchart
The property name should be "gpio", not "gpios". Fix it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/s5pv210-goni.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Cc: linux-samsung-soc@vger.kernel.org Cc: Ku

[PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
g> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: Alexandre Courbot <gnu...@gmail.com> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Mark Brown <broo...@kernel.org> Cc: Linus Walleij <linus.wall...@linaro.org> Laurent Pinchart (37): ARM: dts: am437x-gp-evm: Remove

Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
Hi Javier, On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote: > On 10/12/2015 11:46 PM, Tony Lindgren wrote: > > * Laurent Pinchart <laurent.pinch...@ideasonboard.com> [151012 14:17]: > >> Hello, > >> > >> While working on regulators,

Re: [PATCH v4 1/6] media: get rid of unused extra_links param on media_entity_init()

2015-08-14 Thread Laurent Pinchart
elements. With that fixed, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com And feel free to merge this patch for v4.3 independently of the rest. @@ -52,10 +51,10 @@ */ int media_entity_init(struct media_entity *entity, u16 num_pads, - struct media_pad *pads

Re: [PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall

2015-05-23 Thread Laurent Pinchart
quite right. Have you had a chance to look at the patch series I posted about a week ago to implement IOMMU probe deferral support ? int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr attr, void *data) -- Regards, Laurent Pinchart -- To unsubscribe

Re: [PATCH v6 10/25] iommu: exynos: remove useless device_add/remove callbacks

2015-05-18 Thread Laurent Pinchart
deferral support patch series in the context of iommu groups ? The series pretty much drops groups support from the ipmmu-vmsa driver, not because of a real desire to do so, but because I wasn't sure how to keep them. Tips would be appreciated. -- Regards, Laurent Pinchart -- To unsubscribe

Re: [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks

2015-01-26 Thread Laurent Pinchart
Hi Joerg, On Monday 26 January 2015 12:00:59 Joerg Roedel wrote: Hi Laurent, On Sun, Jan 25, 2015 at 05:38:22PM +0200, Laurent Pinchart wrote: IOMMU groups still seem a bit unclear to me. Will Deacon has nicely explained what they represent in http://lists.infradead.org/pipermail/linux

Re: [PATCH v4 17/18] iommu: exynos: init from dt-specific callback instead of initcall

2015-01-20 Thread Laurent Pinchart
Hi Will, On Monday 19 January 2015 11:33:31 Will Deacon wrote: On Mon, Jan 19, 2015 at 01:11:07AM +, Laurent Pinchart wrote: On Friday 16 January 2015 10:13:11 Marek Szyprowski wrote: This patch introduces IOMMU_OF_DECLARE-based initialization to the driver, which replaces

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2015-01-20 Thread Laurent Pinchart
-by for the DT bindings. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 17/18] iommu: exynos: init from dt-specific callback instead of initcall

2015-01-18 Thread Laurent Pinchart
0; +} + +IOMMU_OF_DECLARE(exynos_iommu_of, samsung,exynos-sysmmu, + exynos_iommu_of_setup); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [Linaro-mm-sig] [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-18 Thread Laurent Pinchart
Hi Arnd, On Wednesday 17 December 2014 16:56:53 Arnd Bergmann wrote: On Wednesday 17 December 2014 15:53:25 Lucas Stach wrote: Am Mittwoch, den 17.12.2014, 15:27 +0100 schrieb Arnd Bergmann: On Wednesday 17 December 2014 01:24:42 Laurent Pinchart wrote: If we forbid the IOMMU driver from

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-12-17 Thread Laurent Pinchart
Hi Javier, On Wednesday 17 December 2014 10:31:41 Javier Martinez Canillas wrote: On 12/16/2014 12:37 AM, Laurent Pinchart wrote: Hi Javier, Tomi and Laurent, You asked Ajay to change his series to use the video port and enpoints DT bindings instead of phandles, could you please

Re: [Linaro-mm-sig] [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-17 Thread Laurent Pinchart
Hi Arnd, On Wednesday 17 December 2014 15:27:36 Arnd Bergmann wrote: On Wednesday 17 December 2014 01:24:42 Laurent Pinchart wrote: If we forbid the IOMMU driver from being compiled as a module can't we just rely on deferred probing ? The bus master driver will just be reprobed after

Re: [Linaro-mm-sig] [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-17 Thread Laurent Pinchart
Hi Arnd, On Wednesday 17 December 2014 16:41:33 Arnd Bergmann wrote: On Wednesday 17 December 2014 16:39:02 Laurent Pinchart wrote: On Wednesday 17 December 2014 15:27:36 Arnd Bergmann wrote: On Wednesday 17 December 2014 01:24:42 Laurent Pinchart wrote: If we forbid the IOMMU driver

Re: [Linaro-mm-sig] [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-17 Thread Laurent Pinchart
Hi Arnd, On Wednesday 17 December 2014 22:58:47 Arnd Bergmann wrote: On Wednesday 17 December 2014 18:02:51 Laurent Pinchart wrote: On Wednesday 17 December 2014 16:41:33 Arnd Bergmann wrote: On Wednesday 17 December 2014 16:39:02 Laurent Pinchart wrote: On Wednesday 17 December 2014 15:27

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-16 Thread Laurent Pinchart
of dma_set_mask(). I've done that in the past on powerpc, but the new approach seems cleaner. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [Linaro-mm-sig] [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-16 Thread Laurent Pinchart
Hi Arnd, On Tuesday 16 December 2014 13:10:59 Arnd Bergmann wrote: On Tuesday 16 December 2014 14:07:11 Laurent Pinchart wrote: On Tuesday 16 December 2014 12:40:28 Arnd Bergmann wrote: On Monday 15 December 2014 18:13:23 Will Deacon wrote: IOMMUs are not as low-level as system

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-15 Thread Laurent Pinchart
Hi Will, On Monday 15 December 2014 17:17:00 Will Deacon wrote: On Sun, Dec 14, 2014 at 12:45:36PM +, Laurent Pinchart wrote: On Wednesday 19 November 2014 12:15:47 Marek Szyprowski wrote: This patch introduces IOMMU_OF_DECLARE-based initialization to the driver, which replaces

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-15 Thread Laurent Pinchart
Hi Will, On Monday 15 December 2014 17:43:02 Will Deacon wrote: On Mon, Dec 15, 2014 at 05:27:30PM +, Laurent Pinchart wrote: On Monday 15 December 2014 17:17:00 Will Deacon wrote: On Sun, Dec 14, 2014 at 12:45:36PM +, Laurent Pinchart wrote: On Wednesday 19 November 2014 12:15

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-15 Thread Laurent Pinchart
On Monday 15 December 2014 18:13:23 Will Deacon wrote: On Mon, Dec 15, 2014 at 05:53:48PM +, Laurent Pinchart wrote: Hi Will, Hello again :) On Monday 15 December 2014 17:43:02 Will Deacon wrote: On Mon, Dec 15, 2014 at 05:27:30PM +, Laurent Pinchart wrote: On Monday 15

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-12-15 Thread Laurent Pinchart
introduced in 03/14 but I won't nack it given lack of time to implement an alternative proposal. It's an internal API, it can always be reworked later anyway. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-14 Thread Laurent Pinchart
, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-16 Thread Laurent Pinchart
Hi Ajay, On Friday 10 October 2014 18:33:05 Ajay kumar wrote: On Wed, Oct 8, 2014 at 12:39 PM, Thierry Reding wrote: On Tue, Oct 07, 2014 at 05:49:24PM +0300, Laurent Pinchart wrote: On Tuesday 07 October 2014 16:06:55 Ajay kumar wrote: On Tue, Oct 7, 2014 at 4:00 PM, Tomi Valkeinen wrote

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-07 Thread Laurent Pinchart
Hi Tomi, On Tuesday 07 October 2014 10:06:10 Tomi Valkeinen wrote: On 06/10/14 17:40, Laurent Pinchart wrote: But seriously speaking, I was thinking about this. I'd really like to have a generic video-mux node, that would still somehow allow us to have device specific configurations

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-07 Thread Laurent Pinchart
on a standard way to describe connections in DT for display devices, which is why I would prefer the ps8622 bindings to use OF graph to describe connections. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-07 Thread Laurent Pinchart
Hi Tomi, On Tuesday 07 October 2014 11:25:56 Tomi Valkeinen wrote: On 07/10/14 10:23, Laurent Pinchart wrote: You mean the bridge driver would somehow take a peek into panel1 and panel2 nodes, looking for bridge specific properties? Sounds somewhat fragile to me... How would the bridge

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-06 Thread Laurent Pinchart
be a better choice. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-06 Thread Laurent Pinchart
Hi Thierry, On Tuesday 23 September 2014 16:49:38 Thierry Reding wrote: On Tue, Sep 23, 2014 at 02:52:24PM +0300, Laurent Pinchart wrote: On Tuesday 23 September 2014 13:47:40 Andrzej Hajda wrote: On 09/23/2014 01:23 PM, Laurent Pinchart wrote: [...] This becomes an issue even on Linux

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-06 Thread Laurent Pinchart
its configuration at runtime by querying properties of the downstream video entities ? That would solve the problem neatly. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Laurent Pinchart
arise when you need to locate the remote device in the direction opposite to the phandle link direction. Traversing a link forward just involves a phandle lookup, but traversing it backwards isn't possible the same way. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Laurent Pinchart
second). -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Laurent Pinchart
On Tuesday 23 September 2014 13:18:30 Andrzej Hajda wrote: On 09/23/2014 01:10 PM, Laurent Pinchart wrote: On Tuesday 23 September 2014 12:02:45 Andrzej Hajda wrote: On 09/23/2014 11:30 AM, Tomi Valkeinen wrote: On 23/09/14 09:21, Thierry Reding wrote: Well, I can write almost any kind

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Laurent Pinchart
there is the biggest pain point for my use cases. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

DT property to selectively disable device features (was [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties)

2014-09-23 Thread Laurent Pinchart
Hi Thierry, On Tuesday 23 September 2014 07:55:34 Thierry Reding wrote: On Tue, Sep 23, 2014 at 03:00:37AM +0300, Laurent Pinchart wrote: On Monday 22 September 2014 13:35:15 Thierry Reding wrote: On Mon, Sep 22, 2014 at 04:53:22PM +0530, Ajay kumar wrote: On Mon, Sep 22, 2014 at 4:11 PM

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Laurent Pinchart
On Tuesday 23 September 2014 13:47:40 Andrzej Hajda wrote: On 09/23/2014 01:23 PM, Laurent Pinchart wrote: On Tuesday 23 September 2014 13:18:30 Andrzej Hajda wrote: On 09/23/2014 01:10 PM, Laurent Pinchart wrote: On Tuesday 23 September 2014 12:02:45 Andrzej Hajda wrote: On 09/23/2014 11

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-22 Thread Laurent Pinchart
it at all and not have the boolean property since you don't seem to have a way to test it in the first place (or at least there's no device support upstream where it's needed). -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: [PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-09-22 Thread Laurent Pinchart
Hi Thierry, On Monday 22 September 2014 09:40:38 Thierry Reding wrote: On Wed, Sep 17, 2014 at 12:27:13PM +0300, Laurent Pinchart wrote: On Wednesday 17 September 2014 14:37:30 Ajay kumar wrote: On Mon, Sep 15, 2014 at 11:07 PM, Laurent Pinchart wrote: Hi Ajay, Thank you

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-09-18 Thread Laurent Pinchart
, Laurent Pinchart wrote: On Wednesday 30 July 2014 11:40:54 Thierry Reding wrote: [snip] One other thing: how does the bridge know which mode to drive? I suspect that it can drive more than one mode? Can it freely be configured or does it have a predefined set of modes? If the latter

Re: [PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-09-17 Thread Laurent Pinchart
Hi Ajay, On Wednesday 17 September 2014 14:37:30 Ajay kumar wrote: On Mon, Sep 15, 2014 at 11:07 PM, Laurent Pinchart wrote: Hi Ajay, Thank you for the patch. I think we're moving in the right direction, but we're not there yet. On Saturday 26 July 2014 00:52:08 Ajay Kumar wrote

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-09-17 Thread Laurent Pinchart
querying the panel driver directly, or the display controller driver doing it and then configuring the bridge accordingly. The latter seems more generic to me and doesn't rely on the assumption that the bridge output will always be directly connected to a panel. -- Regards, Laurent Pinchart

Re: [PATCH V7 00/12] drm/exynos: few patches to enhance bridge chip support

2014-09-16 Thread Laurent Pinchart
Hi Javier, On Tuesday 16 September 2014 14:44:02 Javier Martinez Canillas wrote: [adding Laurent Pinchart to cc who had concerns with a previous version of this patch-set] Thank you, I've indeed missed v7. On Wed, Aug 27, 2014 at 4:29 PM, Ajay Kumar wrote: This series is based on master

Re: [PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-09-15 Thread Laurent Pinchart
drivers/gpu/drm/bridge/ptn3460.c create mode 100644 drivers/gpu/drm/drm_bridge.c delete mode 100644 include/drm/bridge/ptn3460.h -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 04/29] drivers: base: add notifier for failed driver bind

2014-08-21 Thread Laurent Pinchart
failed to bind + to device */ extern struct kset *bus_get_kset(struct bus_type *bus); extern struct klist *bus_get_device_klist(struct bus_type *bus); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 1/2] [media] v4l: Add source change event

2014-05-09 Thread Laurent Pinchart
frame_sync; + struct v4l2_event_src_changesrc_change; __u8data[64]; } u; __u32 pending; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [RFC v3 PATCH v6 11/16] ARM: dts: s6e3fa0: add DT bindings

2014-05-07 Thread Laurent Pinchart
and cpu mode timings. Changelog v2: - Adds unit address (commented by Sachin Kamat) Changelog v3: - Removes optional delay, size properties (commented by Laurent Pinchart) - Adds OLED detection, TE gpio properties Changelog v4: - Moves CPU timings relevant properties from FIMD DT

Re: [RFC v2 PATCH v3 10/14] drm/panel: add S6E3FA0 driver

2014-04-30 Thread Laurent Pinchart
Hi Thierry, On Monday 28 April 2014 23:25:50 Thierry Reding wrote: On Mon, Apr 28, 2014 at 05:05:24PM +0200, Laurent Pinchart wrote: On Tuesday 22 April 2014 10:24:39 YoungJun Cho wrote: On 04/22/2014 08:00 AM, Laurent Pinchart wrote: Hi YoungJun, Thank you for the patch

Re: [RFC v2 PATCH v3 10/14] drm/panel: add S6E3FA0 driver

2014-04-28 Thread Laurent Pinchart
Hi YoungJun, On Tuesday 22 April 2014 10:24:39 YoungJun Cho wrote: On 04/22/2014 08:00 AM, Laurent Pinchart wrote: Hi YoungJun, Thank you for the patch. On Monday 21 April 2014 21:28:37 YoungJun Cho wrote: This patch adds MIPI-DSI command mode based S6E3FA0 AMOLED LCD Panel

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-28 Thread Laurent Pinchart
Hi Arun, On Tuesday 22 April 2014 17:52:08 Arun Kumar K wrote: On Tue, Apr 22, 2014 at 5:23 PM, Laurent Pinchart wrote: On Tuesday 22 April 2014 16:32:48 Arun Kumar K wrote: The patch adds IOMMU support for MFC driver. I've been working on an IOMMU driver lately, which led me to think

Re: [RFC v2 PATCH v4 09/14] ARM: dts: s6e3fa0: add DT bindings

2014-04-23 Thread Laurent Pinchart
by Sachin Kamat) Changelog v3: - Removes optional delay, size properties (commented by Laurent Pinchart) - Adds OLED detection, TE gpio properties Changelog v4: - Moves CPU timings relevant properties from FIMD DT (commeted by Laurent Pinchart, Andrzej Hajda) Signed-off-by: YoungJun

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-22 Thread Laurent Pinchart
, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Laurent Pinchart
correctly. Adding a new v4l2_event_init() function would help with that. } u; __u32 pending; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Laurent Pinchart
Hi Arun, On Monday 21 April 2014 17:19:26 Arun Kumar K wrote: On Mon, Apr 21, 2014 at 3:54 PM, Laurent Pinchart wrote: On Monday 21 April 2014 14:56:01 Arun Kumar K wrote: From: Pawel Osciak posc...@chromium.org This event indicates that the decoder has reached a point in the stream

Re: [RFC v2 PATCH v2 06/14] drm/exynos: support MIPI DSI command mode

2014-04-21 Thread Laurent Pinchart
trigger feature . In case of command mode panel, FIMD should set trigger bit, so that image data has to be transferred to display bus or lcd panel. Changelog v2: - Moves CPU timings relevant properties to panel DT (commented by Laurent Pinchart, Andrzej Hajda) Signed-off

Re: [RFC v2 PATCH v3 10/14] drm/panel: add S6E3FA0 driver

2014-04-21 Thread Laurent Pinchart
properties from FIMD DT (commented by Laurent Pinchart, Andrzej Hajda) Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/panel/Kconfig |7 + drivers/gpu/drm/panel

Re: [PATCH 1/2] v4l: Add resolution change event.

2014-04-16 Thread Laurent Pinchart
V4L2_EVENT_RESOLUTION_CHANGE 5 #define V4L2_EVENT_PRIVATE_START 0x0800 /* Payload for V4L2_EVENT_VSYNC */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC PATCH 05/14] ARM: dts: samsung-fimd: add I80 specific properties

2014-04-16 Thread Laurent Pinchart
in the slave DT node. The device node can contain 'port' child nodes according to the bindings defined in [2]. The following are properties specific to those nodes: -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [RFC PATCH v2 09/14] ARM: dts: s6e3fa0: add DT bindings

2014-04-16 Thread Laurent Pinchart
; + hsync-len = 1; + vfront-porch = 1; + vback-porch = 4; + vsync-len = 1; + }; + }; + }; -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Laurent Pinchart
; + clocks = clock 381; + clock-names = scaler; + }; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Laurent Pinchart
Hi Sylwester, On Wednesday 19 March 2014 12:55:21 Sylwester Nawrocki wrote: On 19/03/14 12:31, Laurent Pinchart wrote: +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt @@ -0,0 +1,24 @@ +* Samsung Exynos5 SCALER device + +SCALER is used for scaling, blending

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
; + #size-cells = 1; /* parallel camera ports */ parallel-ports { -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 11 March 2014 14:38:37 Sylwester Nawrocki wrote: Hi Laurent, Thanks for your review. You're welcome. On 11/03/14 13:30, Laurent Pinchart wrote: [...] --- .../devicetree/bindings/media/samsung-fimc.txt | 34 +- 1 file changed, 26

Re: [PATCH v10 1/2] s5k5baf: add camera sensor driver

2013-12-19 Thread Laurent Pinchart
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Hi Laurent, Does this driver look sane to you, at its 10'th version? :) If so I could send a pull request including it this week. Yes, it does. Sorry for the delay. Please send the pull request. -- Regards, Laurent Pinchart

Re: [PATCH 31/51] DMA-API: media: omap3isp: use dma_coerce_mask_and_coherent()

2013-09-26 Thread Laurent Pinchart
on the DMA mask. It can be replaced with dma_coerce_mask_and_coherent(), avoiding the direct initialization of this mask. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/omap3isp/isp.c |6

Re: [PATCH v3] pinctrl: Pass all configs to driver on pin_config_set()

2013-08-27 Thread Laurent Pinchart
: + return -ENOTSUPP; + } + } /* for each config */ return 0; } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-27 Thread Laurent Pinchart
Hi Andrejz, On Monday 26 August 2013 14:34:21 Andrzej Hajda wrote: On 08/23/2013 02:53 PM, Laurent Pinchart wrote: On Wednesday 21 August 2013 16:41:31 Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor

Re: [PATCH v4] pinctrl: Pass all configs to driver on pin_config_set()

2013-08-27 Thread Laurent Pinchart
| 69 ++-- include/linux/pinctrl/pinconf.h |6 +- Reviewed-by: Stephen Warren swar...@nvidia.com On Tegra (Tegra114 Dalmore board, on top of next-20130816), Tested-by: Stephen Warren swar...@nvidia.com For drivers/pinctrl/sh-pfc/pinctrl.c, Acked-by: Laurent Pinchart

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-23 Thread Laurent Pinchart
.num_data_lanes; + + return 0; +} -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Laurent Pinchart
needs them? All the platforms we are concerned with here (exynos and omap, plus new platforms) can be booted using DT anyway. What about non-DT architectures such as MIPS (still widely used in consumer networking equipments from what I've heard) ? -- Regards, Laurent Pinchart -- To unsubscribe

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
; +} +EXPORT_SYMBOL(v4l2_clk_get); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-26 Thread Laurent Pinchart
in the clock provider implementation of v4l2_clk_enable/disable() :-) /* inform the bridge: binding successful */ v4l2_async_subdev_bound(); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH RFC v4 01/14] [media] Add common video interfaces OF bindings documentation

2013-01-24 Thread Laurent Pinchart
Hi Sylwester, On Thursday 24 January 2013 19:30:10 Sylwester Nawrocki wrote: On 01/24/2013 11:16 AM, Laurent Pinchart wrote: [...] +Data interfaces on all video devices are described by their child 'port' +nodes. Configuration of a port depends on other devices participating

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Laurent Pinchart
to be used later. Aren't DT bindings considered as an ABI, and required to be supported more or less forever ? If you merge this DT binding you'll have to keep supporting it. That's why DT bindings should not be rushed in. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 31 July 2012 13:14:13 Guennadi Liakhovetski wrote: On Tue, 31 Jul 2012, Laurent Pinchart wrote: On Tuesday 31 July 2012 11:56:44 Guennadi Liakhovetski wrote: On Thu, 26 Jul 2012, Laurent Pinchart wrote: On Wednesday 18 July 2012 11:18:33 Sylwester Nawrocki wrote

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-31 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 31 July 2012 13:29:55 Guennadi Liakhovetski wrote: On Tue, 31 Jul 2012, Laurent Pinchart wrote: On Tuesday 31 July 2012 13:14:13 Guennadi Liakhovetski wrote: On Tue, 31 Jul 2012, Laurent Pinchart wrote: On Tuesday 31 July 2012 11:56:44 Guennadi Liakhovetski wrote

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
; data-lanes = 2 3 1; For receivers that can't reroute lanes internally, the data-lanes property would be need to specify lanes in sequence. data-lanes = 1 2 3; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [RFC/PATCH 01/13] ARM: Samsung: Extend MIPI PHY callback with an index argument

2012-07-26 Thread Laurent Pinchart
-clock.h -static int __s5p_mipi_phy_control(struct platform_device *pdev, +static int __s5p_mipi_phy_control(struct platform_device *pdev, int id, bool on, u32 reset) What about removing the pdev argument, as it's now not needed ? -- Regards, Laurent Pinchart

Re: [RFC/PATCH 05/13] media: s5p-fimc: Add device tree support for FIMC devices

2012-07-26 Thread Laurent Pinchart
the discussion by e-mail. I'll try to prepare some summary with topics that appear common. And also to restructure my RFC series to better separate new common features and specific H/W support. In the meantime we could possibly continue discussions in your RFC thread. -- Regards, Laurent

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
can describe the hardware properly. Or at least this shouldn't be Samsung-specific? Yes, good point. If we agree we can keep them, perhaps we could standardize those as boolean properties: horizontal-flip; and vertical-flip; ? -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
; + gpio-rst = gpl2 0 2 0 3; + gpio-stby = gpl2 1 2 0 3; + video-itu-601-bus; + vdd_core-supply = reg0; + vdda-supply = reg1; + vdd_reg-supply = reg2; + vddio-supply = reg3; + }; -- Regards, Laurent Pinchart

Re: [RFC/PATCH 02/13] media: s5p-csis: Add device tree support

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Thursday 26 July 2012 21:51:30 Sylwester Nawrocki wrote: On 07/26/2012 04:38 PM, Laurent Pinchart wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/mipi.txt @@ -0,0 +1,5 @@ +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and transmitters

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-07-26 Thread Laurent Pinchart
Hi Sylwester, On Thursday 26 July 2012 22:39:31 Sylwester Nawrocki wrote: On 07/26/2012 05:21 PM, Laurent Pinchart wrote: On Friday 25 May 2012 21:52:48 Sylwester Nawrocki wrote: The driver initializes all board related properties except the s_power() callback to board code. The platforms

Re: [PATCH 0/2] video: s3c-fb: Add window positioning support

2011-09-18 Thread Laurent Pinchart
Hi Florian, On Sunday 18 September 2011 21:29:57 Florian Tobias Schandinat wrote: On 09/07/2011 03:31 PM, Laurent Pinchart wrote: On Thursday 01 September 2011 18:45:18 Florian Tobias Schandinat wrote: On 08/25/2011 07:51 PM, Ajay Kumar wrote: Just as a note, there are many drivers like

Re: [PATCH 0/2] video: s3c-fb: Add window positioning support

2011-09-07 Thread Laurent Pinchart
additional things that were useful/needed in this context? Would you consider adding support for this API in your drivers? (as standardizing wouldn't be useful if nobody would implement it) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 0/3 v6] Add v4l2 subdev driver for Samsung S5P MIPI-CSI receivers

2011-05-16 Thread Laurent Pinchart
, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Changes since v5: - slightly improved description of struct csis_state - moved the pad number check from __s5pcsis_get_format directly to set_fmt/get_fmt pad level operation handlers - replaced __init attribute of s5pcsis_probe

Re: [PATCH 3/3 v5] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

2011-05-15 Thread Laurent Pinchart
Hi Sylwester, On Sunday 15 May 2011 11:33:14 Sylwester Nawrocki wrote: On 05/14/2011 05:29 PM, Laurent Pinchart wrote: On Wednesday 11 May 2011 17:17:10 Sylwester Nawrocki wrote: [snip] +static int s5pcsis_suspend(struct device *dev) +{ + struct s5p_platform_mipi_csis *pdata = dev

Re: [PATCH 3/3 v5] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

2011-05-14 Thread Laurent Pinchart
; + } + clk_enable(state-clock[CSIS_CLK_GATE]); + } + if (state-flags ST_STREAMING) + s5pcsis_start_stream(state); + + state-flags = ~ST_SUSPENDED; + unlock: + mutex_unlock(state-lock); + return ret ? -EAGAIN : 0; +} [snip] -- Regards, Laurent Pinchart

Re: [PATCH v4 3/3] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

2011-05-05 Thread Laurent Pinchart
Hi Sylwester, On Thursday 05 May 2011 11:33:27 Sylwester Nawrocki wrote: On 05/04/2011 02:00 PM, Laurent Pinchart wrote: On Tuesday 03 May 2011 20:07:43 Sylwester Nawrocki wrote: On 05/03/2011 11:16 AM, Laurent Pinchart wrote: On Thursday 21 April 2011 17:21:04 Sylwester Nawrocki wrote

Re: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h for MFC 5.1

2011-03-04 Thread Laurent Pinchart
that you were against ading H.264 or MPEG4 fourccs, and that drivers should use the MPEG controls instead. Could you clarify your current position on this ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord