Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-10 Thread Lee Jones
. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: a...@kernel.org > Cc: Lee Jones <le

Re: [PATCH 1/3] dt-bindings: regulator/clock/mfd: Reorganize S2MPS-family bindings

2015-12-07 Thread Lee Jones
.txt | 153 > - > .../devicetree/bindings/mfd/samsung,sec-core.txt | 84 +++ Acked-by: Lee Jones <lee.jo...@linaro.org> > .../bindings/regulator/samsung,s2mps11.txt | 102 ++ > MAINTAINERS

Re: [PATCH 3/3] dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings

2015-12-07 Thread Lee Jones
--- > .../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +- Acked-by: Lee Jones <lee.jo...@linaro.org> > .../bindings/regulator/samsung,s2mpa01.txt | 79 +++ > 3 files changed, 82 insertions(+), 91 deletions(-) > delete mode 100644 Documentati

Re: [PATCH 2/3] dt-bindings: regulator/mfd: Reorganize S5M8767 bindings

2015-12-07 Thread Lee Jones
,s5m8767.txt), > - remove duplicated information, > - reorganize the contents to match style of >regulator/samsung,s2mps11.txt. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > --- > .../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +- Ac

Re: [RESEND PATCH v2] mfd: sec-core: Rename MFD and regulator names differently

2015-11-23 Thread Lee Jones
p git-bisect happy. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jo...@linaro.org> > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Acked-by: Mark Brown <b

Re: [RESEND PATCH v5 0/3] mfd: sec: add S2MPS15 PMIC support

2015-11-23 Thread Lee Jones
/s2mps15.h | 158 ++ 8 files changed, 369 insertions(+), 7 deletions(-) create mode 100644 include/linux/mfd/samsung/s2mps15.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL] Immutable branch between MFD, Regulator and RTC

2015-11-23 Thread Lee Jones
4 +- > drivers/regulator/s2mps11.c | 135 +- > drivers/rtc/rtc-s5m.c | 37 - > include/linux/mfd/samsung/core.h| 1 + > include/linux/mfd/samsung/rtc.h | 2 + > include/linux/mfd/samsung/s2mps15.h | 158 ++ > 8 files c

Re: [PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support

2015-11-20 Thread Lee Jones
On Fri, 20 Nov 2015, Alim Akhtar wrote: > On 11/20/2015 02:35 PM, Lee Jones wrote: > >On Thu, 19 Nov 2015, Alim Akhtar wrote: > > > >>Hi Lee, > >>Do I need to resend this series? This series still apply cleanly on > >>top of v4.4-rc1. > >>I

Re: [PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support

2015-11-20 Thread Lee Jones
Krzysztof > > concerns on rtc patch. > > There are some other improvement suggestion from Krzystof for the rtc, I > > feel that can be done > > as a sperate patch later. > > > > Changes since v3: > > * Changes regulator driver name from s2mps15-pmic -> s2mp

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Lee Jones
t; drivers/media/platform/soc_camera/omap1_camera.c | 2 +- > drivers/media/platform/soc_camera/soc_camera_platform.c | 2 +- > drivers/media/platform/timblogiw.c| 2 +- > drivers/media/radio/radio-timb.c | 2

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-02 Thread Lee Jones
t; > >> > > > Applied after fixing the small alignment issue, thanks. > > > > > > > I think you cannot apply it directly because it depends on headers from > > patch 2/4. It won't build. > > > > Yeah, this depends on the mfd tree. I d

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-02 Thread Lee Jones
On Mon, 02 Nov 2015, Alexandre Belloni wrote: > On 02/11/2015 at 09:03:59 +0000, Lee Jones wrote : > > > > I think you cannot apply it directly because it depends on headers from > > > > patch 2/4. It won't build. > > > > > > > > > > Yea

Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

2015-10-30 Thread Lee Jones
s2mpu02_devs[] = { > - { .name = "s2mpu02-pmic", }, > - { .name = "s2mpu02-rtc", }, > { > - .name = "s2mpu02-clk", > - .of_compatible = "samsung,s2mpu02-clk", > - } > + .name = "s

Re: [PATCH 2/2] regulator: s2mps11: Rename s2mpsxx regulator as *-regulator

2015-10-30 Thread Lee Jones
://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jo...@linaro.org> > Signed-off-by: Alim Akhtar <alim.akh...@samsung.com> > --- > drivers/regulator/s2mps11.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) You need to squash the

Re: [PATCH 1/2] mfd: sec-core: Rename MFD and regulator names differently

2015-10-30 Thread Lee Jones
and it > cells need to be named here [1]. > Based in the discussion this patch rename MFD regulator name as > *-regulator instead of current *-pmic. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jo...@linaro.org> > Sig

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Lee Jones
c",S2MPS14X }, > + { "s2mps15-rtc",S2MPS15X }, > { }, > }; > MODULE_DEVICE_TABLE(platform, s5m_rtc_id); > diff --git a/include/linux/mfd/samsung/rtc.h b/include/linux/mfd/samsung/rtc.h > index 29c30ac36020..a65e4655d470 100644 > --- a/inc

Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-30 Thread Lee Jones
to 38 > - S2MPS13: 1 to 40 > - S2MPS14: 1 to 25 > + - S2MPS15: 1 to 27 > - S2MPU02: 1 to 28 > - Example: LDO1, LDO2, LDO28 > - BUCKn > @@ -97,6 +103,7 @@ as per the datasheet of s2m

Re: [PATCH v4 2/4] mfd: sec: Add support for S2MPS15 PMIC

2015-10-29 Thread Lee Jones
++ > 4 files changed, 198 insertions(+) > create mode 100644 include/linux/mfd/samsung/s2mps15.h Looks good now. Acked-by: Lee Jones <lee.jo...@linaro.org> > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 2626fc0b5b8c..fbb8a

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-29 Thread Lee Jones
ps11-pmic", S2MPS11X}, > { "s2mps13-pmic", S2MPS13X}, > { "s2mps14-pmic", S2MPS14X}, > + { "s2mps15-regulator", S2MPS15X}, > { "s2mpu02-pmic", S2MPU02}, > { }, > }; Are you going to s/pmic/regulator/ for the ex

Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > W dniu 28.10.2015 o 17:46, Lee Jones pisze: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > > > >> On 26.10.2015 23:34, Lee Jones wrote: > >>> On Mon, 26 Oct 2015, Alim Akhtar wrote: > >>> &g

Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > On 26.10.2015 23:34, Lee Jones wrote: > > On Mon, 26 Oct 2015, Alim Akhtar wrote: > > > >> From: Thomas Abraham <thomas...@samsung.com> > >> > >> Add support for S2MPS15 PMIC which is similar to S2M

Re: [PATCH v2 2/5] mfd: sec: Add support for S2MPS15 PMIC

2015-10-26 Thread Lee Jones
S2MPS15_LDO10, > + S2MPS15_LDO11, > + S2MPS15_LDO12, > + S2MPS15_LDO13, > + S2MPS15_LDO14, > + S2MPS15_LDO15, > + S2MPS15_LDO16, > + S2MPS15_LDO17, > + S2MPS15_LDO18, > + S2MPS15_LDO19, > + S2MPS15_LDO20, > + S2MPS15_LDO21, &g

Re: [PATCH v2 1/5] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-26 Thread Lee Jones
--- > 1 file changed, 15 insertions(+), 8 deletions(-) Nothing to controversial here. For my own reference: Acked-by: Lee Jones <lee.jo...@linaro.org> > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Documentation/devicetree/bindings/mfd/s2mps11.txt

Re: [PATCH v2 2/5] mfd: sec: Add support for S2MPS15 PMIC

2015-10-26 Thread Lee Jones
On Mon, 26 Oct 2015, Alim Akhtar wrote: > Hi Lee, > Thanks for looking into this. > > On 10/26/2015 04:36 PM, Lee Jones wrote: > >On Mon, 26 Oct 2015, Alim Akhtar wrote: > > > >>From: Thomas Abraham <thomas...@samsung.com> > >> > >>Add

Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC

2015-10-26 Thread Lee Jones
; + S2MPS15_LDO12, > + S2MPS15_LDO13, > + S2MPS15_LDO14, > + S2MPS15_LDO15, > + S2MPS15_LDO16, > + S2MPS15_LDO17, > + S2MPS15_LDO18, > + S2MPS15_LDO19, > + S2MPS15_LDO20, > + S2MPS15_LDO21, > + S2MPS15_LDO22, > + S2MPS15_LDO23, > +

Re: [PATCH v2 1/3] mfd: sec-core: Dump PMIC revision to find out the HW

2015-10-13 Thread Lee Jones
; > +} > + > #ifdef CONFIG_OF > /* > * Only the common platform data elements for s5m8767 are parsed here from > the > @@ -425,6 +434,7 @@ static int sec_pmic_probe(struct i2c_client *i2c, > goto err_mfd; > > device_init_wakeup(sec_pmic->

Re: [PATCH v2 3/3] mfd: sec-core: Disable buck voltage reset on watchdog falling edge

2015-10-13 Thread Lee Jones
samsung.com> > Tested-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> These should be in chronological order. I will do that for you this time when I apply the patch. For my own reference: Acked-by: Lee Jones <lee.jo...@linaro.org> > --- > > Changs since

Re: [PATCH v2 1/3] mfd: sec-core: Dump PMIC revision to find out the HW

2015-10-13 Thread Lee Jones
> Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > > --- > > Changs since v1: > None. > --- > drivers/mfd/sec-core.c | 10 ++ > 1 file changed, 10 insertions(+) For my own reference: Acked-by: Lee Jones <lee.jo...@linaro.org> > diff -

Re: [PATCH v2 3/3] mfd: sec-core: Disable buck voltage reset on watchdog falling edge

2015-10-13 Thread Lee Jones
a/include/linux/mfd/samsung/s2mps13.h > b/include/linux/mfd/samsung/s2mps13.h > index b1fd675fa36f..239e977ba45d 100644 > --- a/include/linux/mfd/samsung/s2mps13.h > +++ b/include/linux/mfd/samsung/s2mps13.h > @@ -184,5 +184,6 @@ enum s2mps13_regulators { > * Let's assume that default va

Re: [PATCH v2 2/3] mfd: dt-bindings: Document pulled down WRSTBI pin on S2MPS1X

2015-10-13 Thread Lee Jones
the system is suspended it will always go down thus triggerring > + unwanted buck warm reset (setting buck voltages to default values). > > Optional nodes: > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered > 32.768 -- Lee Jones Linaro STMicroelectro

Re: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11

2015-10-13 Thread Lee Jones
CTRL1 register to turn off the > > power. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowsk...@gmail.com> > > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> > > Acked-by: Lee Jones <lee.jo...@linaro.org> > > > > --- >

Re: [PATCH 2/2] ARM: multi_v7_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-05 Thread Lee Jones
NFIG_BROADCOM_PHY=y > CONFIG_ICPLUS_PHY=y > CONFIG_MICREL_PHY=y > CONFIG_USB_PEGASUS=y > +CONFIG_USB_RTL8152=y > CONFIG_USB_USBNET=y > CONFIG_USB_NET_SMSC75XX=y > CONFIG_USB_NET_SMSC95XX=y -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH 1/2] ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-05 Thread Lee Jones
gt; CONFIG_DM_CRYPT=m > CONFIG_NETDEVICES=y > CONFIG_SMSC911X=y > +CONFIG_USB_RTL8152=y > CONFIG_USB_USBNET=y > CONFIG_USB_NET_SMSC75XX=y > CONFIG_USB_NET_SMSC95XX=y -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v3 2/4] Documentation: bindings: mfd: cros ec: document vbc EC property

2015-09-24 Thread Lee Jones
,cros-ec-lpc" > - reg: List of (IO address, size) pairs defining the interface uses > > +Optional properties (all): > +- google,has-vbc-nvram: Some implementations of the EC include a small > + nvram space used to store verified boot context data. This boolean flag > + is used to

Re: [PATCH v3 2/4] Documentation: bindings: mfd: cros ec: document vbc EC property

2015-09-22 Thread Lee Jones
er this nvram is present or not. Is there no way to check for this at runtime? > Example for I2C: > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send th

Re: [RESEND v2] mfd: s2mps11: Add manual shutdown method for Odroid XU3

2015-09-19 Thread Lee Jones
adds respective binding allowing Odroid XU3 device to be > powered off. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowsk...@gmail.com> > Reported-by: Anand Moon <linux.am...@gmail.com> > Tested-by: Anand Moon <linux.am...@gmail.com> > Reviewed-by: Javier

Re: [PATCH v2 2/3] mfd: s2mps11: Add manual shutdown method for Odroid XU3

2015-09-14 Thread Lee Jones
OLD/PSHOLD pin will actually cut off the power). > > > > The patch adds respective binding allowing Odroid XU3 device to be > > powered off. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowsk...@gmail.com> > > Reported-by: Anand Moon <linux.am.

Re: [PATCH v4 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property

2015-08-24 Thread Lee Jones
Canillas jav...@osg.samsung.com Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- Changes in v4: - Add Lee Jones Acked-by tag to patch #1. Changes in v3: None Changes in v2: - Add Krzysztof Kozlowski Reviewed-by tag to patch #1

Re: [PATCH v4 4/4] mfd: max77686: Split out regulator part from the DT binding

2015-08-24 Thread Lee Jones
Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- Changes in v4: None Changes in v3: - Add Krzysztof Kozlowski Reviewed-by tag to patch #4. - Add Lee Jones Acked-by tag to patch #4. Changes in v2: - Use a generic name for the max77686 node in the regulator

Re: [PATCH v4 2/4] mfd: max77686: Use a generic name for the PMIC node in the example

2015-08-24 Thread Lee Jones
of using the chip's name. Suggested-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- Changes in v4: - Add Lee Jones Acked-by tag to patch #2. Changes in v3: - Fix typo

Re: [PATCH v4 3/4] mfd: Add DT binding for Maxim MAX77802 IC

2015-08-24 Thread Lee Jones
Jones. - Align max77802 mfd required properties. Suggested by Lee Jones. Changes in v3: - Add Krzysztof Kozlowski Reviewed-by tag to patch #3. - Capitalise all acronyms. Suggested by Lee Jones. - Use relative path to refer other bindings. Suggested by Lee Jones. - Use IRQ_TYPE_NONE instead

Re: [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC

2015-08-11 Thread Lee Jones
. Suggested by Lee Jones. - Use relative path to refer other bindings. Suggested by Lee Jones. - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones. Changes in v2: - Use the correct maxim,max77802 compatible string. Suggested by Krzysztof Kozlowski - Use a pmic generic node name

Re: [PATCH v3 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property

2015-08-11 Thread Lee Jones
deletions(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt index 163bd81a4607..8221102d3fc2 100644 --- a/Documentation/devicetree/bindings/mfd/max77686.txt +++ b/Documentation

Re: [PATCH v3 2/4] mfd: max77686: Use a generic name for the PMIC node in the example

2015-08-11 Thread Lee Jones
/devicetree/bindings/mfd/max77686.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt index 8221102d3fc2..d2ed3c20a5c3 100644

Re: [PATCH 1/2] mfd: s2mps11: Add manual shutdown method for Odroid XU3

2015-08-10 Thread Lee Jones
. Binding looks fine. Please seperate it into a different patch and apply my Ack: Acked-by: Lee Jones lee.jo...@linaro.org Optional nodes: - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

2015-08-10 Thread Lee Jones
regards, Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/2] MAINTAINERS: add Device Tree binding doc for max77686 regulator

2015-07-23 Thread Lee Jones
/devicetree/bindings/*/max77686.txt F: Documentation/devicetree/bindings/mfd/max77693.txt F: Documentation/devicetree/bindings/clock/maxim,max77686.txt F: include/linux/mfd/max14577*.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH 2/2] MAINTAINERS: add an entry for the Maxim MAX77802 PMIC drivers

2015-07-23 Thread Lee Jones
/*/*max77802.txt +F: include/dt-bindings/*/*max77802.h + MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BOARDS M: Chanwoo Choi cw00.c...@samsung.com M: Krzysztof Kozlowski k.kozlow...@samsung.com -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH v2 3/4] mfd: Add DT binding for Maxim MAX77802 IC

2015-07-23 Thread Lee Jones
. + +Example: + + max77802: pmic@09 { + compatible = maxim,max77802; + interrupt-parent = intc; + interrupts = 26 0; Is there a define in include/dt-bindings/interrupt-controller to replace 0? IRQ_TYPE_NONE perhaps. + reg = 0x09; + }; -- Lee

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-22 Thread Lee Jones
On Thu, 25 Jun 2015, Lee Jones wrote: On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM) This happened because

Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

2015-07-22 Thread Lee Jones
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

2015-07-22 Thread Lee Jones
On Thu, 25 Jun 2015, Lee Jones wrote: On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: The ChromeOS EC SPI transport driver has a dependency on OF because it uses some OF helpers from the linux/of.h header. But there isn't a need for an explicit dependency since the header has stub

Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding

2015-07-20 Thread Lee Jones
100644 Documentation/devicetree/bindings/regulator/max77686.txt I'm fine with this, but still needs Marks Ack before I can do anything with it. Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686

Re: [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property

2015-07-20 Thread Lee Jones
; + buck9_reg: BUCK9 { regulator-name = CAM_ISP_CORE_1.2V; regulator-min-microvolt = 100; regulator-max-microvolt = 120; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org

Re: [PATCH] mfd: Drop owner assignment from i2c_drivers

2015-07-10 Thread Lee Jones
, .of_match_table = of_match_ptr(wm8994_of_match), }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

2015-06-25 Thread Lee Jones
(SPI) - depends on MFD_CROS_EC CROS_EC_PROTO SPI OF + depends on MFD_CROS_EC CROS_EC_PROTO SPI ---help--- If you say Y here, you get support for talking to the ChromeOS EC -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-06-25 Thread Lee Jones
MFD_CROS_EC tristate ChromeOS Embedded Controller - depends on X86 || ARM select MFD_CORE select CHROME_PLATFORMS select CROS_EC_PROTO -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH v7 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-15 Thread Lee Jones
...@chromium.org Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks. --- Changes since v6: - Add Olof Johansson Acked-by tag Changes since v5: None Changes since v4: None Changes since v3: - Added

Re: [PATCH v7 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-15 Thread Lee Jones
with the EC. So the driver will only get more bigger as other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Javier Martinez Canillas

Re: [PATCH v7 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-15 Thread Lee Jones
Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks. --- Changes since v6: - Add Olof Johansson Acked-by tag Changes since v5: None Changes since v4: None Changes since v3: None Changes since v2: None Changes since v1: - Added

Re: [PATCH v7 1/8] mfd: cros_ec: Use a zero-length array for command data

2015-06-15 Thread Lee Jones
-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks. --- Changes since v6: - Add Olof Johansson Acked-by tag. Changes since v5: None Changes since v4: None Changes since v3: - Added acked-by tag from

Re: [PATCH v7 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-15 Thread Lee Jones
...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks. --- Changes since v6: - Add Olof Johansson Acked-by tag

Re: [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-15 Thread Lee Jones
changed, 1808 insertions(+), 464 deletions(-) create mode 100644 drivers/platform/chrome/cros_ec_proto.c -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v7 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-15 Thread Lee Jones
-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks

Re: [PATCH v7 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-15 Thread Lee Jones
...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net Applied, thanks. --- Changes since v6: - Add Olof Johansson Acked-by tag

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Lee Jones
-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de --- Changes since v5: - Don't allow to change the device name from DT. Suggested by Lee Jones

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Lee Jones
-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de --- Changes since v5: - Don't allow to change the device name from DT. Suggested by Lee Jones

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Lee Jones
On Wed, 03 Jun 2015, Javier Martinez Canillas wrote: Hello Lee, Thanks a lot for your feedback. On 06/03/2015 10:53 AM, Lee Jones wrote: On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: From: Gwendal Grignou gwen...@chromium.org Chromebooks can have more than one Embedded

Re: [PATCH v5 7/9] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Lee Jones
-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de --- Changes since v4: - Use cros-ec-name DT property instead of devname. Suggested by Lee Jones

Re: [PATCH v3 6/7] mfd: cros_ec: Support multiple EC in a system

2015-05-28 Thread Lee Jones
On Thu, 28 May 2015, Javier Martinez Canillas wrote: Hello Lee, Thanks a lot for your feedback. On 05/27/2015 11:11 AM, Lee Jones wrote: On Fri, 22 May 2015, Javier Martinez Canillas wrote: From: Gwendal Grignou gwen...@chromium.org Chromebooks can have more than one Embedded

Re: [PATCH v3 4/7] mfd: cros_ec: add proto v3 skeleton

2015-05-27 Thread Lee Jones
...@chromium.org --- Changes since v2: - Add the helpers to the drivers/platform/chrome/cros_ec_proto.c driver instead of drivers/mfd/cros_ec.c. Suggested by Lee Jones. - Rename the proto probe functions for proto_query since probe has a special meaning in Linux so is confusing. Changes

Re: [PATCH v3 7/7] mfd: cros_ec: spi: Add delay for asserting CS

2015-05-27 Thread Lee Jones
. If the delay between transactions is not long enough the EC may not be able to respond When re-submitting as seperate patches: Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index faba03e2f1ef..16f228dc243f 100644 --- a/drivers

Re: [PATCH v3 5/7] mfd: cros_ec: add bus-specific proto v3 code

2015-05-27 Thread Lee Jones
! I tried to review, but now my eyes and brain hurt. I feel sorry for the guys who have to actively maintain this stuff. However... you have enough vendor Acks and Tests to make me happy, and if anything is wrong I'm sure you'll come back and fix it promptyly. Acked-by: Lee Jones lee.jo

Re: [PATCH v3 6/7] mfd: cros_ec: Support multiple EC in a system

2015-05-27 Thread Lee Jones
) { err = of_platform_populate(dev-of_node, NULL, NULL, dev); if (err) { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v3 3/7] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-05-27 Thread Lee Jones
with the EC. So the driver will only get more bigger as other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Javier Martinez Canillas

Re: [PATCH v3 1/7] mfd: cros_ec: Use a zero-length array for command data

2015-05-27 Thread Lee Jones
-by: Heiko Stuebner he...@sntech.de --- Changes since v2: - Set the version field in the cros_ec_command. Reported by Heiko Stuebner - Use kmalloc/kfree instead of pre-allocating using variables in the stack. Suggested by Lee Jones. Changes since v1: - Add Heiko Stuebner Tested-by tag

Re: [PATCH v2 04/10] mfd: cros_ec: Use a zero-length array for command data

2015-05-20 Thread Lee Jones
On Wed, 20 May 2015, Javier Martinez Canillas wrote: Hello Lee, On 05/13/2015 01:37 PM, Javier Martinez Canillas wrote: On 05/13/2015 01:10 PM, Lee Jones wrote: On Sat, 09 May 2015, Javier Martinez Canillas wrote: Commit 1b84f2a4cd4a (mfd: cros_ec: Use fixed size arrays

Re: [PATCH 1/2] mfd: sec: Fix RTC alarm interrupt number on S2MPS11

2015-04-07 Thread Lee Jones
, - S2MPS11_IRQ_RTCA0, S2MPS11_IRQ_RTCA1, + S2MPS11_IRQ_RTCA0, S2MPS11_IRQ_SMPL, S2MPS11_IRQ_RTC1S, S2MPS11_IRQ_WTSR, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13

2015-03-26 Thread Lee Jones
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: 2015-03-23 13:34 GMT+01:00 Lee Jones lee.jo...@linaro.org: On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: From: Chanwoo Choi cw00.c...@samsung.com This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is equal

Re: [PATCH] mfd: sec-core: Enable RTC on S2MPS11 PMIC

2015-03-23 Thread Lee Jones
= s2mps11-pmic, }, { + .name = s2mps14-rtc, + }, { .name = s2mps11-clk, .of_compatible = samsung,s2mps11-clk, } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13

2015-03-23 Thread Lee Jones
On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: On wto, 2015-03-17 at 10:54 +0100, Krzysztof Kozlowski wrote: From: Chanwoo Choi cw00.c...@samsung.com This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is equal to S2MPS14's RTC. Cc: Lee Jones lee.jo

Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13

2015-03-23 Thread Lee Jones
On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: From: Chanwoo Choi cw00.c...@samsung.com This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is equal to S2MPS14's RTC. Cc: Lee Jones lee.jo...@linaro.org Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com

Re: [PATCH v3 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-23 Thread Lee Jones
...@collabora.co.uk --- Changes since v2: - Rename the name to cros-ec-ctl. Suggested by Lee Jones. Changes since v1: None, new patch. --- drivers/mfd/cros_ec.c | 4 1 file changed, 4 insertions(+) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/mfd/cros_ec.c b

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/20/2015 05:34 PM, Lee Jones wrote: So, the Embedded Controller driver (drivers/mfd/cros_ec.c) falls into that category and in fact has been in the mfd driver for a long time. Now, if an mfd device support different

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Lee Jones
On Thu, 22 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/22/2015 09:42 AM, Lee Jones wrote: I don't think the drivers you mentioned above do anything practical. For instance, they are not SPI/IC2/etc drivers. They should only offer some abstraction layers which

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Lee Jones
On Thu, 22 Jan 2015, Javier Martinez Canillas wrote: On 01/22/2015 10:46 AM, Lee Jones wrote: But there doesn't seem to be a LPC subsystem in the kernel so we don't have a nice abstraction layer in this case. This is the crux of the problem. However, I feel bad for MFD

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
. + .id = 3, + }, }; int cros_ec_register(struct cros_ec_device *ec_dev) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-20 Thread Lee Jones
); + platform_driver_unregister(cros_ec_lpc_driver); +} + +module_init(cros_ec_lpc_init); +module_exit(cros_ec_lpc_exit); + +MODULE_LICENSE(GPL); +MODULE_DESCRIPTION(ChromeOS EC LPC driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH v5 4/5] mfd/regulator: dt-bindings: max77686: Document gpio properties

2015-01-20 Thread Lee Jones
; + }; } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org

Re: [PATCH v5 4/5] mfd/regulator: dt-bindings: max77686: Document gpio properties

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Krzysztof Kozlowski wrote: On wto, 2015-01-20 at 13:41 +, Lee Jones wrote: On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote: Document usage of maxim,ena-gpios properties which turn on external/GPIO control over regulator. Signed-off-by: Krzysztof

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/20/2015 05:29 PM, Lee Jones wrote: It's not a blocker, but it is a ridiculous name to use inside the driver/ directory 'cos almost everything is a dev(ice) here. Right, do you think that cros-ec-chardev

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, Thanks a lot for your feedback. On 01/20/2015 08:50 AM, Lee Jones wrote: @@ -59,9 +60,17 @@ struct cros_ec_command { * * @ec_name: name of EC device (e.g. 'chromeos-ec') * @phys_name: name of physical comms layer

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/20/2015 09:11 AM, Lee Jones wrote: On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: From: Bill Richardson wfric...@chromium.org This adds the LPC interface to the Chrome OS EC. Like the I2C and SPI drivers

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, Thanks a lot for your feedback. On 01/20/2015 09:20 AM, Lee Jones wrote: On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: The ChromeOS EC character device is an user-space interface to allow applications to access

Re: [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-19 Thread Lee Jones
cros_ec_device *ec, unsigned int offset, +unsigned int bytes, void *dest); Is this safe? Are you sure it's okay to provide an interface from userspace to read (kernel?) memory? /* These are used to implement the platform-specific interface */ void *priv; -- Lee

Re: [PATCH v3 08/14] mfd: max77686/802: Remove support for board files

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Krzysztof Kozlowski wrote: On pon, 2014-11-03 at 17:01 +, Lee Jones wrote: On Thu, 30 Oct 2014, Krzysztof Kozlowski wrote: The driver is used only on Exynos based boards with DTS support. Convert the driver to DTS-only version. This simplifies a little

Re: [PATCH 02/12] drivers: mfd: Add support for Exynos PMU driver

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Pankaj Dubey wrote: On Monday, November 03, 2014 8:56 PM, Lee Jones wrote, Subject: Re: [PATCH 02/12] drivers: mfd: Add support for Exynos PMU driver On Mon, 03 Nov 2014, Amit Daniel Kachhap wrote: From: Pankaj Dubey pankaj.du...@samsung.com This patch

Re: [PATCH 02/12] drivers: mfd: Add support for Exynos PMU driver

2014-11-03 Thread Lee Jones
...@samsung.com CC: Samuel Ortiz sa...@linux.intel.com CC: Lee Jones lee.jo...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-exynos/Makefile

Re: [PATCH v3 02/14] mfd/regulator: dt-bindings: max77686: Document of_compatible for regulator

2014-11-03 Thread Lee Jones
{ regulator-compatible = LDO11; regulator-name = vdd_ldo11; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 08/14] mfd: max77686/802: Remove support for board files

2014-11-03 Thread Lee Jones
*/ - unsigned int buck3_voltage[8]; - unsigned int buck4_voltage[8]; -}; - #endif /* __LINUX_MFD_MAX77686_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list

  1   2   3   >