Re: [PATCH v4 05/20] PM / devfreq: Add new passive governor

2015-12-14 Thread MyungJoo Ham
r is operated as parent > with ondemand governor and then the rest device driver with passive governor > is influenced by parent device. > > Suggested-by: Myungjoo Ham <myungjoo@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > [linux.amoon: Teste

Re: [PATCH v4 06/20] PM / devfreq: Add devfreq_get_devfreq_by_phandle()

2015-12-14 Thread MyungJoo Ham
> Tested-by: Anand Moon <linux.am...@gmail.com> Signed-off-by: MyungJoo Ham <myungjoo@samsung.com> > --- > drivers/devfreq/devfreq.c | 44 > include/linux/devfreq.h | 9 + > 2 files changed, 53 insertions(+) >

Re: [PATCH v4 07/20] PM / devfreq: Show the related information according to governor type

2015-12-14 Thread MyungJoo Ham
> > This patch modifies the following sysfs entry of DEVFREQ framework > because the devfreq device using passive governor don't need the same > information of the devfreq device using rest governor. > - polling_interval: passive gov don't use the sampling rate. > - available_governors :

Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

2015-12-14 Thread MyungJoo Ham
> > This patch adds the generic exynos bus frequency driver for AMBA AXI bus > of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC > have the common architecture for bus between DRAM and sub-blocks in SoC. > This driver can support the generic bus frequency driver for

Re: [PATCH v4 02/20] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver

2015-12-14 Thread MyungJoo Ham
> > This patch adds the documentation for generic exynos bus frequency > driver. > > Signed-off-by: Chanwoo Choi > Reviewed-by: Krzysztof Kozlowski A little changes following: > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 93

Re: [PATCH v4 03/20] ARM: dts: Add DMC bus node for Exynos3250

2015-12-14 Thread MyungJoo Ham
Following list specifies the detailed relation between the clock and DMC > block: > - The source clock of DMC block : div_dmc > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Acked-by: MyungJoo Ham <my

Re: [PATCH v4 04/20] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk

2015-12-14 Thread MyungJoo Ham
mu_dmc0*) can monitor the utilization of DMC bus > on runtime and the buck1_reg (VDD_MIF power line) supplies the power to > the DMC block. > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Acked-by: MyungJoo Ham <myungjoo@samsung.com>

Re: Re: [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver

2015-11-29 Thread MyungJoo Ham
> Hi Rob, > > On Sat, Nov 28, 2015 at 5:30 AM, Rob Herring wrote: > > On Thu, Nov 26, 2015 at 10:47:26PM +0900, Chanwoo Choi wrote: > >> This patch adds the documentation for generic exynos bus frequency > >> driver. > >> > >> Signed-off-by: Chanwoo Choi

Re: [RFC PATCH 01/15] PM / devfreq: exynos: Add generic exynos bus frequency driver

2015-11-26 Thread MyungJoo Ham
On Thu, Nov 26, 2015 at 10:47 PM, Chanwoo Choi wrote: > This patch adds the generic exynos bus frequency driver for AMBA AXI bus > of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC > have the common architecture for bus between DRAM and sub-blocks

Re: [patch] PM / devfreq: exynos-ppmu: fix load_count calculation

2015-08-17 Thread MyungJoo Ham
pmcnt_high 0xff is a u32 so we shifting it 32 spaces is zero. GCC catches this bug: drivers/devfreq/event/exynos-ppmu.c: In function ‘exynos_ppmu_v2_get_event’: drivers/devfreq/event/exynos-ppmu.c:322:3: warning: left shift count = width of type load_count = (u64)((pmcnt_high 0xff)

Re: Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

2015-08-02 Thread MyungJoo Ham
Device Tree binding listed #clock-cells as an optional property. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com [] Example1 : PPMU nodes in exynos3250.dtsi are listed below. Reviewed-by: Chanwoo Choi cw00.c...@samsung.com + Devfreq maintainer (Myungjoo Ham

Re: [PATCH v2 1/2] PM / devfreq: exynos-ppmu: Add the support of PPMUv2 for Exynos5433

2015-07-26 Thread MyungJoo Ham
This patch adds the support for PPMU (Platform Performance Monitoring Unit) version 2.0 for Exynos5433 SoC. Exynos5433 SoC must need PPMUv2 which is quite different from PPMUv1.1. The exynos-ppmu.c driver supports both PPMUv1.1 and PPMUv2. Cc: MyungJoo Ham myungjoo@samsung.com Cc

Re: Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ

2015-06-07 Thread MyungJoo Ham
On 06/05/2015 01:54 PM, MyungJoo Ham wrote: IRQ signal before driver probe is needless because driver sends current state after platform booting done. So, this patch clears MUIC IRQ bits before request IRQ. Signed-off-by: Jaewon Kim jaewon02@samsung.com --- drivers

Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ

2015-06-04 Thread MyungJoo Ham
IRQ signal before driver probe is needless because driver sends current state after platform booting done. So, this patch clears MUIC IRQ bits before request IRQ. Signed-off-by: Jaewon Kim jaewon02@samsung.com --- drivers/extcon/extcon-max77843.c |9 + 1 file

Re: [PATCH 30/35 linux-next] devfreq: constify of_device_id array

2015-03-16 Thread MyungJoo Ham
of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick f...@skynet.be Acked-by: MyungJoo Ham myungjoo@samsung.com --- drivers/devfreq/event/exynos-ppmu.c | 2 +- drivers/devfreq/tegra-devfreq.c | 2 +- 2

Re: [PATCH] devfreq: event: Add 'const' keyword for devfreq_event_ops structure

2015-03-11 Thread MyungJoo Ham
This patch adds the 'const' keyword for devfreq_event_ops structure because the ops of devfreq_event_desc structure shold not be changed after initialization. Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c

Re: Re: [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver

2015-02-23 Thread MyungJoo Ham
Hello Chanwoo! Chanwoo Choi wrote: As you thought, when maintaining lower clock of memory bus frequency, some issue related to multimedia feature will happen. Separately, We have to check the miminum lower clock for working of multimedia feature. and then multimedia or other IP

Re: Re: [patch] PM / devfreq: event: testing the wrong variable

2015-02-12 Thread MyungJoo Ham
releasing Linux 3.20-rc1, this patch will be handled. Thanks, Chanwoo Choi Acked-by: MyungJoo Ham myungjoo@samsung.com

Re: RE: [PATCH v9 0/7] devfreq: Add devfreq-event class to provide raw data for devfreq device

2015-01-25 Thread MyungJoo Ham
Chanwoo Choi wrote: Hi, [] -- Looks good to me. Myungjoo, shall I take DT changes in this series into Samsung tree? 4/7 ARM: dts: Add PPMU dt node for Exynos3250 SoC 5/7 ARM: dts: Add PPMU dt node for Exynos4 SoCs 6/7 ARM: dts: exynos: Add PPMU node for

Re: [PATCHv8 1/9] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor

2015-01-19 Thread MyungJoo Ham
various governors. - devfreq_event class (new) : Provide measured raw data to devfreq device for governor Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- [] +/** + * devfreq_event_enable_edev

Re: [PATCHv8 2/9] devfreq: event: Add resource-managed function for devfreq-event device

2015-01-19 Thread MyungJoo Ham
: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.coma Reviewed-by: MyungJoo Ham myungjoo@samsung.com You may merge this patch with 1/9 as well. I don't think this is a major change the requires a seperated patch

Re: [PATCH v4 8/9] ARM: dts: Add the support for exynos busfreq on Exynos4412-based TRATS2 board

2015-01-19 Thread MyungJoo Ham
...@kernel.org Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: MyungJoo Ham myungjoo@samsung.com N�r��yb�X��ǧv�^�)޺{.n�+{�x,�ȧ���ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z

Re: [PATCH v4 7/9] ARM: dts: Add the support for exynos busfreq on Exynos3250-based Rinato/Monk board

2015-01-19 Thread MyungJoo Ham
...@kernel.org Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Youngjun Cho yj44@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com I am not so confident with this SoC as I didn't write

Re: [PATCH v4 9/9] devfreq: exynos: Remove unused exynos4 memory busfreq driver

2015-01-19 Thread MyungJoo Ham
This patch removes the unused exynos4 memory busfreq driver by adding generic exynos memory bus frequency driver. Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Reviewed-by: MyungJoo Ham myungjoo

Re: [PATCH v4 6/9] ARM: dts: Add memory bus node for Exynos4210

2015-01-19 Thread MyungJoo Ham
: - DMC/ACP clock : DMC (Dynamic Memory Controller) - ACLK200 clock : LCD0 - ACLK100 clock : PERIL/PERIR/MFC(PCLK) - ACLK160 clock : CAM/TV/LCD0/LCD1 - ACLK133 clock : FSYS/GPS - GDL/GDR clock : leftbus/rightbus - SCLK_MFC clock : MFC Cc: Kukjin Kim kg...@kernel.org Cc: Myungjoo Ham

Re: Re: [PATCHv3 2/8] devfreq: exynos: Add documentation for generic exynos memory bus frequency driver

2015-01-13 Thread MyungJoo Ham
Acked-by: MyungJoo Ham myungjoo@samsung.com Adding to Chanwoo's reply: If I understand Chanwoo's intention correctly, this patchset is to provide a common bus memory-interface DVFS driver for several Exynos SoCs, which allows DT to express per-SoC hardware details so that we do not need

Re: Re: [PATCHv3 1/8] devfreq: exynos: Add generic exynos memory bus frequency driver

2015-01-13 Thread MyungJoo Ham
Dear Myungjoo, On 01/13/2015 05:42 PM, MyungJoo Ham wrote: This patch adds the generic exynos bus frequency driver for memory bus with DEVFREQ framework. The Samsung Exynos SoCs have the common architecture for memory bus between DRAM memory and MMC/sub IP in SoC. This driver can

Re: [PATCHv3 3/8] ARM: dts: Add memory bus node for Exynos3250

2015-01-13 Thread MyungJoo Ham
: Kukjin Kim kg...@kernel.org Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: MyungJoo Ham myungjoo@samsung.com --- arch/arm/boot/dts

Re: [PATCHv3 1/8] devfreq: exynos: Add generic exynos memory bus frequency driver

2015-01-13 Thread MyungJoo Ham
. There are a little difference about the number of memory bus because each Exynos SoC have the different sub-IP and different memory bus speed. In spite of this difference among Exynos SoCs, we can support almost Exynos SoC by adding unique data of memory bus to devicetree file. Cc: Myungjoo Ham

Re: [PATCHv3 5/8] ARM: dts: Add memory bus node for Exynos4x12

2015-01-13 Thread MyungJoo Ham
: Kukjin Kim kg...@kernel.org Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: MyungJoo Ham myungjoo@samsung.com for all the other dts file patch with Exynos*. Off Topic. Not urgent. Just out

Re: [PATCHv7 04/10] devfreq: event: Add exynos-ppmu devfreq-event driver

2015-01-12 Thread MyungJoo Ham
logic in each IP. This patch is based on existing drivers/devfreq/exynos/exynos-ppmu.c Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/devfreq/event/Kconfig | 9 + drivers/devfreq

Re: [PATCHv7 03/10] devfreq: event: Add resource-managed function for devfreq-event device

2015-01-12 Thread MyungJoo Ham
: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/devfreq/devfreq-event.c | 63 + include/linux/devfreq-event.h | 16 +++ 2 files changed, 79

Re: [PATCHv7 10/10] ARM: dts: exynos: Add PPMU node for Exynos4412-based TRATS2 board

2015-01-12 Thread MyungJoo Ham
This patch add dt node for PPMU_{DMC0|DMC1|LEFTBUS|RIGHTBUS} for exynos4412-trats2 board. Each PPMU dt node includes one event of 'PPMU Count3'. Cc: Kukjin Kim kg...@kernel.org Cc: Myungjoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo

Re: [PATCHv7 05/10] devfreq: event: Add documentation for exynos-ppmu devfreq-event driver

2015-01-12 Thread MyungJoo Ham
I have rephrased part of the documentation for better readability. Some semantics is guessed so you may need to re-rephrase. Other than that, Acked-by: MyungJoo Ham myungjoo@samsung.com This patch adds the documentation for Exynos PPMU (Platform Performance Monitoring Unit) devfreq

Re: [PATCHv7 07/10] ARM: dts: Add PPMU dt node for Exynos4 SoCs

2015-01-12 Thread MyungJoo Ham
++ arch/arm/boot/dts/exynos4210.dtsi | 8 +++ 2 files changed, 116 insertions(+) Acked-by: MyungJoo Ham myungjoo@samsung.com

Re: [PATCHv7 00/10] devfreq: Add devfreq-event class to provide raw data for devfreq device

2015-01-12 Thread MyungJoo Ham
This patchset add new devfreq_event class to provide raw data to determine current utilization of device which is used for devfreq governor. The following description explains the feature of two kind of devfreq class: - devfreq class (existing) : devfreq consumer device use raw data

Re: Re: [PATCHv7 00/10] devfreq: Add devfreq-event class to provide raw data for devfreq device

2015-01-12 Thread MyungJoo Ham
On 01/12/2015 06:58 PM, MyungJoo Ham wrote: This patchset add new devfreq_event class to provide raw data to determine current utilization of device which is used for devfreq governor. The following description explains the feature of two kind of devfreq class: - devfreq class

Re: [PATCHv7 02/10] devfreq: event: Add the list of supported devfreq-event type

2015-01-11 Thread MyungJoo Ham
- DEVFREQ_EVENT_TYPE_LATENCY Did you try to say: A devfreq-event device may support multiple devfreq-event types simultaneously. If so, your switch expressions are going to screw up. Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Chanwoo

Re: Re: [PATCHv4 1/8] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor

2014-12-18 Thread MyungJoo Ham
Dear Myungjoo, Thanks for your review. On 12/18/2014 03:24 PM, MyungJoo Ham wrote: Hi Chanwoo, I love the idea and I now have a little mechanical issues in your code. --- drivers/devfreq/Kconfig | 2 + drivers/devfreq/Makefile| 5 +- drivers

Re: [PATCHv4 1/8] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor

2014-12-17 Thread MyungJoo Ham
Hi Chanwoo, I love the idea and I now have a little mechanical issues in your code. --- drivers/devfreq/Kconfig | 2 + drivers/devfreq/Makefile| 5 +- drivers/devfreq/devfreq-event.c | 449 drivers/devfreq/event/Makefile | 1

Re: [RFC 1/3] devfreq: dt-bindings: Document Exynos3250 devfreq driver

2014-12-07 Thread MyungJoo Ham
Add documentation for bindings used by Exynos3250 devfreq driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- .../bindings/arm/samsung/exynos3250-devfreq.txt| 66 ++ 1 file changed, 66 insertions(+) create mode 100644

Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV

2014-05-24 Thread MyungJoo Ham
On Fri, May 23, 2014 at 1:52 PM, MyungJoo Ham myungjoo@samsung.com wrote: On Thu, May 22, 2014 at 5:37 AM, Paul Bolle pebo...@tiscali.nl wrote: Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig symbol has never been added to the tree. Remove these checks

Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV

2014-05-22 Thread MyungJoo Ham
On Thu, May 22, 2014 at 5:37 AM, Paul Bolle pebo...@tiscali.nl wrote: Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig symbol has never been added to the tree. Remove these checks, as they always evaluate to false. Signed-off-by: Paul Bolle pebo...@tiscali.nl Thanks

Re: [PATCH 06/11] PM / devfreq: move definitions for exynos4_bus into drivers/devfreq

2013-12-18 Thread MyungJoo Ham
On Thu, Dec 19, 2013 at 2:54 AM, Kukjin Kim kgene@samsung.com wrote: On 12/18/13 15:11, MyungJoo Ham wrote: On Tue, Dec 17, 2013 at 8:52 PM,kg...@kernel.org wrote: From: Kukjin Kimkgene@samsung.com We don't need to keep the definitions for exynos4_bus into mach-exynos/ so

Re: [PATCH 06/11] PM / devfreq: move definitions for exynos4_bus into drivers/devfreq

2013-12-17 Thread MyungJoo Ham
On Tue, Dec 17, 2013 at 8:52 PM, kg...@kernel.org wrote: From: Kukjin Kim kgene@samsung.com We don't need to keep the definitions for exynos4_bus into mach-exynos/ so this moves them into drviers/devfreq with adding header file. Acked-by: MyungJoo Ham myungjoo@samsung.com However

Re: [PATCH 11/11] PM / devfreq: use inclusion mach/map.h instead of plat/map-s5p.h

2013-12-17 Thread MyungJoo Ham
/map.h:22:0: warning: S3C_UART_OFFSET redefined [enabled by default] In file included from drivers/devfreq/exynos/exynos4_bus.c:33:0: arch/arm/plat-samsung/include/plat/map-s5p.h:57:0: note: this is the location of the previous definition Cc: MyungJoo Ham myungjoo@samsung.com Signed-off

Re: [PATCH 3/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
On Tue, Nov 19, 2013 at 10:30 PM, Jonghwan Choi jhbird.c...@gmail.com wrote: Frequency lock should be considered in suspend/hibernation. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Applied in driver-update branch. Do you want

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
On Tue, Nov 19, 2013 at 10:30 PM, Jonghwan Choi jhbird.c...@gmail.com wrote: Frequency lock should be considered in suspend/hibernation. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Cheers, MyungJoo. --- drivers/devfreq

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

2013-11-20 Thread MyungJoo Ham
. Thanks, Sebastian Capella -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. System S/W Lab, S/W Center, Samsung

Re: [RFC 0/4] Add basic support for ASV

2013-11-12 Thread MyungJoo Ham
-kernel ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- MyungJoo Ham, Ph.D. System S/W Lab, S/W Center, Samsung Electronics -- To unsubscribe from this list: send

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread MyungJoo Ham
anyway. Otherwise, you may get unspecified behavior from the BUCK1/2/5, which may incur unstable system. Cheers, MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v4 2/2] regulator: add device tree support for max8997

2012-03-27 Thread MyungJoo Ham
On Sat, Mar 24, 2012 at 6:49 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add device tree based discovery support for max8997. Cc: MyungJoo Ham myungjoo@samsung.com Cc: Rajendra Nayak rna...@ti.com Cc: Rob Herring rob.herr...@calxeda.com Cc: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts

2012-03-26 Thread MyungJoo Ham
the linux irq number for max8997 interrupts. All uses of irq_base in platform data and max8997 driver private data are removed. Cc: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Grant Likely grant.lik...@secretlab.ca Acked-by: MyungJoo Ham

Re: [PATCH 3/3] PM / devfreq: update the name of EXYNOS clock register

2012-01-30 Thread MyungJoo Ham
On Tue, Jan 31, 2012 at 1:49 PM, Kukjin Kim kgene@samsung.com wrote: According to replacing the name of EXYNOS clock registers, this patch updates exynos4_bus.c file where it is used. Cc: MyungJoo Ham myungjoo@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off

Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-30 Thread MyungJoo Ham
before it, not after it should be fine. So what that be attached patch then? Could you also test this patch? This patch looks fine and works. It's tested in Exynos4 machine. Acked-by: MyungJoo Ham myungjoo@samsung.com Thanks. Cheers! MyungJoo. Kind regards, Wim. --- diff --git a/drivers

Re: [PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-16 Thread MyungJoo Ham
On Sat, Jan 14, 2012 at 6:45 AM, Wim Van Sebroeck w...@iguana.be wrote: Hi, On Fri, Jan 13, 2012 at 11:11:17AM +, Russell King - ARM Linux wrote: On Fri, Jan 13, 2012 at 02:14:23PM +0900, MyungJoo Ham wrote: Probe function of s3c2410 watchdog calls request_irq before initializing

[PATCH] watchdog: fix error in probe() of s3c2410_wdt (reset at booting)

2012-01-12 Thread MyungJoo Ham
oder in remove function are also revised accordingly. Reported-by: Chanwoo Park cw00.c...@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/watchdog/s3c2410_wdt.c | 29 +++-- 1 files changed

Re: Pull Requeset: Exynos4 Register Address Update for Devfreq Drivers.

2011-12-25 Thread MyungJoo Ham
another branch for this. Thus, having the patches in your Exynos' branch is also fine. I'll let future pull-requested branches be rebased on rcX anyway. Thanks. Cheers! Happy new year! - MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics

Pull Requeset: Exynos4 Register Address Update for Devfreq Drivers.

2011-12-20 Thread MyungJoo Ham
/linux-samsung.git devfreq-for-samsung MyungJoo Ham (3): ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC. ARM: EXYNOS4: Add clock register addresses for Exynos4x12 bus devfreq driver ARM Exynos4210-Nuri: support Exynos4210-bus Devfreq driver. arch/arm/mach-exynos/cpu.c

Re: [PATCH 1/2] mfd: add irq domain support for max8997 interrupts

2011-12-08 Thread MyungJoo Ham
On Fri, Dec 9, 2011 at 1:27 AM, Thomas Abraham thomas.abra...@linaro.org wrote: Add irq domain support for max8997 interrupts. All uses of irq_base in platform data and max8997 driver private data are removed. Cc: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Thomas Abraham

Re: [PATCH 3/4] ARM Exynos4210-Nuri: remove compiler errors

2011-12-04 Thread MyungJoo Ham
On Sat, Dec 3, 2011 at 6:26 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: On Fri, Dec 2, 2011 at 5:59 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Hamm wrote: What's the 'compiler errors'? And I don't know why this patch included in this series, maybe

Re: [PATCH 3/4] ARM Exynos4210-Nuri: remove compiler errors

2011-12-02 Thread MyungJoo Ham
) for the device driver and we had to resolve the compiler error first. Cheers! MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

[PATCH 0/4] PM/Devfreq: Exynos4210 Bus/VDD_int

2011-12-01 Thread MyungJoo Ham
CONFIG_EXYNOS4_ASV to block ASV-related code. With support of ASV, this devfreq driver reduces power consumption futher; most Exynos4210 SoCs have lower voltage requirement than the worst case (ASV number 0) scenario. MyungJoo Ham (4): ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC. PM

[PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-01 Thread MyungJoo Ham
- Add DMC1 - Enlarge address space for DMC from 4k to 64k so that PPMU registers may be accessed. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/cpu.c |7 ++- arch/arm/mach-exynos/include

[PATCH 2/4] PM/Devfreq: Add Exynos4210-bus device DVFS driver.

2011-12-01 Thread MyungJoo Ham
because without ASV, this Devfreq driver assumes the worst case scenario, which consumes more power. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/devfreq/Kconfig| 12 + drivers/devfreq/Makefile

[PATCH 4/4] ARM Exynos4210-Nuri: support Exynos4210-bus Devfreq driver.

2011-12-01 Thread MyungJoo Ham
Support varying voltages: - GPIODVS for Buck2 is removed. - Voltage ragne for Buck2 is widen. Support Buck2 regulator for Exynos4210-bus devfreq driver: - Added device name for buck2 regulator - Added exynos4210-busfreq platform device fro Nuri board. Signed-off-by: MyungJoo Ham myungjoo

[PATCH 3/4] ARM Exynos4210-Nuri: remove compiler errors

2011-12-01 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-nuri.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c index

Re: [GIT PULL] Samsung fixes for v3.2

2011-11-23 Thread MyungJoo Ham
for this?        Arnd There was a discussion about this and a patch seemed to be ready although I don't know where: ---[quoting: Re: [PATCH 1/2] ARM: EXYNOS4: convert MCT to percpu interrupt API from linux-arm-ker...@lists.infradead.org]--- On 10/11/11 23:33, MyungJoo Ham wrote: On Thu, Nov 10, 2011 at 6:43 PM

Re: [PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-17 Thread MyungJoo Ham
On Thu, Nov 17, 2011 at 8:22 PM, Amit Kachhap amit.kach...@linaro.org wrote: On 11 November 2011 13:03, MyungJoo Ham myungjoo@gmail.com wrote: On Sat, Nov 5, 2011 at 2:03 AM,  amit.kach...@linaro.org wrote: From: Amit Daniel Kachhap amit.kach...@linaro.org This patch adds support for AFTR

Re: [PATCH 3/3] ARM: EXYNOS4: Support ASV for Exynos4210

2011-11-10 Thread MyungJoo Ham
-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-10 Thread MyungJoo Ham
the value at the same location, which is the method we have been using. Besides, the Exynos4210 chipmaker (S.LSI) has told that INFORM6 and 7 registers are used by in-chip code (iROM or iRAM). Cheers! MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics

Re: [PATCH 1/3] ARM: EXYNOS: Add ASV feature for Exynos4 series

2011-11-09 Thread MyungJoo Ham
. This location mach/asv.h seems the perfect location for the purpose. Besides, now, with Exynos4x12s, I start to hear cases where all the INFORMx registers are fully used; thus, it seems that it's time to remove unnecessary usage of the registers. Cheers! MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software

Re: [PATCH 1/3] ARM: EXYNOS: Add ASV feature for Exynos4 series

2011-11-09 Thread MyungJoo Ham
. Cheers! MyungJoo -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform

Re: [PATCH 5/5] [CPUFREQ] EXYNOS4210: Add support ASV feature

2011-11-02 Thread MyungJoo Ham
://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 4/5] [CPUFREQ] EXYNOS4210: Add DVS lock feature for other driver

2011-11-02 Thread MyungJoo Ham
. Cheers! MyungJoo. -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/5] [CPUFREQ] EXYNOS4210: Remove code about bus on cpufreq

2011-11-02 Thread MyungJoo Ham
-samsung/shortlog/refs/heads/devfreq (drivers/devfreq/exynos4210_memorybus.c) Devfreq is a framework to support DVFS feature for non-CPU devices, which is at 3.2-next tree. Cheers! MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe

Re: [PATCH] ARM: EXYNOS4: Remove useless codes on NURI board

2011-10-06 Thread MyungJoo Ham
On Thu, Oct 6, 2011 at 3:31 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: 2011/8/19 Kyungmin Park kmp...@infradead.org: Maybe charger manager codes are not merged. it's used for charger managers. To Mr. Ham, which patches are missing? Thank you, Kyungmin Park

Re: [PATCH] CPUFREQ: ARM Exynos4210 PM/Suspend Compatibility with Different Bootloaders

2011-08-29 Thread MyungJoo Ham
, MyungJoo Ham myungjoo@samsung.com wrote: We have various bootloaders for Exynos4210 machines. Some of they set the ARM core frequency at boot time even when the boot is a resume from suspend-to-RAM. Such changes may create inconsistency in the data of CPUFREQ driver and have incurred hang issues

Re: [PATCH 3/5] ARM: EXYNOS4: Add support PM for EXYNOS4212

2011-08-25 Thread MyungJoo Ham
once? Also, consider using CONFIG_PM_SLEEP rather than CONFIG_PM for suspend/resume ops. Cheers! MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

[PATCH] CPUFREQ: ARM Exynos4210 PM/Suspend Compatibility with Different Bootloaders

2011-08-18 Thread MyungJoo Ham
mutex that is being used by regulators that are used by the target function. This also prevents any CPUFREQ transitions during suspend-resume context, which could be dangerous at noirq-context along with regulator framework. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off

[PATCH] ARM: EXYNOS4: Add more register addresses of CMU.

2011-07-20 Thread MyungJoo Ham
These registers are crucial for PM to work properly. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos4/include/mach/regs-clock.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm

Re: [PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs

2011-07-20 Thread MyungJoo Ham
On Thu, Jul 21, 2011 at 2:04 AM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: MAX8997/17042, which are used by Exynos4-NURI, use additional IRQ numbers after GPIO's IRQs. The patch creates some room for those devices. Signed-off-by: MyungJoo Ham myungjoo@samsung.com

Re: [PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs

2011-07-20 Thread MyungJoo Ham
On Thu, Jul 21, 2011 at 2:04 AM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: MAX8997/17042, which are used by Exynos4-NURI, use additional IRQ numbers after GPIO's IRQs. The patch creates some room for those devices. Signed-off-by: MyungJoo Ham myungjoo@samsung.com

Re: [PATCH 2/2] ARM: EXYNOS4: Add more registers to be saved and restored for PM

2011-07-19 Thread MyungJoo Ham
On Mon, Jul 18, 2011 at 5:00 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: We need more registers to be saved and restored for PM of Exynos4210. Otherwise, with additional drivers running, suspend-to-RAM fails to wake up properly. This patch adds registers omitted

[PATCH v2 2/2] ARM: EXYNOS4: Add more registers to be saved and restored for PM

2011-07-19 Thread MyungJoo Ham
We need more registers to be saved and restored for PM of Exynos4210. Otherwise, with additional drivers running, suspend-to-RAM fails to wake up properly. This patch adds registers omitted in the initial PM patches. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin

Re: [PATCH 3/3] rtc: rtc-s3c: allow multiple open / allow no-ioctl-open'ed rtc to have irq.

2011-07-03 Thread MyungJoo Ham
On Mon, Jul 4, 2011 at 12:40 PM, Changhwan Youn chaos.y...@samsung.com wrote: AbwBwAGUAbgAgAC8AIAB         hAGwAbABvAHcAIABuAG8ALQBpAG8AYwB0AGwALQBvAHAAZQBuACcAZQBkACAAcgB0AGMAIAB0AG8AIABoAGEAdgBlACAAaQByAHEALgA= x-cr-puzzleid: {71A23705-5400-4E21-9C23-2B1E96E33A68} MyungJoo Ham wrote

Re: [PATCH 1/7] ARM: EXYNOS4: Add external GIC io memory mapping

2011-06-30 Thread MyungJoo Ham
. -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v3 0/6] Update Samsung-SoC ADC to support recent CPUs

2011-06-30 Thread MyungJoo Ham
for S5PC110/S5PV210 Patch 6/6: Header file correction (plat/devs.h) The long-overdue bugfix for compiler errors. ADC for Exynos4 fails to be compiled without this patch. MyungJoo Ham (6): Samsung SoC ADC: use regulator (VDD for ADC). Samsung SoC ADC: Channel selection for S5PV210

[PATCH v3 2/6] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4

2011-06-30 Thread MyungJoo Ham
In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX register, not ADCCON register. This patch corrects the behavior of Samsung-ADC for such cpus. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com -- updates from v2 - Renamed

[PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).

2011-06-30 Thread MyungJoo Ham
to be available at probe. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com -- changed from v2 with valuable comments from Mark Brown. - Bugfix on error handling - Faster escape when error at resume function changes from v1 - Removed macro defining

[PATCH v3 4/6] ARM: EXYNOS4: Support ADC

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com -- Updates from v2 - Based on EXT_GIC patches from Changhwan Youn (ARM: EXYNOS4: Adds External GIC) --- arch/arm/mach-exynos4/Kconfig |1 + arch/arm/mach-exynos4/cpu.c

[PATCH v3 3/6] Samsung SoC ADC: Revise PM for 12-bit ADC operations

2011-06-30 Thread MyungJoo Ham
- Fixed: 12bit precision is lost at suspend/resume - Updated: use pm_dev_ops Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/plat-samsung/adc.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions

[PATCH v3 5/6] ARM: S5PC110/S5PV210: Support ADC

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s5pv210/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c index 61e6c24..79907ec

[PATCH v3 6/6] Samsung SoC: header file revised to prevent declaring duplicated.

2011-06-30 Thread MyungJoo Ham
There has been no #ifndef - #define - #endif protection for this header file. The patch adds it for Exynos4-ADC support Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- arch/arm/plat-samsung/include/plat/devs.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4

2011-06-30 Thread MyungJoo Ham
On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim kgene@samsung.com wrote: MyungJoo Ham wrote: In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX register, not ADCCON register. This patch corrects the behavior of Samsung-ADC for such cpus. Signed-off-by: MyungJoo Ham myungjoo

[PATCH v3 6/6] Exynos4 NURI: configure rtc-s3c.

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos4/mach-nuri.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index

[PATCH v3 0/6] ARM: EXYNOS4: NURI Board Configuration Update

2011-06-30 Thread MyungJoo Ham
is with NURI board. MyungJoo Ham (6): ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs Exynos4 NURI: configure regulators and PMIC (MAX8997) Exynos4 NURI: configure MAX17042 fuel gauge Exynos4 NURI: configure ADC. Exynos4 NURI: configure MAX8903 secondary charger Exynos4 NURI

[PATCH v3 1/6] ARM: EXYNOS4: Increase NR_IRQS for devices with more IRQs

2011-06-30 Thread MyungJoo Ham
MAX8997/17042, which are used by Exynos4-NURI, use additional IRQ numbers after GPIO's IRQs. The patch creates some room for those devices. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos4/include/mach/irqs.h

[PATCH v3 2/6] Exynos4 NURI: configure regulators and PMIC (MAX8997)

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com -- Changes from v3 - Updated init function name to include other power related devices. Changes from v2 - Add more __initdata entries - Moved and renamed pmic init function - Rearranged

[PATCH v3 4/6] Exynos4 NURI: configure ADC.

2011-06-30 Thread MyungJoo Ham
Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos4/mach-nuri.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c index

  1   2   >