Re: [PATCH 3/4] clk: samsung: exynos7: add clocks for audio block

2015-01-14 Thread Padma Venkat
Hi Vivek, On 1/13/15, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Padma, On Fri, Dec 19, 2014 at 6:53 PM, Padmavathi Venna padm...@samsung.com wrote: Add required clk support for I2S,PCM amd SPDIF Signed-off-by: Padmavathi Venna padm...@samsung.com --- verified from Exynos7

Re: [PATCH 3/4] clk: samsung: exynos7: add clocks for audio block

2015-01-12 Thread Padma Venkat
Hi Sylwester, On 12/22/14, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 19/12/14 14:23, Padmavathi Venna wrote: Add required clk support for I2S,PCM amd SPDIF There is a non-trivial conflict with the MSCL CMU patch, could you please resend rebased onto my exynos7 branch: Ok. I

Re: [PATCH 2/4] clk: samsung: exynos7: add clocks for SPI block

2015-01-12 Thread Padma Venkat
Hi ViVek, On 1/9/15, Vivek Gautam gautamvivek1...@gmail.com wrote: On Fri, Jan 9, 2015 at 5:18 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Padma, On Fri, Dec 19, 2014 at 6:53 PM, Padmavathi Venna padm...@samsung.com wrote: Add clock support for 5 SPI channels. Signed-off-by:

Re: [alsa-devel] [PATCH/RFC 00/14] ASoC: samsung: Add clk provider for I2S internal clocks

2014-12-15 Thread Padma Venkat
Hi Sylwester, I need some more thought about interaction between the clk API calls on the clocks being exposed and the ASoC calls into sound/soc/samsung/i2s.c. I'm sending teh patches for review though to avoid any waste of time should it turn out the direction taken is wrong. This whole

Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Add missing assignment of variant_regs

2014-12-08 Thread Padma Venkat
Hi, On 12/9/14, Mark Brown broo...@kernel.org wrote: On Mon, Dec 08, 2014 at 06:45:54PM +0100, Sylwester Nawrocki wrote: Add assignment of the variant_regs field which is missing in commit a5a56871f804edac93a53b5e871c0e9818fb9033 (ASoC: samsung: add support for exynos7 I2S controller).

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-02 Thread Padma Venkat
Hi Lars, [snip] + + ret = dma_cookie_status(chan, cookie, txstate); + if (ret == DMA_COMPLETE || !txstate) + return ret; + + used = txstate-used; + + spin_lock_irqsave(pch-lock, flags); + sar = readl(regs + SA(thrd-id)); + dar = readl(regs + DA(thrd-id)); + +

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-01 Thread Padma Venkat
Hi Vinod/Lars, On 11/26/14, Padmavathi Venna padm...@samsung.com wrote: Fill txstate.residue with the amount of bytes remaining in the current transfer if the transfer is not complete. This will be of particular use to i2s DMA transfers, providing more accurate hw_ptr values to ASoC. I had

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-24 Thread Padma Venkat
Hi Mark, OK. I don't have provision to test on this board. I will try to test on older boards by disabling manual mode. I tested on exynos5420 peach-pit by enabling auto mode. I used dd command to read 1MB data from spi flash and I compared the result with manual mode. Both are same. I

Re: [alsa-devel] [PATCH] ASoC: samsung: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register in i2s_set_sysclk. It's due to an incorrect mask used for the AND ope

2014-11-20 Thread Padma Venkat
Hi, On 11/20/14, Padmavathi Venna padm...@samsung.com wrote: Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Padmavathi Venna padm...@samsung.com --- sound/soc/samsung/i2s.c |5 +++-- 1 files changed, 3

Re: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-20 Thread Padma Venkat
Hi Sylwester, On 11/20/14, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 20/11/14 08:04, Padma Venkat wrote: diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 947352d..8db8c66 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -494,7

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-20 Thread Padma Venkat
Hi Mark, CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The driver by default uses manual mode. But on exynos7 the manual mode is

Re: [alsa-devel] [PATCH] ASoC: samsung: Fix IISMOD setting in i2s_set_sysclk()

2014-11-19 Thread Padma Venkat
Hi Sylwester, On 11/19/14, Sylwester Nawrocki s.nawro...@samsung.com wrote: In the i2s_set_sysclk() callback we are currently clearing all bits of the IISMOD register when clk_id is SAMSUNG_I2S_CDCLK and dir is SND_SOC_CLOCK_OUT. It's due to an incorrect mask used for the AND operation and

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-14 Thread Padma Venkat
Hi Mark, On 11/10/14, Padma Venkat padma@gmail.com wrote: Hi Mark, On 11/7/14, Mark Brown broo...@kernel.org wrote: On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote: CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-09 Thread Padma Venkat
Hi Mark, On 11/7/14, Mark Brown broo...@kernel.org wrote: On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote: CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-07 Thread Padma Venkat
Hi Mark, CCing Kukjin Kim. On 11/6/14, Mark Brown broo...@kernel.org wrote: On Thu, Nov 06, 2014 at 03:21:49PM +0530, Padmavathi Venna wrote: Exynos7 SPI controller supports only the auto Selection of CS toggle mode and Exynos7 SoC includes six SPI controllers. Add support for these changes

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-12-10 Thread Padma Venkat
Hi Mark, On Mon, Dec 9, 2013 at 11:00 PM, Mark Brown broo...@kernel.org wrote: On Fri, Dec 06, 2013 at 10:44:19AM +0530, Padma Venkat wrote: I couldn't test this patch set due to some crash in recent kernel in dmaengine_unmap_put. I think this unmap support is not yet implemented for pl330

Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init

2013-12-09 Thread Padma Venkat
Hi Mark, On Fri, Dec 6, 2013 at 4:57 PM, Mark Brown broo...@kernel.org wrote: On Fri, Dec 06, 2013 at 10:44:33AM +0530, Padma Venkat wrote: This is done in your earlier patch ASoC: samsung: Ensure DMA data is initialised for secondary DAI . Was it done on purpose or by mistake in this patch

Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init

2013-12-09 Thread Padma Venkat
Hi Mark, On Mon, Dec 9, 2013 at 5:30 PM, Padma Venkat padma@gmail.com wrote: Hi Mark, On Fri, Dec 6, 2013 at 4:57 PM, Mark Brown broo...@kernel.org wrote: On Fri, Dec 06, 2013 at 10:44:33AM +0530, Padma Venkat wrote: This is done in your earlier patch ASoC: samsung: Ensure DMA data

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-12-09 Thread Padma Venkat
Hi Mark, On Thu, Dec 5, 2013 at 5:15 PM, Mark Brown broo...@kernel.org wrote: On Thu, Dec 05, 2013 at 04:20:03PM +0530, Padma Venkat wrote: On Thu, Nov 28, 2013 at 5:23 PM, Mark Brown broo...@kernel.org wrote: OK, so we can probably just reinitialise the dmaengine data after we reset

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-12-05 Thread Padma Venkat
Hi Mark, On Thu, Nov 28, 2013 at 5:23 PM, Mark Brown broo...@kernel.org wrote: On Thu, Nov 28, 2013 at 03:29:31PM +0530, Padma Venkat wrote: On Wed, Nov 27, 2013 at 8:35 PM, Mark Brown broo...@kernel.org wrote: But if it's initialised at probe time then when is it getting overwritten

Re: [PATCH] ASoC: samsung: Initialize the dma_data for secondary dai

2013-12-05 Thread Padma Venkat
Hi Mark, On Thu, Nov 28, 2013 at 5:08 PM, Mark Brown broo...@kernel.org wrote: On Thu, Nov 28, 2013 at 03:32:12PM +0530, Padmavathi Venna wrote: This is made based on Mark Brown for-next branch of sound.git This patch is based on Mark Brown below patches for generic dma engine support for

Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init

2013-12-05 Thread Padma Venkat
Hi Mark, On Thu, Dec 5, 2013 at 7:55 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org In preparation for using the dmaengine helpers in ASoC rather than the dmaengine wrappers for the Samsung API wrap the configuration of dma_data. The dmaengine code expects

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-12-05 Thread Padma Venkat
Hi Mark, On Thu, Dec 5, 2013 at 7:55 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Since all Exynos platforms have been converted to dmaengine and many of the older platforms are in the process of conversion they do not need to use the legacy s3c-dma APIs for

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-11-28 Thread Padma Venkat
Hi Mark, On Wed, Nov 27, 2013 at 8:35 PM, Mark Brown broo...@kernel.org wrote: On Wed, Nov 27, 2013 at 06:08:47PM +0530, Padma Venkat wrote: On Tue, Nov 26, 2013 at 5:50 PM, Mark Brown broo...@kernel.org wrote: So this is 16 bit stereo or something, and did it work beforehand? Like I say

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-11-27 Thread Padma Venkat
Hi Mark, On Tue, Nov 26, 2013 at 5:50 PM, Mark Brown broo...@kernel.org wrote: On Tue, Nov 26, 2013 at 04:18:41PM +0530, Padma Venkat wrote: I tried this on linux-samsung tree by applying all the patches from you and Lars. Can you use -next plus the posted patches please in case there's

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-11-26 Thread Padma Venkat
Hi Mark, On Tue, Nov 26, 2013 at 3:53 PM, Mark Brown broo...@kernel.org wrote: On Tue, Nov 26, 2013 at 10:55:17AM +0530, Padma Venkat wrote: I tested this patch set on smdk5420 i2s. During playback audio playing fast and there is underrun error like below. underrun!!! (at least 0.061 ms long

Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init

2013-11-25 Thread Padma Venkat
Hi Mark, On Tue, Nov 12, 2013 at 7:18 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org In preparation for using the dmaengine helpers in ASoC rather than the dmaengine wrappers for the Samsung API wrap the configuration of dma_data. The dmaengine code expects

Re: [alsa-devel] [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

2013-11-25 Thread Padma Venkat
Hi Mark, On Tue, Nov 12, 2013 at 7:18 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Since all Exynos platforms have been converted to dmaengine and many of the older platforms are in the process of conversion they do not need to use the legacy s3c-dma APIs for

Re: [PATCH 1/3] dmaengine: pl330: Set residue in tx_status callback.

2013-09-12 Thread Padma Venkat
Hi Chanho, On Thu, Sep 12, 2013 at 5:10 PM, Chanho Park chanho61.p...@samsung.com wrote: Hi Padmavathi, -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel- boun...@lists.infradead.org] On Behalf Of Padmavathi Venna Sent: Wednesday, September 11, 2013 3:08 PM To:

Re: [PATCH V2 0/4] clk: Samsung: audss: Add support for Exynos5420

2013-08-27 Thread Padma Venkat
Hi Mike, On Mon, Aug 19, 2013 at 2:18 PM, Padma Venkat padma@gmail.com wrote: Hi Mike, On Fri, Aug 16, 2013 at 1:19 PM, Padmavathi Venna padm...@samsung.com wrote: This patch set adds support for audio subsystem clks on Exynos5420. Exynos5420 audio subsystem has a gate bit for ADMA

Re: [PATCH V2 0/4] clk: Samsung: audss: Add support for Exynos5420

2013-08-19 Thread Padma Venkat
Hi Mike, On Fri, Aug 16, 2013 at 1:19 PM, Padmavathi Venna padm...@samsung.com wrote: This patch set adds support for audio subsystem clks on Exynos5420. Exynos5420 audio subsystem has a gate bit for ADMA controller and the some of the parent clks for mout_i2s and sclk_pcm are different from

Re: Broken device trees for exynos in linux-next

2013-08-15 Thread Padma Venkat
Hi, On Fri, Aug 16, 2013 at 6:12 AM, Mark Brown broo...@kernel.org wrote: On Fri, Aug 16, 2013 at 01:35:57AM +0100, Mark Brown wrote: On Fri, Aug 16, 2013 at 09:04:28AM +0900, Kukjin Kim wrote: NO, the build breakage is due to commit 6187288f15bc (ARM: dts: exynos5250: move common i2s

Re: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers

2013-08-13 Thread Padma Venkat
Hi Tomasz, On Mon, Aug 12, 2013 at 10:32 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Monday 12 of August 2013 14:12:36 Mark Brown wrote: On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote: On Monday 12 of August 2013 12:34:48 Mark Brown wrote: I'd expect that to interact badly

Re: [PATCH 0/4] clk: Samsung: audss: Add support for Exynos5420

2013-08-12 Thread Padma Venkat
Hi Kukjin, Any comments on this patch set? Thanks Padma On Wed, Jul 10, 2013 at 5:41 PM, Padmavathi Venna padm...@samsung.com wrote: This patch set adds support for audio subsystem clks on Exynos5420. Exynos5420 audio subsystem has a gate bit for ADMA controller and the some of parent clks

Re: [PATCH 0/2] Move comon DMA nodes to exynos5.dtsi and

2013-08-12 Thread Padma Venkat
Hi Kukjin, Any comment on this patch set? If not can you take into your tree? Thanks Padma On Wed, Jul 10, 2013 at 5:44 PM, Padmavathi Venna padm...@samsung.com wrote: Exynos5250 and Exynos5420 has 4 DMA controllers in common. So this patch set moved the common nodes to exynos.dtsi keeping

Re: [PATCH V3 0/7] Add i2s nodes on Exynos5420 and enable sound support on sdmk5420

2013-08-07 Thread Padma Venkat
Hi, Abandoning this series due to some mistake in the post. Will post new patch set. Thanks Padma On Wed, Aug 7, 2013 at 2:20 PM, Padmavathi Venna padm...@samsung.com wrote: Changes since V2: - Seperated out driver side changes and dts changes in two patch sets -

Re: [PATCH V3 1/7] ARM: dts: Change i2s compatible string on exynos5250

2013-08-07 Thread Padma Venkat
Hi Mark, On Wed, Aug 7, 2013 at 3:40 PM, Mark Brown broo...@kernel.org wrote: On Wed, Aug 07, 2013 at 02:40:10PM +0530, Padmavathi Venna wrote: This patch removes quirks from i2s node and change the i2s compatible names. This needs to go along with the driver change otherwise we break

Re: [PATCH V3 6/7] ASoC: Samsung: wm8994: Register the osc clock.

2013-08-07 Thread Padma Venkat
Hi Mark, On Wed, Aug 7, 2013 at 3:40 PM, Mark Brown broo...@kernel.org wrote: On Wed, Aug 07, 2013 at 02:40:15PM +0530, Padmavathi Venna wrote: This patch registers the 16MHz oscillator clock as fixed clk. +/* 16.9MHz fixed oscillator clock */ +static void init_osc_clock(void) +{ +

Re: [PATCH V3 2/3] ASoC: Samsung: I2S: Add quirks as driver data in I2S

2013-08-07 Thread Padma Venkat
Hi Tomasz, On Wed, Aug 7, 2013 at 4:32 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Padmavathi, [Ccing DT maintainers with a little comment about contents of this patch for them: This is a rework of Samsung i2s bindings to make them more reasonable than they are at the moment. I know this

Re: [PATCH V2 7/8] ARM: dts: wm8994: Add wm8994 support on smdk5420

2013-08-02 Thread Padma Venkat
Hi Mark, On Tue, Jul 30, 2013 at 8:58 AM, Padma Venkat padma@gmail.com wrote: Hi Mark, On Mon, Jul 29, 2013 at 7:13 PM, Mark Brown broo...@kernel.org wrote: On Mon, Jul 29, 2013 at 05:31:16PM +0530, Padma Venkat wrote: On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat padma@gmail.com

Re: [PATCH V2 7/8] ARM: dts: wm8994: Add wm8994 support on smdk5420

2013-07-29 Thread Padma Venkat
Hi Mark, On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat padma@gmail.com wrote: Hi Mark, On Fri, Jul 26, 2013 at 8:49 PM, Mark Brown broo...@kernel.org wrote: On Fri, Jul 26, 2013 at 07:06:51PM +0530, Padmavathi Venna wrote: This patch adds wm8994 codec node on i2c bus1 and the required

Re: [PATCH V2 7/8] ARM: dts: wm8994: Add wm8994 support on smdk5420

2013-07-29 Thread Padma Venkat
Hi Mark, On Mon, Jul 29, 2013 at 7:13 PM, Mark Brown broo...@kernel.org wrote: On Mon, Jul 29, 2013 at 05:31:16PM +0530, Padma Venkat wrote: On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat padma@gmail.com wrote: + vdd: fixed-regulator@0 { + compatible = regulator-fixed

Re: [PATCH V2 0/8] Add audio support on smdk5420

2013-07-26 Thread Padma Venkat
On Fri, Jul 26, 2013 at 7:52 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Padmavathi, On Friday 26 of July 2013 19:06:44 Padmavathi Venna wrote: Samsung has different versions of I2S introduced in different platforms. Each version has some new support added for multichannel, secondary fifo,

Re: [PATCH V2 1/8] platform: Increase platform name size

2013-07-26 Thread Padma Venkat
Hi Sachin, On Fri, Jul 26, 2013 at 8:06 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Padma, On 26 July 2013 19:06, Padmavathi Venna padm...@samsung.com wrote: This patch increases the platform name size from 20 to 30. Instead of describing what the patch does (which is quite obvious

Re: [PATCH V2 7/8] ARM: dts: wm8994: Add wm8994 support on smdk5420

2013-07-26 Thread Padma Venkat
Hi Mark, On Fri, Jul 26, 2013 at 8:49 PM, Mark Brown broo...@kernel.org wrote: On Fri, Jul 26, 2013 at 07:06:51PM +0530, Padmavathi Venna wrote: This patch adds wm8994 codec node on i2c bus1 and the required regulator supplies and properties on smdk5420 board. This isn't a device tree patch

Re: [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree

2013-07-23 Thread Padma Venkat
Hi Tomasz, On Tue, Jul 23, 2013 at 1:12 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Monday 22 of July 2013 11:15:30 Mike Turquette wrote: Quoting Tomasz Figa (2013-07-22 09:28:47) Hi Padmavathi, Andrew, On Wednesday 10 of July 2013 17:41:51 Padmavathi Venna wrote: From: Andrew

Re: [PATCH] ASoC: Samsung: Modify the I2S driver to support I2S on Exynos5420

2013-07-22 Thread Padma Venkat
Hi Mark, On Fri, Jul 12, 2013 at 2:19 PM, Mark Brown broo...@kernel.org wrote: On Fri, Jul 12, 2013 at 10:07:22AM +0530, Padma Venkat wrote: A new version number is added when a there was some change in the IP like adding a internal mux to the IP, adding multi channel support, adding reset

Re: [PATCH] ASoC: Samsung: Modify the I2S driver to support I2S on Exynos5420

2013-07-11 Thread Padma Venkat
On Thu, Jul 11, 2013 at 4:37 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 11 of July 2013 11:48:04 Mark Brown wrote: On Thu, Jul 11, 2013 at 12:38:24PM +0530, Padmavathi Venna wrote: -#define MOD_LR_LLOW(0 7) -#define MOD_LR_RLOW(1 7) -#define

Re: [PATCH] ASoC: Samsung: Modify the I2S driver to support I2S on Exynos5420

2013-07-11 Thread Padma Venkat
Hi, On Thu, Jul 11, 2013 at 6:31 PM, Mark Brown broo...@kernel.org wrote: On Thu, Jul 11, 2013 at 01:41:40PM +0200, Tomasz Figa wrote: On Thursday 11 of July 2013 12:20:23 Mark Brown wrote: This is a bit of a larger project sadly, there was resistance to doing the DT bindings based on

Re: [PATCH] ASoC: Samsung: Set RFS and BFS in slave mode

2013-07-11 Thread Padma Venkat
Hi, On Thu, Jul 11, 2013 at 4:41 PM, Mark Brown broo...@kernel.org wrote: On Thu, Jul 11, 2013 at 12:38:25PM +0530, Padmavathi Venna wrote: As per the User Manual, the RFS and BFS should be set in slave mode for correct operation. Applied, thanks. Since this is a fix it should have been the

Re: [PATCH V6 6/6] clk: exynos5250: Add enum entries for divider clock of i2s1 and i2s2

2013-06-16 Thread Padma Venkat
Hi Mike, On Thu, Jun 13, 2013 at 8:32 AM, Padma Venkat padma@gmail.com wrote: Hi Mike, On Wed, Jun 12, 2013 at 10:15 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Padmavathi Venna (2013-06-12 01:07:43) This patch adds enum entries for div_i2s1 and div_i2s2 which are required

Re: [PATCH V6 6/6] clk: exynos5250: Add enum entries for divider clock of i2s1 and i2s2

2013-06-12 Thread Padma Venkat
Hi Mike, On Wed, Jun 12, 2013 at 10:15 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Padmavathi Venna (2013-06-12 01:07:43) This patch adds enum entries for div_i2s1 and div_i2s2 which are required for i2s1 and i2s2 controllers. Signed-off-by: Padmavathi Venna padm...@samsung.com

Re: [PATCH V5 2/5] clk: samsung: register audio subsystem clocks using common clock framework

2013-06-11 Thread Padma Venkat
Hi Mike, On Wed, Jun 12, 2013 at 3:43 AM, Mike Turquette mturque...@linaro.org wrote: Quoting Padmavathi Venna (2013-06-04 05:28:07) Audio subsystem is introduced in s5pv210 and exynos platforms. This has seperate clock controller which can control i2s0 and pcm0 clocks. This patch registers

Re: [PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250

2013-06-05 Thread Padma Venkat
Hi Doug, On Tue, Jun 4, 2013 at 10:49 PM, Doug Anderson diand...@chromium.org wrote: Padmavathi, On Tue, Jun 4, 2013 at 5:28 AM, Padmavathi Venna padm...@samsung.com wrote: @@ -471,6 +477,8 @@ dmas = pdma1 12 pdma1 11; dma-names = tx,

Re: [PATCH V4 3/4] ARM: dts: add Exynos audio subsystem clock controller node

2013-06-03 Thread Padma Venkat
Hi Doug, On Tue, Jun 4, 2013 at 1:43 AM, Doug Anderson diand...@chromium.org wrote: Padmavathi, On Sun, Jun 2, 2013 at 10:19 PM, Padmavathi Venna padm...@samsung.com wrote: Audio subsystem introduced in s5pv210 and exynos platforms which has a internal clock controller. This patch adds a

Re: [PATCH V4 4/4] ARM: dts: add clock provider information for i2s controllers in Exynos5250

2013-06-03 Thread Padma Venkat
Hi Doug, On Tue, Jun 4, 2013 at 1:48 AM, Doug Anderson diand...@chromium.org wrote: Padmavathi, On Sun, Jun 2, 2013 at 10:19 PM, Padmavathi Venna padm...@samsung.com wrote: + clocks = clock_audss EXYNOS_I2S_BUS, + clock_audss EXYNOS_I2S_BUS, +

Re: [PATCH V3 0/4] clk: Samsung: audss: Register audio subsytem clocks using common clk framework

2013-06-01 Thread Padma Venkat
Hi Sylwester, On Sat, Jun 1, 2013 at 1:59 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Padmavathi, On 05/28/2013 12:02 PM, Padmavathi Venna wrote: Samsung S5PV210 and Exynos SoC has a separate subsystem for audio. This subsystem has a internal clock controller which controls

Re: [PATCH V2 1/3] clk: samsung: register audio subsystem clocks using common clock framework

2013-05-11 Thread Padma Venkat
Hi Tomasz, On Fri, May 10, 2013 at 5:51 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Padmavathi, I managed to review the patch a bit more thoroughly and I had few more comments. You can find them inline. Thanks for the review. On Tuesday 07 of May 2013 12:13:34 Padmavathi Venna wrote:

Re: [PATCH] ASoC: Samsung: i2s: Fix crash in i2s driver

2013-05-07 Thread Padma Venkat
Hi Tomasz, On Tue, May 7, 2013 at 3:20 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Padmavathi, On Tuesday 07 of May 2013 09:09:01 Padmavathi Venna wrote: This patch fixes a null pointer deference in i2s driver in DT case Signed-off-by: Padmavathi Venna padm...@samsung.com --- This

Re: [PATCH V2 2/3] ARM: dts: add Exynos audio subsystem clock controller node

2013-05-07 Thread Padma Venkat
Hi Tomasz, On Tue, May 7, 2013 at 3:24 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Padmavathi, On Tuesday 07 of May 2013 12:13:35 Padmavathi Venna wrote: Audio subsystem introduced in s5pv210 and exynos platforms which has a internal clock controller. This patch adds a node for the same on

Re: [PATCH] ARM: dts: Correct the base address of pinctrl_3

2013-05-06 Thread Padma Venkat
Hi, On Tue, May 7, 2013 at 10:28 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Hi, On Tue, May 07, 2013 at 09:07:33AM +0530, Padmavathi Venna wrote: This patch corrects the base address of pinctrl_3 on Exynos5250 platform. Exynos5250 should be part of the subject so that other people can

Re: [PATCH 1/3] clk: exynos: register audio subsystem clocks using common clock framework

2013-04-06 Thread Padma Venkat
Hi Sylwester, On Fri, Apr 5, 2013 at 7:23 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/05/2013 08:23 AM, Padmavathi Venna wrote: Audio subsystem is introduced in exynos platforms. This has seperate clock controller which can control i2s0 and pcm0 clocks. This patch registers the

Re: [PATCH 0/3] clk: Exynos: Register audio subsytem clocks using common clk framework

2013-04-06 Thread Padma Venkat
Hi Sylwester, On Fri, Apr 5, 2013 at 6:24 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Padmavathi, On 04/05/2013 08:40 AM, Padmavathi Venna wrote: Samsung Exynos SoC has a separate subsystem for audio. This subsystem has a internal clock controller which controls i2s0 and pcm0

Re: [PATCH V2] DMA: PL330: Add check if device tree compatible

2013-04-01 Thread Padma Venkat
Hi Vinod, I apologies for the delayed reply. Last week I was out of station and no access to mails. I will send another patch addressing your comments. Thanks Padma On Mon, Apr 1, 2013 at 11:51 PM, Vinod Koul vinod.k...@intel.com wrote: On Mon, Apr 01, 2013 at 08:13:31AM -0500, Rob Herring

Re: exynos4210 not booting

2013-03-16 Thread Padma Venkat
Hi, On Fri, Mar 15, 2013 at 10:01 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: Using the exynos4_defconfig and compiling the kernel from the samsung git tree at 3.9-rc1, I am stuck. Does anyone have any idea ? Thanks ! -- Daniel

Re: [PATCH V2] DMA: PL330: Add check if device tree compatible

2013-03-12 Thread Padma Venkat
Hi, On Tue, Mar 5, 2013 at 2:55 PM, Padmavathi Venna padm...@samsung.com wrote: This patch register the dma controller with generic dma helpers only in DT case. This also adds some extra error handling in the driver. Signed-off-by: Padmavathi Venna padm...@samsung.com Reported-by: Sachin

Re: [PATCH 18/23] ASoC: samsung: convert to dmaengine API

2013-03-06 Thread Padma Venkat
Hi Arnd, On Tue, Mar 5, 2013 at 11:12 PM, Arnd Bergmann a...@arndb.de wrote: In order to build the exynos kernel with CONFIG_ARCH_MULTIPLATFORM, we must convert all users of the Samsung private DMA interface to the generic dmaengine API. This converts the sound/soc drivers, breaking the older

Re: [PATCH 15/23] spi: s3c64xx: move to generic dmaengine API

2013-03-06 Thread Padma Venkat
Hi Arnd, On Tue, Mar 5, 2013 at 11:12 PM, Arnd Bergmann a...@arndb.de wrote: The spi-s3c64xx uses a Samsung proprietary interface for talking to the DMA engine, which does not work with multiplatform kernels. Since the driver can also operate in PIO mode without any DMA, older platforms that

Re: [PATCH] dma: of-dma: return error when 'dma-cells' not found

2013-03-05 Thread Padma Venkat
On Tue, Mar 5, 2013 at 3:13 PM, Rob Herring robherri...@gmail.com wrote: On 03/05/2013 03:25 AM, Padmavathi Venna wrote: This patch returns error when 'dma-cells' property not found in the corresponding device node. With out this change there is a crash in the generic dma incompatible

Re: [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings

2013-03-05 Thread Padma Venkat
On Tue, Mar 5, 2013 at 3:36 PM, Sachin Kamat sachin.ka...@linaro.org wrote: On 5 March 2013 15:34, Padmavathi Venna padm...@samsung.com wrote: This patch removes custom way of adding spi dma channels and adds according to new generic DMA DT bindings on samsung exynos4 and exynos5440 platforms.

Re: [PATCH 1/2] ARM: exynos: pl330: Add #dma-cells for generic dma binding support

2013-03-05 Thread Padma Venkat
On Wed, Mar 6, 2013 at 4:07 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 04 March 2013, Padmavathi Venna wrote: This patch adds #dma-cells property to PL330 DMA controller nodes for supporting generic dma dt bindings on samsung exynos platforms. #dma-channels and #dma-requests are not

Re: [PATCH] DMA: PL330: Add check if device tree compatible

2013-03-04 Thread Padma Venkat
Hi Arnd, On Mon, Mar 4, 2013 at 6:28 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 04 March 2013, Padmavathi Venna wrote: + + if (adev-dev.of_node) { + ret = of_dma_controller_register(adev-dev.of_node, +of_dma_pl330_xlate,

Re: Boot failure on Origen board using latest kernel

2013-03-01 Thread Padma Venkat
Hi, On Sat, Mar 2, 2013 at 10:26 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Alim, On 2 March 2013 10:18, Alim Akhtar alim.akh...@gmail.com wrote: Hi Sachin, Looks like exynos4 is not yet moved to the generic dma binding recently merged. Could you try out below: I forgot to

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-16 Thread Padma Venkat
Hi, On Fri, Feb 15, 2013 at 5:31 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Feb 14, 2013 at 09:33:00PM +0100, Sylwester Nawrocki wrote: My apologies for the late review. It's already sixth version of this patch series... But I noticed it just now when applying it for

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-13 Thread Padma Venkat
Hi Vinod, On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote: Hi Vinod, On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul vinod.k...@intel.com wrote: On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-12 Thread Padma Venkat
Hi Vinod, On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul vinod.k...@intel.com wrote: On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote: This looks fine, I have only question. The code seems to assume that pl330 dma controller always uses DT. But I dont see that as dependency for

Re: [PATCH V3 4/5] ARM: dts: Add #dma-cells for generic dma binding support

2013-02-07 Thread Padma Venkat
Hi Rob, On Wed, Feb 6, 2013 at 8:54 PM, Rob Herring robherri...@gmail.com wrote: On 02/06/2013 12:18 AM, Padmavathi Venna wrote: This patch adds #dma-cells property to PL330 DMA controller nodes for supporting generic dma dt bindings on samsung exynos5250 platform. The subject doesn't

Re: [RESEND][PATCH] ARM: EXYNOS: Add clocks for EXYNOS I2S and PCM I/F

2013-02-07 Thread Padma Venkat
On Wed, Feb 6, 2013 at 10:51 AM, Sangsu Park sangsu4u.p...@samsung.com wrote: Audio Subsystem has own clocks for I2S0 and PCM0 in all EXYNOS series. This patch add clocks for I2S0 and PCM0 I/F. Signed-off-by: Sangsu Park sangsu4u.p...@samsung.com --- arch/arm/mach-exynos/Makefile |

Re: [PATCH] ARM: SAMSUNG: dma: Remove unnecessary code

2013-02-05 Thread Padma Venkat
Hi Arnd, On Mon, Feb 4, 2013 at 11:13 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 04 February 2013, Padmavathi Venna wrote: diff --git a/arch/arm/plat-samsung/dma-ops.c b/arch/arm/plat-samsung/dma-ops.c index 71d58dd..ec0d731 100644 --- a/arch/arm/plat-samsung/dma-ops.c +++

Re: [PATCH V2 4/4] DMA: PL330: Modify pl330 filter based on new generic dma dt bindings.

2013-02-03 Thread Padma Venkat
On Sat, Feb 2, 2013 at 8:39 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 02 February 2013 08:00:54 Padma Venkat wrote: The result of this looks good, but I fear that changing the filter function like this wil break all drivers that currently use the plat-samsung/dma-ops.c code

Re: [PATCH V2 4/4] DMA: PL330: Modify pl330 filter based on new generic dma dt bindings.

2013-02-01 Thread Padma Venkat
Hi Arnd, On Fri, Feb 1, 2013 at 8:53 PM, Arnd Bergmann a...@arndb.de wrote: On Friday 01 February 2013, Padmavathi Venna wrote: This patch modify the filter function to filter the required channel based on new filter params. Signed-off-by: Padmavathi Venna padm...@samsung.com The result of

Re: [PATCH V6 10/10] dmaengine: Fix compilation error in non-DT case

2013-01-29 Thread Padma Venkat
Hi, On Mon, Jan 28, 2013 at 7:17 PM, Vinod Koul vinod.k...@intel.com wrote: On Fri, Jan 18, 2013 at 05:17:09PM +0530, Padmavathi Venna wrote: Signed-off-by: Padmavathi Venna padm...@samsung.com --- include/linux/dmaengine.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH 3/4] ARM: dts: Add #dma-cells for generic dma binding support

2013-01-29 Thread Padma Venkat
Hi, On Mon, Jan 28, 2013 at 8:17 PM, Arnd Bergmann a...@arndb.de wrote: On Friday 18 January 2013, Padmavathi Venna wrote: diff --git a/Documentation/devicetree/bindings/dma/arm-pl330.txt b/Documentation/devicetree/bindings/dma/arm-pl330.txt index 36e27d5..457a233 100644 ---

Re: [PATCH V6 03/10] ARM: SAMSUNG: Make dma request compatible to generic dma bindings.

2013-01-29 Thread Padma Venkat
On Tue, Jan 29, 2013 at 11:50 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Jan 18, 2013 at 05:17:02PM +0530, Padmavathi Venna wrote: This patch make the dma dev request operation compatible for both DT and non-DT cases. It takes the all the arguments required for

Re: [PATCH V6 04/10] spi: s3c64xx: Modify SPI driver to use generic DMA DT support

2013-01-29 Thread Padma Venkat
On Tue, Jan 29, 2013 at 10:49 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Jan 18, 2013 at 05:17:03PM +0530, Padmavathi Venna wrote: This patch modifies the SPI driver to use generic dma dt bindings support. This passes all the required arguments to dma dev request functon

Re: [PATCH V6 07/10] ASoC: SMDK: WM8994: Add device tree support for machine file

2013-01-29 Thread Padma Venkat
On Tue, Jan 29, 2013 at 12:42 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Jan 18, 2013 at 05:17:06PM +0530, Padmavathi Venna wrote: +Samsung SMDK audio complex This is just for SMDKs with WM8994. I'll apply but please send a followup patch to clarify this - it'll be a

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-26 Thread Padma Venkat
Hi, On Mon, Dec 24, 2012 at 9:33 AM, Padma Venkat padma@gmail.com wrote: Hi, On Sat, Dec 22, 2012 at 12:32 AM, Kukjin Kim kgene@samsung.com wrote: Padma Venkat wrote: Hi, On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-23 Thread Padma Venkat
Hi, On Sat, Dec 22, 2012 at 12:32 AM, Kukjin Kim kgene@samsung.com wrote: Padma Venkat wrote: Hi, On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: On Thu, 13 Dec 2012 16:12:53 +0530

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-21 Thread Padma Venkat
Hi, On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padm...@samsung.com wrote: +- compatible : samsung,samsung-i2s Isn't that kind of

Re: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c

2012-12-16 Thread Padma Venkat
Hi, On Mon, Dec 17, 2012 at 6:12 AM, Olof Johansson o...@lixom.net wrote: On Fri, Dec 14, 2012 at 12:15 AM, Jonghwan Choi jhbird.c...@samsung.com wrote: arch/arm/mach-exynos/dev-audio.c:58:4: error: unknown field 'src_clk' specified in initializer arch/arm/mach-exynos/dev-audio.c:58:4:

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-10 Thread Padma Venkat
Hi Mark, On Sun, Dec 9, 2012 at 12:56 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sat, Dec 08, 2012 at 10:07:54AM +0530, Padma Venkat wrote: Samsung i2s driver registers the platform device twice one for the samsung-i2s.0,1 or 2 and two for samsung-i2s.4(which actually

Re: [PATCH V2 1/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-07 Thread Padma Venkat
Hi Mark, On Fri, Dec 7, 2012 at 12:16 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Dec 06, 2012 at 09:20:36AM +0530, Padmavathi Venna wrote: Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well,

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-07 Thread Padma Venkat
Hi, On Fri, Dec 7, 2012 at 7:21 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 6 Dec 2012 13:11:42 +0900, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Dec 06, 2012 at 09:31:40AM +0530, Padma Venkat wrote: On Wed, Nov 28, 2012 at 4:17 PM, Padmavathi Venna padm

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-05 Thread Padma Venkat
Hi Mark, On Wed, Nov 28, 2012 at 4:17 PM, Padmavathi Venna padm...@samsung.com wrote: V4 patches are based on Mark Brown's for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git Changes since V3: - Added syntex of gpio specifier as suggested by Mark Brown

Re: [GIT PULL] ASoC: Samsung: Updates for v3.8

2012-11-27 Thread Padma Venkat
Hi Mark, On Wed, Nov 28, 2012 at 10:55 AM, Sangbeom Kim sbki...@samsung.com wrote: There's some problems with this binding. The main one is the gpios property the format of which isn't specified at all. All of above gpio property is i2s. That is, + gpios = gpz 0 2 0 0, - SCLK +

Re: [RFC PATCH] ASoC: Samsung: Register the audio platform device

2012-11-26 Thread Padma Venkat
Hi, On Wed, Nov 14, 2012 at 5:39 PM, Padmavathi Venna padm...@samsung.com wrote: Audio platform device is not a hardware peripherial. So this device can't be added in the dt devices list. So expanded the module_platform_driver and registered this device using platform_device_register_simple.

Re: [PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-11-26 Thread Padma Venkat
On Tue, Nov 27, 2012 at 12:13 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 27, 2012 at 09:33:43AM +0900, Kukjin Kim wrote: I checked Samsung audio driver stuff just now. If you don't mind, I will drop the patch 48a2050d (ARM: SAMSUNG: Delete the unnecessary variable)

Re: [PATCH V3 0/5] Avoid passing clks through platform data

2012-11-23 Thread Padma Venkat
cc'ing Mark Brown. On Tue, Nov 6, 2012 at 10:18 AM, Padmavathi Venna padm...@samsung.com wrote: Changes since v2: - Rebased on 3.7-rc3 I2S controller has an internal mux for RCLK source clks. The list of source clk names were passed through platform data in non-dt case. The variable

Re: [PATCH V3] ASoC: SAMSUNG: Add DT support for i2s

2012-11-23 Thread Padma Venkat
cc'ing Mark Brown. On Tue, Nov 6, 2012 at 10:11 AM, Padmavathi Venna padm...@samsung.com wrote: Add support for device based discovery. Signed-off-by: Padmavathi Venna padm...@samsung.com --- Changes since V2: - Rebased on 3.7-rc3 - Custom DT bindings are prefixed with

Re: [PATCH V3 1/2] ARM: dts: Add nodes for i2s controllers for Samsung Exynos5 platforms

2012-11-23 Thread Padma Venkat
cc'ing Mark Brown. On Tue, Nov 6, 2012 at 10:14 AM, Padmavathi Venna padm...@samsung.com wrote: Add device nodes for the three instances of i2s controllers in Exynos5 platforms. Enable instance i2s 0 for exynos5250 board and disable all other i2s instances. Signed-off-by: Padmavathi Venna

  1   2   >