Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-27 Thread Sakari Ailus
Hi Mauro, On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 10 Sep 2015 20:14:04 +0300 > Sakari Ailus <sakari.ai...@linux.intel.com> escreveu: > > > Hi Javier, > > > > Thanks for the set! A few comments below. > &

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-12 Thread Sakari Ailus
Hi Mauro, On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 12 Oct 2015 00:07:52 +0300 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro, > > > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote:

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-11 Thread Sakari Ailus
V) > + if (!pad || !is_media_entity_v4l2_subdev(pad->entity)) > break; > > entity = pad->entity; > diff --git a/drivers/staging/media/omap4iss/iss_video.c > b/drivers/staging/media/omap4iss/iss_video.c > index 45a3f2d778fc

Re: [PATCH v4 2/2] [media] media-device: split media initialization and registration

2015-09-15 Thread Sakari Ailus
for dev being NULL instead. > > Also, add a media_device_cleanup() function that will destroy the > graph_mutex that is initialized in media_device_init(). > > Suggested-by: Sakari Ailus <sakari.ai...@linux.intel.com> > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Th

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-11 Thread Sakari Ailus
Hi Mauro, Mauro Carvalho Chehab wrote: > Em Fri, 11 Sep 2015 09:31:36 +0200 > Javier Martinez Canillas <jav...@osg.samsung.com> escreveu: > >> Hello Sakari, >> >> On 09/11/2015 07:51 AM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Javier

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
plicitly > by the driver or asynchronously using v4l2_async_register_subdev(). > > Also, add a media_entity_cleanup() function that will destroy the > graph_mutex that is initialized in media_entity_init(). > > Suggested-by: Sakari Ailus <sakari.ai...@linux.intel.com>

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
Javier Martinez Canillas wrote: > Also, add a media_entity_cleanup() function that will destroy the > graph_mutex that is initialized in media_entity_init(). media_device_init() and media_device_cleanup()? -- Sakari Ailus sakari.ai...@linux.intel.com -- To unsubscribe from this list

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
Hi Javier, Javier Martinez Canillas wrote: Hello Sakari, On 09/10/2015 07:14 PM, Sakari Ailus wrote: Hi Javier, Thanks for the set! A few comments below. Thanks to you for your feedback. Javier Martinez Canillas wrote: The media device node is registered and so made visible to user

Re: [PATCH RFC v3 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-14 Thread Sakari Ailus
*source, u16 source_pad, How about putting this in front of the set? It has no dependencies to the other patches, does it? Acked-by: Sakari Ailus sakari.ai...@linux.intel.com -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

2013-11-06 Thread Sakari Ailus
the firmware interface. if I understood things correctly. I guess it wouldn't hurt to use uint32_t there instead of u32 (and __u32). entirely up to you. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line

Re: [PATCH v11 02/12] [media] exynos5-fimc-is: Add driver core files

2013-11-05 Thread Sakari Ailus
+ */ +struct fimc_is_fmt { + char*name; + unsigned intfourcc; + unsigned intdepth[FIMC_IS_MAX_PLANES]; + unsigned intnum_planes; +}; + +#endif -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH v11 03/12] [media] exynos5-fimc-is: Add common driver header files

2013-11-05 Thread Sakari Ailus
buffer_number; + /* 0: continuous, 1: single */ + u32 run_mode; + u32 reserved[PARAMETER_MAX_MEMBER - 6]; + u32 err; +}; ... -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-08-19 Thread Sakari Ailus
needed. Kind regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo