Re: [PATCH 1/3] clk: samsung: exynos4: Add SSS gate clock

2015-10-19 Thread Stephen Boyd
given that it's part of a series that has dts changes I guess that means it should go through arm-soc: Acked-by: Stephen Boyd <sb...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list:

Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks

2015-10-16 Thread Stephen Boyd
k to their original parents > > > when the domain is powered on again. > > > > > > We expose these two clocks in the DT bindings so that the DT node of the > > > power domain can reference them. > > > > > > Signed-off-by: Tomeu Vizos

Re: [PATCH v1 1/2] clk: samsung: exynos5250: Add DISP1 clocks

2015-10-14 Thread Stephen Boyd
hat the DT node of the > power domain can reference them. > > Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> > --- Acked-by: Stephen Boyd <sb...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [GIT PULL] clk/samsung updates for v4.4

2015-10-02 Thread Stephen Boyd
samsung-4.4 > > for you to fetch changes up to 7993b3ebec979b23c2d7425959c9d232c452498b: > > clk: samsung: exynos7: Add required clock tree for UFS (2015-09-15 11:18:15 > +0200) > Thanks, pulled. I put this patch on top though. -8<- From: Stephen Boyd <sb...@codeau

Re: [PATCH v2] clk: samsung: fix cpu clock's flags checking

2015-09-22 Thread Stephen Boyd
On 08/28, Bartlomiej Zolnierkiewicz wrote: > CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were > incorrectly used as a bit numbers. Fix it. > > Tested on Exynos4210 based Origen board and on Exynos5250 based > Arndale board. > > Cc: Tomasz Figa > Cc: Michael

Re: [PATCH v2] cpufreq-dt: add suspend frequency support

2015-09-02 Thread Stephen Boyd
On 09/02/2015 09:47 AM, Bartlomiej Zolnierkiewicz wrote: > Add suspend frequency support and set it to the boot frequency, > this matches what the old exynos-cpufreq driver has been doing. > > This patch fixes suspend/resume support on Exynos4412 based > Trats2 board and reboot hang on Exynos4412

[PATCH 2/2] clk: Convert __clk_get_name(hw-clk) to clk_hw_get_name(hw)

2015-08-12 Thread Stephen Boyd
geert+rene...@glider.be Cc: Ulrich Hecht ulrich.hecht+rene...@gmail.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-rockc...@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-te...@vger.kernel.org Cc: linux-o...@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

2015-07-28 Thread Stephen Boyd
On 07/26, Sylwester Nawrocki wrote: On 07/22/2015 08:41 AM, Krzysztof Kozlowski wrote: On 22.07.2015 07:42, Stephen Boyd wrote: On 06/12, Krzysztof Kozlowski wrote: [...] Signed-off-by: Krzysztof Kozlowskik.kozlow...@samsung.com Cc:sta...@vger.kernel.org Fixes: c63c57433003 (ARM: dts: Add

Re: [PATCH] clk: s2mps11: Use kcalloc instead of kzalloc for array allocation

2015-07-24 Thread Stephen Boyd
On 07/22, Vaibhav Hiremath wrote: This patch cleans up the driver for, - Use devm_kcalloc varient instead of devm_kzalloc for array allocation. - clk_prepare/unprepare, remove ret variable as it is not required - use __exit for cleanup function As I am referring this driver as

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

2015-07-21 Thread Stephen Boyd
On 06/12, Krzysztof Kozlowski wrote: The TSADC gate clock was used in Exynos4x12 DTSI for exynos-adc driver. However TSADC is present only on Exynos4210 so on Trats2 board (with Exynos4412 SoC) the exynos-adc driver could not be probed: ERROR: could not get clock /adc@126C:adc(0)

Re: [PATCH v5 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock

2015-07-01 Thread Stephen Boyd
Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- Looks ok. Acked-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line

Re: [question] [PATCH RFC] clocksource: exynos_mct: remove unneeded container_of()

2015-06-15 Thread Stephen Boyd
--- Acked-by: Stephen Boyd sb...@codeaurora.org It was done this way to minimize the diff. I don't see any problem changing it as you propose. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line

Re: [PATCH] clk: make several parent names const

2015-06-04 Thread Stephen Boyd
On 05/28, Uwe Kleine-König wrote: Since commit 2893c379461a (clk: make strings in parent name arrays const) the name of parent clocks can be const. So add more const in several clock drivers. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Applied to clk-next --

Re: [PATCH] clk:samsung:clk - Fix typo in panic log.

2015-05-21 Thread Stephen Boyd
On 05/21, Shailendra Verma wrote: Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 3/8] clk: tegra: Fix inconsistent indenting

2015-05-01 Thread Stephen Boyd
On 04/28, Krzysztof Kozlowski wrote: Fix the indentation - spaces used instead of tabs and actually wrong number of spaces. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/tegra/clk-emc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

Re: [PATCH 4/8] clk: tegra: Fix duplicate const for parent names

2015-04-09 Thread Stephen Boyd
On 04/09, Thierry Reding wrote: On Thu, Apr 09, 2015 at 12:07:59PM +0200, Krzysztof Kozlowski wrote: 2015-04-09 12:00 GMT+02:00 Thierry Reding thierry.red...@gmail.com: On Wed, Apr 08, 2015 at 03:22:15PM +0200, Krzysztof Kozlowski wrote: Replace duplicated const keyword for

Re: [PATCH 3/8] clk: Constify pointers to parent names in init data

2015-04-08 Thread Stephen Boyd
On 04/08/15 06:22, Krzysztof Kozlowski wrote: The 'parent_names' member of 'clk_init_data' is not modified so it can be made as an array of const pointers to constant strings. Some drivers (e.g. arch/mips/alchemy/common/clock.c) already pass such data. Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v2] clk: samsung: Add CLKOUT driver support for Exynos3250 SoC.

2015-03-11 Thread Stephen Boyd
-by: Inha Song ideal.s...@samsung.com Do you want to take this through some SoC tree? If so: Acked-by: Stephen Boyd sb...@codeaurora.org --- drivers/clk/samsung/clk-exynos-clkout.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk

Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency

2015-02-17 Thread Stephen Boyd
disabling the cache coherency so just use soc_is_exynos(). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Fixes: adc548d77c22 (ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420) Cc: sta...@vger.kernel.org Reported-by: Stephen Boyd sb...@codeaurora.org --- Looks good

Re: [PATCH v2 1/3] clk: Don't dereference parent clock if is NULL

2015-02-12 Thread Stephen Boyd
with no parent is a bug but the core should be robust to handle that case. Fixes: 035a61c314eb3 (clk: Make clk API return per-user struct clk instances) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation

Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

2015-02-12 Thread Stephen Boyd
Canillas javier.marti...@collabora.co.uk Reviewed-by: Stephen Boyd sb...@codeaurora.org Did you run this on all files that include clk-provider.h? I hope there aren't similar situations in arch/arm/ for example. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation

Re: [PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

2015-02-12 Thread Stephen Boyd
and this is going to s/clk_core/clk/? change again so to avoid having to change the assignments twice in all the drivers, add a helper function to have an indirection level. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Reviewed-by: Stephen Boyd sb...@codeaurora.org

Re: [PATCH 2/2] clk: composite: Set clk_core to composite rate and mux components

2015-02-11 Thread Stephen Boyd
On 02/11, Javier Martinez Canillas wrote: Commit 035a61c314eb3 (clk: Make clk API return per-user struct clk instances) moved the clock state to struct clk_core to allow the clk API returning per user clk instances so now the struct clk_hw .core field is used instead of .clk for most

Re: PROBLEM: BUG appearing when trying to allocate interrupt on Exynos MCT after CPU hotplug

2015-01-30 Thread Stephen Boyd
Kept meaning to get back to this thread. Have you resolved it? On 10/29/14 03:38, Marcin Jabrzyk wrote: So I've tried this patch, it resolves one problem but introduces also new ones. As expected the BUG warning is not showing after applying this patch but there are some interesting side

Re: [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure

2015-01-08 Thread Stephen Boyd
resources. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe linux

Re: PROBLEM: BUG appearing when trying to allocate interrupt on Exynos MCT after CPU hotplug

2014-10-27 Thread Stephen Boyd
On 10/24/2014 06:22 AM, Marcin Jabrzyk wrote: On 23/10/14 20:41, Stephen Boyd wrote: On 10/23/2014 07:06 AM, Russell King - ARM Linux wrote: The CPU notifier is called via notify_cpu_starting(), which is called with interrupts disabled, and a reason code of CPU_STARTING. Interrupts

Re: PROBLEM: BUG appearing when trying to allocate interrupt on Exynos MCT after CPU hotplug

2014-10-23 Thread Stephen Boyd
permissible. So, this code is wrong today, and it was also wrong when it was written. It /couldn't/ have been tested. It looks like this commit added this buggy code: commit ee98d27df6827b5ba4bd99cb7d5cb1239b6a1a31 Author: Stephen Boyd sb...@codeaurora.org Date: Fri Feb 15 16:40:51 2013 -0800

Re: [PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up

2014-01-22 Thread Stephen Boyd
On 01/11, Tomasz Figa wrote: + +/** + * of_genpd_lock() - Lock access to of_genpd_providers list + */ +static void of_genpd_lock(void) +{ + mutex_lock(of_genpd_mutex); +} + +/** + * of_genpd_unlock() - Unlock access to of_genpd_providers list + */ +static void

Re: [PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up

2014-01-22 Thread Stephen Boyd
On 01/20, Tomasz Figa wrote: Hi Kevin, On 14.01.2014 16:42, Kevin Hilman wrote: Tomasz Figa tomasz.f...@gmail.com writes: This patch introduces generic code to perform power domain look-up using device tree and automatically bind devices to their power domains. Generic device tree

Re: [PATCH] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online

2013-08-26 Thread Stephen Boyd
...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Looks good to me if you want to go this route. Acked-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from

Re: [PATCH] irqchip: gic: Allow setting affinity to offline CPUs

2013-08-20 Thread Stephen Boyd
On 08/20/13 09:11, Tomasz Figa wrote: Sometimes it is necessary to fix interrupt affinity to an offline CPU, for example in initialization of local timers. This patch modifies .set_affinity() operation of irq-gic driver to fall back to any possible CPU if no online CPU can be found in

Re: [PATCH] irqchip: gic: Allow setting affinity to offline CPUs

2013-08-20 Thread Stephen Boyd
On 08/20/13 09:41, Tomasz Figa wrote: On Tuesday 20 of August 2013 09:33:31 Stephen Boyd wrote: On 08/20/13 09:11, Tomasz Figa wrote: Sometimes it is necessary to fix interrupt affinity to an offline CPU, for example in initialization of local timers. This patch modifies .set_affinity

Re: [PATCH] irqchip: gic: Allow setting affinity to offline CPUs

2013-08-20 Thread Stephen Boyd
On 08/21, Tomasz Figa wrote: On Tuesday 20 of August 2013 22:14:42 Russell King - ARM Linux wrote: On Tue, Aug 20, 2013 at 06:11:10PM +0200, Tomasz Figa wrote: Sometimes it is necessary to fix interrupt affinity to an offline CPU, for example in initialization of local timers. This patch

Re: [PATCH] ARM: timer: Shutdown clock event device when stopping local timer

2013-03-29 Thread Stephen Boyd
On 03/29/13 02:24, ning.n.ji...@gmail.com wrote: From: Ning Jiang ning.n.ji...@gmail.com Currently there are two problems when we try to stop local timer. First, it calls set_mode function directly so mode state is not updated for the clock event device. Second, it makes the device unused

Re: [PATCH] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-08-28 Thread Stephen Boyd
On 8/28/2012 4:13 AM, Tomasz Figa wrote: diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 36c3984..1114ced 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -34,8 +34,19 @@ extern void exynos4_secondary_startup(void);

Re: [PATCH v3 1/2] i2c: s3c2410: Keep a copy of platform data and use it

2011-09-13 Thread Stephen Boyd
On 9/12/2011 9:16 PM, Thomas Abraham wrote: @@ -809,6 +810,15 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) return -ENOMEM; } + i2c-pdata = devm_kzalloc(pdev-dev, sizeof(*pdata), GFP_KERNEL); + if (!i2c-pdata) { + ret = -ENOMEM; +

Re: [PATCH] arm: platsmp: Allow secondary cpu hotplug with maxcpus=1

2011-06-30 Thread Stephen Boyd
On 6/30/2011 6:11 AM, Russell King - ARM Linux wrote: On Wed, Jun 29, 2011 at 11:31:39AM -0700, Stephen Boyd wrote: void __init platform_smp_prepare_cpus(unsigned int max_cpus) { -int i; - /* * Initialise the present map, which describes the set of CPUs * actually

[PATCH] arm: platsmp: Allow secondary cpu hotplug with maxcpus=1

2011-06-29 Thread Stephen Boyd
system with maxcpus=1 on the command line and then hotplug in secondary cpus via sysfs. This is more in line with how x86 works with maxcpus=1 on the command line. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- This patch was tested along with an MSM patch: https://lkml.org/lkml/2011/4/7

Re: [PATCH] TWD: enable one-shot mode

2011-01-14 Thread Stephen Boyd
On 01/11/2011 03:52 AM, Russell King - ARM Linux wrote: On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote: I see this patch was already tested and merged but can you elaborate on why this was done? From what I understand, NOHZ selects one-shot (like is done in this patch), so why

Re: [PATCH] TWD: enable one-shot mode

2011-01-10 Thread Stephen Boyd
On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote: Allow one shot timer mode to be used with the TWD. This allows NOHZ mode to be used on SMP systems using the TWD localtimer. Tested on Versatile Express. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- Acks/Tested-by's