[PATCH] drm/exynos: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding <tred...@nvidia.com> Replace the driver-specific implementations with the ones implemented in the core. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 42 +++-- 1 file changed, 8 inser

Re: [PATCH] pwm: Avoid double mutex lock on pwm_enable

2015-11-23 Thread Thierry Reding
On Sun, Nov 22, 2015 at 09:13:17AM +0900, Krzysztof Kozlowski wrote: > 2015-11-22 3:14 GMT+09:00 Anand Moon : > > Hi Krzysztof, > > > > On 21 November 2015 at 18:37, Krzysztof Kozlowski > > wrote: > >> 2015-11-21 21:11 GMT+09:00 Anand Moon

Re: [PATCH] drm/exynos: only run atomic_check() if crtc is active

2015-11-12 Thread Thierry Reding
On Thu, Nov 12, 2015 at 11:11:20AM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace > direct cross-driver call with drm mode). The whole atomic update > was failing if the hdmi display is

Re: [PATCH 2/6] ARM: s3c24xx: rx1950: Use PWM lookup table

2015-10-07 Thread Thierry Reding
On Wed, Oct 07, 2015 at 10:35:54AM +0900, Krzysztof Kozlowski wrote: > On 05.10.2015 21:47, Thierry Reding wrote: > > Use a PWM lookup table to provide the PWM to the pwm-backlight device. > > The driver has a legacy code path that is required only because boards > > still

Re: [PATCH 5/6] ARM: s3c64xx: hmt: Use PWM lookup table

2015-10-07 Thread Thierry Reding
On Wed, Oct 07, 2015 at 10:37:42AM +0900, Krzysztof Kozlowski wrote: > On 05.10.2015 21:47, Thierry Reding wrote: > > Use a PWM lookup table to provide the PWM to the pwm-backlight device. > > The driver has a legacy code path that is required only because boards > > still

Re: [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table

2015-10-06 Thread Thierry Reding
On Tue, Oct 06, 2015 at 09:28:50AM +0900, Krzysztof Kozlowski wrote: > On 05.10.2015 21:47, Thierry Reding wrote: > > Back when the PWM framework was introduced the concept of PWM lookup > > tables was added to allow board code to register a table of PWM devices > >

[PATCH 6/6] ARM: s3c64xx: smartq: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c64xx/mach-smartq.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm

[PATCH 5/6] ARM: s3c64xx: hmt: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c64xx/mach-hmt.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-hmt.c b/arch/arm/mach-

[PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table

2015-10-05 Thread Thierry Reding
to use the new PWM lookup tables. All patches have been compile-tested, but I don't have access to any of these boards, so I couldn't verify that they really work. Thierry Thierry Reding (6): ARM: s3c24xx: h1940: Use PWM lookup table ARM: s3c24xx: rx1950: Use PWM lookup table ARM: s3c64xx

[PATCH 1/6] ARM: s3c24xx: h1940: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c24xx/mach-h1940.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm

[PATCH 4/6] ARM: s3c64xx: crag6410: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c64xx/mach-crag6410.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm

[PATCH 3/6] ARM: s3c64xx: smdk6410: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c64xx/dev-backlight.c | 4 arch/arm/mach-s3c64xx/mach-smdk6410.c | 8 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --g

[PATCH 2/6] ARM: s3c24xx: rx1950: Use PWM lookup table

2015-10-05 Thread Thierry Reding
;kg...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Thierry Reding <thierry.red...@gmail.com> --- arch/arm/mach-s3c24xx/mach-rx1950.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-rx1950.c b/arch/arm

[PATCH 1/3] drm/exynos: Suspend/resume is unused if !PM

2015-09-24 Thread Thierry Reding
From: Thierry Reding <tred...@nvidia.com> Protect the suspend and resume callbacks with an #ifdef CONFIG_PM_SLEEP guard to avoid "defined but not used" warnings. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 ++ 1 file

[PATCH 2/3] drm/exynos: fimc: Clock control is unused if !PM

2015-09-24 Thread Thierry Reding
From: Thierry Reding <tred...@nvidia.com> Protect the fimc_clk_ctrl() function with an #ifdef CONFIG_PM guard to avoid "defined but not used" warnings. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 36 --

[PATCH 3/3] drm/exynos: rotator: Clock control is unused if !PM

2015-09-24 Thread Thierry Reding
From: Thierry Reding <tred...@nvidia.com> Protect the rotator_clk_crtl() function with an #ifdef CONFIG_PM guard to avoid "defined but not used" warnings. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +- 1 file chan

Re: [PATCH v4 0/16] Add Analogix Core Display Port Driver

2015-09-21 Thread Thierry Reding
On Mon, Sep 21, 2015 at 06:27:40PM +0800, Yakir Yang wrote: > Hi Thierry, > > Thanks for your suggest :) > > On 09/21/2015 05:15 PM, Thierry Reding wrote: > >On Mon, Sep 21, 2015 at 04:45:44PM +0800, Yakir Yang wrote: > >>Hi Heiko, > >> > >>On 09/0

Re: [PATCH v4 0/16] Add Analogix Core Display Port Driver

2015-09-21 Thread Thierry Reding
On Mon, Sep 21, 2015 at 04:45:44PM +0800, Yakir Yang wrote: > Hi Heiko, > > On 09/02/2015 10:15 AM, Yakir Yang wrote: > >Hi Heiko, > > > >在 09/02/2015 05:47 AM, Heiko Stuebner 写道: > >>Hi Yakir, > >> > >>Am Dienstag, 1. September 2015, 13:46:11 schrieb Yakir Yang: > >>>The Samsung Exynos eDP

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-07 Thread Thierry Reding
On Sun, Sep 06, 2015 at 11:59:08AM +0800, Yakir Yang wrote: > Hi Thierry, > > 在 09/03/2015 05:04 PM, Thierry Reding 写道: > >On Thu, Sep 03, 2015 at 12:27:47PM +0800, Yakir Yang wrote: > >>Hi Rob, > >> > >>在 09/03/2015 04:17 AM, Rob Herring 写道: > >

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-07 Thread Thierry Reding
On Fri, Sep 04, 2015 at 11:20:03AM +0100, Russell King - ARM Linux wrote: > On Thu, Sep 03, 2015 at 11:04:40AM +0200, Thierry Reding wrote: > > Conversely, if the panel isn't capable of generating an HPD signal, then > > I don't think it would be appropriate to make it a DT pro

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-07 Thread Thierry Reding
On Fri, Sep 04, 2015 at 11:29:30PM +0200, Heiko Stuebner wrote: > Am Freitag, 4. September 2015, 16:06:02 schrieb Rob Herring: > > On Tue, Sep 1, 2015 at 3:46 PM, Heiko Stuebner wrote: > > > Am Dienstag, 1. September 2015, 13:49:58 schrieb Yakir Yang: > > >> Split the dp core

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-04 Thread Thierry Reding
On Thu, Sep 03, 2015 at 04:55:59PM -0500, Rob Herring wrote: > On Thu, Sep 3, 2015 at 3:47 AM, Thierry Reding <tred...@nvidia.com> wrote: > > On Wed, Sep 02, 2015 at 03:17:57PM -0500, Rob Herring wrote: > > [...] > >> Are there any eDP panels which don't ha

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-03 Thread Thierry Reding
On Wed, Sep 02, 2015 at 06:02:25PM +0800, Yakir Yang wrote: > 在 2015/9/2 16:34, Thierry Reding 写道: [...] > >At the very least your code must compile when applied against a recent > >upstream tree. I would also expect you to make sure the code works at > >runtime, though, cont

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-03 Thread Thierry Reding
On Wed, Sep 02, 2015 at 03:17:57PM -0500, Rob Herring wrote: [...] > Are there any eDP panels which don't have EDID and need panel details in DT? Most panels need information other than EDID. They typically have some requirements regarding the power up sequence that aren't to be found anywhere in

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-03 Thread Thierry Reding
On Thu, Sep 03, 2015 at 12:27:47PM +0800, Yakir Yang wrote: > Hi Rob, > > 在 09/03/2015 04:17 AM, Rob Herring 写道: > >On Tue, Sep 1, 2015 at 1:14 AM, Yakir Yang wrote: > >>Some edp screen do not have hpd signal, so we can't just return > >>failed when hpd plug in detect

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-02 Thread Thierry Reding
On Wed, Sep 02, 2015 at 10:06:36AM +0800, Yakir Yang wrote: > 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: > >Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: [...] > >>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > >>b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 10:03:52PM +0800, Yakir Yang wrote: Hi Thierry, 在 2015/8/25 17:58, Thierry Reding 写道: On Wed, Aug 19, 2015 at 09:50:34AM -0500, Yakir Yang wrote: [...] + -analogix,color-space: + input video data format. + COLOR_RGB = 0, COLOR_YCBCR422

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 09:48:01PM +0800, Yakir Yang wrote: Hi Thierry Rob, 在 2015/8/25 21:27, Rob Herring 写道: On Tue, Aug 25, 2015 at 4:15 AM, Thierry Reding tred...@nvidia.com wrote: On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang y...@rock-chips.com wrote: +

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Wed, Aug 19, 2015 at 09:50:34AM -0500, Yakir Yang wrote: [...] + -analogix,color-space: + input video data format. + COLOR_RGB = 0, COLOR_YCBCR422 = 1, COLOR_YCBCR444 = 2 I don't think DT is an appropriate place to set this. To my knowledge this depends

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 10:29:39AM +0100, Russell King - ARM Linux wrote: On Tue, Aug 25, 2015 at 11:12:48AM +0200, Thierry Reding wrote: On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: It goes beyond bindings IMO. The use of the component framework or not has been

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 05:41:19PM +0800, Yakir Yang wrote: Hi Thierry, 在 2015/8/25 17:12, Thierry Reding 写道: On Mon, Aug 24, 2015 at 09:48:27AM -0500, Rob Herring wrote: On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Aug 23, 2015 at 06:23

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-25 Thread Thierry Reding
On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote: On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang y...@rock-chips.com wrote: [...] + -analogix,link-rate: + max link rate supported by the eDP controller. + LINK_RATE_1_62GBPS = 0x6,

Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver

2015-08-21 Thread Thierry Reding
On Fri, Aug 21, 2015 at 08:24:16PM +0900, Jingoo Han wrote: On 2015. 8. 21., at PM 7:01, Yakir Yang y...@rock-chips.com wrote: Hi Jingoo, 在 2015/8/21 16:20, Jingoo Han 写道: On 2015. 8. 19., at PM 11:48, Yakir Yang y...@rock-chips.com wrote: .

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Thierry Reding
tegra_wdt_probe(struct platform_device *pdev) wdd-ops = tegra_wdt_ops; wdd-min_timeout = MIN_WDT_TIMEOUT; wdd-max_timeout = MAX_WDT_TIMEOUT; + wdd-parent = pdev-dev; watchdog_set_drvdata(wdd, wdt); Acked-by: Thierry Reding tred...@nvidia.com signature.asc Description

Re: [PATCH 2/2] clk: Convert __clk_get_name(hw-clk) to clk_hw_get_name(hw)

2015-08-13 Thread Thierry Reding
) +clk_hw_get_name(E) [...] drivers/clk/tegra/clk-pll.c | 8 Acked-by: Thierry Reding tred...@nvidia.com signature.asc Description: PGP signature

Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Thierry Reding
On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: [...] edp: edp@ff97 { [...] hsync-active-high = 0; vsync-active-high = 0; interlaced = 0; These look like they should come from the display mode definition (EDID) rather

Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 08:59:44PM +0800, Yakir Yang wrote: Hi Thierry, 在 2015/8/10 18:00, Thierry Reding 写道: On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: [...] edp: edp@ff97 { [...] hsync-active-high = 0; vsync-active-high

[PATCH 2/4] drm/bridge: Add vendor prefixes

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Use vendor prefixes for Kconfig symbols and filenames. This should make it easier to identify the various bridge drivers and to organize the directory. While at it, rename dw_hdmi.[ch] to dw-hdmi.[ch] for consistency. Signed-off-by: Thierry Reding tred

[PATCH 1/4] ARM: exynos: Remove PTN3460 dependency

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Now that the PTN3460 driver has been rewritten as a proper I2C driver and there is infrastructure to hook up the bridge with a DRM device, it is no longer necessary to have this dependency to ensure the correct build mode. Signed-off-by: Thierry Reding

[PATCH 4/4] drm/bridge: Put Kconfig entries in a separate menu

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Put the Kconfig entries for bridge drivers into a separate menu so that they are automatically grouped and don't clutter up the top-level menu. While at it, move the bridge menu towards the end of the top-level menu where the panel menu is already located

[PATCH 3/4] drm/panel: Add Samsung prefix to panel drivers

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The likelihood of getting a large number of panel drivers from different vendors is quite high. Add a prefix to the two existing Samsung panel drivers to set a guideline for future patch submissions. Using vendor prefixes consistently should allow a cleaner

Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias

2015-05-21 Thread Thierry Reding
On Thu, May 14, 2015 at 02:32:31AM +0200, Javier Martinez Canillas wrote: If the pwm-samsung driver is built as a module, modalias information is not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE() macro to export the OF device ID so the module contains that information.

Re: [PATCH 4/8] clk: tegra: Fix duplicate const for parent names

2015-04-09 Thread Thierry Reding
On Thu, Apr 09, 2015 at 12:07:59PM +0200, Krzysztof Kozlowski wrote: 2015-04-09 12:00 GMT+02:00 Thierry Reding thierry.red...@gmail.com: On Wed, Apr 08, 2015 at 03:22:15PM +0200, Krzysztof Kozlowski wrote: Replace duplicated const keyword for 'emc_parent_clk_names' with proper array

Re: [PATCH 4/8] clk: tegra: Fix duplicate const for parent names

2015-04-09 Thread Thierry Reding
On Wed, Apr 08, 2015 at 03:22:15PM +0200, Krzysztof Kozlowski wrote: Replace duplicated const keyword for 'emc_parent_clk_names' with proper array of const pointers to const strings. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/tegra/clk-emc.c | 2 +- 1 file

Re: [PATCH 09/16] iommu/tegra-smmu: Make use of domain_alloc and domain_free

2015-03-27 Thread Thierry Reding
+++-- 1 file changed, 23 insertions(+), 18 deletions(-) Acked-by: Thierry Reding tred...@nvidia.com pgpIvQf6VeP3T.pgp Description: PGP signature

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-27 Thread Thierry Reding
deletions(-) The core and Tegra bits: Tested-by: Thierry Reding tred...@nvidia.com pgpld3hZekpiI.pgp Description: PGP signature

Re: [PATCH 10/16] iommu/tegra-gart: Make use of domain_alloc and domain_free

2015-03-27 Thread Thierry Reding
+++--- 1 file changed, 46 insertions(+), 21 deletions(-) Acked-by: Thierry Reding tred...@nvidia.com pgpqhT7suGaYx.pgp Description: PGP signature

Re: [PATCH 03/14] drm/bridge: make bridge registration independent of drm flow

2015-02-03 Thread Thierry Reding
On Fri, Jan 30, 2015 at 10:37:19AM -0500, Rob Clark wrote: On Tue, Jan 20, 2015 at 11:38 AM, Ajay Kumar ajaykumar...@samsung.com wrote: Currently, third party bridge drivers(ptn3460) are dependent on the corresponding encoder driver init, since bridge driver needs a drm_device pointer to

Re: [PATCH V9 12/14] drm/bridge: Add i2c based driver for ps8622/ps8625 bridge

2015-01-30 Thread Thierry Reding
On Thu, Jan 29, 2015 at 08:12:20PM +0530, Ajay kumar wrote: Hi Thierry, I think you forgot to take this patch! Can you check this? Yes, I missed it somehow. It didn't build for me after applying it now, but I fixed that up (and a few sparse warnings along with it). I'll send out another pull

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2015-01-19 Thread Thierry Reding
On Mon, Jan 19, 2015 at 11:27:52AM +0100, Javier Martinez Canillas wrote: Hello Thierry, On 01/05/2015 02:50 PM, Thierry Reding wrote: On Fri, Jan 02, 2015 at 01:10:14PM +, Daniel Stone wrote: Ajay's series don't apply cleanly anymore because it has been a while since he

Re: [Resend][PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver

2015-01-16 Thread Thierry Reding
On Tue, Jan 06, 2015 at 12:28:22AM +0900, Inki Dae wrote: [...] Original Message Subject: [PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver Date: Tue, 09 Dec 2014 18:29:05 +0900 From: Hyungwon Hwang human.hw...@samsung.com To: dri-de...@lists.freedesktop.org CC:

Re: [PATCH] i2c: exynos5: Move initialization code to subsys_initcall()

2015-01-16 Thread Thierry Reding
On Tue, Jan 13, 2015 at 02:13:51PM +0200, Tomi Valkeinen wrote: On 12/01/15 10:43, Joonyoung Shim wrote: +Cc Tomi Valkeinen, Hi Uwe, On 01/12/2015 04:50 PM, Uwe Kleine-König wrote: Hello, On Mon, Jan 12, 2015 at 11:53:02AM +0900, Joonyoung Shim wrote: This is required in order

Re: [PATCH v2 06/21] ARM: tegra: remove old LIC support

2015-01-08 Thread Thierry Reding
On Wed, Jan 07, 2015 at 05:42:41PM +, Marc Zyngier wrote: [...] diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c [...] void __init tegra_init_irq(void) { - int i; - void __iomem *distbase; - - if (of_find_matching_node(NULL, tegra_ictlr_match)) -

Re: [PATCH v2 01/21] ARM: tegra: irq: nuke leftovers from non-DT support

2015-01-08 Thread Thierry Reding
(-) Acked-by: Thierry Reding tred...@nvidia.com pgpwOEMBfpvYA.pgp Description: PGP signature

Re: [PATCH v2 02/21] irqchip: tegra: add DT-based support for legacy interrupt controller

2015-01-08 Thread Thierry Reding
On Wed, Jan 07, 2015 at 05:42:37PM +, Marc Zyngier wrote: Tegra's LIC (Legacy Interrupt Controller) has been so far only supported as a weird extension of the GIC, which is not exactly pretty. The stacked irq domain framework fits this pretty well, and allows Nit: s/irq/IRQ/ the LIC

Re: [PATCH v2 05/21] DT: tegra: add binding for the legacy interrupt controller

2015-01-08 Thread Thierry Reding
On Wed, Jan 07, 2015 at 05:42:40PM +, Marc Zyngier wrote: Signed-off-by: Marc Zyngier marc.zyng...@arm.com --- .../interrupt-controller/nvidia,tegra-ictlr.txt| 39 ++ 1 file changed, 39 insertions(+) create mode 100644

Re: [PATCH v2 04/21] ARM: tegra: update DTs to expose legacy interrupt controller

2015-01-08 Thread Thierry Reding
On Wed, Jan 07, 2015 at 05:42:39PM +, Marc Zyngier wrote: Describe the legacy interrupt controller in every tegra DTSI files, and make it the parent of most interrupts. Signed-off-by: Marc Zyngier marc.zyng...@arm.com --- arch/arm/boot/dts/tegra114.dtsi | 16 +++-

Re: [PATCH v2 2/3] drm/panel: add s6e63j0x03 LCD panel driver

2015-01-05 Thread Thierry Reding
On Wed, Dec 31, 2014 at 07:41:43PM +0900, Inki Dae wrote: Hi Thierry, Ping~. Or is it ok to pick up this patch to my tree, exynos-drm-next? It doesn't seem to care for a long time. I don't seem to have a copy of the v2 2/3 patch. All I found in my inbox is the v2 0/3 cover-letter. Please

Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2015-01-05 Thread Thierry Reding
On Fri, Jan 02, 2015 at 01:10:14PM +, Daniel Stone wrote: Hi Ajay, On 17 December 2014 at 09:31, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 12/16/2014 12:37 AM, Laurent Pinchart wrote: You asked Ajay to change his series to use the video port and enpoints

[PATCH 01/13] drm/irq: Remove negative CRTC index special-case

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The drm_send_vblank_event() function treats negative CRTC indices as meaning that a driver doesn't have proper VBLANK handling. This is the only place where DRM needs negative CRTC indices, so in order to enable subsequent cleanup, remove this special case

[PATCH 13/13] drm/irq: Move some prototypes to drm_crtc.h

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The new prototypes that deal with struct drm_crtc * directly are better located in include/drm/drm_crtc.h along with the other functions that deal with CRTCs. Signed-off-by: Thierry Reding tred...@nvidia.com --- include/drm/drmP.h | 17

[PATCH 04/13] drm/imx: Make pipe number unsigned

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com There's no reason whatsoever why this should ever be negative. Cc: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/gpu/drm/imx/imx-drm-core.c | 4 ++-- drivers/gpu/drm/imx/imx-drm.h | 2 +- 2 files

[PATCH 09/13] drm/irq: Make pipe unsigned and name consistent

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Name all references to the pipe number (CRTC index) consistently to make it easier to distinguish which is a pipe number and which is a pointer to struct drm_crtc. While at it also make all references to the pipe number unsigned because there is no longer

[PATCH 10/13] drm/irq: Add drm_crtc_vblank_count_and_time()

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com This function is the KMS native variant of drm_vblank_count_and_time(). It takes a struct drm_crtc * instead of a struct drm_device * and an index of the CRTC. Eventually the goal is to access vblank data through the CRTC only so that the per-CRTC data can

[PATCH 07/13] drm/sti: Store correct CRTC index in events

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com A negative pipe causes a special case to be triggered for drivers that don't have proper VBLANK support. STi does support VBLANKs, so there is no need for the fallback code. Cc: Benjamin Gaignard benjamin.gaign...@linaro.org Signed-off-by: Thierry Reding

[PATCH 02/13] drm/bochs: Store correct CRTC index in events

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Previously a negative pipe caused a special case to be triggered for drivers that didn't have proper VBLANK support. The trigger for this special case is now independent of the pipe, so the correct CRTC index can now be stored in events. Cc: Gerd Hoffmann

[PATCH 06/13] drm/rockchip: Store correct CRTC index in events

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com A negative pipe causes a special case to be triggered for drivers that don't have proper VBLANK support. Rockchip does support VBLANKs, so there is no need for the fallback code. Cc: Mark Yao mark@rock-chips.com Signed-off-by: Thierry Reding tred

[PATCH 05/13] drm/imx: Store correct CRTC index in events

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com A negative pipe causes a special case to be triggered for drivers that don't have proper VBLANK support. i.MX does support VBLANKs, so there is no need for the fallback code. Cc: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Thierry Reding tred

[PATCH 08/13] drm/irq: Check for valid VBLANK before dereference

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com When accessing the array of per-CRTC VBLANK structures we must always check that the index into the array is valid before dereferencing to avoid crashing. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/gpu/drm/drm_irq.c | 7 +-- 1 file

[PATCH 03/13] drm/exynos: Store correct CRTC index in events

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com A negative pipe causes a special case to be triggered for drivers that don't have proper VBLANK support. Exynos does support VBLANKs, so there is no need for the fallback code. Cc: Inki Dae inki@samsung.com Cc: Joonyoung Shim jy0922.s...@samsung.com Cc

[PATCH 11/13] drm/irq: Document return values more consistently

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Some of the functions are documented inconsistently. Add Returns: sections where missing and use consistent style to describe the return value. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/gpu/drm/drm_irq.c | 7 +-- 1 file changed, 5

[PATCH 12/13] drm/irq: Expel legacy API

2014-12-16 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com These legacy functions all operate on the struct drm_device * and an index to the CRTC that they should access. This is bad because it requires keeping track of a global data structures to resolve the index to CRTC object lookup. In order to get rid

Re: drm: exynos: mixer: fix using usleep() in atomic context

2014-12-16 Thread Thierry Reding
On Mon, Dec 01, 2014 at 05:16:17PM +0100, Tobias Jakobi wrote: On 2014-12-01 16:54, Thierry Reding wrote: On Sun, Nov 30, 2014 at 01:35:25AM +0100, tjak...@math.uni-bielefeld.de wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com This patch fixes calling usleep_range() after taking

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-15 Thread Thierry Reding
On Sun, Dec 14, 2014 at 02:45:36PM +0200, Laurent Pinchart wrote: Hi Marek, Thank you for the patch. On Wednesday 19 November 2014 12:15:47 Marek Szyprowski wrote: This patch introduces IOMMU_OF_DECLARE-based initialization to the driver, which replaces subsys_initcall-based procedure.

Re: [PATCH 2/3] drm/panel: add s6e63j0x03 LCD Panel driver

2014-12-01 Thread Thierry Reding
On Fri, Nov 28, 2014 at 08:39:50PM +0900, Inki Dae wrote: This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD Panel driver which uses mipi_dsi bus to communicate with Panel. s/Panel/panel/. Also I prefer to have more information in the commit message than this. Physical size and resolution

Re: drm: exynos: mixer: fix using usleep() in atomic context

2014-12-01 Thread Thierry Reding
On Sun, Nov 30, 2014 at 01:35:25AM +0100, tjak...@math.uni-bielefeld.de wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com This patch fixes calling usleep_range() after taking reg_slock using spin_lock_irqsave(). The mdelay() is used instead. Waiting in atomic context is not the best

Re: [PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-24 Thread Thierry Reding
On Mon, Nov 24, 2014 at 11:11:23AM +0530, Vivek Gautam wrote: DP PHY now require pmu-system-controller to handle PMU register to control PHY's power isolation. Adding the same to dp-phy node. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com

Re: [PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-24 Thread Thierry Reding
On Mon, Nov 24, 2014 at 04:17:18PM +0530, Vivek Gautam wrote: Hi, On Mon, Nov 24, 2014 at 4:02 PM, Thierry Reding thierry.red...@gmail.com wrote: On Mon, Nov 24, 2014 at 11:11:23AM +0530, Vivek Gautam wrote: DP PHY now require pmu-system-controller to handle PMU register to control

Re: [PATCH] drm/panel: simple: Add AUO B116XW03 panel support

2014-11-06 Thread Thierry Reding
On Mon, Sep 01, 2014 at 03:40:02PM +0530, Ajay Kumar wrote: The AUO B116XW03 is a 11.6 HD TFT LCD panel connecting to a LVDS interface and with an integrated LED backlight unit. This panel is used on the Samsung Chromebook(XE303C12). Signed-off-by: Ajay Kumar ajaykumar...@samsung.com ---

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-11-03 Thread Thierry Reding
On Fri, Oct 31, 2014 at 04:51:43PM +0100, Daniel Vetter wrote: On Wed, Oct 29, 2014 at 10:14:37AM +0100, Thierry Reding wrote: On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote: That makes the entire thing a bit non-trivial, which is why I think it would be better as some

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-11-03 Thread Thierry Reding
On Fri, Oct 31, 2014 at 04:59:40PM +0100, Daniel Vetter wrote: On Wed, Oct 29, 2014 at 10:16:49AM +0100, Thierry Reding wrote: On Wed, Oct 29, 2014 at 08:51:27AM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:29:47PM +0100, Thierry Reding wrote: On Mon, Oct 27, 2014 at 11:20:31PM

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-29 Thread Thierry Reding
On Wed, Oct 29, 2014 at 08:43:14AM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:35:50PM +0100, Thierry Reding wrote: On Mon, Oct 27, 2014 at 11:26:30PM +0100, Daniel Vetter wrote: On Mon, Oct 27, 2014 at 11:20 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Oct 27, 2014 at 8

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-29 Thread Thierry Reding
On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote: On Wed, Oct 29, 2014 at 09:38:23AM +0100, Thierry Reding wrote: On Wed, Oct 29, 2014 at 08:43:14AM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:35:50PM +0100, Thierry Reding wrote: On Mon, Oct 27, 2014 at 11:26:30PM

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-29 Thread Thierry Reding
On Wed, Oct 29, 2014 at 08:51:27AM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:29:47PM +0100, Thierry Reding wrote: On Mon, Oct 27, 2014 at 11:20:31PM +0100, Daniel Vetter wrote: On Mon, Oct 27, 2014 at 8:58 PM, Sean Paul seanp...@chromium.org wrote: @@ -660,8 +662,11

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-28 Thread Thierry Reding
On Mon, Oct 27, 2014 at 11:20:31PM +0100, Daniel Vetter wrote: On Mon, Oct 27, 2014 at 8:58 PM, Sean Paul seanp...@chromium.org wrote: @@ -660,8 +662,11 @@ struct drm_bridge_funcs { * @driver_private: pointer to the bridge driver's internal context */ struct drm_bridge { -

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-28 Thread Thierry Reding
On Mon, Oct 27, 2014 at 11:26:30PM +0100, Daniel Vetter wrote: On Mon, Oct 27, 2014 at 11:20 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Oct 27, 2014 at 8:58 PM, Sean Paul seanp...@chromium.org wrote: @@ -660,8 +662,11 @@ struct drm_bridge_funcs { * @driver_private: pointer to the

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-28 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:19:36PM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 1:28 PM, Ajay kumar ajayn...@gmail.com wrote: On Tue, Oct 28, 2014 at 3:31 PM, Daniel Vetter dan...@ffwll.ch wrote: [...] Hm, if you do this can you pls also update drm_panel accordingly? It shouldn't be

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-28 Thread Thierry Reding
On Tue, Oct 28, 2014 at 08:16:44PM +0530, Ajay kumar wrote: On Tue, Oct 28, 2014 at 8:11 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Oct 28, 2014 at 03:19:36PM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 1:28 PM, Ajay kumar ajayn...@gmail.com wrote: On Tue, Oct 28

[PATCH 02/15] drm/dsi: Constify mipi_dsi_msg

2014-10-13 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com struct mipi_dsi_msg is a read-only structure, drivers should never need to modify it. Make this explicit by making all references to the struct const. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-09 Thread Thierry Reding
On Thu, Oct 09, 2014 at 09:52:58AM +0100, Russell King - ARM Linux wrote: On Thu, Oct 09, 2014 at 02:43:02PM +0900, Alexandre Courbot wrote: But there might be another issue, which is that calls to drm_vblank_get() will return -EINVAL if invoked between drm_blank_off and drm_blank_on.

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-08 Thread Thierry Reding
On Tue, Oct 07, 2014 at 05:49:24PM +0300, Laurent Pinchart wrote: Hi Ajay, On Tuesday 07 October 2014 16:06:55 Ajay kumar wrote: On Tue, Oct 7, 2014 at 4:00 PM, Tomi Valkeinen wrote: On 20/09/14 14:22, Ajay kumar wrote: Well, I am okay with using video ports to describe the

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-30 Thread Thierry Reding
On Mon, Sep 29, 2014 at 02:12:43PM +0100, Grant Likely wrote: On Mon, Sep 29, 2014 at 1:57 PM, Thierry Reding thierry.red...@gmail.com wrote: Though there are two cases: one is to use simplefb as a means to have early boot messages on a graphical display (and optionally hand off to a real

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-29 Thread Thierry Reding
On Wed, Sep 10, 2014 at 03:56:16PM +0100, Grant Likely wrote: On Wed, Sep 10, 2014 at 3:31 PM, Mark Brown broo...@kernel.org wrote: On Wed, Sep 10, 2014 at 06:06:46AM -0700, Olof Johansson wrote: On Mon, Sep 8, 2014 at 12:40 PM, Grant Likely grant.lik...@secretlab.ca wrote: Well, lets

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-25 Thread Thierry Reding
On Wed, Sep 24, 2014 at 12:08:37PM +0300, Tomi Valkeinen wrote: On 23/09/14 17:58, Thierry Reding wrote: But if a panel driver controls its video source, it makes sense for the panel driver to get its video source in its probe, and that happens easiest if the panel has a link to the video

Re: [PATCH v7 2/5] ARM: add AFTR mode support to firmware do_idle method

2014-09-25 Thread Thierry Reding
do_idle() (yet?) so I don't think this patch would cause any damage. Acked-by: Thierry Reding tred...@nvidia.com pgp07lS6Zp04I.pgp Description: PGP signature

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Thierry Reding
On Mon, Sep 22, 2014 at 05:23:25PM +0300, Tomi Valkeinen wrote: On 22/09/14 11:06, Thierry Reding wrote: Why do we need a complex graph when it can be handled using a simple phandle? Maybe in your case you can handle it with simple phandle. Can you guarantee that it's enough

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Thierry Reding
On Mon, Sep 22, 2014 at 05:04:54PM +0300, Tomi Valkeinen wrote: On 22/09/14 10:54, Thierry Reding wrote: I wish all new display component bindings would use the video ports/endpoints to describe the connections. It will be very difficult to improve the display driver model later if we're

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Thierry Reding
On Tue, Sep 23, 2014 at 11:41:33AM +0530, Ajay kumar wrote: On Tue, Sep 23, 2014 at 11:25 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Sep 23, 2014 at 03:00:37AM +0300, Laurent Pinchart wrote: On Monday 22 September 2014 13:35:15 Thierry Reding wrote: On Mon, Sep 22, 2014

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-23 Thread Thierry Reding
On Tue, Sep 23, 2014 at 09:24:12AM +0200, Andrzej Hajda wrote: Hi Thierry, Tomi, On 09/23/2014 08:04 AM, Thierry Reding wrote: On Mon, Sep 22, 2014 at 05:23:25PM +0300, Tomi Valkeinen wrote: On 22/09/14 11:06, Thierry Reding wrote: Why do we need a complex graph when it can be handled

  1   2   3   4   >