Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

[Tobias Jakobi]

Hello!


Inki Dae wrote:
> On 2015년 08월 24일 23:13, Tobias Jakobi wrote:
>> The amount of commands (regular and GEM) doesn't depend
>> on the input here.
>>
>> Signed-off-by: Tobias Jakobi 
>> ---
>>  exynos/exynos_fimg2d.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
>> index 1ae8adf..9b7bcce 100644
>> --- a/exynos/exynos_fimg2d.c
>> +++ b/exynos/exynos_fimg2d.c
>> @@ -319,6 +319,9 @@ g2d_solid_fill(struct g2d_context *ctx, struct g2d_image 
>> *img,
>>  union g2d_bitblt_cmd_val bitblt;
>>  union g2d_point_val pt;
>>  
>> +if (g2d_check_space(ctx, 7, 1))
>> +return -ENOSPC;
> 
> You can make 3 and 4 patches to one. These should be same patch.
Hmm, so which 3 (respectively 4) patches should be squashed?

I tried to separate stuff to make review easier. If squashing here is
the only issue, do I need to resend the series or can e.g. Emil just do
the squash when merging?

With best wishes,
Tobias


> 
>> +
>>  g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_NORMAL);
>>  g2d_add_cmd(ctx, DST_COLOR_MODE_REG, img->color_mode);
>>  g2d_add_base_addr(ctx, img, g2d_dst);
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

[Emil Velikov]

On 31 August 2015 at 20:27, Tobias Jakobi  wrote:
> Hello!
>
> Inki Dae wrote:
>> On 2015년 08월 24일 23:13, Tobias Jakobi wrote:

>>> +if (g2d_check_space(ctx, 7, 1))
>>> +return -ENOSPC;
>>
>> You can make 3 and 4 patches to one. These should be same patch.
> Hmm, so which 3 (respectively 4) patches should be squashed?
>
I believe he meant "squash the introduction of the function and its
uses into a single patch".

Not sure how much value that brings, so I'll let you guys decide on
the bike shed colour :-)

-Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

[Inki Dae]

On 2015년 09월 01일 04:57, Emil Velikov wrote:
> On 31 August 2015 at 20:27, Tobias Jakobi  
> wrote:
>> Hello!
>>
>> Inki Dae wrote:
>>> On 2015년 08월 24일 23:13, Tobias Jakobi wrote:
> 
 +if (g2d_check_space(ctx, 7, 1))
 +return -ENOSPC;
>>>
>>> You can make 3 and 4 patches to one. These should be same patch.
>> Hmm, so which 3 (respectively 4) patches should be squashed?
>>
> I believe he meant "squash the introduction of the function and its
> uses into a single patch".
> 
> Not sure how much value that brings, so I'll let you guys decide on
> the bike shed colour :-)

That - including relevant my comments - is just my opinion so no problem
to upstream it as is. This is really trivial.

Thanks,
Inki Dae

> 
> -Emil
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" 
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

[Inki Dae]

On 2015년 08월 24일 23:13, Tobias Jakobi wrote:
> The amount of commands (regular and GEM) doesn't depend
> on the input here.
> 
> Signed-off-by: Tobias Jakobi 
> ---
>  exynos/exynos_fimg2d.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
> index 1ae8adf..9b7bcce 100644
> --- a/exynos/exynos_fimg2d.c
> +++ b/exynos/exynos_fimg2d.c
> @@ -319,6 +319,9 @@ g2d_solid_fill(struct g2d_context *ctx, struct g2d_image 
> *img,
>   union g2d_bitblt_cmd_val bitblt;
>   union g2d_point_val pt;
>  
> + if (g2d_check_space(ctx, 7, 1))
> + return -ENOSPC;

You can make 3 and 4 patches to one. These should be same patch.

> +
>   g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_NORMAL);
>   g2d_add_cmd(ctx, DST_COLOR_MODE_REG, img->color_mode);
>   g2d_add_base_addr(ctx, img, g2d_dst);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

[Tobias Jakobi]

The amount of commands (regular and GEM) doesn't depend
on the input here.

Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de
---
 exynos/exynos_fimg2d.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index 1ae8adf..9b7bcce 100644
--- a/exynos/exynos_fimg2d.c
+++ b/exynos/exynos_fimg2d.c
@@ -319,6 +319,9 @@ g2d_solid_fill(struct g2d_context *ctx, struct g2d_image 
*img,
union g2d_bitblt_cmd_val bitblt;
union g2d_point_val pt;
 
+   if (g2d_check_space(ctx, 7, 1))
+   return -ENOSPC;
+
g2d_add_cmd(ctx, DST_SELECT_REG, G2D_SELECT_MODE_NORMAL);
g2d_add_cmd(ctx, DST_COLOR_MODE_REG, img-color_mode);
g2d_add_base_addr(ctx, img, g2d_dst);
-- 
2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html