RE: [PATCH 3/3] ARM: S5PV210: GONI: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim 
Marek Szyprowski wrote:
 
 This patch adds required platform definitions for MAX8998 PMIC driver.
Power
 regulators for LDO and BUCK outputs has been defined as well as a simple
 gpio-keys button for power key (to enable wakeup functionality with
 external interrupt).
 
 Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
Ok..will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-13 Thread Kukjin Kim 
Marek Szyprowski wrote:
 
 This patch adds required platform definitions for MAX8998 PMIC driver.
Power
 regulators for LDO and BUCK outputs has been defined as well as a simple
 gpio-keys button for power key (to enable wakeup functionality with
 external interrupt).

Almost same with previous patch...except ldo7_data, ldo17_data and
name...Hmm...
See the previous comments...

 
 Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/mach-s5pv210/mach-goni.c |  323
 +
  1 files changed, 323 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/mach-s5pv210/mach-goni.c
b/arch/arm/mach-s5pv210/mach-
 goni.c
 index 05b4a1a..f0eaf86 100644
 --- a/arch/arm/mach-s5pv210/mach-goni.c
 +++ b/arch/arm/mach-s5pv210/mach-goni.c
 @@ -13,8 +13,13 @@
  #include linux/init.h
  #include linux/serial_core.h
  #include linux/fb.h
 +#include linux/i2c.h
 +#include linux/i2c-gpio.h
 +#include linux/mfd/max8998.h
  #include linux/delay.h
  #include linux/clk.h
 +#include linux/gpio_keys.h
 +#include linux/input.h
 
No need inclusion linux/gpio.h and plat/gpio-cfg.h?

  #include asm/mach/arch.h
  #include asm/mach/map.h
 @@ -107,9 +112,323 @@ static struct s3c_fb_platdata goni_lcd_pdata
__initdata
 = {
   .setup_gpio = s5pv210_fb_gpio_setup_24bpp,
  };
 

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown 
On Thu, Jul 01, 2010 at 08:07:46AM +0200, Marek Szyprowski wrote:

 +static struct regulator_consumer_supply goni_ldo3_consumers[] = {
 + {   .supply = VMIPI_1.1V, },
 +};

A similar issue to the previous patch applies here - you should be
defining consumers using struct device based lookups only.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html