Re: [PATCH] ARM: EXYNOS: Remove the L2 cache latency setting for EXYNOS5

2012-06-26 Thread Joonyoung Shim
Hi,

2012/6/21 Kukjin Kim kgene@samsung.com:
 From: Boojin Kim boojin@samsung.com

 Since SYSRAM set the L2 cache latency on EXYNOS5 SoCs,

I don't understand this. Do you mean that BL1 codes do it?
I also wonder how enable L2 cache at the exynos5.

 no longer need that in the kernel. It helps to reduce
 booting time (no need cache disable and cache enable).

 Signed-off-by: Boojin Kim boojin@samsung.com
 Signed-off-by: Kukjin Kim kgene@samsung.com
 ---
  arch/arm/mach-exynos/common.c |   25 -
  1 files changed, 0 insertions(+), 25 deletions(-)

 diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
 index 742edd3..0ec1a91 100644
 --- a/arch/arm/mach-exynos/common.c
 +++ b/arch/arm/mach-exynos/common.c
 @@ -712,31 +712,6 @@ static int __init exynos4_l2x0_cache_init(void)
  early_initcall(exynos4_l2x0_cache_init);
  #endif

 -static int __init exynos5_l2_cache_init(void)
 -{
 -       unsigned int val;
 -
 -       if (!soc_is_exynos5250())
 -               return 0;
 -
 -       asm volatile(mrc p15, 0, %0, c1, c0, 0\n
 -                    bic %0, %0, #(1  2)\n  /* cache disable */
 -                    mcr p15, 0, %0, c1, c0, 0\n
 -                    mrc p15, 1, %0, c9, c0, 2\n
 -                    : =r(val));
 -
 -       val |= (1  9) | (1  5) | (2  6) | (2  0);
 -
 -       asm volatile(mcr p15, 1, %0, c9, c0, 2\n : : r(val));
 -       asm volatile(mrc p15, 0, %0, c1, c0, 0\n
 -                    orr %0, %0, #(1  2)\n  /* cache enable */
 -                    mcr p15, 0, %0, c1, c0, 0\n
 -                    : : r(val));
 -
 -       return 0;
 -}
 -early_initcall(exynos5_l2_cache_init);
 -
  static int __init exynos_init(void)
  {
        printk(KERN_INFO EXYNOS: Initializing architecture\n);
 --
 1.7.1


 ___
 linux-arm-kernel mailing list
 linux-arm-ker...@lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
- Joonyoung Shim
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH] ARM: EXYNOS: Remove the L2 cache latency setting for EXYNOS5

2012-06-26 Thread Boojin Kim
Joonyoung Shim wrote:

 I don't understand this. Do you mean that BL1 codes do it?
 I also wonder how enable L2 cache at the exynos5.
Yes, the latency configuration of L2 cache is located on IROM or BL1 code.
It can remove the overhead about cache reset and cache flush.
And, Kernel enables L2 cache.
Thanks.

  no longer need that in the kernel. It helps to reduce
  booting time (no need cache disable and cache enable).
 
  Signed-off-by: Boojin Kim boojin@samsung.com
  Signed-off-by: Kukjin Kim kgene@samsung.com
  ---
  쟞rch/arm/mach-exynos/common.c | � 25 -
  �1 files changed, 0 insertions(+), 25 deletions(-)
 
  diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
  index 742edd3..0ec1a91 100644
  --- a/arch/arm/mach-exynos/common.c
  +++ b/arch/arm/mach-exynos/common.c
  @@ -712,31 +712,6 @@ static int __init exynos4_l2x0_cache_init(void)
  쟢arly_initcall(exynos4_l2x0_cache_init);
  �#endif
 
  -static int __init exynos5_l2_cache_init(void)
  -{
  - � � � unsigned int val;
  -
  - � � � if (!soc_is_exynos5250())
  - � � � � � � � return 0;
  -
  - � � � asm volatile(mrc p15, 0, %0, c1, c0, 0\n
  - � � � � � � � � � �bic %0, %0, #(1  2)\n �/* cache disable */
  - � � � � � � � � � �mcr p15, 0, %0, c1, c0, 0\n
  - � � � � � � � � � �mrc p15, 1, %0, c9, c0, 2\n
  - � � � � � � � � � �: =r(val));
  -
  - � � � val |= (1  9) | (1  5) | (2  6) | (2  0);
  -
  - � � � asm volatile(mcr p15, 1, %0, c9, c0, 2\n : : r(val));
  - � � � asm volatile(mrc p15, 0, %0, c1, c0, 0\n
  - � � � � � � � � � �orr %0, %0, #(1  2)\n �/* cache enable */
  - � � � � � � � � � �mcr p15, 0, %0, c1, c0, 0\n
  - � � � � � � � � � �: : r(val));
  -
  - � � � return 0;
  -}
  -early_initcall(exynos5_l2_cache_init);
  -
  쟳tatic int __init exynos_init(void)
  �{
  � � � 쟰rintk(KERN_INFO EXYNOS: Initializing architecture\n);
  --
  1.7.1
 
 
  ___
  linux-arm-kernel mailing list
  linux-arm-ker...@lists.infradead.org
  http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



 --
 - Joonyoung Shim

 ___
 linux-arm-kernel mailing list
 linux-arm-ker...@lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] ARM: EXYNOS: Remove the L2 cache latency setting for EXYNOS5

2012-06-20 Thread Kukjin Kim
From: Boojin Kim boojin@samsung.com

Since SYSRAM set the L2 cache latency on EXYNOS5 SoCs,
no longer need that in the kernel. It helps to reduce
booting time (no need cache disable and cache enable).

Signed-off-by: Boojin Kim boojin@samsung.com
Signed-off-by: Kukjin Kim kgene@samsung.com
---
 arch/arm/mach-exynos/common.c |   25 -
 1 files changed, 0 insertions(+), 25 deletions(-)

diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
index 742edd3..0ec1a91 100644
--- a/arch/arm/mach-exynos/common.c
+++ b/arch/arm/mach-exynos/common.c
@@ -712,31 +712,6 @@ static int __init exynos4_l2x0_cache_init(void)
 early_initcall(exynos4_l2x0_cache_init);
 #endif
 
-static int __init exynos5_l2_cache_init(void)
-{
-   unsigned int val;
-
-   if (!soc_is_exynos5250())
-   return 0;
-
-   asm volatile(mrc p15, 0, %0, c1, c0, 0\n
-bic %0, %0, #(1  2)\n  /* cache disable */
-mcr p15, 0, %0, c1, c0, 0\n
-mrc p15, 1, %0, c9, c0, 2\n
-: =r(val));
-
-   val |= (1  9) | (1  5) | (2  6) | (2  0);
-
-   asm volatile(mcr p15, 1, %0, c9, c0, 2\n : : r(val));
-   asm volatile(mrc p15, 0, %0, c1, c0, 0\n
-orr %0, %0, #(1  2)\n  /* cache enable */
-mcr p15, 0, %0, c1, c0, 0\n
-: : r(val));
-
-   return 0;
-}
-early_initcall(exynos5_l2_cache_init);
-
 static int __init exynos_init(void)
 {
printk(KERN_INFO EXYNOS: Initializing architecture\n);
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html