Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-09 Thread Arnd Bergmann
On Thursday 09 October 2014 10:46:59 Ulf Hansson wrote: > On 8 October 2014 20:28, Arnd Bergmann wrote: > > On Wednesday 08 October 2014 08:29:16 Doug Anderson wrote: > >> > >> On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann wrote: > >> > Why does it cause a regression though? Does this mean you ar

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-09 Thread Ulf Hansson
On 8 October 2014 20:28, Arnd Bergmann wrote: > On Wednesday 08 October 2014 08:29:16 Doug Anderson wrote: >> >> On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann wrote: >> > Why does it cause a regression though? Does this mean you are breaking >> > any boot with an old DT file and a new kernel? Tha

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 08:29:16 Doug Anderson wrote: > > On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann wrote: > > Why does it cause a regression though? Does this mean you are breaking > > any boot with an old DT file and a new kernel? That would be very > > bad, the driver is supposed to k

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Doug Anderson
Hi, On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann wrote: > Why does it cause a regression though? Does this mean you are breaking > any boot with an old DT file and a new kernel? That would be very > bad, the driver is supposed to keep working with an existing dtb. The old dts file specified com

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 14:50:46 Ulf Hansson wrote: > On 8 October 2014 14:07, Arnd Bergmann wrote: > > On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote: > >> On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz > >> wrote: > >> > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19)

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Ulf Hansson
On 8 October 2014 14:07, Arnd Bergmann wrote: > On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote: >> On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz >> wrote: >> > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc >> > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Current

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Arnd Bergmann
On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote: > On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz > wrote: > > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > > tree entry for MMC2 uses PVDD_PRE_1

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-08 Thread Ulf Hansson
On 8 October 2014 02:19, Jaehoon Chung wrote: > Hi, > > On 10/07/2014 01:51 AM, Doug Anderson wrote: >> Bartlomiej, >> >> On Thu, Oct 2, 2014 at 10:24 AM, Bartlomiej Zolnierkiewicz >> wrote: >>> >>> Hi, >>> >>> On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: Bartiomiej >>

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-07 Thread Jaehoon Chung
Hi, On 10/07/2014 01:51 AM, Doug Anderson wrote: > Bartlomiej, > > On Thu, Oct 2, 2014 at 10:24 AM, Bartlomiej Zolnierkiewicz > wrote: >> >> Hi, >> >> On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: >>> Bartiomiej >>> >>> On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz >

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-06 Thread Doug Anderson
Bartlomiej, On Thu, Oct 2, 2014 at 10:24 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: >> Bartiomiej >> >> On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > On Thursday, October 02, 2014 09:19:08 AM Doug And

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Ulf Hansson
On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz wrote: > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is > not specified. Fix it. > > Wit

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, October 02, 2014 09:45:41 AM Doug Anderson wrote: > Bartiomiej > > On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz > wrote: > > On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: > >> Bartiomiej, > >> > >> On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnier

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
Bartiomiej On Thu, Oct 2, 2014 at 9:39 AM, Bartlomiej Zolnierkiewicz wrote: > On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: >> Bartiomiej, >> >> On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
On Thursday, October 02, 2014 09:19:08 AM Doug Anderson wrote: > Bartiomiej, > > On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz > wrote: > > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > > tree

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Doug Anderson
Bartiomiej, On Thu, Oct 2, 2014 at 9:10 AM, Bartlomiej Zolnierkiewicz wrote: > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is > not specifi

[PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-02 Thread Bartlomiej Zolnierkiewicz
Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is not specified. Fix it. Without this patch: - "mmc: dw_mmc: use mmc_regulator_get_supply to handl