Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-26 Thread Mark Brown
On Wed, Nov 26, 2014 at 02:26:07PM +0530, D Krishna Mohan wrote: > Following your suggestion I have sent a patch > (187024b36c635bd454c1b1587b58c9439d3a46ad on your git, branch: rt5631 ) > using ifdef which you have already applied. > Since there are more suggestion asking for second (__maybe_unus

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-26 Thread D Krishna Mohan
tml -Krishna -- From: "Mark Brown" Sent: Monday, November 24, 2014 10:34 PM To: "Krishna Mohan Dani" Cc: ; ; ; ; "Claude Youn" Subject: Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled On Mon, No

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-24 Thread Mark Brown
On Mon, Nov 24, 2014 at 04:52:42PM +0530, Krishna Mohan Dani wrote: > Fixes the following compilation warning: > Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. This doesn't apply, please check and resend. signature.asc Description: Digital signature

[PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-24 Thread Krishna Mohan Dani
Fixes the following compilation warning: Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. Signed-off-by: Claude Youn Signed-off-by: Krishna Mohan Dani --- sound/soc/codecs/rt5631.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-24 Thread Mark Brown
On Mon, Nov 24, 2014 at 12:48:31PM +0530, D Krishna Mohan wrote: > Attaching the patch with changes suggested by Uwe. Though there is another > patch which I submitted, but I leave it to Mark Brown as to which patch to > pick. Please send patches in the format covered in SubmittingPatches, the too

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-23 Thread D Krishna Mohan
laude Youn" Subject: Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled On Mon, Nov 17, 2014 at 07:26:29PM +0530, Krishna Mohan Dani wrote: Fixes the following compilation warning: Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. S

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-17 Thread Uwe Kleine-König
On Mon, Nov 17, 2014 at 07:26:29PM +0530, Krishna Mohan Dani wrote: > Fixes the following compilation warning: > Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. > > Signed-off-by: Claude Youn > Signed-off-by: Krishna Mohan Dani > --- > sound/soc/codecs/rt5631.c |2 +

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-17 Thread Mark Brown
On Mon, Nov 17, 2014 at 07:26:29PM +0530, Krishna Mohan Dani wrote: > Fixes the following compilation warning: > Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. > > Signed-off-by: Claude Youn > Signed-off-by: Krishna Mohan Dani Applied, thanks. It's really weird that s

[PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-17 Thread Krishna Mohan Dani
Fixes the following compilation warning: Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used. Signed-off-by: Claude Youn Signed-off-by: Krishna Mohan Dani --- sound/soc/codecs/rt5631.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5631.c b/sound