Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-19 Thread Dmitry Torokhov
On Wed, Sep 18, 2013 at 12:41:11AM +0530, Manish Badarkhe wrote: Hi Dmitry, On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-19 Thread Manish Badarkhe
Hi Dmitry, On Fri, Sep 20, 2013 at 2:52 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Sep 18, 2013 at 12:41:11AM +0530, Manish Badarkhe wrote: Hi Dmitry, On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Sun, Sep 15, 2013 at

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Tomasz Figa
Hi Manish, Thanks for the patch. I have few comments inline, though. On Sunday 15 of September 2013 01:22:23 Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Manish Badarkhe
Hi Tomasz On Tue, Sep 17, 2013 at 4:49 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Manish, Thanks for the patch. I have few comments inline, though. On Sunday 15 of September 2013 01:22:23 Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources.

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Dmitry Torokhov
Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. And the benefit of this would be...? There are still resources that are managed in traditional way and I really dislike mixing the 2

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Manish Badarkhe
Hi Dmitry, On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. And the benefit of this would be...?

[PATCH] Input: gpio-keys - update to devm_* API

2013-09-14 Thread Manish Badarkhe
Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 440ce32... b4db721... M drivers/input/keyboard/gpio_keys.c drivers/input/keyboard/gpio_keys.c | 18 ++ 1 file changed, 6