Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Heiko Stübner
Hi Thomas, thanks for your review: Am Montag, 27. August 2012, 06:20:49 schrieb Thomas Abraham: Hi Heiko, On 26 August 2012 03:23, Heiko Stübner he...@sntech.de wrote: Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs via the device tree. This patch implements

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Vasily Khoruzhick
Hi, On Mon, Aug 27, 2012 at 11:01 AM, Heiko Stübner he...@sntech.de wrote: Hi Thomas, thanks for your review: Hmmm, but the logic to drive the gpio controller is the same for all arches. The only difference is the number to use for the different pull up/down settings. So I think the

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Heiko Stübner
Hi Vasily, Am Montag, 27. August 2012, 10:57:04 schrieb Vasily Khoruzhick: Hi, On Mon, Aug 27, 2012 at 11:01 AM, Heiko Stübner he...@sntech.de wrote: Hi Thomas, thanks for your review: Hmmm, but the logic to drive the gpio controller is the same for all arches. The only

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Vasily Khoruzhick
On Mon, Aug 27, 2012 at 12:44 PM, Heiko Stübner he...@sntech.de wrote: Hi Vasily, I'm not sure I follow :-) . The compatible property here only sets the mechanism on how to handle the gpios defined in the devicetree - here to use the s3c24xx-style. As you can see in gpio-samsung.c the

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-27 Thread Thomas Abraham
On 27 August 2012 13:31, Heiko Stübner he...@sntech.de wrote: Hi Thomas, thanks for your review: Am Montag, 27. August 2012, 06:20:49 schrieb Thomas Abraham: Hi Heiko, On 26 August 2012 03:23, Heiko Stübner he...@sntech.de wrote: Until now the Exynos-SoC was the only Samsung-SoC

Re: [PATCH] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-26 Thread Thomas Abraham
Hi Heiko, On 26 August 2012 03:23, Heiko Stübner he...@sntech.de wrote: Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs via the device tree. This patch implements dt-support for the s3c24xx arches. The controllers contain only 3 cells, as the underlying gpio controller