Re: [PATCH] mmc: dw_mmc: Don't print data errors

2014-04-24 Thread Ulf Hansson
The status here could be useful information about the status register, which is not considered while printing errors by the higher levels. An option could be to print the error, but not when you perform tuning. No big deal though, just a thought. Right, I could potentially put the driver

Re: [PATCH] mmc: dw_mmc: Don't print data errors

2014-04-23 Thread Ulf Hansson
On 23 April 2014 01:51, Doug Anderson diand...@chromium.org wrote: Data errors are completely expected during tuning. Printing them out is confusing people looking at the kernel logs. They see things like: [3.613296] dwmmc_exynos 1220.dwmmc0: data error, status 0x0088 ...and

Re: [PATCH] mmc: dw_mmc: Don't print data errors

2014-04-23 Thread Doug Anderson
Seungwon / Ulf, On Wed, Apr 23, 2014 at 1:17 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 23 April 2014 01:51, Doug Anderson diand...@chromium.org wrote: Data errors are completely expected during tuning. Printing them out is confusing people looking at the kernel logs. They see things

[PATCH] mmc: dw_mmc: Don't print data errors

2014-04-22 Thread Doug Anderson
Data errors are completely expected during tuning. Printing them out is confusing people looking at the kernel logs. They see things like: [3.613296] dwmmc_exynos 1220.dwmmc0: data error, status 0x0088 ...and they think something is wrong with their hardware. Remove the