Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-26 Thread Mark Brown
On Thu, Nov 06, 2014 at 03:21:49PM +0530, Padmavathi Venna wrote: Exynos7 SPI controller supports only the auto Selection of CS toggle mode and Exynos7 SoC includes six SPI controllers. Add support for these changes in Exynos7 SPI controller driver. Applied, thanks. It does seem like these

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-24 Thread Padma Venkat
Hi Mark, OK. I don't have provision to test on this board. I will try to test on older boards by disabling manual mode. I tested on exynos5420 peach-pit by enabling auto mode. I used dd command to read 1MB data from spi flash and I compared the result with manual mode. Both are same. I

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-20 Thread Padma Venkat
Hi Mark, CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The driver by default uses manual mode. But on exynos7 the manual mode is

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-14 Thread Padma Venkat
Hi Mark, On 11/10/14, Padma Venkat padma@gmail.com wrote: Hi Mark, On 11/7/14, Mark Brown broo...@kernel.org wrote: On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote: CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-09 Thread Padma Venkat
Hi Mark, On 11/7/14, Mark Brown broo...@kernel.org wrote: On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote: CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-07 Thread Padma Venkat
Hi Mark, CCing Kukjin Kim. On 11/6/14, Mark Brown broo...@kernel.org wrote: On Thu, Nov 06, 2014 at 03:21:49PM +0530, Padmavathi Venna wrote: Exynos7 SPI controller supports only the auto Selection of CS toggle mode and Exynos7 SoC includes six SPI controllers. Add support for these changes

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-07 Thread Mark Brown
On Fri, Nov 07, 2014 at 02:01:57PM +0530, Padma Venkat wrote: CS can also be controlled automatically by setting AUTO_N_MANUAL to 1 in CS_CFG. When it is auto CS automatically toggles between packet to packet. NCS_TIME_COUNT in CS_CFG controls the inactive period. The driver by default uses

[PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-06 Thread Padmavathi Venna
Exynos7 SPI controller supports only the auto Selection of CS toggle mode and Exynos7 SoC includes six SPI controllers. Add support for these changes in Exynos7 SPI controller driver. Signed-off-by: Padmavathi Venna padm...@samsung.com --- .../devicetree/bindings/spi/spi-samsung.txt|

Re: [PATCH] spi: s3c64xx: add support for exynos7 SPI controller

2014-11-06 Thread Mark Brown
On Thu, Nov 06, 2014 at 03:21:49PM +0530, Padmavathi Venna wrote: Exynos7 SPI controller supports only the auto Selection of CS toggle mode and Exynos7 SoC includes six SPI controllers. Add support for these changes in Exynos7 SPI controller driver. Could you give a bit more detail on what the