Re: [PATCH] thermal: Add missing cpumask_clear

2014-07-08 Thread Javi Merino
On Fri, Jul 04, 2014 at 11:22:40AM +0100, Jonghwan Choi wrote: Cpumasks should be cleared before using. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- drivers/thermal/db8500_cpufreq_cooling.c|1 + drivers/thermal/imx_thermal.c |1 +

Re: [PATCH] thermal: Add missing cpumask_clear

2014-07-05 Thread Sachin Kamat
On Sat, Jul 5, 2014 at 6:04 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Jonghwan, On 05.07.2014 01:37, Jonghwan Choi wrote: On Fri, Jul 4, 2014 at 8:23 PM, Sachin Kamat spk.li...@gmail.com wrote: Cpumasks should be cleared before using. Please explain why and what is issue observed

[PATCH] thermal: Add missing cpumask_clear

2014-07-04 Thread Jonghwan Choi
Cpumasks should be cleared before using. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- drivers/thermal/db8500_cpufreq_cooling.c|1 + drivers/thermal/imx_thermal.c |1 + drivers/thermal/samsung/exynos_thermal_common.c |1 + 3 files changed, 3

Re: [PATCH] thermal: Add missing cpumask_clear

2014-07-04 Thread Sachin Kamat
Hi Jonghwan, On Fri, Jul 4, 2014 at 3:52 PM, Jonghwan Choi jhbird.c...@samsung.com wrote: Cpumasks should be cleared before using. Please explain why and what is issue observed without this. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- -- Regards, Sachin. -- To unsubscribe

RE: [PATCH] thermal: Add missing cpumask_clear

2014-07-04 Thread Jonghwan Choi
On Fri, Jul 4, 2014 at 8:23 PM, Sachin Kamat spk.li...@gmail.com wrote: Cpumasks should be cleared before using. Please explain why and what is issue observed without this. - When I checked the mask value, I knew that unwanted bit is set. Test code without cpumask_clear. +

Re: [PATCH] thermal: Add missing cpumask_clear

2014-07-04 Thread Tomasz Figa
Hi Jonghwan, On 05.07.2014 01:37, Jonghwan Choi wrote: On Fri, Jul 4, 2014 at 8:23 PM, Sachin Kamat spk.li...@gmail.com wrote: Cpumasks should be cleared before using. Please explain why and what is issue observed without this. - When I checked the mask value, I knew that unwanted bit

RE: [PATCH] thermal: Add missing cpumask_clear

2014-07-04 Thread Jonghwan Choi
On Fri, Jul 5, 2014 at 9:34 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Console message- 4.861157] [c6] --ID [ 1] = 0,4-5,7 (4,5,7 cpu bit was set.) And when I tried to register two cooling devices with cpumask_set_cpu(0, mask_val) and cpumask_set_cpu(4, mask_val). I found that