Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-02-01 Thread Joonyoung Shim
On 01/31/2015 02:17 AM, Gustavo Padovan wrote: 2015-01-30 Daniel Vetter dan...@ffwll.ch: On Fri, Jan 30, 2015 at 03:57:53PM +, Daniel Stone wrote: Hi, On 30 January 2015 at 14:30, Gustavo Padovan gust...@padovan.org wrote: 2015-01-30 Joonyoung Shim jy0922.s...@samsung.com: We will

Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-30 Thread Daniel Stone
Hi, On 30 January 2015 at 14:30, Gustavo Padovan gust...@padovan.org wrote: 2015-01-30 Joonyoung Shim jy0922.s...@samsung.com: We will lose unfinished prior events by this change. That's why we use linked list. I think you are right, but I was using exynos_crtc-event to do exactly the same

Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-30 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 03:57:53PM +, Daniel Stone wrote: Hi, On 30 January 2015 at 14:30, Gustavo Padovan gust...@padovan.org wrote: 2015-01-30 Joonyoung Shim jy0922.s...@samsung.com: We will lose unfinished prior events by this change. That's why we use linked list. I think you

Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-30 Thread Gustavo Padovan
2015-01-30 Daniel Vetter dan...@ffwll.ch: On Fri, Jan 30, 2015 at 03:57:53PM +, Daniel Stone wrote: Hi, On 30 January 2015 at 14:30, Gustavo Padovan gust...@padovan.org wrote: 2015-01-30 Joonyoung Shim jy0922.s...@samsung.com: We will lose unfinished prior events by this change.

Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-30 Thread Gustavo Padovan
2015-01-30 Joonyoung Shim jy0922.s...@samsung.com: +Cc Inki, Hi, On 01/30/2015 02:10 AM, Gustavo Padovan wrote: From: Mandeep Singh Baines m...@chromium.org The goal of the change is to make sure we send the vblank event on the current vblank. My hope is to fix any races that

[PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-29 Thread Gustavo Padovan
From: Mandeep Singh Baines m...@chromium.org The goal of the change is to make sure we send the vblank event on the current vblank. My hope is to fix any races that might be causing flicker. After this change I only see a flicker in the transition plymouth and X11. Simplified the code by

Re: [PATCH -v2] drm/exynos: track vblank events on a per crtc basis

2015-01-29 Thread Joonyoung Shim
+Cc Inki, Hi, On 01/30/2015 02:10 AM, Gustavo Padovan wrote: From: Mandeep Singh Baines m...@chromium.org The goal of the change is to make sure we send the vblank event on the current vblank. My hope is to fix any races that might be causing flicker. After this change I only see a flicker