Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Tue, Jul 24, 2012 at 09:53:11PM +0200, Rafael J. Wysocki wrote: [ ... ] > > If anything, I should not have applied Rafael's patch to the driver either. > > Well, it looks like I sent it at a wrong time. Sorry about that. > My fault, not yours. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Tuesday, July 24, 2012, Guenter Roeck wrote: > On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote: > > Hi Amit, > > > > On 14 July 2012 12:55, amit kachhap wrote: > > > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck wrote: > > >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: > > >>> Amit Daniel Kachhap wrote: > > >>> > > > >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU > > >>> > driver patches sent earlier. The link for those are > > >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html. > > >>> > > > >>> How was going on above patches? I can't see them you said in linux-next > > >>> now, > > >>> it means if I apply this series in my tree, problem will be happened :( > > >>> > > >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using > > >>> struct > > >>> dev_pm_ops for pm and applied by Guenter. > > >>> > > >> If that is in the way, I can drop it, to be applied after the move. Let > > >> me know. > > >> There is now another patch pending, to convert the driver to use devm_ > > >> functions. > > >> Please let me know what you want me to do with it. > > >> > > > Hi Guenter, > > > > > > I rebased my V5 patch series with hwmon-next branch so Rafael's pm > > > changes are already included. Regarding the devm_ patch by sachin > > > please hold it. > > > > Guenter has already sent the pull request to Linus for v3.6 [1]. > > That does not include your patches. I do not understand why you want > > to hold back my patch when you can rebase your series on top of it. > > > > [1] https://lkml.org/lkml/2012/7/23/414 > > > Linus doesn't like rebases, especially not from one tree to another. > As it is, it may even be that he rejects my pull request because I rebased > to 3.5 before sending the pull request to him (I'll definitely not do that > again). > > In addition, it may well be that some of your changes no longer apply > after the driver moved to its new location. So it is overall safer to move > the driver first, and convert it to devm_ functions afterwards. > > If anything, I should not have applied Rafael's patch to the driver either. Well, it looks like I sent it at a wrong time. Sorry about that. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote: > Hi Amit, > > On 14 July 2012 12:55, amit kachhap wrote: > > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck wrote: > >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: > >>> Amit Daniel Kachhap wrote: > >>> > > >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU > >>> > driver patches sent earlier. The link for those are > >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html. > >>> > > >>> How was going on above patches? I can't see them you said in linux-next > >>> now, > >>> it means if I apply this series in my tree, problem will be happened :( > >>> > >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct > >>> dev_pm_ops for pm and applied by Guenter. > >>> > >> If that is in the way, I can drop it, to be applied after the move. Let me > >> know. > >> There is now another patch pending, to convert the driver to use devm_ > >> functions. > >> Please let me know what you want me to do with it. > >> > > Hi Guenter, > > > > I rebased my V5 patch series with hwmon-next branch so Rafael's pm > > changes are already included. Regarding the devm_ patch by sachin > > please hold it. > > Guenter has already sent the pull request to Linus for v3.6 [1]. > That does not include your patches. I do not understand why you want > to hold back my patch when you can rebase your series on top of it. > > [1] https://lkml.org/lkml/2012/7/23/414 > Linus doesn't like rebases, especially not from one tree to another. As it is, it may even be that he rejects my pull request because I rebased to 3.5 before sending the pull request to him (I'll definitely not do that again). In addition, it may well be that some of your changes no longer apply after the driver moved to its new location. So it is overall safer to move the driver first, and convert it to devm_ functions afterwards. If anything, I should not have applied Rafael's patch to the driver either. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
Hi Amit, On 14 July 2012 12:55, amit kachhap wrote: > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck wrote: >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: >>> Amit Daniel Kachhap wrote: >>> > >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU >>> > driver patches sent earlier. The link for those are >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html. >>> > >>> How was going on above patches? I can't see them you said in linux-next now, >>> it means if I apply this series in my tree, problem will be happened :( >>> >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct >>> dev_pm_ops for pm and applied by Guenter. >>> >> If that is in the way, I can drop it, to be applied after the move. Let me >> know. >> There is now another patch pending, to convert the driver to use devm_ >> functions. >> Please let me know what you want me to do with it. >> > Hi Guenter, > > I rebased my V5 patch series with hwmon-next branch so Rafael's pm > changes are already included. Regarding the devm_ patch by sachin > please hold it. Guenter has already sent the pull request to Linus for v3.6 [1]. That does not include your patches. I do not understand why you want to hold back my patch when you can rebase your series on top of it. [1] https://lkml.org/lkml/2012/7/23/414 > > Thanks, > Amit D >>> Note2: would be helpful if you could do adding me in Cc of exynos tmu >>> patches... >>> >> If you want to be copied, it might make sense to add yourself as maintainer >> for >> this file. Otherwise you can not expect people to know. >> >> Thanks, >> Guenter >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" >> in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim wrote: > Amit Daniel Kachhap wrote: >> >> These TMU enablement patches are needed for exynos4 and exynos5 TMU >> driver patches sent earlier. The link for those are >> http://www.spinics.net/lists/lm-sensors/msg35858.html. >> > How was going on above patches? I can't see them you said in linux-next now, > it means if I apply this series in my tree, problem will be happened :( The TMU driver patches have appeared in linux-next. If it is not late please accept these enablement patches. > > Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct > dev_pm_ops for pm and applied by Guenter. > > Note2: would be helpful if you could do adding me in Cc of exynos tmu > patches... > >> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham. >> (http://www.spinics.net/lists/arm-kernel/msg184129.html) >> > Already in my tree. > >> This patchset is based Samsung Maintainer's tree, >> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for- >> next >> > OK. > >> Amit Daniel Kachhap (2): >> ARM: exynos4: Add devicetree node for TMU driver >> ARM: exynos5: Add devicetree node for TMU driver >> >> arch/arm/boot/dts/exynos4210.dtsi|7 +++ >> arch/arm/boot/dts/exynos5250.dtsi|6 ++ >> arch/arm/mach-exynos/clock-exynos4.c |5 + >> arch/arm/mach-exynos/clock-exynos5.c |5 + >> arch/arm/mach-exynos/include/mach/irqs.h |3 +++ >> arch/arm/mach-exynos/include/mach/map.h |3 +++ >> arch/arm/mach-exynos/mach-exynos4-dt.c |2 ++ >> arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++ >> 8 files changed, 33 insertions(+), 0 deletions(-) > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck wrote: > On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: >> Amit Daniel Kachhap wrote: >> > >> > These TMU enablement patches are needed for exynos4 and exynos5 TMU >> > driver patches sent earlier. The link for those are >> > http://www.spinics.net/lists/lm-sensors/msg35858.html. >> > >> How was going on above patches? I can't see them you said in linux-next now, >> it means if I apply this series in my tree, problem will be happened :( >> >> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct >> dev_pm_ops for pm and applied by Guenter. >> > If that is in the way, I can drop it, to be applied after the move. Let me > know. > There is now another patch pending, to convert the driver to use devm_ > functions. > Please let me know what you want me to do with it. > Hi Guenter, I rebased my V5 patch series with hwmon-next branch so Rafael's pm changes are already included. Regarding the devm_ patch by sachin please hold it. Thanks, Amit D >> Note2: would be helpful if you could do adding me in Cc of exynos tmu >> patches... >> > If you want to be copied, it might make sense to add yourself as maintainer > for > this file. Otherwise you can not expect people to know. > > Thanks, > Guenter > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim wrote: > Amit Daniel Kachhap wrote: >> >> These TMU enablement patches are needed for exynos4 and exynos5 TMU >> driver patches sent earlier. The link for those are >> http://www.spinics.net/lists/lm-sensors/msg35858.html. >> > How was going on above patches? I can't see them you said in linux-next now, > it means if I apply this series in my tree, problem will be happened :( Well, the above patches were accepted by Len for 3.5 merge but could not done because of some last minute pull issue. I hope it will go through in this merge window. I thought it is better to get the enablement patches also in mainline together. > > Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct > dev_pm_ops for pm and applied by Guenter. I have rebased the V5 with hwmon-next changes. So this change is already included. > > Note2: would be helpful if you could do adding me in Cc of exynos tmu > patches... Yes sure. > >> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham. >> (http://www.spinics.net/lists/arm-kernel/msg184129.html) >> > Already in my tree. > >> This patchset is based Samsung Maintainer's tree, >> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for- >> next >> > OK. > >> Amit Daniel Kachhap (2): >> ARM: exynos4: Add devicetree node for TMU driver >> ARM: exynos5: Add devicetree node for TMU driver >> >> arch/arm/boot/dts/exynos4210.dtsi|7 +++ >> arch/arm/boot/dts/exynos5250.dtsi|6 ++ >> arch/arm/mach-exynos/clock-exynos4.c |5 + >> arch/arm/mach-exynos/clock-exynos5.c |5 + >> arch/arm/mach-exynos/include/mach/irqs.h |3 +++ >> arch/arm/mach-exynos/include/mach/map.h |3 +++ >> arch/arm/mach-exynos/mach-exynos4-dt.c |2 ++ >> arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++ >> 8 files changed, 33 insertions(+), 0 deletions(-) > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: > Amit Daniel Kachhap wrote: > > > > These TMU enablement patches are needed for exynos4 and exynos5 TMU > > driver patches sent earlier. The link for those are > > http://www.spinics.net/lists/lm-sensors/msg35858.html. > > > How was going on above patches? I can't see them you said in linux-next now, > it means if I apply this series in my tree, problem will be happened :( > > Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct > dev_pm_ops for pm and applied by Guenter. > If that is in the way, I can drop it, to be applied after the move. Let me know. There is now another patch pending, to convert the driver to use devm_ functions. Please let me know what you want me to do with it. > Note2: would be helpful if you could do adding me in Cc of exynos tmu > patches... > If you want to be copied, it might make sense to add yourself as maintainer for this file. Otherwise you can not expect people to know. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
Amit Daniel Kachhap wrote: > > These TMU enablement patches are needed for exynos4 and exynos5 TMU > driver patches sent earlier. The link for those are > http://www.spinics.net/lists/lm-sensors/msg35858.html. > How was going on above patches? I can't see them you said in linux-next now, it means if I apply this series in my tree, problem will be happened :( Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct dev_pm_ops for pm and applied by Guenter. Note2: would be helpful if you could do adding me in Cc of exynos tmu patches... > Also patch 1 depends on combiner dt node patch sent by Thomas Abraham. > (http://www.spinics.net/lists/arm-kernel/msg184129.html) > Already in my tree. > This patchset is based Samsung Maintainer's tree, > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for- > next > OK. > Amit Daniel Kachhap (2): > ARM: exynos4: Add devicetree node for TMU driver > ARM: exynos5: Add devicetree node for TMU driver > > arch/arm/boot/dts/exynos4210.dtsi|7 +++ > arch/arm/boot/dts/exynos5250.dtsi|6 ++ > arch/arm/mach-exynos/clock-exynos4.c |5 + > arch/arm/mach-exynos/clock-exynos5.c |5 + > arch/arm/mach-exynos/include/mach/irqs.h |3 +++ > arch/arm/mach-exynos/include/mach/map.h |3 +++ > arch/arm/mach-exynos/mach-exynos4-dt.c |2 ++ > arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++ > 8 files changed, 33 insertions(+), 0 deletions(-) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms
These TMU enablement patches are needed for exynos4 and exynos5 TMU driver patches sent earlier. The link for those are http://www.spinics.net/lists/lm-sensors/msg35858.html. Also patch 1 depends on combiner dt node patch sent by Thomas Abraham. (http://www.spinics.net/lists/arm-kernel/msg184129.html) This patchset is based Samsung Maintainer's tree, git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next Amit Daniel Kachhap (2): ARM: exynos4: Add devicetree node for TMU driver ARM: exynos5: Add devicetree node for TMU driver arch/arm/boot/dts/exynos4210.dtsi|7 +++ arch/arm/boot/dts/exynos5250.dtsi|6 ++ arch/arm/mach-exynos/clock-exynos4.c |5 + arch/arm/mach-exynos/clock-exynos5.c |5 + arch/arm/mach-exynos/include/mach/irqs.h |3 +++ arch/arm/mach-exynos/include/mach/map.h |3 +++ arch/arm/mach-exynos/mach-exynos4-dt.c |2 ++ arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++ 8 files changed, 33 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
