Re: [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
On 10/05/15 21:47, Thierry Reding wrote: > Back when the PWM framework was introduced the concept of PWM lookup > tables was added to allow board code to register a table of PWM devices > and their association with consumers. The goal is to allow drivers to > use a unified method to request PWM devices. At the same time, since no > boards were exposing these tables, fallback code was kept in drivers to > allow old code to remain functional. In order to get rid of the legacy > fallback code, legacy users need to be updated to register PWM lookup > tables. > > This series converts all s3c24xx and s3c64xx boards that hook up a pwm- > backlight device to use the new PWM lookup tables. All patches have been > compile-tested, but I don't have access to any of these boards, so I > couldn't verify that they really work. > > Thierry > > Thierry Reding (6): > ARM: s3c24xx: h1940: Use PWM lookup table > ARM: s3c24xx: rx1950: Use PWM lookup table > ARM: s3c64xx: smdk6410: Use PWM lookup table > ARM: s3c64xx: crag6410: Use PWM lookup table > ARM: s3c64xx: hmt: Use PWM lookup table > ARM: s3c64xx: smartq: Use PWM lookup table > > arch/arm/mach-s3c24xx/mach-h1940.c| 10 +++--- > arch/arm/mach-s3c24xx/mach-rx1950.c | 8 ++-- > arch/arm/mach-s3c64xx/dev-backlight.c | 4 > arch/arm/mach-s3c64xx/mach-crag6410.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-hmt.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-smartq.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-smdk6410.c | 8 +++- > 7 files changed, 41 insertions(+), 16 deletions(-) > Applied this whole series with Krzysztof's review tag. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
W dniu 06.10.2015 o 17:43, Thierry Reding pisze: > On Tue, Oct 06, 2015 at 09:28:50AM +0900, Krzysztof Kozlowski wrote: >> On 05.10.2015 21:47, Thierry Reding wrote: >>> Back when the PWM framework was introduced the concept of PWM lookup >>> tables was added to allow board code to register a table of PWM devices >>> and their association with consumers. The goal is to allow drivers to >>> use a unified method to request PWM devices. At the same time, since no >>> boards were exposing these tables, fallback code was kept in drivers to >>> allow old code to remain functional. In order to get rid of the legacy >>> fallback code, legacy users need to be updated to register PWM lookup >>> tables. >>> >>> This series converts all s3c24xx and s3c64xx boards that hook up a pwm- >>> backlight device to use the new PWM lookup tables. All patches have been >>> compile-tested, but I don't have access to any of these boards, so I >>> couldn't verify that they really work. >> >> Unfortunately I can't verify them neither. I don't have these boards. In >> that case I would prefer approach "if it ain't broken, don't touch >> it"... unless someone tests the patches of course. > > Backlight on these boards is likely to be currently broken anyway. In > fact this series is part of an effort to restore backlight support for > these legacy boards (I sent out a similar series for PXA boards). > > We're going to need to have this series merged so that we can remove the > legacy code that's being a lot of trouble maintaining. If this series > ends up breaking anything, I'd be happy to help fix things up. So you suspect that it is already broken? Fair enough, I'll look at the patches. In the same time these are really old SoCs for mobile standard. I wonder if anyone uses them... :) Tomasz, Do you have 6410 board? I remember you were quite involved in it. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
On Tue, Oct 06, 2015 at 09:28:50AM +0900, Krzysztof Kozlowski wrote: > On 05.10.2015 21:47, Thierry Reding wrote: > > Back when the PWM framework was introduced the concept of PWM lookup > > tables was added to allow board code to register a table of PWM devices > > and their association with consumers. The goal is to allow drivers to > > use a unified method to request PWM devices. At the same time, since no > > boards were exposing these tables, fallback code was kept in drivers to > > allow old code to remain functional. In order to get rid of the legacy > > fallback code, legacy users need to be updated to register PWM lookup > > tables. > > > > This series converts all s3c24xx and s3c64xx boards that hook up a pwm- > > backlight device to use the new PWM lookup tables. All patches have been > > compile-tested, but I don't have access to any of these boards, so I > > couldn't verify that they really work. > > Unfortunately I can't verify them neither. I don't have these boards. In > that case I would prefer approach "if it ain't broken, don't touch > it"... unless someone tests the patches of course. Backlight on these boards is likely to be currently broken anyway. In fact this series is part of an effort to restore backlight support for these legacy boards (I sent out a similar series for PXA boards). We're going to need to have this series merged so that we can remove the legacy code that's being a lot of trouble maintaining. If this series ends up breaking anything, I'd be happy to help fix things up. Thierry signature.asc Description: PGP signature
Re: [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
On 05.10.2015 21:47, Thierry Reding wrote: > Back when the PWM framework was introduced the concept of PWM lookup > tables was added to allow board code to register a table of PWM devices > and their association with consumers. The goal is to allow drivers to > use a unified method to request PWM devices. At the same time, since no > boards were exposing these tables, fallback code was kept in drivers to > allow old code to remain functional. In order to get rid of the legacy > fallback code, legacy users need to be updated to register PWM lookup > tables. > > This series converts all s3c24xx and s3c64xx boards that hook up a pwm- > backlight device to use the new PWM lookup tables. All patches have been > compile-tested, but I don't have access to any of these boards, so I > couldn't verify that they really work. Unfortunately I can't verify them neither. I don't have these boards. In that case I would prefer approach "if it ain't broken, don't touch it"... unless someone tests the patches of course. Anyone can provide tested-by tag? Best regards, Krzysztof > > Thierry > > Thierry Reding (6): > ARM: s3c24xx: h1940: Use PWM lookup table > ARM: s3c24xx: rx1950: Use PWM lookup table > ARM: s3c64xx: smdk6410: Use PWM lookup table > ARM: s3c64xx: crag6410: Use PWM lookup table > ARM: s3c64xx: hmt: Use PWM lookup table > ARM: s3c64xx: smartq: Use PWM lookup table > > arch/arm/mach-s3c24xx/mach-h1940.c| 10 +++--- > arch/arm/mach-s3c24xx/mach-rx1950.c | 8 ++-- > arch/arm/mach-s3c64xx/dev-backlight.c | 4 > arch/arm/mach-s3c64xx/mach-crag6410.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-hmt.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-smartq.c | 9 +++-- > arch/arm/mach-s3c64xx/mach-smdk6410.c | 8 +++- > 7 files changed, 41 insertions(+), 16 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
Back when the PWM framework was introduced the concept of PWM lookup tables was added to allow board code to register a table of PWM devices and their association with consumers. The goal is to allow drivers to use a unified method to request PWM devices. At the same time, since no boards were exposing these tables, fallback code was kept in drivers to allow old code to remain functional. In order to get rid of the legacy fallback code, legacy users need to be updated to register PWM lookup tables. This series converts all s3c24xx and s3c64xx boards that hook up a pwm- backlight device to use the new PWM lookup tables. All patches have been compile-tested, but I don't have access to any of these boards, so I couldn't verify that they really work. Thierry Thierry Reding (6): ARM: s3c24xx: h1940: Use PWM lookup table ARM: s3c24xx: rx1950: Use PWM lookup table ARM: s3c64xx: smdk6410: Use PWM lookup table ARM: s3c64xx: crag6410: Use PWM lookup table ARM: s3c64xx: hmt: Use PWM lookup table ARM: s3c64xx: smartq: Use PWM lookup table arch/arm/mach-s3c24xx/mach-h1940.c| 10 +++--- arch/arm/mach-s3c24xx/mach-rx1950.c | 8 ++-- arch/arm/mach-s3c64xx/dev-backlight.c | 4 arch/arm/mach-s3c64xx/mach-crag6410.c | 9 +++-- arch/arm/mach-s3c64xx/mach-hmt.c | 9 +++-- arch/arm/mach-s3c64xx/mach-smartq.c | 9 +++-- arch/arm/mach-s3c64xx/mach-smdk6410.c | 8 +++- 7 files changed, 41 insertions(+), 16 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
