Re: [PATCH 01/13] regulator: Fix DT node name checking in max8997-pmic
Hi, On Thu, Apr 12, 2012 at 08:45:20PM +0200, Karol Lewandowski wrote: Avoid hard lockup when someone provides non-supported regulator name. Signed-off-by: Karol Lewandowski k.lewando...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Thomas Abraham thomas.abra...@linaro.org What is this supposed to apply against? It doesn't match any contents in linux-next. Also, fixes like these should just go straight to Mark Brown (and cc LAKML and others). -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/13] regulator: Fix DT node name checking in max8997-pmic
On Tue, Apr 24, 2012 at 3:56 PM, Olof Johansson o...@lixom.net wrote: Hi, On Thu, Apr 12, 2012 at 08:45:20PM +0200, Karol Lewandowski wrote: Avoid hard lockup when someone provides non-supported regulator name. Signed-off-by: Karol Lewandowski k.lewando...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Thomas Abraham thomas.abra...@linaro.org What is this supposed to apply against? D'oh, I didn't see the dependency in 0/13, nevermind. -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 01/13] regulator: Fix DT node name checking in max8997-pmic
Avoid hard lockup when someone provides non-supported regulator name. Signed-off-by: Karol Lewandowski k.lewando...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Thomas Abraham thomas.abra...@linaro.org --- drivers/regulator/max8997.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index dce8aaf..c20fd72 100644 --- a/drivers/regulator/max8997.c +++ b/drivers/regulator/max8997.c @@ -1011,6 +1011,13 @@ static int max8997_pmic_dt_parse_pdata(struct max8997_dev *iodev, for (i = 0; i ARRAY_SIZE(regulators); i++) if (!of_node_cmp(reg_np-name, regulators[i].name)) break; + + if (i == ARRAY_SIZE(regulators)) { + dev_warn(iodev-dev, don't know how to configure regulator %s\n, +reg_np-name); + continue; + } + rdata-id = i; rdata-initdata = of_get_regulator_init_data( iodev-dev, reg_np); -- 1.7.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html