Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-30 Thread Thomas Abraham
Hi Olof, On 30 May 2012 15:23, Olof Johansson wrote: > Hi, > > Some comments below. > > On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham > wrote: >> Platform data is used to specify controller hardware specific information >> such as the tx/rx fifo level mask and bit offset of rx fifo level. Such

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-30 Thread Olof Johansson
Hi, Some comments below. On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Inst

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
On Wed, 09 May 2012 03:34:46 +0530, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Instead, > it can be moved

[PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-08 Thread Thomas Abraham
Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data. Cc: Jaswinder