Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()
Hi Bartlomiej,
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote:
pdata-reference_voltage and pdata-gain are always defined
to non-zero values so remove the redundant checks from
exynos_tmu_control().
I prefer to have these checks for the same reason that new soc support
should not add these same code again.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
drivers/thermal/samsung/exynos_tmu.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c
b/drivers/thermal/samsung/exynos_tmu.c
index a8d9524..45d7c6f 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -215,15 +215,11 @@ static void exynos_tmu_control(struct platform_device
*pdev, bool on)
if (pdata-test_mux)
con |= (pdata-test_mux reg-test_mux_addr_shift);
- if (pdata-reference_voltage) {
- con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
- con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- }
+ con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
+ con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- if (pdata-gain) {
- con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
- con |= (pdata-gain reg-buf_slope_sel_shift);
- }
+ con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
+ con |= (pdata-gain reg-buf_slope_sel_shift);
if (pdata-noise_cancel_mode) {
con = ~(reg-therm_trip_mode_mask
--
1.8.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-pm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()
Hello Bartlomiej,
On Mon, May 05, 2014 at 01:15:38PM +0200, Bartlomiej Zolnierkiewicz wrote:
pdata-reference_voltage and pdata-gain are always defined
to non-zero values so remove the redundant checks from
exynos_tmu_control().
In all existing SoCs?
Should this be considered to any upcoming SoCs?
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
drivers/thermal/samsung/exynos_tmu.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c
b/drivers/thermal/samsung/exynos_tmu.c
index a8d9524..45d7c6f 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -215,15 +215,11 @@ static void exynos_tmu_control(struct platform_device
*pdev, bool on)
if (pdata-test_mux)
con |= (pdata-test_mux reg-test_mux_addr_shift);
- if (pdata-reference_voltage) {
- con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
- con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- }
+ con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
+ con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- if (pdata-gain) {
- con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
- con |= (pdata-gain reg-buf_slope_sel_shift);
- }
+ con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
+ con |= (pdata-gain reg-buf_slope_sel_shift);
The way it is put, looks like gain and reference_voltage are mandatory
pdata fields. Should these checks be moved to initialization phase?
if (pdata-noise_cancel_mode) {
con = ~(reg-therm_trip_mode_mask
--
1.8.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-pm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()
On Thursday, May 15, 2014 11:03:08 AM Eduardo Valentin wrote:
Hello Bartlomiej,
Hi,
On Mon, May 05, 2014 at 01:15:38PM +0200, Bartlomiej Zolnierkiewicz wrote:
pdata-reference_voltage and pdata-gain are always defined
to non-zero values so remove the redundant checks from
exynos_tmu_control().
In all existing SoCs?
Yes.
Should this be considered to any upcoming SoCs?
Yes, if/when it changes we will update the code.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
drivers/thermal/samsung/exynos_tmu.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c
b/drivers/thermal/samsung/exynos_tmu.c
index a8d9524..45d7c6f 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -215,15 +215,11 @@ static void exynos_tmu_control(struct platform_device
*pdev, bool on)
if (pdata-test_mux)
con |= (pdata-test_mux reg-test_mux_addr_shift);
- if (pdata-reference_voltage) {
- con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
- con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- }
+ con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
+ con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- if (pdata-gain) {
- con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
- con |= (pdata-gain reg-buf_slope_sel_shift);
- }
+ con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
+ con |= (pdata-gain reg-buf_slope_sel_shift);
The way it is put, looks like gain and reference_voltage are mandatory
pdata fields. Should these checks be moved to initialization phase?
Yes, they should be considered mandatory pdata fields but I'm against
adding any superfluous pdata checks for initialization phase (I will
update struct exynos_tmu_platform_data documentation to indicate that
these fields cannot be zero instead).
if (pdata-noise_cancel_mode) {
con = ~(reg-therm_trip_mode_mask
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung RD Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()
pdata-reference_voltage and pdata-gain are always defined
to non-zero values so remove the redundant checks from
exynos_tmu_control().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
drivers/thermal/samsung/exynos_tmu.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c
b/drivers/thermal/samsung/exynos_tmu.c
index a8d9524..45d7c6f 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -215,15 +215,11 @@ static void exynos_tmu_control(struct platform_device
*pdev, bool on)
if (pdata-test_mux)
con |= (pdata-test_mux reg-test_mux_addr_shift);
- if (pdata-reference_voltage) {
- con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
- con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- }
+ con = ~(reg-buf_vref_sel_mask reg-buf_vref_sel_shift);
+ con |= pdata-reference_voltage reg-buf_vref_sel_shift;
- if (pdata-gain) {
- con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
- con |= (pdata-gain reg-buf_slope_sel_shift);
- }
+ con = ~(reg-buf_slope_sel_mask reg-buf_slope_sel_shift);
+ con |= (pdata-gain reg-buf_slope_sel_shift);
if (pdata-noise_cancel_mode) {
con = ~(reg-therm_trip_mode_mask
--
1.8.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
