Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Tomasz Figa
On 03.06.2014 14:17, Wolfram Sang wrote: > >> Couldn't it be made configurable with a Kconfig entry? E.g. "Enable >> deprecated class-based instantiation" under Drivers / I2C? Turning it >> off could make the code ignore the class field completely. > > Technically, yes. But we could also wait ano

Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Wolfram Sang
> Couldn't it be made configurable with a Kconfig entry? E.g. "Enable > deprecated class-based instantiation" under Drivers / I2C? Turning it > off could make the code ignore the class field completely. Technically, yes. But we could also wait another cycle and just be done with it :) signatur

Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Tomasz Figa
Hi Wolfram, Sachin, On 03.06.2014 13:21, Sachin Kamat wrote: > Hi Wolfram, > > On Tue, Jun 3, 2014 at 3:35 PM, Wolfram Sang wrote: >> On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: >>> With multiplatform support enabled for Exynos, class based >>> instantiation causes a boot time

Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Wolfram Sang
> The reason for the removal is the boot delay it is causing on Exynos 5250 > based boards by throwing the following errors continuously. > > [ 55.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) > [ 59.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110) > [ 63.005300] s3c-i2c

Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Sachin Kamat
Hi Wolfram, On Tue, Jun 3, 2014 at 3:35 PM, Wolfram Sang wrote: > On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: >> With multiplatform support enabled for Exynos, class based >> instantiation causes a boot time delay due to I2C_CLASS_HWMON >> triggered probe. Since class based inst

Re: [PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Wolfram Sang
On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote: > With multiplatform support enabled for Exynos, class based > instantiation causes a boot time delay due to I2C_CLASS_HWMON > triggered probe. Since class based instantiation has been > deprecated since some time now, remove it for Sams

[PATCH 1/1] i2c: s3c2410: Remove class based instantiation

2014-06-03 Thread Sachin Kamat
With multiplatform support enabled for Exynos, class based instantiation causes a boot time delay due to I2C_CLASS_HWMON triggered probe. Since class based instantiation has been deprecated since some time now, remove it for Samsung I2C driver. Signed-off-by: Sachin Kamat Cc: Olof Johansson ---