Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-17 Thread Thomas Abraham
On 11 September 2012 01:32, Linus Walleij wrote: > On Thu, Sep 6, 2012 at 11:23 AM, Thomas Abraham > wrote: > >> Add optional support for i2c bus pin configuration using pinctrl interface >> >> Cc: Ben Dooks >> Signed-off-by: Thomas Abraham > (...) >> diff --git a/drivers/i2c/busses/i2c-s3c2410

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-17 Thread Thomas Abraham
On 11 September 2012 00:51, Stephen Warren wrote: > On 09/06/2012 05:06 AM, Thomas Abraham wrote: >> On 6 September 2012 15:04, Tomasz Figa wrote: >>> Hi, >>> >>> This patch shows the problem of the need to explicitly migrate all drivers >>> to pinctrl. >>> >>> Maybe we should consider extending

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Linus Walleij
On Thu, Sep 6, 2012 at 11:23 AM, Thomas Abraham wrote: > Add optional support for i2c bus pin configuration using pinctrl interface > > Cc: Ben Dooks > Signed-off-by: Thomas Abraham (...) > diff --git a/drivers/i2c/busses/i2c-s3c2410.c > b/drivers/i2c/busses/i2c-s3c2410.c (...) > - else

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Linus Walleij
On Thu, Sep 6, 2012 at 2:28 PM, Tomasz Figa wrote: > Thanks for your comments. > > On Thursday 06 of September 2012 16:36:08 Thomas Abraham wrote: >> > This patch shows the problem of the need to explicitly migrate all >> > drivers to pinctrl. >> > >> > Maybe we should consider extending the pinct

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Stephen Warren
On 09/06/2012 05:06 AM, Thomas Abraham wrote: > On 6 September 2012 15:04, Tomasz Figa wrote: >> Hi, >> >> This patch shows the problem of the need to explicitly migrate all drivers >> to pinctrl. >> >> Maybe we should consider extending the pinctrl subsystem to set the default >> state automatica

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Tomasz Figa
Hi, Thanks for your comments. On Thursday 06 of September 2012 16:36:08 Thomas Abraham wrote: > > This patch shows the problem of the need to explicitly migrate all > > drivers to pinctrl. > > > > Maybe we should consider extending the pinctrl subsystem to set the > > default state automatically

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Thomas Abraham
On 6 September 2012 15:04, Tomasz Figa wrote: > Hi, > > This patch shows the problem of the need to explicitly migrate all drivers > to pinctrl. > > Maybe we should consider extending the pinctrl subsystem to set the default > state automatically before binding a driver to a device, at least in ca

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Tomasz Figa
Hi, This patch shows the problem of the need to explicitly migrate all drivers to pinctrl. Maybe we should consider extending the pinctrl subsystem to set the default state automatically before binding a driver to a device, at least in case of DT-based platforms? This would be similar to what

[PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Thomas Abraham
Add optional support for i2c bus pin configuration using pinctrl interface Cc: Ben Dooks Signed-off-by: Thomas Abraham --- drivers/i2c/busses/i2c-s3c2410.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/