Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-18 Thread Chris Ball
Hi, On Fri, Sep 14 2012, Chander Kashyap wrote: > In case of multiple bus clock sources, all the clock sources were > getting enabled. As only one clock source is needed at the time hence > enable only the required bus clock. > > This patch does as follows: > 1.In sdhci_s3c_probe enable only r

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Jaehoon Chung
Acked-by: Jaehoon Chung On 09/14/2012 07:46 PM, Chander Kashyap wrote: > Hi Jaehoon Chung, > > On 14 September 2012 15:25, Jaehoon Chung wrote: >> Hi Chander, >> >> Could you add the error control for clk_enable()? > It is maintained as original and clk is already checked for error using > IS_

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Chander Kashyap
Hi Jaehoon Chung, On 14 September 2012 15:25, Jaehoon Chung wrote: > Hi Chander, > > Could you add the error control for clk_enable()? It is maintained as original and clk is already checked for error using IS_ERR. > > On 09/14/2012 06:08 PM, Chander Kashyap wrote: >> In case of multiple bus cloc

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Jaehoon Chung
Hi Chander, Could you add the error control for clk_enable()? On 09/14/2012 06:08 PM, Chander Kashyap wrote: > In case of multiple bus clock sources, all the clock sources were > getting enabled. As only one clock source is needed at the time hence > enable only the required bus clock. > > This

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Girish K S
looks good Reviewed by: Girish KS On 14 September 2012 14:38, Chander Kashyap wrote: > In case of multiple bus clock sources, all the clock sources were > getting enabled. As only one clock source is needed at the time hence > enable only the required bus clock. > > This patch does as follows: >

[PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Chander Kashyap
In case of multiple bus clock sources, all the clock sources were getting enabled. As only one clock source is needed at the time hence enable only the required bus clock. This patch does as follows: 1. In sdhci_s3c_probe enable only required bus clock source. 2. Handle the disabling of