Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Mark Brown
On Thu, Jun 04, 2015 at 12:52:19PM +0200, Michal Suchanek wrote: > There is no code interdependency with the other patches so if it's > preferred I can send patches like this separately. Yes, that's better practice. signature.asc Description: Digital signature

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Michal Suchanek
On 4 June 2015 at 12:26, Mark Brown wrote: > On Thu, Jun 04, 2015 at 11:33:37AM +0200, Michal Suchanek wrote: >> On 4 June 2015 at 11:16, Mark Brown wrote: > >> > Also for this patch (which just adds some trace) there isn't any clear >> > reason for it to be sent as part of the series at all, it

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Mark Brown
On Thu, Jun 04, 2015 at 11:33:37AM +0200, Michal Suchanek wrote: > On 4 June 2015 at 11:16, Mark Brown wrote: > > Also for this patch (which just adds some trace) there isn't any clear > > reason for it to be sent as part of the series at all, it doesn't help > > deliver the functionality and doe

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Mark Brown
On Thu, Jun 04, 2015 at 11:30:15AM +0200, Geert Uytterhoeven wrote: > On Thu, Jun 4, 2015 at 11:16 AM, Mark Brown wrote: > >> --- a/drivers/spi/spi-s3c64xx.c > >> +++ b/drivers/spi/spi-s3c64xx.c > >> @@ -18,6 +18,7 @@ > >> #include > >> #include > >> #include > >> +#include > > Whatever yo

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Michal Suchanek
Hello, On 4 June 2015 at 11:16, Mark Brown wrote: > On Wed, Jun 03, 2015 at 09:26:42PM -, Michal Suchanek wrote: >> The SPI NOR transfers mysteriously fail so add more debug prints about >> SPI transactions. > > Please try to only send patches to relevant people - the list of > recipients for

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Geert Uytterhoeven
On Thu, Jun 4, 2015 at 11:16 AM, Mark Brown wrote: >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -18,6 +18,7 @@ >> #include >> #include >> #include >> +#include > > Whatever you're doing here this indicates that there's a very big > abstraction problem going on

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-04 Thread Mark Brown
On Wed, Jun 03, 2015 at 09:26:42PM -, Michal Suchanek wrote: > The SPI NOR transfers mysteriously fail so add more debug prints about > SPI transactions. Please try to only send patches to relevant people - the list of recipients for this is so large that it only barely fits on a single screen

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-03 Thread Marek Vasut
On Wednesday, June 03, 2015 at 11:26:42 PM, Michal Suchanek wrote: > The SPI NOR transfers mysteriously fail so add more debug prints about > SPI transactions. > > Signed-off-by: Michal Suchanek dev_dbg() and friends would certainly be nicer here. Best regards, Marek Vasut -- To unsubscribe fro